Documented that ACLs should be refcounted.

Refcounting would avoid ACL destruction problems (when some ACLs use other
ACLs or when an ACL goes async during reconfigure) and may even reduce
problems with AclMatchedName.

diff --git a/src/acl/Acl.h b/src/acl/Acl.h
index 6b82937f44afe2631f5190e952eb94896174f1fc..dc61d568f4207226edbd25842c6b2a7572c10d6b 100644 (file)
--- a/src/acl/Acl.h
+++ b/src/acl/Acl.h
@@ -135,7 +135,7 @@ public:
 
     char name[ACL_NAME_SZ];
     char *cfgline;
-    ACL *next;
+    ACL *next; // XXX: remove or at least use refcounting
     ACLFlags flags; ///< The list of given ACL flags
     bool registered; ///< added to Config.aclList and can be reused via by FindByName()
 
@@ -244,6 +244,7 @@ public:
 MEMPROXY_CLASS_INLINE(acl_proxy_auth_match_cache);
 
 /// \ingroup ACLAPI
+/// XXX: find a way to remove or at least use a refcounted ACL pointer
 extern const char *AclMatchedName;     /* NULL */
 
 #endif /* SQUID_ACL_H */

diff --git a/src/acl/InnerNode.h b/src/acl/InnerNode.h
index 6f3b14446b85fe6c4fb90ad1266336e4b378b250..bd20dd5d258d6525e3bccafd06bbe587be73c801 100644 (file)
--- a/src/acl/InnerNode.h
+++ b/src/acl/InnerNode.h
@@ -40,6 +40,7 @@ protected:
     /* ACL API */
     virtual int match(ACLChecklist *checklist);
 
+    // XXX: use refcounting instead of raw pointers
     std::vector<ACL*> nodes; ///< children nodes of this intermediate node
 };