]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: qcom: pmi8994: Remove hardcoded linear WLED enabled-strings
authorMarijn Suijten <marijn.suijten@somainline.org>
Thu, 7 Oct 2021 21:33:58 +0000 (23:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2023 10:22:37 +0000 (12:22 +0200)
[ Upstream commit 9b729b0932d0e6097d9f103e9dd149ef10881f43 ]

The driver now sets an appropriate default for WLED4 (and WLED5) just
like WLED3 making this linear array from 0-3 redundant.  In addition the
driver is now able to parse arrays of variable length solving the "all
four strings *have to* be defined" comment.

Besides the driver will now warn when both properties are specified to
prevent ambiguity: the length of the array is enough to imply a set
number of strings.

Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
Reviewed-By: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20211007213400.258371-12-marijn.suijten@somainline.org
Stable-dep-of: 8db944326903 ("arm64: dts: qcom: pmi8994: Add missing OVP interrupt")
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm64/boot/dts/qcom/pmi8994.dtsi

index 7b41c1ed464ac98b343ac3af740bae543fee3624..166467b637527bf13125f3a2652862b219d23198 100644 (file)
@@ -39,8 +39,6 @@
                        interrupts = <3 0xd8 0x02 IRQ_TYPE_EDGE_RISING>;
                        interrupt-names = "short";
                        qcom,num-strings = <3>;
-                       /* Yes, all four strings *have to* be defined or things won't work. */
-                       qcom,enabled-strings = <0 1 2 3>;
                        qcom,cabc;
                        qcom,external-pfet;
                        status = "disabled";