]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
platform/x86: barco-p50-gpio: Add check for platform_driver_register
authorJiasheng Jiang <jiasheng@iscas.ac.cn>
Thu, 26 May 2022 09:03:45 +0000 (17:03 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 16:41:42 +0000 (18:41 +0200)
[ Upstream commit 011881b80ebe773914b59905bce0f5e0ef93e7ba ]

As platform_driver_register() could fail, it should be better
to deal with the return value in order to maintain the code
consisitency.

Fixes: 86af1d02d458 ("platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Acked-by: Peter Korsgaard <peter.korsgaard@barco.com>
Link: https://lore.kernel.org/r/20220526090345.1444172-1-jiasheng@iscas.ac.cn
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/x86/barco-p50-gpio.c

index f5c72e33f9ae340b5e2aa75d2cd3694e5bfa19e4..f8b796820ef43729a4a3c123996404c953d202f3 100644 (file)
@@ -406,11 +406,14 @@ MODULE_DEVICE_TABLE(dmi, dmi_ids);
 static int __init p50_module_init(void)
 {
        struct resource res = DEFINE_RES_IO(P50_GPIO_IO_PORT_BASE, P50_PORT_CMD + 1);
+       int ret;
 
        if (!dmi_first_match(dmi_ids))
                return -ENODEV;
 
-       platform_driver_register(&p50_gpio_driver);
+       ret = platform_driver_register(&p50_gpio_driver);
+       if (ret)
+               return ret;
 
        gpio_pdev = platform_device_register_simple(DRIVER_NAME, PLATFORM_DEVID_NONE, &res, 1);
        if (IS_ERR(gpio_pdev)) {