]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
io-wq: ensure that hash wait lock is IRQ disabling
authorJens Axboe <axboe@kernel.dk>
Tue, 31 Aug 2021 12:57:25 +0000 (06:57 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Nov 2021 10:04:47 +0000 (11:04 +0100)
commit 08bdbd39b58474d762242e1fadb7f2eb9ffcca71 upstream.

A previous commit removed the IRQ safety of the worker and wqe locks,
but that left one spot of the hash wait lock now being done without
already having IRQs disabled.

Ensure that we use the right locking variant for the hashed waitqueue
lock.

Fixes: a9a4aa9fbfc5 ("io-wq: wqe and worker locks no longer need to be IRQ safe")
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/io-wq.c

index cb5d84f6b7693712b14824345726f8a3189999d0..4f460797f962525c742711b91da66ee935e1f16d 100644 (file)
@@ -405,7 +405,7 @@ static void io_wait_on_hash(struct io_wqe *wqe, unsigned int hash)
 {
        struct io_wq *wq = wqe->wq;
 
-       spin_lock(&wq->hash->wait.lock);
+       spin_lock_irq(&wq->hash->wait.lock);
        if (list_empty(&wqe->wait.entry)) {
                __add_wait_queue(&wq->hash->wait, &wqe->wait);
                if (!test_bit(hash, &wq->hash->map)) {
@@ -413,7 +413,7 @@ static void io_wait_on_hash(struct io_wqe *wqe, unsigned int hash)
                        list_del_init(&wqe->wait.entry);
                }
        }
-       spin_unlock(&wq->hash->wait.lock);
+       spin_unlock_irq(&wq->hash->wait.lock);
 }
 
 /*