tests: actually detect missing 'test' in 'if "$foo" = ...'.

* tests/sh.test: Remove extra backslash in regex.

Signed-off-by: Peter Rosin <peda@lysator.liu.se>

diff --git a/ChangeLog b/ChangeLog
index 514a20e720051ea90ea19d217507b483cc78aa23..e6984aebb8225a59ef340921e6b7a2e3d4dd06e9 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2010-09-17  Peter Rosin  <peda@lysator.liu.se>
 
+       tests: actually detect missing 'test' in 'if "$foo" = ...'.
+       * tests/sh.test: Remove extra backslash in regex.
+
        Copy over DLL_EXPORT handling from C to C++ for non-GCC on w32.
        * libltdl/m4/libtool.m4 (_LT_COMPILER_PIC) [mingw, cygwin, os2]
        [pw32, cegcc]: Copy over the DLL_EXPORT handling from C to C++.

diff --git a/tests/sh.test b/tests/sh.test
index 6d2fa20736b922eabdff43294c4e79bb8b8db542..5324b318deef3beb4b1e7c3daf9d7fa1853b870b 100755 (executable)
--- a/tests/sh.test
+++ b/tests/sh.test
@@ -2,8 +2,8 @@
 # sh.test - check for some nonportable or dubious or undesired shell
 #           constructs in shell scripts.
 #
-#   Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Free Software
-#   Foundation, Inc.
+#   Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2010 Free
+#   Software Foundation, Inc.
 #   Written by Gary V. Vaughan, 2003
 #
 #   This file is part of GNU Libtool.
@@ -31,7 +31,7 @@
 status=$EXIT_SUCCESS
 
 # Check for bad binary operators.
-if $EGREP -n -e 'if[   ]+["'\'']?\\$[^         ]+[     ]+(=|-[lg][te]|-eq|-ne)' $scripts; then
+if $EGREP -n -e 'if[   ]+["'\'']?\$[^  ]+[     ]+(=|-[lg][te]|-eq|-ne)' $scripts; then
   echo "use \`if test \$something =' instead of \`if \$something ='"
   status=$EXIT_FAILURE
 fi