]> git.ipfire.org Git - thirdparty/openwrt.git/commitdiff
mtk-mmc: replace empty body macros
authorMieczyslaw Nalewaj <namiltd@yahoo.com>
Sun, 18 May 2025 09:30:18 +0000 (11:30 +0200)
committerHauke Mehrtens <hauke@hauke-m.de>
Wed, 11 Jun 2025 12:16:21 +0000 (14:16 +0200)
Replace macros with empty body with 'do {} while (0)'.
Remove unnecessary semicolons.

Fixes:
drivers/mmc/host/mtk-mmc/sd.c: In function 'msdc_irq':
drivers/mmc/host/mtk-mmc/sd.c:1969:87: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body]
 1969 |                                 IRQ_MSG("XXX CMD<%d> MSDC_INT_RSPCRCERR", cmd->opcode);
      |                                                                                       ^
drivers/mmc/host/mtk-mmc/sd.c:1975:84: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body]
 1975 |                                 IRQ_MSG("XXX CMD<%d> MSDC_INT_CMDTMO", cmd->opcode);
      |                                                                                    ^
cc1: all warnings being treated as errors

Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
Link: https://github.com/openwrt/openwrt/pull/18654
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
target/linux/ramips/files/drivers/mmc/host/mtk-mmc/dbg.h

index 5a25a69b00c9d56e870da9e73df56ddfb611661c..146c467b99ec0e8bc10ffc60a410a8e84d10aac1 100644 (file)
@@ -108,7 +108,7 @@ do { \
 } while (0)
 #endif /* end of +++ */
 
-#define N_MSG(evt, fmt, args...)
+#define N_MSG(evt, fmt, args...) do {} while (0)
 /*
 do {    \
     if ((DBG_EVT_##evt) & sd_debug_zone[host->id]) { \
@@ -122,25 +122,25 @@ do {    \
 do { \
        printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
               host->id,  ##args, __FUNCTION__, __LINE__, current->comm, current->pid); \
-} while (0);
+} while (0)
 
 #if 1
 //defined CONFIG_MTK_MMC_CD_POLL
-#define INIT_MSG(fmt, args...)
-#define IRQ_MSG(fmt, args...)
+#define INIT_MSG(fmt, args...) do {} while (0)
+#define IRQ_MSG(fmt, args...) do {} while (0)
 #else
 #define INIT_MSG(fmt, args...) \
 do { \
        printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d> PID<%s><0x%x>\n", \
               host->id,  ##args, __FUNCTION__, __LINE__, current->comm, current->pid); \
-} while (0);
+} while (0)
 
 /* PID in ISR in not corrent */
 #define IRQ_MSG(fmt, args...) \
 do { \
        printk(KERN_ERR TAG"%d -> "fmt" <- %s() : L<%d>\n",     \
               host->id,  ##args, __FUNCTION__, __LINE__);      \
-} while (0);
+} while (0)
 #endif
 
 void msdc_debug_proc_init(void);