]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
ssl: fix compiler warning
authorPhilippe Antoine <pantoine@oisf.net>
Tue, 27 Sep 2022 13:47:06 +0000 (15:47 +0200)
committerVictor Julien <vjulien@oisf.net>
Fri, 13 Jan 2023 11:33:04 +0000 (12:33 +0100)
implicit conversion loses integer precision: 'int' to 'uint16_t'
because C shifts << translates automatically to signed integers

(cherry picked from commit ae6abd8ca3eb0e3157eb8709d97c9432beb9e373)

src/app-layer-ssl.c

index 435411e4a326de6f81b6dfcfad0a2bcd2f090636..c1b3779ebc8e0d639d2aaf5534c28800cdb9a6d7 100644 (file)
@@ -2080,7 +2080,7 @@ static struct SSLDecoderResult SSLv2Decode(uint8_t direction, SSLState *ssl_stat
             ssl_state->current_flags = SSL_AL_FLAG_STATE_CLIENT_HELLO;
             ssl_state->current_flags |= SSL_AL_FLAG_SSL_CLIENT_HS;
 
-            const uint16_t version = input[0] << 8 | input[1];
+            const uint16_t version = (uint16_t)(input[0] << 8) | input[1];
             SCLogDebug("SSLv2: version %04x", version);
             ssl_state->curr_connp->version = version;
             uint16_t session_id_length = (input[5]) | (uint16_t)(input[4] << 8);