]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: platform: ti: Remove unused vpdma_update_dma_addr
authorDr. David Alan Gilbert <linux@treblig.org>
Sun, 15 Jun 2025 23:58:01 +0000 (00:58 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Tue, 17 Jun 2025 08:35:17 +0000 (10:35 +0200)
vpdma_update_dma_addr() was added in 2016 as part of
commit 2f88703a0bfd ("[media] media: ti-vpe: vpdma: Add multi-instance and
multi-client support")

but has remained unused.

Remove it.

I did see that there was a VIP driver submitted in 2020 that
doesn't seem to have got merged which did use this (and a bunch
of other unused functions).

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/ti/vpe/vpdma.c
drivers/media/platform/ti/vpe/vpdma.h

index da90d7f03f82d72e77cf6a471989512daf0f2e22..bb8a8bd7980c1c5dab214320596334982a779d15 100644 (file)
@@ -552,38 +552,6 @@ EXPORT_SYMBOL(vpdma_submit_descs);
 
 static void dump_dtd(struct vpdma_dtd *dtd);
 
-void vpdma_update_dma_addr(struct vpdma_data *vpdma,
-       struct vpdma_desc_list *list, dma_addr_t dma_addr,
-       void *write_dtd, int drop, int idx)
-{
-       struct vpdma_dtd *dtd = list->buf.addr;
-       dma_addr_t write_desc_addr;
-       int offset;
-
-       dtd += idx;
-       vpdma_unmap_desc_buf(vpdma, &list->buf);
-
-       dtd->start_addr = dma_addr;
-
-       /* Calculate write address from the offset of write_dtd from start
-        * of the list->buf
-        */
-       offset = (void *)write_dtd - list->buf.addr;
-       write_desc_addr = list->buf.dma_addr + offset;
-
-       if (drop)
-               dtd->desc_write_addr = dtd_desc_write_addr(write_desc_addr,
-                                                          1, 1, 0);
-       else
-               dtd->desc_write_addr = dtd_desc_write_addr(write_desc_addr,
-                                                          1, 0, 0);
-
-       vpdma_map_desc_buf(vpdma, &list->buf);
-
-       dump_dtd(dtd);
-}
-EXPORT_SYMBOL(vpdma_update_dma_addr);
-
 void vpdma_set_max_size(struct vpdma_data *vpdma, int reg_addr,
                        u32 width, u32 height)
 {
index 393fcbb3cb40654a0c4821b135bcafa70dbcc18d..e4d7941c62070093c103a4ce38aa94bb3964773d 100644 (file)
@@ -222,9 +222,6 @@ void vpdma_free_desc_list(struct vpdma_desc_list *list);
 int vpdma_submit_descs(struct vpdma_data *vpdma, struct vpdma_desc_list *list,
                       int list_num);
 bool vpdma_list_busy(struct vpdma_data *vpdma, int list_num);
-void vpdma_update_dma_addr(struct vpdma_data *vpdma,
-       struct vpdma_desc_list *list, dma_addr_t dma_addr,
-       void *write_dtd, int drop, int idx);
 
 /* VPDMA hardware list funcs */
 int vpdma_hwlist_alloc(struct vpdma_data *vpdma, void *priv);