]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
accel/qaic: Change aic100_image_table definition
authorYoussef Samir <quic_yabdulra@quicinc.com>
Fri, 13 Dec 2024 18:51:10 +0000 (11:51 -0700)
committerJeffrey Hugo <quic_jhugo@quicinc.com>
Fri, 17 Jan 2025 16:04:09 +0000 (09:04 -0700)
aic100_image_table is currently defined as a "const char *" array,
this can potentially lead to the accidental modification of the
pointers inside. Also, checkpatch.pl gives a warning about it.

Change the type to a "const char * const" array to make the pointers
immutable, preventing accidental modification of the images' paths.

Signed-off-by: Youssef Samir <quic_yabdulra@quicinc.com>
Reviewed-by: Carl Vanderlip <quic_carlv@quicinc.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Signed-off-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241213185110.2469159-1-quic_jhugo@quicinc.com
drivers/accel/qaic/sahara.c

index 21d58aed0deba63782d370f76c2b3649f0972cbb..09c8b055aa8191136f23f182d64d916a03d9d39a 100644 (file)
@@ -160,7 +160,7 @@ struct sahara_context {
        struct work_struct              fw_work;
        struct work_struct              dump_work;
        struct mhi_device               *mhi_dev;
-       const char                      **image_table;
+       const char * const              *image_table;
        u32                             table_size;
        u32                             active_image_id;
        const struct firmware           *firmware;
@@ -177,7 +177,7 @@ struct sahara_context {
        bool                            is_mem_dump_mode;
 };
 
-static const char *aic100_image_table[] = {
+static const char * const aic100_image_table[] = {
        [1]  = "qcom/aic100/fw1.bin",
        [2]  = "qcom/aic100/fw2.bin",
        [4]  = "qcom/aic100/fw4.bin",