]> git.ipfire.org Git - thirdparty/shadow.git/commitdiff
login: use strlcpy to always NUL terminate
authorChristian Göttsche <cgzones@googlemail.com>
Thu, 26 Jan 2023 19:24:09 +0000 (20:24 +0100)
committerSerge Hallyn <serge@hallyn.com>
Mon, 21 Aug 2023 19:05:18 +0000 (14:05 -0500)
    login.c:728:25: warning: ‘strncpy’ specified bound 256 equals destination size [-Wstringop-truncation]

Reviewed-by: Alejandro Colomar <alx@kernel.org>
src/login.c

index 0f308dc10390fffe099ad735c2cfa3cbe493e1a8..8a109801b3b319768b63c4f58f4e9ffb1d08250f 100644 (file)
@@ -709,7 +709,7 @@ int main (int argc, char **argv)
                                  sizeof (loginprompt),
                                  _("%s login: "), hostn);
                } else {
-                       strncpy (loginprompt, _("login: "),
+                       strlcpy (loginprompt, _("login: "),
                                 sizeof (loginprompt));
                }