]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tcp: Don't reinitialise tw->tw_transparent in tcp_time_wait().
authorKuniyuki Iwashima <kuniyu@google.com>
Tue, 18 Nov 2025 00:04:40 +0000 (00:04 +0000)
committerJakub Kicinski <kuba@kernel.org>
Wed, 19 Nov 2025 02:00:38 +0000 (18:00 -0800)
tw->tw_transparent is initialised twice in inet_twsk_alloc()
and tcp_time_wait().

Let's remove the latter.

Signed-off-by: Kuniyuki Iwashima <kuniyu@google.com>
Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
Link: https://patch.msgid.link/20251118000445.4091280-1-kuniyu@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/tcp_minisocks.c

index d8f4d813e8dd28315900df1246281106fd73bb7e..bd5462154f970ba6d244882275a6baadadd283c6 100644 (file)
@@ -337,7 +337,6 @@ void tcp_time_wait(struct sock *sk, int state, int timeo)
                struct tcp_timewait_sock *tcptw = tcp_twsk((struct sock *)tw);
                const int rto = (icsk->icsk_rto << 2) - (icsk->icsk_rto >> 1);
 
-               tw->tw_transparent      = inet_test_bit(TRANSPARENT, sk);
                tw->tw_mark             = sk->sk_mark;
                tw->tw_priority         = READ_ONCE(sk->sk_priority);
                tw->tw_rcv_wscale       = tp->rx_opt.rcv_wscale;