]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
clk: nuvoton: ma35d1-divider: convert from divider_round_rate() to divider_determine_...
authorBrian Masney <bmasney@redhat.com>
Thu, 8 Jan 2026 21:16:30 +0000 (16:16 -0500)
committerBrian Masney <bmasney@redhat.com>
Thu, 22 Jan 2026 15:48:25 +0000 (10:48 -0500)
The divider_round_rate() function is now deprecated, so let's migrate
to divider_determine_rate() instead so that this deprecated API can be
removed.

Note that when the main function itself was migrated to use
determine_rate, this was mistakenly converted to:

    req->rate = divider_round_rate(...)

This is invalid in the case when an error occurs since it can set the
rate to a negative value.

Fixes: 215f8aa095a1 ("clk: nuvoton: ma35d1-divider: convert from round_rate() to determine_rate()")
Signed-off-by: Brian Masney <bmasney@redhat.com>
drivers/clk/nuvoton/clk-ma35d1-divider.c

index e39f53d5bf4578c628d34b05233c8e8da317c4d4..e992e7c30341977bd4baaad8b24e17039252f90c 100644 (file)
@@ -44,11 +44,8 @@ static int ma35d1_clkdiv_determine_rate(struct clk_hw *hw,
 {
        struct ma35d1_adc_clk_div *dclk = to_ma35d1_adc_clk_div(hw);
 
-       req->rate = divider_round_rate(hw, req->rate, &req->best_parent_rate,
-                                      dclk->table, dclk->width,
-                                      CLK_DIVIDER_ROUND_CLOSEST);
-
-       return 0;
+       return divider_determine_rate(hw, req, dclk->table, dclk->width,
+                                     CLK_DIVIDER_ROUND_CLOSEST);
 }
 
 static int ma35d1_clkdiv_set_rate(struct clk_hw *hw, unsigned long rate, unsigned long parent_rate)