if (r < 0)
return bus_log_connect_error(r, arg_transport, arg_runtime_scope);
- n = acquire_time_data(bus, /* require_finished = */ false, ×);
+ n = acquire_time_data(bus, /* require_finished= */ false, ×);
if (n <= 0)
return n;
assert(u);
assert(line);
- line = skip_leading_chars(line, /* bad = */ NULL);
+ line = skip_leading_chars(line, /* bad= */ NULL);
const char *eq = strchr(line, '=');
if (!eq)
if (!type_string)
return log_oom();
- delete_trailing_chars(type_string, /* bad = */ NULL);
+ delete_trailing_chars(type_string, /* bad= */ NULL);
Condition **target;
ConditionType type;
if (type < 0)
return log_error_errno(type, "Cannot parse \"%s\".", line);
- const char *val = skip_leading_chars(eq + 1, /* bad = */ NULL);
+ const char *val = skip_leading_chars(eq + 1, /* bad= */ NULL);
ConfigParserCallback callback;
if (condition_takes_path(type))
else
callback = config_parse_unit_condition_string;
- return callback(/* unit = */ NULL,
- /* filename = */ "(cmdline)",
- /* line = */ 0,
- /* section = */ NULL,
- /* section_line = */ 0,
- /* lvalue = */ type_string,
- /* ltype = */ type,
- /* rvalue = */ val,
- /* data = */ target,
- /* userdata = */ u);
+ return callback(/* unit= */ NULL,
+ /* filename= */ "(cmdline)",
+ /* line= */ 0,
+ /* section= */ NULL,
+ /* section_line= */ 0,
+ /* lvalue= */ type_string,
+ /* ltype= */ type,
+ /* rvalue= */ val,
+ /* data= */ target,
+ /* userdata= */ u);
}
_printf_(7, 8)
va_start(ap, format);
r = log_object_internalv(level, error, file, line, func,
- /* object_field = */ unit_log_field(u),
- /* object = */ u->id,
- /* extra_field = */ NULL,
- /* extra = */ NULL,
+ /* object_field= */ unit_log_field(u),
+ /* object= */ u->id,
+ /* extra_field= */ NULL,
+ /* extra= */ NULL,
format, ap);
va_end(ap);
typesafe_qsort(deps, strv_length(deps), list_dependencies_compare);
- r = acquire_boot_times(bus, /* require_finished = */ true, &boot);
+ r = acquire_boot_times(bus, /* require_finished= */ true, &boot);
if (r < 0)
return r;
times = hashmap_get(unit_times_hashmap, id);
- r = acquire_boot_times(bus, /* require_finished = */ true, &boot);
+ r = acquire_boot_times(bus, /* require_finished= */ true, &boot);
if (r < 0)
return r;
if (r < 0)
return bus_log_connect_error(r, arg_transport, arg_runtime_scope);
- n = acquire_time_data(bus, /* require_finished = */ true, ×);
+ n = acquire_time_data(bus, /* require_finished= */ true, ×);
if (n <= 0)
return n;
if (table_isempty(table) && !sd_json_format_enabled(arg_json_format_flags))
log_info("No file descriptors in fdstore of '%s'.", unit);
else {
- r = table_print_with_pager(table, arg_json_format_flags, arg_pager_flags, /* show_header= */true);
+ r = table_print_with_pager(table, arg_json_format_flags, arg_pager_flags, /* show_header= */ true);
if (r < 0)
return r;
}
if (r < 0)
return log_error_errno(r, "Failed to read '%s': %m", p);
- r = unhexmem_full(s, ss, /* secure = */ false, &buf, &bufsize);
+ r = unhexmem_full(s, ss, /* secure= */ false, &buf, &bufsize);
if (r < 0)
return log_error_errno(r, "Failed to decode hex PCR data '%s': %m", s);
return r;
}
- r = table_print_with_pager(table, arg_json_format_flags, arg_pager_flags, /* show_header= */true);
+ r = table_print_with_pager(table, arg_json_format_flags, arg_pager_flags, /* show_header= */ true);
if (r < 0)
return r;
if (r < 0)
return bus_log_connect_error(r, arg_transport, arg_runtime_scope);
- n = acquire_boot_times(bus, /* require_finished = */ true, &boot);
+ n = acquire_boot_times(bus, /* require_finished= */ true, &boot);
if (n < 0)
return n;
return n;
}
- n = acquire_time_data(bus, /* require_finished = */ true, ×);
+ n = acquire_time_data(bus, /* require_finished= */ true, ×);
if (n <= 0)
return n;
return log_error_errno(r, "Failed to set columns to display: %m");
}
- r = table_print_with_pager(details_table, json_format_flags, pager_flags, /* show_header= */true);
+ r = table_print_with_pager(details_table, json_format_flags, pager_flags, /* show_header= */ true);
if (r < 0)
return r;
}
fflush(stdout);
}
- r = table_print_with_pager(overview_table, json_format_flags, pager_flags, /* show_header= */true);
+ r = table_print_with_pager(overview_table, json_format_flags, pager_flags, /* show_header= */ true);
if (r < 0)
return r;
}
unsigned line = 0, column = 0;
if (arg_security_policy) {
- r = sd_json_parse_file(/*f=*/ NULL, arg_security_policy, /*flags=*/ 0, &policy, &line, &column);
+ r = sd_json_parse_file(/* f= */ NULL, arg_security_policy, /* flags= */ 0, &policy, &line, &column);
if (r < 0)
return log_error_errno(r, "Failed to parse '%s' at %u:%u: %m", arg_security_policy, line, column);
} else {
_cleanup_fclose_ FILE *f = NULL;
_cleanup_free_ char *pp = NULL;
- r = search_and_fopen_nulstr("systemd-analyze-security.policy", "re", /*root=*/ NULL, CONF_PATHS_NULSTR("systemd"), &f, &pp);
+ r = search_and_fopen_nulstr("systemd-analyze-security.policy", "re", /* root= */ NULL, CONF_PATHS_NULSTR("systemd"), &f, &pp);
if (r < 0 && r != -ENOENT)
return r;
if (f) {
- r = sd_json_parse_file(f, pp, /*flags=*/ 0, &policy, &line, &column);
+ r = sd_json_parse_file(f, pp, /* flags= */ 0, &policy, &line, &column);
if (r < 0)
return log_error_errno(r, "[%s:%u:%u] Failed to parse JSON policy: %m", pp, line, column);
}
arg_profile,
arg_json_format_flags,
arg_pager_flags,
- /*flags=*/ 0);
+ /* flags= */ 0);
}
BootTimes *t;
int r;
- r = acquire_boot_times(bus, /* require_finished = */ true, &t);
+ r = acquire_boot_times(bus, /* require_finished= */ true, &t);
if (r < 0)
return r;
} else
assert_not_reached();
- r = strv_extend_strv(&debugger_call, arg_debugger_args, /* filter_duplicates = */ false);
+ r = strv_extend_strv(&debugger_call, arg_debugger_args, /* filter_duplicates= */ false);
if (r < 0)
return log_oom();
unit_dump(u, stdout, "\t");
log_unit_debug(u, "Creating %s/start job", u->id);
- r = manager_add_job(u->manager, JOB_START, u, JOB_REPLACE, &error, /* ret = */ NULL);
+ r = manager_add_job(u->manager, JOB_START, u, JOB_REPLACE, &error, /* ret= */ NULL);
if (r < 0)
log_unit_error_errno(u, r, "Failed to create %s/start: %s", u->id, bus_error_message(&error, r));
if (r < 0)
return r;
- r = sd_device_enumerator_add_match_subsystem(e, "pci", /* match = */ true);
+ r = sd_device_enumerator_add_match_subsystem(e, "pci", /* match= */ true);
if (r < 0)
return r;
/* class is an unsigned number, let's validate the value later. */
- r = sd_device_enumerator_add_match_sysattr(e, "class", NULL, /* match = */ true);
+ r = sd_device_enumerator_add_match_sysattr(e, "class", NULL, /* match= */ true);
if (r < 0)
return r;
if (r < 0)
return log_debug_errno(r, "Failed to allow uninitialized devices: %m");
- r = sd_device_enumerator_add_match_subsystem(enumerate, "backlight", /* match = */ true);
+ r = sd_device_enumerator_add_match_subsystem(enumerate, "backlight", /* match= */ true);
if (r < 0)
return log_debug_errno(r, "Failed to add subsystem match: %m");
if (r < 0)
return log_debug_errno(r, "Failed to add sysname unmatch: %m");
- r = sd_device_enumerator_add_match_sysattr(enumerate, "type", "platform", /* match = */ true);
+ r = sd_device_enumerator_add_match_sysattr(enumerate, "type", "platform", /* match= */ true);
if (r < 0)
return log_debug_errno(r, "Failed to add sysattr match: %m");
- r = sd_device_enumerator_add_match_sysattr(enumerate, "type", "firmware", /* match = */ true);
+ r = sd_device_enumerator_add_match_sysattr(enumerate, "type", "firmware", /* match= */ true);
if (r < 0)
return log_debug_errno(r, "Failed to add sysattr match: %m");
if (r < 0)
return log_device_error_errno(device, r, "Failed to read current brightness: %m");
- (void) clamp_brightness(device, percent, /* saved = */ false, max_brightness, &brightness);
+ (void) clamp_brightness(device, percent, /* saved= */ false, max_brightness, &brightness);
} else if (clamp)
- (void) clamp_brightness(device, percent, /* saved = */ true, max_brightness, &brightness);
+ (void) clamp_brightness(device, percent, /* saved= */ true, max_brightness, &brightness);
r = sd_device_set_sysattr_valuef(device, "brightness", "%u", brightness);
if (r < 0)
const char *e;
if (find_environment_binary(fn, &e) >= 0) {
/* The environment variable counts. We'd fail if the executable is not available/invalid. */
- r = open_and_check_executable(e, /* root = */ NULL, ret_path, &fd);
+ r = open_and_check_executable(e, /* root= */ NULL, ret_path, &fd);
if (r < 0)
return r;
_cleanup_free_ char *np = NULL;
if (find_build_dir_binary(fn, &np) >= 0) {
- r = open_and_check_executable(np, /* root = */ NULL, ret_path, &fd);
+ r = open_and_check_executable(np, /* root= */ NULL, ret_path, &fd);
if (r >= 0)
return fd;
}
- r = find_executable_full(path, /* root = */ NULL,
- /* exec_search_path = */ NULL, /* use_path_envvar = */ true,
+ r = find_executable_full(path, /* root= */ NULL,
+ /* exec_search_path= */ NULL, /* use_path_envvar= */ true,
ret_path, &fd);
if (r < 0)
return r;
/* This is not recursive! */
- r = cg_get_path(path, /* suffix = */ NULL, &fs);
+ r = cg_get_path(path, /* suffix= */ NULL, &fs);
if (r < 0)
return r;
assert(name);
assert(value || size <= 0);
- r = cg_get_path(path, /* suffix = */ NULL, &fs);
+ r = cg_get_path(path, /* suffix= */ NULL, &fs);
if (r < 0)
return r;
assert(path);
assert(name);
- r = cg_get_path(path, /* suffix = */ NULL, &fs);
+ r = cg_get_path(path, /* suffix= */ NULL, &fs);
if (r < 0)
return r;
assert(path);
assert(name);
- r = cg_get_path(path, /* suffix = */ NULL, &fs);
+ r = cg_get_path(path, /* suffix= */ NULL, &fs);
if (r < 0)
return r;
assert(path);
assert(name);
- r = cg_get_path(path, /* suffix = */ NULL, &fs);
+ r = cg_get_path(path, /* suffix= */ NULL, &fs);
if (r < 0)
return r;
const char *s;
int n;
- n = path_find_first_component(&p, /* accept_dot_dot = */ false, &s);
+ n = path_find_first_component(&p, /* accept_dot_dot= */ false, &s);
if (n < 0)
return n;
if (!valid_slice_name(s, n))
assert(ret_uid);
- r = cg_get_path(path, /* suffix = */ NULL, &f);
+ r = cg_get_path(path, /* suffix= */ NULL, &f);
if (r < 0)
return r;
if (r < 0)
return r;
- r = read_full_file(filename, &contents, /* ret_size = */ NULL);
+ r = read_full_file(filename, &contents, /* ret_size= */ NULL);
if (r < 0)
return r;
}
/* Otherwise let's pin it by file descriptor, via O_PATH. */
- child = r = openat_opath_with_automount(fd, first, /* automount = */ FLAGS_SET(flags, CHASE_TRIGGER_AUTOFS));
+ child = r = openat_opath_with_automount(fd, first, /* automount= */ FLAGS_SET(flags, CHASE_TRIGGER_AUTOFS));
if (r < 0) {
if (r != -ENOENT)
return r;
int set_proj_id_recursive(int fd, uint32_t proj_id) {
return recurse_dir_at(
fd,
- /* path = */ NULL,
- /* statx_mask = */ 0,
- /* n_depth_max = */ UINT_MAX,
+ /* path= */ NULL,
+ /* statx_mask= */ 0,
+ /* n_depth_max= */ UINT_MAX,
RECURSE_DIR_ENSURE_TYPE|RECURSE_DIR_TOPLEVEL|RECURSE_DIR_INODE_FD,
set_proj_id_cb,
UINT32_TO_PTR(proj_id));
CHASE_AT_RESOLVE_IN_ROOT |
CHASE_MUST_BE_DIRECTORY |
(FLAGS_SET(chase_flags, CHASE_NONEXISTENT) ? CHASE_NONEXISTENT : 0),
- &resolved_dirpath, /* ret_fd = */ NULL);
+ &resolved_dirpath, /* ret_fd= */ NULL);
if (r < 0)
return log_debug_errno(r, "Failed to chase '%s%s': %m", empty_to_root(root), skip_leading_slash(dirpath));
}
_cleanup_free_ char *root_abs = NULL;
_cleanup_close_ int rfd = -EBADF;
- r = prepare_dirs(root, /* dirs = */ NULL, &rfd, &root_abs, /* ret_dirs = */ NULL);
+ r = prepare_dirs(root, /* dirs= */ NULL, &rfd, &root_abs, /* ret_dirs= */ NULL);
if (r < 0)
return r;
return r;
r = conf_files_list_impl(suffix, rfd, root_abs, flags, (const char * const *) dirs_abs,
- /* replacement = */ NULL, &fh, /* ret_inserted = */ NULL);
+ /* replacement= */ NULL, &fh, /* ret_inserted= */ NULL);
if (r < 0)
return r;
return r;
r = conf_files_list_impl(suffix, rfd, root_abs, flags, (const char * const *) dirs_abs,
- /* replacement = */ NULL, &fh, /* ret_inserted = */ NULL);
+ /* replacement= */ NULL, &fh, /* ret_inserted= */ NULL);
if (r < 0)
return r;
if (rfd >= 0 && DEBUG_LOGGING)
(void) fd_get_path(rfd, &root); /* for logging */
- r = conf_files_list_impl(suffix, rfd, root, flags, dirs, /* replacement = */ NULL, &fh, /* ret_inserted = */ NULL);
+ r = conf_files_list_impl(suffix, rfd, root, flags, dirs, /* replacement= */ NULL, &fh, /* ret_inserted= */ NULL);
if (r < 0)
return r;
- return copy_and_sort_files_from_hashmap(fh, suffix, /* root = */ NULL, flags, ret);
+ return copy_and_sort_files_from_hashmap(fh, suffix, /* root= */ NULL, flags, ret);
}
int conf_files_list_strv_at_full(
if (rfd >= 0 && DEBUG_LOGGING)
(void) fd_get_path(rfd, &root); /* for logging */
- r = conf_files_list_impl(suffix, rfd, root, flags, dirs, /* replacement = */ NULL, &fh, /* ret_inserted = */ NULL);
+ r = conf_files_list_impl(suffix, rfd, root, flags, dirs, /* replacement= */ NULL, &fh, /* ret_inserted= */ NULL);
if (r < 0)
return r;
- return dump_files(fh, /* root = */ NULL, ret_files, ret_n_files);
+ return dump_files(fh, /* root= */ NULL, ret_files, ret_n_files);
}
int conf_files_list(char ***ret, const char *suffix, const char *root, ConfFilesFlags flags, const char *dir) {
* accidentally however, hence let's unset the bit first. */
r = chattr_full(AT_FDCWD, p,
- /* value = */ 0,
- /* mask = */ FS_IMMUTABLE_FL,
- /* ret_previous = */ &saved_flags,
- /* ret_final = */ NULL,
- /* flags = */ 0);
+ /* value= */ 0,
+ /* mask= */ FS_IMMUTABLE_FL,
+ /* ret_previous= */ &saved_flags,
+ /* ret_final= */ NULL,
+ /* flags= */ 0);
if (r < 0 && r != -ENOENT)
log_debug_errno(r, "Failed to drop FS_IMMUTABLE_FL flag from '%s', ignoring: %m", p);
/* For some reason efivarfs doesn't update mtime automatically. Let's do it manually then. This is
* useful for processes that cache EFI variables to detect when changes occurred. */
- if (futimens(fd, /* times = */ NULL) < 0)
+ if (futimens(fd, /* times= */ NULL) < 0)
log_debug_errno(errno, "Failed to update mtime/atime on %s, ignoring: %m", p);
r = 0;
_cleanup_free_ char *p = NULL;
const char *s = line;
- r = extract_first_word(&s, &p, /* separators = */ NULL, /* flags = */ 0);
+ r = extract_first_word(&s, &p, /* separators= */ NULL, /* flags= */ 0);
if (r < 0)
return r;
if (r == 0)
/* Support for AT_EMPTY_PATH is added rather late (kernel 5.8), so fall back to going through /proc/
* if unavailable. */
- if (utimensat(AT_FDCWD, FORMAT_PROC_FD_PATH(fd), ts, /* flags = */ 0) < 0) {
+ if (utimensat(AT_FDCWD, FORMAT_PROC_FD_PATH(fd), ts, /* flags= */ 0) < 0) {
if (errno != ENOENT)
return -errno;
return 0;
}
- k = is_dir(def, /* follow = */ true);
+ k = is_dir(def, /* follow= */ true);
if (k == 0)
k = -ENOTDIR;
if (k < 0)
if (r < 0)
return r;
- return strv_extend_strv_consume(strv, v, /* filter_duplicates = */ false);
+ return strv_extend_strv_consume(strv, v, /* filter_duplicates= */ false);
}
int glob_non_glob_prefix(const char *path, char **ret) {
fd = xopenat_lock_full(dfd,
p,
O_CREAT|O_RDWR|O_NOFOLLOW|O_CLOEXEC|O_NOCTTY,
- /* xopen_flags = */ 0,
+ /* xopen_flags= */ 0,
0600,
LOCK_UNPOSIX,
operation);
}
int posix_lock(int fd, int operation) {
- return fcntl_lock(fd, operation, /*ofd=*/ false);
+ return fcntl_lock(fd, operation, /* ofd= */ false);
}
int unposix_lock(int fd, int operation) {
- return fcntl_lock(fd, operation, /*ofd=*/ true);
+ return fcntl_lock(fd, operation, /* ofd= */ true);
}
void posix_unlockpp(int **fd) {
if (!*fd || **fd < 0)
return;
- (void) fcntl_lock(**fd, LOCK_UN, /*ofd=*/ false);
+ (void) fcntl_lock(**fd, LOCK_UN, /* ofd= */ false);
*fd = NULL;
}
if (!*fd || **fd < 0)
return;
- (void) fcntl_lock(**fd, LOCK_UN, /*ofd=*/ true);
+ (void) fcntl_lock(**fd, LOCK_UN, /* ofd= */ true);
*fd = NULL;
}
DEFINE_TRIVIAL_REF_UNREF_FUNC(LogContext, log_context, log_context_free);
LogContext* log_context_new_strv_consume(char **fields) {
- LogContext *c = log_context_new_strv(fields, /*owned=*/ true);
+ LogContext *c = log_context_new_strv(fields, /* owned= */ true);
if (!c)
strv_free(fields);
}
LogContext* log_context_new_iov_consume(struct iovec *input_iovec, size_t n_input_iovec) {
- LogContext *c = log_context_new_iov(input_iovec, n_input_iovec, /*owned=*/ true);
+ LogContext *c = log_context_new_iov(input_iovec, n_input_iovec, /* owned= */ true);
if (!c)
iovec_array_free(input_iovec, n_input_iovec);
_LOG_CONTEXT_PUSH_KEY_VALUE(key, value, UNIQ_T(c, UNIQ))
#define _LOG_CONTEXT_PUSH_STRV(strv, c) \
- _unused_ _cleanup_(log_context_unrefp) LogContext *c = log_context_new_strv(strv, /*owned=*/ false);
+ _unused_ _cleanup_(log_context_unrefp) LogContext *c = log_context_new_strv(strv, /* owned= */ false);
#define LOG_CONTEXT_PUSH_STRV(strv) \
_LOG_CONTEXT_PUSH_STRV(strv, UNIQ_T(c, UNIQ))
#define _LOG_CONTEXT_PUSH_IOV(input_iovec, n_input_iovec, c) \
- _unused_ _cleanup_(log_context_unrefp) LogContext *c = log_context_new_iov(input_iovec, n_input_iovec, /*owned=*/ false);
+ _unused_ _cleanup_(log_context_unrefp) LogContext *c = log_context_new_iov(input_iovec, n_input_iovec, /* owned= */ false);
#define LOG_CONTEXT_PUSH_IOV(input_iovec, n_input_iovec) \
_LOG_CONTEXT_PUSH_IOV(input_iovec, n_input_iovec, UNIQ_T(c, UNIQ))
log_syntax_parse_error_internal(unit, config_file, config_line, error, critical, PROJECT_FILE, __LINE__, __func__, lvalue, rvalue)
#define log_syntax_parse_error(unit, config_file, config_line, error, lvalue, rvalue) \
- log_syntax_parse_error_full(unit, config_file, config_line, error, /* critical = */ false, lvalue, rvalue)
+ log_syntax_parse_error_full(unit, config_file, config_line, error, /* critical= */ false, lvalue, rvalue)
#define DEBUG_LOGGING _unlikely_(log_get_max_level() >= LOG_DEBUG)
/* drop the last component */
path = strndupa_safe(path, e - path);
- r = is_dir_at(dir_fd, path, /* follow = */ true);
+ r = is_dir_at(dir_fd, path, /* follow= */ true);
if (r > 0)
return 0;
if (r == 0)
const char *p, *q;
int r, s;
- r = path_find_first_component(&a, /* accept_dot_dot = */ false, &p);
+ r = path_find_first_component(&a, /* accept_dot_dot= */ false, &p);
if (r < 0)
return r;
- s = path_find_first_component(&b, /* accept_dot_dot = */ false, &q);
+ s = path_find_first_component(&b, /* accept_dot_dot= */ false, &q);
if (s < 0)
return s;
_cleanup_close_ int our_fd = -EBADF;
if (pid_fd < 0) {
- our_fd = pidfd_open(getpid_cached(), /* flags = */ 0);
+ our_fd = pidfd_open(getpid_cached(), /* flags= */ 0);
if (our_fd < 0)
return -errno;
if (a[1] == '-') {
if (a[2] == '\0') {
/* "--" is specified, accepting remaining strings. */
- r = strv_extend_strv(&filtered, strv_skip(p, 1), /* filter_duplicates = */ false);
+ r = strv_extend_strv(&filtered, strv_skip(p, 1), /* filter_duplicates= */ false);
if (r < 0)
return r;
break;
if (detect_container() > 0) {
_cleanup_strv_free_ char **args = NULL;
- r = pid_get_cmdline_strv(1, /* flags = */ 0, &args);
+ r = pid_get_cmdline_strv(1, /* flags= */ 0, &args);
if (r < 0)
return r;
}
int proc_cmdline_strv(char ***ret) {
- return proc_cmdline_strv_internal(ret, /* filter_pid1_args = */ false);
+ return proc_cmdline_strv_internal(ret, /* filter_pid1_args= */ false);
}
static char *mangle_word(const char *word, ProcCmdlineFlags flags) {
* for proc_cmdline_parse(), let's make this clear. */
assert(!(flags & (PROC_CMDLINE_VALUE_OPTIONAL|PROC_CMDLINE_TRUE_WHEN_MISSING)));
- r = proc_cmdline_strv_internal(&args, /* filter_pid1_args = */ true);
+ r = proc_cmdline_strv_internal(&args, /* filter_pid1_args= */ true);
if (r < 0)
return r;
if (FLAGS_SET(flags, PROC_CMDLINE_VALUE_OPTIONAL) && !ret_value)
return -EINVAL;
- r = proc_cmdline_strv_internal(&args, /* filter_pid1_args = */ true);
+ r = proc_cmdline_strv_internal(&args, /* filter_pid1_args= */ true);
if (r < 0)
return r;
/* Drop trailing NULs, otherwise strv_parse_nulstr() adds additional empty strings at the end.
* See also issue #21186. */
- args = strv_parse_nulstr_full(t, k, /* drop_trailing_nuls = */ true);
+ args = strv_parse_nulstr_full(t, k, /* drop_trailing_nuls= */ true);
if (!args)
return -ENOMEM;
if (r < 0)
return r;
- args = strv_parse_nulstr_full(t, k, /* drop_trailing_nuls = */ true);
+ args = strv_parse_nulstr_full(t, k, /* drop_trailing_nuls= */ true);
if (!args)
return -ENOMEM;
/* The issue here is that it's impossible to distinguish between an error code returned by child and
* IO error arose when reading it. So, the function logs errors and return EIO for the later case. */
- ssize_t n = loop_read(errno_fd, &r, sizeof(r), /* do_poll = */ false);
+ ssize_t n = loop_read(errno_fd, &r, sizeof(r), /* do_poll= */ false);
if (n < 0) {
log_debug_errno(n, "Failed to read errno: %m");
return -EIO;
assert(s);
assert(ret);
- r = extract_first_word(&s, &w, /* separators = */ NULL, /* flags = */ 0);
+ r = extract_first_word(&s, &w, /* separators= */ NULL, /* flags= */ 0);
if (r < 0)
return r;
if (r == 0)
typedef struct RateLimit {
usec_t interval; /* Keep those two fields first so they can be initialized easily: */
- unsigned burst; /* RateLimit rl = { INTERVAL, BURST }; */
+ unsigned burst; /* RateLimit rl = { INTERVAL, BURST }; */
unsigned num;
usec_t begin;
} RateLimit;
r = func(RECURSE_DIR_SKIP_OPEN_DIR_ERROR_BASE + errno,
p,
dir_fd,
- /* inode_fd = */ -EBADF,
+ /* inode_fd= */ -EBADF,
i,
- /* sx = */ NULL,
+ /* sx= */ NULL,
userdata);
if (r == RECURSE_DIR_LEAVE_DIRECTORY)
break;
r = func(RECURSE_DIR_SKIP_OPEN_INODE_ERROR_BASE + errno,
p,
dir_fd,
- /* inode_fd = */ -EBADF,
+ /* inode_fd= */ -EBADF,
i,
- /* sx = */ NULL,
+ /* sx= */ NULL,
userdata);
if (r == RECURSE_DIR_LEAVE_DIRECTORY)
break;
r = func(RECURSE_DIR_SKIP_STAT_INODE_ERROR_BASE + errno,
p,
dir_fd,
- /* inode_fd = */ -EBADF,
+ /* inode_fd= */ -EBADF,
i,
- /* sx = */ NULL,
+ /* sx= */ NULL,
userdata);
if (r == RECURSE_DIR_LEAVE_DIRECTORY)
break;
r = func(RECURSE_DIR_SKIP_STAT_INODE_ERROR_BASE + EISDIR,
p,
dir_fd,
- /* inode_fd = */ -EBADF,
+ /* inode_fd= */ -EBADF,
i,
- /* sx = */ NULL,
+ /* sx= */ NULL,
userdata);
if (r == RECURSE_DIR_LEAVE_DIRECTORY)
break;
if (sx_valid && FLAGS_SET(sx.stx_attributes_mask, STATX_ATTR_MOUNT_ROOT))
is_mount = FLAGS_SET(sx.stx_attributes, STATX_ATTR_MOUNT_ROOT);
else {
- r = is_mount_point_at(dir_fd, i->d_name, /* flags = */ 0);
+ r = is_mount_point_at(dir_fd, i->d_name, /* flags= */ 0);
if (r < 0)
log_debug_errno(r, "Failed to determine whether %s is a submount, assuming not: %m", p);
const char *p = procfs_file_alloca(pid, "limits");
_cleanup_free_ char *limits = NULL;
- r = read_full_file(p, &limits, /* ret_size = */ NULL);
+ r = read_full_file(p, &limits, /* ret_size= */ NULL);
if (r < 0)
return -EPERM; /* propagate original permission error if we can't access the limits file */
return -ENOMEM;
}
- l = mq_receive(fd, buf, attr.mq_msgsize, /* msg_prio = */ NULL);
+ l = mq_receive(fd, buf, attr.mq_msgsize, /* msg_prio= */ NULL);
if (l < 0) {
if (errno == EINTR)
continue;
x = ((new_length - need_space) * percent + 50) / 100;
assert(x <= new_length - need_space);
- write_ellipsis(mempcpy(t, s, x), /* unicode = */ false);
+ write_ellipsis(mempcpy(t, s, x), /* unicode= */ false);
suffix_len = new_length - x - need_space;
memcpy(t + x + 3, s + old_length - suffix_len, suffix_len);
*(t + x + 3 + suffix_len) = '\0';
return NULL;
memcpy_safe(e, s, len);
- write_ellipsis(e + len, /* unicode = */ true);
+ write_ellipsis(e + len, /* unicode= */ true);
char *dst = e + len + 3;
}
if (i + 4 <= len) /* yay, enough space */
- i += write_ellipsis(buf + i, /* unicode = */ false);
+ i += write_ellipsis(buf + i, /* unicode= */ false);
else if (i + 3 <= len) { /* only space for ".." */
buf[i++] = '.';
buf[i++] = '.';
va_list ap;
va_start(ap, n);
- char *x = strextendv_with_separator(/* x= */ NULL, /* separator=*/ NULL, ap);
+ char *x = strextendv_with_separator(/* x= */ NULL, /* separator= */ NULL, ap);
va_end(ap);
if (!x)
return -ENOMEM;
/* n_columns= */ SIZE_MAX,
/* column_width= */ SIZE_MAX,
/* ellipsize_percentage= */ 0,
- /* grey_prefix=*/ string,
+ /* grey_prefix= */ string,
/* with_numbers= */ false);
if (r < 0)
goto fail;
.fd = notify,
.events = POLLIN,
},
- /* n_fds = */ 1,
+ /* n_fds= */ 1,
left,
&poll_ss);
if (r < 0)
* about whether it's strictly valid, but only asking "does this fall into the vt category?", for which
* "yes" seems to be a better answer. */
- return vtnr_from_tty_raw(tty, /* ret = */ NULL) >= 0;
+ return vtnr_from_tty_raw(tty, /* ret= */ NULL) >= 0;
}
bool tty_is_console(const char *tty) {
if (!colskey)
return -ENOMEM;
- r = proc_cmdline_get_key_many(/* flags = */ 0,
+ r = proc_cmdline_get_key_many(/* flags= */ 0,
rowskey, &rowsvalue,
colskey, &colsvalue);
if (r < 0)
_cleanup_close_pair_ int pair[2] = EBADF_PAIR;
int r;
- r = pidref_namespace_open(pidref, &pidnsfd, &mntnsfd, /* ret_netns_fd = */ NULL, &usernsfd, &rootfd);
+ r = pidref_namespace_open(pidref, &pidnsfd, &mntnsfd, /* ret_netns_fd= */ NULL, &usernsfd, &rootfd);
if (r < 0)
return r;
size_t t_len = strlen(t);
if (t_len > 2 && t[t_len - 1] == 'Z') {
/* Try to parse as RFC3339-style welded UTC: "1985-04-12T23:20:50.52Z" */
- r = parse_timestamp_impl(t, t_len - 1, /* utc = */ true, /* isdst = */ -1, /* gmtoff = */ 0, ret);
+ r = parse_timestamp_impl(t, t_len - 1, /* utc= */ true, /* isdst= */ -1, /* gmtoff= */ 0, ret);
if (r >= 0)
return r;
}
/* RFC3339-style welded offset: "1990-12-31T15:59:60-08:00" */
if (t_len > 7 && IN_SET(t[t_len - 6], '+', '-') && t[t_len - 7] != ' ' && parse_gmtoff(&t[t_len - 6], &gmtoff) >= 0)
- return parse_timestamp_impl(t, t_len - 6, /* utc = */ true, /* isdst = */ -1, gmtoff, ret);
+ return parse_timestamp_impl(t, t_len - 6, /* utc= */ true, /* isdst= */ -1, gmtoff, ret);
const char *tz = strrchr(t, ' ');
if (!tz)
- return parse_timestamp_impl(t, /* max_len = */ SIZE_MAX, /* utc = */ false, /* isdst = */ -1, /* gmtoff = */ 0, ret);
+ return parse_timestamp_impl(t, /* max_len= */ SIZE_MAX, /* utc= */ false, /* isdst= */ -1, /* gmtoff= */ 0, ret);
size_t max_len = tz - t;
tz++;
/* Shortcut, parse the string as UTC. */
if (streq(tz, "UTC"))
- return parse_timestamp_impl(t, max_len, /* utc = */ true, /* isdst = */ -1, /* gmtoff = */ 0, ret);
+ return parse_timestamp_impl(t, max_len, /* utc= */ true, /* isdst= */ -1, /* gmtoff= */ 0, ret);
/* If the timezone is compatible with RFC-822/ISO 8601 (e.g. +06, or -03:00) then parse the string as
* UTC and shift the result. Note, this must be earlier than the timezone check with tzname[], as
* tzname[] may be in the same format. */
if (parse_gmtoff(tz, &gmtoff) >= 0)
- return parse_timestamp_impl(t, max_len, /* utc = */ true, /* isdst = */ -1, gmtoff, ret);
+ return parse_timestamp_impl(t, max_len, /* utc= */ true, /* isdst= */ -1, gmtoff, ret);
/* Check if the last word matches tzname[] of the local timezone. Note, this must be done earlier
* than the check by timezone_is_valid() below, as some short timezone specifications have their own
continue;
/* The specified timezone matches tzname[] of the local timezone. */
- return parse_timestamp_impl(t, max_len, /* utc = */ false, /* isdst = */ j, /* gmtoff = */ 0, ret);
+ return parse_timestamp_impl(t, max_len, /* utc= */ false, /* isdst= */ j, /* gmtoff= */ 0, ret);
}
/* If the last word is a valid timezone file (e.g. Asia/Tokyo), then save the current timezone, apply
if (timezone_is_valid(tz, LOG_DEBUG)) {
SAVE_TIMEZONE;
- if (setenv("TZ", tz, /* overwrite = */ true) < 0)
+ if (setenv("TZ", tz, /* overwrite= */ true) < 0)
return negative_errno();
- return parse_timestamp_impl(t, max_len, /* utc = */ false, /* isdst = */ -1, /* gmtoff = */ 0, ret);
+ return parse_timestamp_impl(t, max_len, /* utc= */ false, /* isdst= */ -1, /* gmtoff= */ 0, ret);
}
/* Otherwise, assume that the last word is a part of the time and try to parse the whole string as a
* local time. */
- return parse_timestamp_impl(t, SIZE_MAX, /* utc = */ false, /* isdst = */ -1, /* gmtoff = */ 0, ret);
+ return parse_timestamp_impl(t, SIZE_MAX, /* utc= */ false, /* isdst= */ -1, /* gmtoff= */ 0, ret);
}
static const char* extract_multiplier(const char *p, usec_t *ret) {
assert(t);
assert(default_unit > 0);
- p = skip_leading_chars(t, /* bad = */ NULL);
+ p = skip_leading_chars(t, /* bad= */ NULL);
s = startswith(p, "infinity");
if (s) {
if (!in_charset(s, WHITESPACE))
long long l;
char *e;
- p = skip_leading_chars(p, /* bad = */ NULL);
+ p = skip_leading_chars(p, /* bad= */ NULL);
if (*p == 0) {
if (!something)
return -EINVAL;
void reset_timezonep(char **p) {
assert(p);
- (void) set_unset_env("TZ", *p, /* overwrite = */ true);
+ (void) set_unset_env("TZ", *p, /* overwrite= */ true);
tzset();
*p = mfree(*p);
}
_warn_unused_result_
static inline char* format_timestamp_relative(char *buf, size_t l, usec_t t) {
- return format_timestamp_relative_full(buf, l, t, CLOCK_REALTIME, /* implicit_left = */ false);
+ return format_timestamp_relative_full(buf, l, t, CLOCK_REALTIME, /* implicit_left= */ false);
}
_warn_unused_result_
static inline char* format_timestamp_relative_monotonic(char *buf, size_t l, usec_t t) {
- return format_timestamp_relative_full(buf, l, t, CLOCK_MONOTONIC, /* implicit_left = */ false);
+ return format_timestamp_relative_full(buf, l, t, CLOCK_MONOTONIC, /* implicit_left= */ false);
}
_warn_unused_result_
* /foo/bar/.#<extra>waldoXXXXXX
*/
- return tempfn_build(p, extra, "XXXXXX", /* child = */ false, ret);
+ return tempfn_build(p, extra, "XXXXXX", /* child= */ false, ret);
}
int tempfn_random(const char *p, const char *extra, char **ret) {
if (asprintf(&s, "%016" PRIx64, random_u64()) < 0)
return -ENOMEM;
- return tempfn_build(p, extra, s, /* child = */ false, ret);
+ return tempfn_build(p, extra, s, /* child= */ false, ret);
}
int tempfn_random_child(const char *p, const char *extra, char **ret) {
if (asprintf(&s, "%016" PRIx64, random_u64()) < 0)
return -ENOMEM;
- return tempfn_build(p, extra, s, /* child = */ true, ret);
+ return tempfn_build(p, extra, s, /* child= */ true, ret);
}
int open_tmpfile_unlinkable(const char *directory, int flags) {
if (r < 0)
return r;
- return uid_range_add_internal(range, start, end - start + 1, /* coalesce = */ true);
+ return uid_range_add_internal(range, start, end - start + 1, /* coalesce= */ true);
}
int uid_range_next_lower(const UIDRange *range, uid_t *uid) {
&range,
IN_SET(mode, UID_RANGE_USERNS_INSIDE, GID_RANGE_USERNS_INSIDE) ? uid_base : uid_shift,
uid_range,
- /* coalesce = */ false);
+ /* coalesce= */ false);
if (r < 0)
return r;
}
if (getenv_bool("SYSTEMD_IGNORE_CHROOT") > 0)
return 0;
- r = inode_same("/proc/1/root", "/", /* flags = */ 0);
+ r = inode_same("/proc/1/root", "/", /* flags= */ 0);
if (r == -ENOENT) {
r = proc_mounted();
if (r == 0) {
usec = now(CLOCK_REALTIME);
le = htole64((uint64_t) usec);
- return xsetxattr_full(fd, /* path = */ NULL, AT_EMPTY_PATH,
+ return xsetxattr_full(fd, /* path= */ NULL, AT_EMPTY_PATH,
"user.crtime_usec", (const char*) &le, sizeof(le),
- /* xattr_flags = */ 0);
+ /* xattr_flags= */ 0);
}
bool xattr_is_acl(const char *name) {
log_warning_errno(fd, "Failed to open console, ignoring: %m");
else
dprintf(fd, ANSI_HIGHLIGHT_RED "%s " BATTERY_LOW_MESSAGE ANSI_NORMAL "\n",
- glyph_full(GLYPH_LOW_BATTERY, /* force_utf = */ false));
+ glyph_full(GLYPH_LOW_BATTERY, /* force_utf= */ false));
if (asprintf(&plymouth_message, "%s " BATTERY_LOW_MESSAGE,
- glyph_full(GLYPH_LOW_BATTERY, /* force_utf = */ true)) < 0)
+ glyph_full(GLYPH_LOW_BATTERY, /* force_utf= */ true)) < 0)
return log_oom();
(void) plymouth_send_message("shutdown", plymouth_message);
}
}
-DEFINE_EFI_MAIN_FUNCTION(run, "systemd-boot", /*wait_for_debugger=*/false);
+DEFINE_EFI_MAIN_FUNCTION(run, "systemd-boot", /* wait_for_debugger= */ false);
return EFI_SUCCESS;
}
- str = dp_to_text->ConvertDevicePathToText(dp, /* DisplayOnly=*/ false, /* AllowShortcuts= */ false);
+ str = dp_to_text->ConvertDevicePathToText(dp, /* DisplayOnly= */ false, /* AllowShortcuts= */ false);
if (!str)
return EFI_OUT_OF_RESOURCES;
#define FWHEADERMAGIC (UINT32_C(0xfeeddead))
-/* The structure of the efifw UKI blob is the following:
- * ---------------------------------------------------------
- * EfiFw header|fwid|payload| reserved for future attributes
- * ---------------------------------------------------------
- * The base header defines the length of full header, fwid and payload.
- * The fwid is a NUL terminated string.
- * The payload contains the actual efi firmware.
- */
+/* The structure of the efifw UKI blob is the following:
+ * ---------------------------------------------------------
+ * EfiFw header|fwid|payload| reserved for future attributes
+ * ---------------------------------------------------------
+ * The base header defines the length of full header, fwid and payload.
+ * The fwid is a NUL terminated string.
+ * The payload contains the actual efi firmware. */
typedef struct EfiFwHeader {
uint32_t magic; /* magic number that defines Efifw */
uint32_t header_len; /* total length of header including all attributes */
});
- err = BS->LoadImage(/* BootPolicy= */false,
+ err = BS->LoadImage(/* BootPolicy= */ false,
parent,
&kernel_file_path->memmap_path.Header,
kernel->iov_base,
} _packed_ GptHeader;
assert_cc(sizeof(GptHeader) == 512);
-static bool verify_gpt(/*const*/ GptHeader *h, EFI_LBA lba_expected) {
+static bool verify_gpt(/* const */ GptHeader *h, EFI_LBA lba_expected) {
uint32_t crc32, crc32_saved;
EFI_STATUS err;
n_section_table,
section_names,
validate_base,
- /* device_table = */ NULL,
- /* device = */ NULL,
+ /* device_table= */ NULL,
+ /* device= */ NULL,
sections);
/* It doesn't make sense not to provide validate_base here */
n_section_table,
hwid_section_names,
validate_base,
- /* device_table = */ NULL,
- /* device = */ NULL,
+ /* device_table= */ NULL,
+ /* device= */ NULL,
hwids_section);
if (PE_SECTION_VECTOR_IS_SET(hwids_section)) {
}
if (need_custom_mode && !custom_mode_enabled()) {
- err = set_custom_mode(/* enable = */ true);
+ err = set_custom_mode(/* enable= */ true);
if (err != EFI_SUCCESS) {
log_error_status(err, "Failed to enable custom mode: %m");
goto out_deallocate;
if (file->size < file->offset)
return EFI_INVALID_PARAMETER;
- /* check device-independent bitmap */
+ /* check device-independent bitmap */
struct bmp_dib *dib = (struct bmp_dib *) (bmp + sizeof(struct bmp_file));
if (dib->size < SIZEOF_BMP_DIB)
return EFI_UNSUPPORTED;
if (!dest_path)
return log_oom();
- r = copy_file_with_version_check(source_path, dest_path, /* force = */ false);
+ r = copy_file_with_version_check(source_path, dest_path, /* force= */ false);
if (IN_SET(r, -ESTALE, -ESRCH))
continue;
RET_GATHER(ret, r);
if (r != -ENXIO)
log_debug_errno(r, "Failed to parse $SOURCE_DATE_EPOCH, ignoring: %m");
- r = localtime_or_gmtime_usec(epoch != UINT64_MAX ? epoch : now(CLOCK_REALTIME), /*utc=*/ true, &tm);
+ r = localtime_or_gmtime_usec(epoch != UINT64_MAX ? epoch : now(CLOCK_REALTIME), /* utc= */ true, &tm);
if (r < 0)
return log_error_errno(r, "Failed to convert timestamp to calendar time: %m");
return log_error_errno(SYNTHETIC_ERRNO(EIO), "Failed to write signature list to bio");
_cleanup_(PKCS7_freep) PKCS7 *p7 = NULL;
- p7 = PKCS7_sign(certificate, private_key, /*certs=*/ NULL, bio, PKCS7_DETACHED|PKCS7_NOATTR|PKCS7_BINARY|PKCS7_NOSMIMECAP);
+ p7 = PKCS7_sign(certificate, private_key, /* certs= */ NULL, bio, PKCS7_DETACHED|PKCS7_NOATTR|PKCS7_BINARY|PKCS7_NOSMIMECAP);
if (!p7)
return log_error_errno(SYNTHETIC_ERRNO(EIO), "Failed to calculate PKCS7 signature: %s",
ERR_error_string(ERR_get_error(), NULL));
}
if (arg_certificate_source_type == OPENSSL_CERTIFICATE_SOURCE_FILE) {
- r = parse_path_argument(arg_certificate, /*suppress_root=*/ false, &arg_certificate);
+ r = parse_path_argument(arg_certificate, /* suppress_root= */ false, &arg_certificate);
if (r < 0)
return r;
}
int vl_method_get_reboot_to_firmware(sd_varlink *link, sd_json_variant *parameters, sd_varlink_method_flags_t flags, void *userdata) {
int r;
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
/* ret_part= */ NULL,
/* ret_pstart= */ NULL,
/* ret_psize= */ NULL,
- /* ret_uuid=*/ NULL,
+ /* ret_uuid= */ NULL,
&esp_devid);
if (r == -EACCES) /* We really need the ESP path for this call, hence also log about access errors */
return log_error_errno(r, "Failed to determine ESP location: %m");
arg_root,
secure_getenv("KERNEL_INSTALL_CONF_ROOT"),
arg_machine_id,
- /* machine_id_is_random = */ false,
+ /* machine_id_is_random= */ false,
&arg_entry_token_type,
&arg_entry_token);
if (r < 0)
TABLE_SET_COLOR, ansi_highlight());
else
r = table_add_cell_stringf(
- table, /* ret_cell = */ NULL, ".%s", m->name);
+ table, /* ret_cell= */ NULL, ".%s", m->name);
if (r < 0)
return table_log_add_error(r);
return log_error_errno(r, "Failed to rewind: %m");
if (FLAGS_SET(flags, SD_BUS_MESSAGE_DUMP_SUBTREE_ONLY)) {
- r = sd_bus_message_peek_type(m, /* ret_type = */ NULL, &contents);
+ r = sd_bus_message_peek_type(m, /* ret_type= */ NULL, &contents);
if (r < 0)
return bus_log_parse_error(r);
fputs(FLAGS_SET(flags, SD_BUS_MESSAGE_DUMP_SUBTREE_ONLY) ? contents : sd_bus_message_get_signature(m, true), stdout);
fputc(' ', stdout);
- r = format_cmdline(m, stdout, /* needs_space = */ false);
+ r = format_cmdline(m, stdout, /* needs_space= */ false);
if (r < 0)
return bus_log_parse_error(r);
return log_error_errno(r, "Call failed: %s", bus_error_message(&error, r));
}
- return bus_message_dump(reply, /* flags = */ 0);
+ return bus_message_dump(reply, /* flags= */ 0);
}
static int emit_signal(int argc, char **argv, void *userdata) {
static int on_bus_signal(sd_bus_message *msg, void *userdata, sd_bus_error *ret_error) {
return sd_event_exit(sd_bus_get_event(sd_bus_message_get_bus(ASSERT_PTR(msg))),
- bus_message_dump(msg, /* flags = */ 0));
+ bus_message_dump(msg, /* flags= */ 0));
}
static int wait_signal(int argc, char **argv, void *userdata) {
if (t >= usec_add(last_refresh, arg_delay) || immediate_refresh) {
- r = refresh(root, a, b, iteration++, /* depth = */ 0, /* ret = */ NULL);
+ r = refresh(root, a, b, iteration++, /* depth= */ 0, /* ret= */ NULL);
if (r < 0)
return log_error_errno(r, "Failed to refresh: %m");
if (state != old_state)
log_unit_debug(UNIT(a), "Changed %s -> %s", automount_state_to_string(old_state), automount_state_to_string(state));
- unit_notify(UNIT(a), state_translation_table[old_state], state_translation_table[state], /* reload_success = */ true);
+ unit_notify(UNIT(a), state_translation_table[old_state], state_translation_table[state], /* reload_success= */ true);
}
static int automount_coldplug(Unit *u) {
goto fail;
}
- r = manager_add_job(UNIT(a)->manager, JOB_START, trigger, JOB_REPLACE, &error, /* ret = */ NULL);
+ r = manager_add_job(UNIT(a)->manager, JOB_START, trigger, JOB_REPLACE, &error, /* ret= */ NULL);
if (r < 0) {
log_unit_warning(UNIT(a), "Failed to queue mount startup job: %s", bus_error_message(&error, r));
goto fail;
goto fail;
}
- r = manager_add_job(UNIT(a)->manager, JOB_STOP, trigger, JOB_REPLACE, &error, /* ret = */ NULL);
+ r = manager_add_job(UNIT(a)->manager, JOB_STOP, trigger, JOB_REPLACE, &error, /* ret= */ NULL);
if (r < 0) {
log_unit_warning(UNIT(a), "Failed to queue unmount job: %s", bus_error_message(&error, r));
goto fail;
if (r < 0)
return log_error_errno(r, "Extending device control BPF program failed: %m");
- r = cg_get_path(cgroup_path, /* suffix = */ NULL, &controller_path);
+ r = cg_get_path(cgroup_path, /* suffix= */ NULL, &controller_path);
if (r < 0)
return log_error_errno(r, "Failed to determine cgroup path: %m");
return log_unit_debug_errno(u, SYNTHETIC_ERRNO(EOPNOTSUPP),
"bpf-firewall: BPF firewalling not supported, proceeding without.");
- r = cg_get_path(crt->cgroup_path, /* suffix = */ NULL, &path);
+ r = cg_get_path(crt->cgroup_path, /* suffix= */ NULL, &path);
if (r < 0)
return log_unit_error_errno(u, r, "bpf-firewall: Failed to determine cgroup path: %m");
if (!crt)
return 0;
- r = cg_get_path(crt->cgroup_path, /* suffix = */ NULL, &cgroup_path);
+ r = cg_get_path(crt->cgroup_path, /* suffix= */ NULL, &cgroup_path);
if (r < 0)
return log_unit_error_errno(u, r, "bpf-foreign: Failed to get cgroup path: %m");
assert(u->manager);
/* If we never successfully detected support, there is nothing to clean up. */
- if (!bpf_restrict_fs_supported(/* initialize = */ false))
+ if (!bpf_restrict_fs_supported(/* initialize= */ false))
return 0;
if (!u->manager->restrict_fs)
if (!crt)
return 0;
- r = cg_get_path(crt->cgroup_path, /* suffix = */ NULL, &cgroup_path);
+ r = cg_get_path(crt->cgroup_path, /* suffix= */ NULL, &cgroup_path);
if (r < 0)
return log_unit_error_errno(u, r, "restrict-interfaces: Failed to get cgroup path: %m");
if (dlopen_bpf_full(LOG_WARNING) < 0)
return false;
- r = prepare_socket_bind_bpf(/*unit=*/NULL, /*allow_rules=*/NULL, /*deny_rules=*/NULL, &obj);
+ r = prepare_socket_bind_bpf(/* unit= */ NULL, /* allow_rules= */ NULL, /* deny_rules= */ NULL, &obj);
if (r < 0) {
log_debug_errno(r, "bpf-socket-bind: socket bind filtering is not supported: %m");
return false;
if (!crt)
return 0;
- r = cg_get_path(crt->cgroup_path, /* suffix = */ NULL, &cgroup_path);
+ r = cg_get_path(crt->cgroup_path, /* suffix= */ NULL, &cgroup_path);
if (r < 0)
return log_unit_error_errno(u, r, "bpf-socket-bind: Failed to get cgroup path: %m");
if (apply_mask & CGROUP_MASK_BPF_RESTRICT_NETWORK_INTERFACES)
cgroup_apply_restrict_network_interfaces(u);
- unit_modify_nft_set(u, /* add = */ true);
+ unit_modify_nft_set(u, /* add= */ true);
}
static bool unit_get_needs_bpf_firewall(Unit *u) {
if (crt && streq_ptr(crt->cgroup_path, path))
return 0;
- unit_release_cgroup(u, /* drop_cgroup_runtime = */ true);
+ unit_release_cgroup(u, /* drop_cgroup_runtime= */ true);
crt = unit_setup_cgroup_runtime(u);
if (!crt)
CGroupRuntime *crt = ASSERT_PTR(unit_get_cgroup_runtime(u));
uint64_t cgroup_id = 0;
- r = cg_get_path(crt->cgroup_path, /* suffix = */ NULL, &cgroup_full_path);
+ r = cg_get_path(crt->cgroup_path, /* suffix= */ NULL, &cgroup_full_path);
if (r == 0) {
r = cg_path_get_cgroupid(cgroup_full_path, &cgroup_id);
if (r < 0)
/* Do not free CGroupRuntime when called from unit_prune_cgroup. Various accounting data
* we should keep, especially CPU usage and *_peak ones which would be shown even after
* the unit stops. */
- unit_release_cgroup(u, /* drop_cgroup_runtime = */ false);
+ unit_release_cgroup(u, /* drop_cgroup_runtime= */ false);
return true;
}
return;
/* Cache the last resource usage values before we destroy the cgroup */
- (void) unit_get_cpu_usage(u, /* ret = */ NULL);
+ (void) unit_get_cpu_usage(u, /* ret= */ NULL);
for (CGroupMemoryAccountingMetric metric = 0; metric <= _CGROUP_MEMORY_ACCOUNTING_METRIC_CACHED_LAST; metric++)
- (void) unit_get_memory_accounting(u, metric, /* ret = */ NULL);
+ (void) unit_get_memory_accounting(u, metric, /* ret= */ NULL);
/* All IO metrics are read at once from the underlying cgroup, so issue just a single call */
- (void) unit_get_io_accounting(u, _CGROUP_IO_ACCOUNTING_METRIC_INVALID, /* ret = */ NULL);
+ (void) unit_get_io_accounting(u, _CGROUP_IO_ACCOUNTING_METRIC_INVALID, /* ret= */ NULL);
/* We do not cache IP metrics here because the firewall objects are not freed with cgroups */
(void) bpf_restrict_fs_cleanup(u); /* Remove cgroup from the global LSM BPF map */
#endif
- unit_modify_nft_set(u, /* add = */ false);
+ unit_modify_nft_set(u, /* add= */ false);
is_root_slice = unit_has_name(u, SPECIAL_ROOT_SLICE);
/* 5. Make sure we are in the special "init.scope" unit in the root slice. */
const char *scope_path = strjoina(m->cgroup_root, "/" SPECIAL_INIT_SCOPE);
- r = cg_create_and_attach(scope_path, /* pid = */ 0);
+ r = cg_create_and_attach(scope_path, /* pid= */ 0);
if (r >= 0) {
/* Also, move all other userspace processes remaining in the root cgroup into that scope. */
r = cg_migrate(m->cgroup_root, scope_path, 0);
.deserialized_cgroup_realized = -1,
};
- unit_reset_cpu_accounting(/* unit = */ NULL, crt);
- unit_reset_io_accounting(/* unit = */ NULL, crt);
+ unit_reset_cpu_accounting(/* unit= */ NULL, crt);
+ unit_reset_io_accounting(/* unit= */ NULL, crt);
cgroup_runtime_reset_memory_accounting_last(crt);
assert_se(cgroup_runtime_reset_ip_accounting(crt) >= 0);
return r;
r = sd_bus_message_append_log_filter_patterns(reply, c->log_filter_allowed_patterns,
- /* is_allowlist = */ true);
+ /* is_allowlist= */ true);
if (r < 0)
return r;
r = sd_bus_message_append_log_filter_patterns(reply, c->log_filter_denied_patterns,
- /* is_allowlist = */ false);
+ /* is_allowlist= */ false);
if (r < 0)
return r;
if (r < 0)
return r;
- if (!isempty(h) && !hostname_is_valid(h, /* flags = */ 0))
+ if (!isempty(h) && !hostname_is_valid(h, /* flags= */ 0))
return sd_bus_error_setf(reterr_error, SD_BUS_ERROR_INVALID_ARGS, "Invalid hostname in %s setting: %s", name, h);
ProtectHostname t = protect_hostname_from_string(s);
}
static int method_start_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_start_unit_generic(message, userdata, JOB_START, /* reload_if_possible = */ false, reterr_error);
+ return method_start_unit_generic(message, userdata, JOB_START, /* reload_if_possible= */ false, reterr_error);
}
static int method_stop_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_start_unit_generic(message, userdata, JOB_STOP, /* reload_if_possible = */ false, reterr_error);
+ return method_start_unit_generic(message, userdata, JOB_STOP, /* reload_if_possible= */ false, reterr_error);
}
static int method_reload_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_start_unit_generic(message, userdata, JOB_RELOAD, /* reload_if_possible = */ false, reterr_error);
+ return method_start_unit_generic(message, userdata, JOB_RELOAD, /* reload_if_possible= */ false, reterr_error);
}
static int method_restart_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_start_unit_generic(message, userdata, JOB_RESTART, /* reload_if_possible = */ false, reterr_error);
+ return method_start_unit_generic(message, userdata, JOB_RESTART, /* reload_if_possible= */ false, reterr_error);
}
static int method_try_restart_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_start_unit_generic(message, userdata, JOB_TRY_RESTART, /* reload_if_possible = */ false, reterr_error);
+ return method_start_unit_generic(message, userdata, JOB_TRY_RESTART, /* reload_if_possible= */ false, reterr_error);
}
static int method_reload_or_restart_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_start_unit_generic(message, userdata, JOB_RESTART, /* reload_if_possible = */ true, reterr_error);
+ return method_start_unit_generic(message, userdata, JOB_RESTART, /* reload_if_possible= */ true, reterr_error);
}
static int method_reload_or_try_restart_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_start_unit_generic(message, userdata, JOB_TRY_RESTART, /* reload_if_possible = */ true, reterr_error);
+ return method_start_unit_generic(message, userdata, JOB_TRY_RESTART, /* reload_if_possible= */ true, reterr_error);
}
typedef enum GenericUnitOperationFlags {
if (!u->job || u->job->type != JOB_START)
return sd_bus_error_setf(reterr_error, BUS_ERROR_NO_SUCH_JOB, "No job queued for unit %s", old_name);
- return method_start_unit_generic(message, m, JOB_START, /* reload_if_possible = */ false, reterr_error);
+ return method_start_unit_generic(message, m, JOB_START, /* reload_if_possible= */ false, reterr_error);
}
static int method_kill_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
/* We don't bother with GENERIC_UNIT_LOAD or GENERIC_UNIT_VALIDATE_LOADED here, as it shouldn't
* matter whether a unit is loaded for killing any processes in the unit's cgroup. */
- return method_generic_unit_operation(message, userdata, reterr_error, _UNIT_TYPE_INVALID, bus_unit_method_kill, /* flags = */ 0);
+ return method_generic_unit_operation(message, userdata, reterr_error, _UNIT_TYPE_INVALID, bus_unit_method_kill, /* flags= */ 0);
}
static int method_kill_unit_subgroup(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
/* We don't bother with GENERIC_UNIT_LOAD or GENERIC_UNIT_VALIDATE_LOADED here, as it shouldn't
* matter whether a unit is loaded for killing any processes in the unit's cgroup. */
- return method_generic_unit_operation(message, userdata, reterr_error, _UNIT_TYPE_INVALID, bus_unit_method_kill_subgroup, /* flags = */ 0);
+ return method_generic_unit_operation(message, userdata, reterr_error, _UNIT_TYPE_INVALID, bus_unit_method_kill_subgroup, /* flags= */ 0);
}
static int method_clean_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
static int method_reset_failed_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
/* Don't load the unit (because unloaded units can't be in failed state), and don't insist on the
* unit to be loaded properly (since a failed unit might have its unit file disappeared) */
- return method_generic_unit_operation(message, userdata, reterr_error, _UNIT_TYPE_INVALID, bus_unit_method_reset_failed, /* flags = */ 0);
+ return method_generic_unit_operation(message, userdata, reterr_error, _UNIT_TYPE_INVALID, bus_unit_method_reset_failed, /* flags= */ 0);
}
static int method_set_unit_properties(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
static int method_unref_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
/* Dropping a ref OTOH should not require the unit to still be loaded. And since a reffed unit is a
* loaded unit there's no need to load the unit for unreffing it. */
- return method_generic_unit_operation(message, userdata, reterr_error, _UNIT_TYPE_INVALID, bus_unit_method_unref, /* flags = */ 0);
+ return method_generic_unit_operation(message, userdata, reterr_error, _UNIT_TYPE_INVALID, bus_unit_method_unref, /* flags= */ 0);
}
static int reply_unit_info(sd_bus_message *reply, Unit *u) {
/* Don't load a unit actively (since it won't have any processes if it's not loaded), but don't
* insist on the unit being loaded either (because even improperly loaded units might still have
* processes around). */
- return method_generic_unit_operation(message, userdata, reterr_error, _UNIT_TYPE_INVALID, bus_unit_method_get_processes, /* flags = */ 0);
+ return method_generic_unit_operation(message, userdata, reterr_error, _UNIT_TYPE_INVALID, bus_unit_method_get_processes, /* flags= */ 0);
}
static int method_attach_processes_to_unit(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
if (r < 0)
return r;
- r = transient_unit_from_message(m, message, name, /* ret_unit = */ NULL, reterr_error);
+ r = transient_unit_from_message(m, message, name, /* ret_unit= */ NULL, reterr_error);
if (r < 0)
return r;
* operations, and can cause PID1 to stall. So it seems similar enough in terms of security
* considerations and impact, and thus use the same access check for dumps which, given the
* large amount of data to fetch, can stall PID1 for quite some time. */
- r = mac_selinux_access_check(message, "reload", /* error = */ NULL);
+ r = mac_selinux_access_check(message, "reload", /* error= */ NULL);
if (r < 0)
goto ratelimited;
- r = bus_verify_bypass_dump_ratelimit_async(m, message, /* reterr_error = */ NULL);
+ r = bus_verify_bypass_dump_ratelimit_async(m, message, /* reterr_error= */ NULL);
if (r < 0)
goto ratelimited;
if (r == 0)
if (r < 0)
return r;
- r = unit_file_get_list(m->runtime_scope, /* root_dir = */ NULL, states, patterns, &h);
+ r = unit_file_get_list(m->runtime_scope, /* root_dir= */ NULL, states, patterns, &h);
if (r < 0)
return r;
}
static int method_enable_unit_files_with_flags(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_enable_unit_files_generic(message, userdata, unit_file_enable, /* carries_install_info = */ true, reterr_error);
+ return method_enable_unit_files_generic(message, userdata, unit_file_enable, /* carries_install_info= */ true, reterr_error);
}
static int method_enable_unit_files(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_enable_unit_files_generic(message, userdata, unit_file_enable, /* carries_install_info = */ true, reterr_error);
+ return method_enable_unit_files_generic(message, userdata, unit_file_enable, /* carries_install_info= */ true, reterr_error);
}
static int method_reenable_unit_files(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_enable_unit_files_generic(message, userdata, unit_file_reenable, /* carries_install_info = */ true, reterr_error);
+ return method_enable_unit_files_generic(message, userdata, unit_file_reenable, /* carries_install_info= */ true, reterr_error);
}
static int method_link_unit_files(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_enable_unit_files_generic(message, userdata, unit_file_link, /* carries_install_info = */ false, reterr_error);
+ return method_enable_unit_files_generic(message, userdata, unit_file_link, /* carries_install_info= */ false, reterr_error);
}
static int unit_file_preset_without_mode(RuntimeScope scope, UnitFileFlags flags, const char *root_dir, char * const *files, InstallChange **changes, size_t *n_changes) {
}
static int method_preset_unit_files(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_enable_unit_files_generic(message, userdata, unit_file_preset_without_mode, /* carries_install_info = */ true, reterr_error);
+ return method_enable_unit_files_generic(message, userdata, unit_file_preset_without_mode, /* carries_install_info= */ true, reterr_error);
}
static int method_mask_unit_files(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_enable_unit_files_generic(message, userdata, unit_file_mask, /* carries_install_info = */ false, reterr_error);
+ return method_enable_unit_files_generic(message, userdata, unit_file_mask, /* carries_install_info= */ false, reterr_error);
}
static int method_preset_unit_files_with_mode(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
}
static int method_disable_unit_files_with_flags(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_disable_unit_files_generic(message, userdata, unit_file_disable, /* carries_install_info = */ false, reterr_error);
+ return method_disable_unit_files_generic(message, userdata, unit_file_disable, /* carries_install_info= */ false, reterr_error);
}
static int method_disable_unit_files_with_flags_and_install_info(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_disable_unit_files_generic(message, userdata, unit_file_disable, /* carries_install_info = */ true, reterr_error);
+ return method_disable_unit_files_generic(message, userdata, unit_file_disable, /* carries_install_info= */ true, reterr_error);
}
static int method_disable_unit_files(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_disable_unit_files_generic(message, userdata, unit_file_disable, /* carries_install_info = */ false, reterr_error);
+ return method_disable_unit_files_generic(message, userdata, unit_file_disable, /* carries_install_info= */ false, reterr_error);
}
static int method_unmask_unit_files(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
- return method_disable_unit_files_generic(message, userdata, unit_file_unmask, /* carries_install_info = */ false, reterr_error);
+ return method_disable_unit_files_generic(message, userdata, unit_file_unmask, /* carries_install_info= */ false, reterr_error);
}
static int method_revert_unit_files(sd_bus_message *message, void *userdata, sd_bus_error *reterr_error) {
* We'll see ENODEV when trying to enumerate processes and the cgroup is removed at the same
* time. Handle this gracefully. */
- r = cg_read_pidref(f, &pidref, /* flags = */ 0);
+ r = cg_read_pidref(f, &pidref, /* flags= */ 0);
if (IN_SET(r, 0, -EOPNOTSUPP, -ENODEV))
break;
if (r < 0)
return -ENOMEM;
}
- r = manager_add_job_full(u->manager, type, u, mode, /* extra_flags = */ 0, affected, reterr_error, &j);
+ r = manager_add_job_full(u->manager, type, u, mode, /* extra_flags= */ 0, affected, reterr_error, &j);
if (r < 0)
return r;
goto failed;
}
- r = manager_add_job(m, JOB_START, u, JOB_REPLACE, &error, /* ret = */ NULL);
+ r = manager_add_job(m, JOB_START, u, JOB_REPLACE, &error, /* ret= */ NULL);
if (r < 0)
goto failed;
if (state != old_state)
log_unit_debug(UNIT(d), "Changed %s -> %s", device_state_to_string(old_state), device_state_to_string(state));
- unit_notify(UNIT(d), state_translation_table[old_state], state_translation_table[state], /* reload_success = */ true);
+ unit_notify(UNIT(d), state_translation_table[old_state], state_translation_table[state], /* reload_success= */ true);
}
static void device_found_changed(Device *d, DeviceFound previous, DeviceFound now) {
/* Note, even if the device is being processed by udevd, setup the unit on enumerate.
* See also the comments in device_catchup(). */
- return device_setup_unit(m, dev, devlink, /* main = */ false, ready_units);
+ return device_setup_unit(m, dev, devlink, /* main= */ false, ready_units);
}
/* the devlink is already removed or not ready */
* To achieve that, they set the path to SYSTEMD_ALIAS. Hence, we cannot refuse aliases start
* with /dev/, unfortunately. */
- (void) device_setup_unit(m, dev, *alias, /* main = */ false, ready_units);
+ (void) device_setup_unit(m, dev, *alias, /* main= */ false, ready_units);
}
l = hashmap_get(m->devices_by_sysfs, syspath);
/* Add the main unit named after the syspath. If this one fails, don't bother with the rest,
* as this one shall be the main device unit the others just follow. (Compare with how
* device_following() is implemented, see below, which looks for the sysfs device.) */
- r = device_setup_unit(m, dev, syspath, /* main = */ true, &ready_units);
+ r = device_setup_unit(m, dev, syspath, /* main= */ true, &ready_units);
if (r < 0)
return r;
/* Add an additional unit for the device node */
if (sd_device_get_devname(dev, &devname) >= 0)
- (void) device_setup_unit(m, dev, devname, /* main = */ false, &ready_units);
+ (void) device_setup_unit(m, dev, devname, /* main= */ false, &ready_units);
} else {
Unit *u;
return;
}
- (void) device_setup_unit(m, dev, node, /* main = */ false, NULL); /* 'dev' may be NULL. */
+ (void) device_setup_unit(m, dev, node, /* main= */ false, NULL); /* 'dev' may be NULL. */
}
/* Update the device unit's state, should it exist */
if (!j)
return -ENOMEM;
- r = safe_glob(j, /* flags = */ 0, &paths);
+ r = safe_glob(j, /* flags= */ 0, &paths);
if (r == -ENOENT)
continue;
if (r < 0)
return log_debug_errno(dfd, "Failed to create workspace for credentials: %m");
workspace_rm = workspace;
- (void) label_fix_full(dfd, /* inode_path = */ NULL, cred_dir, /* flags = */ 0);
+ (void) label_fix_full(dfd, /* inode_path= */ NULL, cred_dir, /* flags= */ 0);
- r = acquire_credentials(context, cgroup_context, params, unit, dfd, uid, gid, /* ownership_ok = */ false);
+ r = acquire_credentials(context, cgroup_context, params, unit, dfd, uid, gid, /* ownership_ok= */ false);
if (r < 0)
return r;
/* rename() requires both the source and target to be writable, hence lock down write permission
* as last step. */
- r = credentials_dir_finalize_permissions(dfd, uid, gid, /* ownership_ok = */ false);
+ r = credentials_dir_finalize_permissions(dfd, uid, gid, /* ownership_ok= */ false);
if (r < 0)
return log_debug_errno(r, "Failed to adjust ACLs of credentials dir: %m");
if (!FLAGS_SET(params->flags, EXEC_SETUP_CREDENTIALS_FRESH)) {
/* We may reuse the previous credential dir */
- r = dir_is_empty(cred_dir, /* ignore_hidden_or_backup = */ false);
+ r = dir_is_empty(cred_dir, /* ignore_hidden_or_backup= */ false);
if (r < 0)
return r;
if (r == 0) {
if (dfd < 0)
return dfd;
- (void) label_fix_full(dfd, /* inode_path = */ NULL, cred_dir, /* flags = */ 0);
+ (void) label_fix_full(dfd, /* inode_path= */ NULL, cred_dir, /* flags= */ 0);
- r = acquire_credentials(context, cgroup_context, params, unit, dfd, uid, gid, /* ownership_ok = */ true);
+ r = acquire_credentials(context, cgroup_context, params, unit, dfd, uid, gid, /* ownership_ok= */ true);
if (r < 0)
return r;
- r = credentials_dir_finalize_permissions(dfd, uid, gid, /* ownership_ok = */ true);
+ r = credentials_dir_finalize_permissions(dfd, uid, gid, /* ownership_ok= */ true);
if (r < 0)
return log_debug_errno(r, "Failed to adjust ACLs of credentials dir: %m");
assert(group_or_gid);
assert(ret_groupname);
- r = get_group_creds(&group_or_gid, ret_gid, /* flags = */ 0);
+ r = get_group_creds(&group_or_gid, ret_gid, /* flags= */ 0);
if (r < 0)
return r;
return -E2BIG;
const char *g = *i;
- r = get_group_creds(&g, l_gids + k, /* flags = */ 0);
+ r = get_group_creds(&g, l_gids + k, /* flags= */ 0);
if (r < 0)
return r;
if (!username && !c->dynamic_user && p->runtime_scope == RUNTIME_SCOPE_SYSTEM) {
assert(!c->user);
- r = get_fixed_user("root", /* prefer_nss = */ false, &username, NULL, NULL, &home, &shell);
+ r = get_fixed_user("root", /* prefer_nss= */ false, &username, NULL, NULL, &home, &shell);
if (r < 0) {
log_debug_errno(r, "Failed to determine credentials for user root: %s",
STRERROR_USER(r));
assert(c);
assert(socket_fd >= 0);
- _cleanup_close_ int fs_fd = receive_one_fd(socket_fd, /* flags = */ 0);
+ _cleanup_close_ int fs_fd = receive_one_fd(socket_fd, /* flags= */ 0);
if (fs_fd < 0)
return log_debug_errno(fs_fd, "Failed to receive file descriptor from parent: %m");
char number[STRLEN("0x") + sizeof(c->bpf_delegate_commands) * 2 + 1];
xsprintf(number, "0x%"PRIx64, c->bpf_delegate_commands);
- if (fsconfig(fs_fd, FSCONFIG_SET_STRING, "delegate_cmds", number, /* aux = */ 0) < 0)
+ if (fsconfig(fs_fd, FSCONFIG_SET_STRING, "delegate_cmds", number, /* aux= */ 0) < 0)
return log_debug_errno(errno, "Failed to FSCONFIG_SET_STRING: %m");
xsprintf(number, "0x%"PRIx64, c->bpf_delegate_maps);
- if (fsconfig(fs_fd, FSCONFIG_SET_STRING, "delegate_maps", number, /* aux = */ 0) < 0)
+ if (fsconfig(fs_fd, FSCONFIG_SET_STRING, "delegate_maps", number, /* aux= */ 0) < 0)
return log_debug_errno(errno, "Failed to FSCONFIG_SET_STRING: %m");
xsprintf(number, "0x%"PRIx64, c->bpf_delegate_programs);
- if (fsconfig(fs_fd, FSCONFIG_SET_STRING, "delegate_progs", number, /* aux = */ 0) < 0)
+ if (fsconfig(fs_fd, FSCONFIG_SET_STRING, "delegate_progs", number, /* aux= */ 0) < 0)
return log_debug_errno(errno, "Failed to FSCONFIG_SET_STRING: %m");
xsprintf(number, "0x%"PRIx64, c->bpf_delegate_attachments);
- if (fsconfig(fs_fd, FSCONFIG_SET_STRING, "delegate_attachs", number, /* aux = */ 0) < 0)
+ if (fsconfig(fs_fd, FSCONFIG_SET_STRING, "delegate_attachs", number, /* aux= */ 0) < 0)
return log_debug_errno(errno, "Failed to FSCONFIG_SET_STRING: %m");
- if (fsconfig(fs_fd, FSCONFIG_CMD_CREATE, /* key = */ NULL, /* value = */ NULL, /* aux = */ 0) < 0)
+ if (fsconfig(fs_fd, FSCONFIG_CMD_CREATE, /* key= */ NULL, /* value= */ NULL, /* aux= */ 0) < 0)
return log_debug_errno(errno, "Failed to create bpffs superblock: %m");
return 0;
if (n != 0) /* on success we should have read 0 bytes */
return -EIO;
- r = wait_for_terminate_and_check("(sd-proc-check)", TAKE_PID(pid), 0 /* flags= */);
+ r = wait_for_terminate_and_check("(sd-proc-check)", TAKE_PID(pid), /* flags= */ 0);
if (r < 0)
return log_debug_errno(r, "Failed to wait for (sd-proc-check) child process to terminate: %m");
if (r != EXIT_SUCCESS) /* If something strange happened with the child, let's consider this fatal, too */
p->pidref_transport_fd,
pidref.fd,
&IOVEC_MAKE(&pidref.pid, sizeof(pidref.pid)),
- /*iovlen=*/ 1,
- /*flags=*/ 0);
+ /* iovlen= */ 1,
+ /* flags= */ 0);
/* Send error code to child process. */
(void) write(errno_pipe[1], &q, sizeof(q));
/* Exit here so we only go through the destructors in exec_invoke only once - in the child - as
return -errno;
uint32_t xattr_flags = 0;
- r = read_fs_xattr_fd(fd_parent, &xattr_flags, /* ret_projid = */ NULL);
+ r = read_fs_xattr_fd(fd_parent, &xattr_flags, /* ret_projid= */ NULL);
if (r < 0)
return r;
/* Refuse if parent has FS_XFLAG_PROJINHERIT since this will mean the total number of blocks will not
/* Get the project ID of the current directory */
uint32_t proj_id;
- r = read_fs_xattr_fd(fd, /* ret_xflags = */ NULL, &proj_id);
+ r = read_fs_xattr_fd(fd, /* ret_xflags= */ NULL, &proj_id);
if (ERRNO_IS_NEG_IOCTL_NOT_SUPPORTED(r)) {
log_debug_errno(r, "Not applying storage quotas. FS_IOC_FSGETXATTR not supported for %s: %m", target_dir);
return 0;
if (!key)
return -ENOMEM;
- r = proc_cmdline_get_key(key, /* flags = */ 0, &cmdline);
+ r = proc_cmdline_get_key(key, /* flags= */ 0, &cmdline);
if (r > 0)
return strv_env_assign(env, "TERM", cmdline);
if (r < 0)
* or PAM shall be invoked, let's consult NSS even for root, so that the user
* gets accurate $SHELL in session(-like) contexts. */
r = get_fixed_user(u,
- /* prefer_nss = */ context->set_login_environment > 0 || context->pam_name,
+ /* prefer_nss= */ context->set_login_environment > 0 || context->pam_name,
&username, &uid, &gid, &pwent_home, &shell);
if (r < 0) {
*exit_status = EXIT_USER;
_cleanup_free_ void *d = NULL;
size_t size;
- r = unbase64mem_full(data, SIZE_MAX, /* secure = */ true, &d, &size);
+ r = unbase64mem_full(data, SIZE_MAX, /* secure= */ true, &d, &size);
if (r < 0)
return r;
}
/* Filename supports globbing, take all matching files */
- r = safe_glob(fn, /* flags = */ 0, &paths);
+ r = safe_glob(fn, /* flags= */ 0, &paths);
if (r < 0) {
if (ignore)
continue;
if (!l)
return -ENOMEM;
- r = strv_extend_strv_consume(&c->argv, l, /* filter_duplicates = */ false);
+ r = strv_extend_strv_consume(&c->argv, l, /* filter_duplicates= */ false);
if (r < 0)
return r;
/* Optionally base64 decode the data, if requested, to allow binary credentials */
if (unbase64) {
- r = unbase64mem_full(eq + 1, nul - (eq + 1), /* secure = */ false, &buf, &buflen);
+ r = unbase64mem_full(eq + 1, nul - (eq + 1), /* secure= */ false, &buf, &buflen);
if (r < 0) {
log_warning_errno(r, "Failed to base64 decode credential '%s', ignoring: %m", cn);
continue;
* be merged with C either.
*/
static const JobType job_merging_table[] = {
-/* What \ With * JOB_START JOB_VERIFY_ACTIVE JOB_STOP JOB_RELOAD */
+/* What \ With * JOB_START JOB_VERIFY_ACTIVE JOB_STOP JOB_RELOAD */
/*********************************************************************************/
-/*JOB_START */
-/*JOB_VERIFY_ACTIVE */ JOB_START,
-/*JOB_STOP */ -1, -1,
-/*JOB_RELOAD */ JOB_RELOAD_OR_START, JOB_RELOAD, -1,
-/*JOB_RESTART */ JOB_RESTART, JOB_RESTART, -1, JOB_RESTART,
+/* JOB_START */
+/* JOB_VERIFY_ACTIVE */ JOB_START,
+/* JOB_STOP */ -1, -1,
+/* JOB_RELOAD */ JOB_RELOAD_OR_START, JOB_RELOAD, -1,
+/* JOB_RESTART */ JOB_RESTART, JOB_RESTART, -1, JOB_RESTART,
};
JobType job_type_lookup_merge(JobType a, JobType b) {
return r;
/* Load .conf dropins */
- r = unit_find_dropin_paths(u, /* use_unit_path_cache = */ true, &l);
+ r = unit_find_dropin_paths(u, /* use_unit_path_cache= */ true, &l);
if (r <= 0)
return 0;
- r = strv_extend_strv_consume(&u->dropin_paths, TAKE_PTR(l), /* filter_duplicates = */ true);
+ r = strv_extend_strv_consume(&u->dropin_paths, TAKE_PTR(l), /* filter_duplicates= */ true);
if (r < 0)
return log_oom();
/* Check explicitly for an unquoted semicolon as command separator token. */
if (p[0] == ';' && (!p[1] || strchr(WHITESPACE, p[1]))) {
p++;
- p = skip_leading_chars(p, /* bad = */ NULL);
+ p = skip_leading_chars(p, /* bad= */ NULL);
semicolon = true;
break;
}
* extract_first_word() would return the same for all of those. */
if (p[0] == '\\' && p[1] == ';' && (!p[2] || strchr(WHITESPACE, p[2]))) {
p += 2;
- p = skip_leading_chars(p, /* bad = */ NULL);
+ p = skip_leading_chars(p, /* bad= */ NULL);
if (strv_extend(&args, ";") < 0)
return log_oom();
return log_oom();
}
- r = strv_extend_strv_consume(passenv, TAKE_PTR(n), /* filter_duplicates = */ true);
+ r = strv_extend_strv_consume(passenv, TAKE_PTR(n), /* filter_duplicates= */ true);
if (r < 0)
return log_oom();
return log_oom();
}
- r = strv_extend_strv_consume(unsetenv, TAKE_PTR(n), /* filter_duplicates = */ true);
+ r = strv_extend_strv_consume(unsetenv, TAKE_PTR(n), /* filter_duplicates= */ true);
if (r < 0)
return log_oom();
size_t size;
if (encrypted) {
- r = unbase64mem_full(p, SIZE_MAX, /* secure = */ true, &d, &size);
+ r = unbase64mem_full(p, SIZE_MAX, /* secure= */ true, &d, &size);
if (r == -ENOMEM)
return log_oom();
if (r < 0) {
return 0;
}
- if (!hostname_is_valid(h, /* flags = */ 0))
+ if (!hostname_is_valid(h, /* flags= */ 0))
return log_syntax(unit, LOG_WARNING, filename, line, 0,
"Invalid hostname is specified to %s=, ignoring: %s", lvalue, h);
(const char* const*) files,
(const char* const*) dirs,
"user.conf.d",
- /* root = */ NULL,
+ /* root= */ NULL,
"Manager\0",
config_item_table_lookup, items,
CONFIG_PARSE_WARN,
}
}
- if (support_end && os_release_support_ended(support_end, /* quiet = */ false, /* ret_eol = */ NULL) > 0)
+ if (support_end && os_release_support_ended(support_end, /* quiet= */ false, /* ret_eol= */ NULL) > 0)
/* pretty_name may include the version already, so we'll print the version only if we
* have it and we're not using pretty_name. */
status_printf(ANSI_HIGHLIGHT_RED " !! " ANSI_NORMAL, 0,
/* If we're supposed to switch root, preemptively check the existence of a usable init.
* Otherwise the system might end up in a completely undebuggable state afterwards. */
if (switch_root_init) {
- r = chase_and_access(switch_root_init, switch_root_dir, CHASE_PREFIX_ROOT, X_OK, /* ret_path = */ NULL);
+ r = chase_and_access(switch_root_init, switch_root_dir, CHASE_PREFIX_ROOT, X_OK, /* ret_path= */ NULL);
if (r < 0)
log_warning_errno(r, "Failed to chase configured init %s/%s: %m",
switch_root_dir, switch_root_init);
} else {
- r = chase_and_access(SYSTEMD_BINARY_PATH, switch_root_dir, CHASE_PREFIX_ROOT, X_OK, /* ret_path = */ NULL);
+ r = chase_and_access(SYSTEMD_BINARY_PATH, switch_root_dir, CHASE_PREFIX_ROOT, X_OK, /* ret_path= */ NULL);
if (r < 0)
log_debug_errno(r, "Failed to chase our own binary %s/%s: %m",
switch_root_dir, SYSTEMD_BINARY_PATH);
}
if (r < 0) {
- r = chase_and_access("/sbin/init", switch_root_dir, CHASE_PREFIX_ROOT, X_OK, /* ret_path = */ NULL);
+ r = chase_and_access("/sbin/init", switch_root_dir, CHASE_PREFIX_ROOT, X_OK, /* ret_path= */ NULL);
if (r < 0) {
*ret_error_message = "Switch root target contains no usable init";
return log_error_errno(r, "Failed to chase %s/sbin/init", switch_root_dir);
/* Let's check whether we are in first boot. First, check if an override was
* specified on the kernel command line. If yes, we honour that. */
- r = proc_cmdline_get_bool("systemd.condition_first_boot", /* flags = */ 0, &first_boot);
+ r = proc_cmdline_get_bool("systemd.condition_first_boot", /* flags= */ 0, &first_boot);
if (r < 0)
log_debug_errno(r, "Failed to parse systemd.condition_first_boot= kernel command line argument, ignoring: %m");
if (!skip_setup) {
/* Check that /usr/ is either on the same file system as / or mounted already. */
- if (dir_is_empty("/usr", /* ignore_hidden_or_backup = */ true) > 0) {
+ if (dir_is_empty("/usr", /* ignore_hidden_or_backup= */ true) > 0) {
*ret_error_message = "Refusing to run in unsupported environment where /usr/ is not populated";
return -ENOEXEC;
}
(void) import_credentials();
(void) os_release_status();
- (void) machine_id_setup(/* root = */ NULL, arg_machine_id,
+ (void) machine_id_setup(/* root= */ NULL, arg_machine_id,
(first_boot ? MACHINE_ID_SETUP_FORCE_TRANSIENT : 0) |
(arg_machine_id_from_firmware ? MACHINE_ID_SETUP_FORCE_FIRMWARE : 0),
- /* ret = */ NULL);
- (void) hostname_setup(/* really = */ true);
+ /* ret= */ NULL);
+ (void) hostname_setup(/* really= */ true);
(void) loopback_setup();
bump_unix_max_dgram_qlen();
return r;
#if HAVE_LIBBPF
- if (MANAGER_IS_SYSTEM(m) && bpf_restrict_fs_supported(/* initialize = */ true)) {
+ if (MANAGER_IS_SYSTEM(m) && bpf_restrict_fs_supported(/* initialize= */ true)) {
r = bpf_restrict_fs_setup(m);
if (r < 0)
log_warning_errno(r, "Failed to setup LSM BPF, ignoring: %m");
}
/* Ok, nobody needs us anymore. Sniff. Then let's commit suicide */
- r = manager_add_job(u->manager, JOB_STOP, u, JOB_FAIL, &error, /* ret = */ NULL);
+ r = manager_add_job(u->manager, JOB_STOP, u, JOB_FAIL, &error, /* ret= */ NULL);
if (r < 0)
log_unit_warning_errno(u, r, "Failed to enqueue stop job, ignoring: %s", bus_error_message(&error, r));
}
continue;
}
- r = manager_add_job(u->manager, JOB_START, u, JOB_FAIL, &error, /* ret = */ NULL);
+ r = manager_add_job(u->manager, JOB_START, u, JOB_FAIL, &error, /* ret= */ NULL);
if (r < 0)
log_unit_warning_errno(u, r, "Failed to enqueue start job, ignoring: %s", bus_error_message(&error, r));
}
continue;
}
- r = manager_add_job(u->manager, JOB_STOP, u, JOB_REPLACE, &error, /* ret = */ NULL);
+ r = manager_add_job(u->manager, JOB_STOP, u, JOB_REPLACE, &error, /* ret= */ NULL);
if (r < 0)
log_unit_warning_errno(u, r, "Failed to enqueue stop job, ignoring: %s", bus_error_message(&error, r));
}
CLEANUP_ARRAY(changes, n_changes, install_changes_free);
log_info("Applying preset policy.");
- r = unit_file_preset_all(RUNTIME_SCOPE_SYSTEM, /* file_flags = */ 0,
- /* root_dir = */ NULL, mode, &changes, &n_changes);
- install_changes_dump(r, "preset", changes, n_changes, /* quiet = */ false);
+ r = unit_file_preset_all(RUNTIME_SCOPE_SYSTEM, /* file_flags= */ 0,
+ /* root_dir= */ NULL, mode, &changes, &n_changes);
+ install_changes_dump(r, "preset", changes, n_changes, /* quiet= */ false);
if (r < 0)
log_full_errno(r == -EEXIST ? LOG_NOTICE : LOG_WARNING, r,
"Failed to populate /etc with preset unit settings, ignoring: %m");
return r;
assert(unit);
- return manager_add_job_full(m, type, unit, mode, /* extra_flags = */ 0, affected_jobs, e, ret);
+ return manager_add_job_full(m, type, unit, mode, /* extra_flags= */ 0, affected_jobs, e, ret);
}
int manager_add_job_by_name_and_warn(Manager *m, JobType type, const char *name, JobMode mode, Set *affected_jobs, Job **ret) {
assert(m);
/* Let whoever invoked us know that we are now reloading */
- (void) notify_reloading_full(/* status = */ NULL);
+ (void) notify_reloading_full(/* status= */ NULL);
/* And ensure that we'll send READY=1 again as soon as we are ready again */
m->ready_sent = false;
bool from_kernel = m->from_proc_self_mountinfo || u->perpetual;
- r = unit_load_fragment_and_dropin(u, /* fragment_required = */ !from_kernel);
+ r = unit_load_fragment_and_dropin(u, /* fragment_required= */ !from_kernel);
/* Add in some extras. Note we do this in all cases (even if we failed to load the unit) when announced by the
* kernel, because we need some things to be set up no matter what when the kernel establishes a mount and thus
break;
case MOUNT_MOUNTED:
assert(!pidref_is_set(&m->control_pid));
- mount_enter_dead(m, MOUNT_SUCCESS, /* flush_result = */ false);
+ mount_enter_dead(m, MOUNT_SUCCESS, /* flush_result= */ false);
break;
default:
;
m->result = f;
unit_log_result(UNIT(m), m->result == MOUNT_SUCCESS, mount_result_to_string(m->result));
- unit_warn_leftover_processes(UNIT(m), /* start = */ false);
+ unit_warn_leftover_processes(UNIT(m), /* start= */ false);
mount_set_state(m, m->result != MOUNT_SUCCESS ? MOUNT_FAILED : MOUNT_DEAD);
m->exec_runtime = exec_runtime_destroy(m->exec_runtime);
- unit_destroy_runtime_data(UNIT(m), &m->exec_context, /* destroy_runtime_dir = */ true);
+ unit_destroy_runtime_data(UNIT(m), &m->exec_context, /* destroy_runtime_dir= */ true);
unit_unref_uid_gid(UNIT(m), true);
*
* Note that this effectively means fresh creds are used during remount, but that's mostly what
* users would expect anyways. */
- unit_destroy_runtime_data(UNIT(m), &m->exec_context, /* destroy_runtime_dir = */ false);
+ unit_destroy_runtime_data(UNIT(m), &m->exec_context, /* destroy_runtime_dir= */ false);
mount_set_state(m, MOUNT_MOUNTED);
}
else if (state == MOUNT_UNMOUNTING_SIGTERM && m->kill_context.send_sigkill)
mount_enter_signal(m, MOUNT_UNMOUNTING_SIGKILL, MOUNT_SUCCESS);
else
- mount_enter_dead_or_mounted(m, MOUNT_SUCCESS, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, MOUNT_SUCCESS, /* flush_result= */ false);
return;
fail:
- mount_enter_dead_or_mounted(m, MOUNT_FAILURE_RESOURCES, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, MOUNT_FAILURE_RESOURCES, /* flush_result= */ false);
}
static int mount_set_umount_command(Mount *m, ExecCommand *c) {
return;
fail:
- mount_enter_dead_or_mounted(m, MOUNT_FAILURE_RESOURCES, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, MOUNT_FAILURE_RESOURCES, /* flush_result= */ false);
}
static int mount_apply_graceful_options(Mount *m, const MountParameters *p, char **opts) {
bool source_is_dir = true;
if (mount_is_bind(p)) {
- r = is_dir(p->what, /* follow = */ true);
+ r = is_dir(p->what, /* follow= */ true);
if (r < 0 && r != -ENOENT)
log_unit_info_errno(UNIT(m), r, "Failed to determine type of bind mount source '%s', ignoring: %m", p->what);
else if (r == 0)
}
mount_unwatch_control_pid(m);
- unit_warn_leftover_processes(UNIT(m), /* start = */ true);
+ unit_warn_leftover_processes(UNIT(m), /* start= */ true);
m->control_command_id = MOUNT_EXEC_MOUNT;
m->control_command = m->exec_command + MOUNT_EXEC_MOUNT;
- r = mount_set_mount_command(m, m->control_command, p, /* remount = */ false);
+ r = mount_set_mount_command(m, m->control_command, p, /* remount= */ false);
if (r < 0) {
log_unit_error_errno(UNIT(m), r, "Failed to prepare mount command line: %m");
goto fail;
return;
fail:
- mount_enter_dead_or_mounted(m, MOUNT_FAILURE_RESOURCES, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, MOUNT_FAILURE_RESOURCES, /* flush_result= */ false);
}
static void mount_set_reload_result(Mount *m, MountResult result) {
m->control_command_id = MOUNT_EXEC_REMOUNT;
m->control_command = m->exec_command + MOUNT_EXEC_REMOUNT;
- r = mount_set_mount_command(m, m->control_command, p, /* remount = */ true);
+ r = mount_set_mount_command(m, m->control_command, p, /* remount= */ true);
if (r < 0) {
log_unit_error_errno(UNIT(m), r, "Failed to prepare remount command line: %m");
goto fail;
fail:
mount_set_reload_result(m, MOUNT_FAILURE_RESOURCES);
- mount_enter_dead_or_mounted(m, MOUNT_SUCCESS, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, MOUNT_SUCCESS, /* flush_result= */ false);
}
static void mount_cycle_clear(Mount *m) {
log_unit_warning(UNIT(m), "Mount process finished, but there is no mount.");
f = MOUNT_FAILURE_PROTOCOL;
}
- mount_enter_dead(m, f, /* flush_result = */ false);
+ mount_enter_dead(m, f, /* flush_result= */ false);
break;
case MOUNT_MOUNTING_DONE:
case MOUNT_REMOUNTING:
case MOUNT_REMOUNTING_SIGTERM:
case MOUNT_REMOUNTING_SIGKILL:
- mount_enter_dead_or_mounted(m, MOUNT_SUCCESS, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, MOUNT_SUCCESS, /* flush_result= */ false);
break;
case MOUNT_UNMOUNTING:
/* Hmm, umount process spawned by us failed, but the mount disappeared anyway?
* Maybe someone else is trying to unmount at the same time. */
log_unit_notice(u, "Mount disappeared even though umount process failed, continuing.");
- mount_enter_dead(m, MOUNT_SUCCESS, /* flush_result = */ true);
+ mount_enter_dead(m, MOUNT_SUCCESS, /* flush_result= */ true);
} else
/* At this point, either the unmount succeeded or unexpected error occurred. We usually
* remember the first error in 'result', but here let's update that forcibly, since
* there could previous failed attempts yet we only care about the most recent
* attempt. IOW, if we eventually managed to unmount the stuff, don't enter failed
* end state. */
- mount_enter_dead_or_mounted(m, f, /* flush_result = */ true);
+ mount_enter_dead_or_mounted(m, f, /* flush_result= */ true);
break;
case MOUNT_UNMOUNTING_SIGTERM:
case MOUNT_UNMOUNTING_SIGKILL:
- mount_enter_dead_or_mounted(m, f, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, f, /* flush_result= */ false);
break;
case MOUNT_CLEANING:
if (m->clean_result == MOUNT_SUCCESS)
m->clean_result = f;
- mount_enter_dead(m, MOUNT_SUCCESS, /* flush_result = */ false);
+ mount_enter_dead(m, MOUNT_SUCCESS, /* flush_result= */ false);
break;
default:
mount_enter_signal(m, MOUNT_REMOUNTING_SIGKILL, MOUNT_SUCCESS);
} else {
log_unit_warning(UNIT(m), "Remounting timed out. Skipping SIGKILL. Ignoring.");
- mount_enter_dead_or_mounted(m, MOUNT_SUCCESS, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, MOUNT_SUCCESS, /* flush_result= */ false);
}
break;
mount_set_reload_result(m, MOUNT_FAILURE_TIMEOUT);
log_unit_warning(UNIT(m), "Mount process still around after SIGKILL. Ignoring.");
- mount_enter_dead_or_mounted(m, MOUNT_SUCCESS, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, MOUNT_SUCCESS, /* flush_result= */ false);
break;
case MOUNT_UNMOUNTING:
mount_enter_signal(m, MOUNT_UNMOUNTING_SIGKILL, MOUNT_FAILURE_TIMEOUT);
} else {
log_unit_warning(UNIT(m), "Mount process timed out. Skipping SIGKILL. Ignoring.");
- mount_enter_dead_or_mounted(m, MOUNT_FAILURE_TIMEOUT, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, MOUNT_FAILURE_TIMEOUT, /* flush_result= */ false);
}
break;
case MOUNT_UNMOUNTING_SIGKILL:
log_unit_warning(UNIT(m), "Mount process still around after SIGKILL. Ignoring.");
- mount_enter_dead_or_mounted(m, MOUNT_FAILURE_TIMEOUT, /* flush_result = */ false);
+ mount_enter_dead_or_mounted(m, MOUNT_FAILURE_TIMEOUT, /* flush_result= */ false);
break;
case MOUNT_CLEANING:
* Also explicitly override the result (see the comment in mount_sigchld_event()),
* but more aggressively here since the state change is extrinsic. */
mount_cycle_clear(mount);
- mount_enter_dead(mount, MOUNT_SUCCESS, /* flush_result = */ true);
+ mount_enter_dead(mount, MOUNT_SUCCESS, /* flush_result= */ true);
break;
case MOUNT_MOUNTING_DONE:
r = unit_test_start_limit(u);
if (r < 0) {
- mount_enter_dead(m, MOUNT_FAILURE_START_LIMIT_HIT, /* flush_result = */ false);
+ mount_enter_dead(m, MOUNT_FAILURE_START_LIMIT_HIT, /* flush_result= */ false);
return r;
}
/* We lack permissions to mount a new instance, and it is not already mounted. But we can
* access the host's, so as a final fallback bind-mount it to the destination, as most likely
* we are inside a user manager in an unprivileged user namespace. */
- r = mount_nofollow_verbose(LOG_DEBUG, bind_source, entry_path, /* fstype = */ NULL, MS_BIND|MS_REC, /* options = */ NULL);
+ r = mount_nofollow_verbose(LOG_DEBUG, bind_source, entry_path, /* fstype= */ NULL, MS_BIND|MS_REC, /* options= */ NULL);
if (r < 0)
return r;
return r;
/* OK. We have a new mount instance. Let's clear an existing mount and its submounts. */
- r = umount_recursive(entry_path, /* flags = */ 0);
+ r = umount_recursive(entry_path, /* flags= */ 0);
if (r < 0)
log_debug_errno(r, "Failed to unmount directories below '%s', ignoring: %m", entry_path);
/* Then, move the new mount instance. */
- r = mount_nofollow_verbose(LOG_DEBUG, temporary_mount, entry_path, /* fstype = */ NULL, MS_MOVE, /* options = */ NULL);
+ r = mount_nofollow_verbose(LOG_DEBUG, temporary_mount, entry_path, /* fstype= */ NULL, MS_MOVE, /* options= */ NULL);
if (r < 0)
return r;
static int mount_private_sysfs(const MountEntry *m, const NamespaceParameters *p) {
assert(m);
assert(p);
- return mount_private_apivfs("sysfs", mount_entry_path(m), "/sys", /* opts = */ NULL, p->runtime_scope);
+ return mount_private_apivfs("sysfs", mount_entry_path(m), "/sys", /* opts= */ NULL, p->runtime_scope);
}
static int mount_private_cgroup2fs(const MountEntry *m, const NamespaceParameters *p) {
assert(m);
assert(p);
- return mount_private_apivfs("cgroup2", mount_entry_path(m), "/sys/fs/cgroup", /* opts = */ NULL, p->runtime_scope);
+ return mount_private_apivfs("cgroup2", mount_entry_path(m), "/sys/fs/cgroup", /* opts= */ NULL, p->runtime_scope);
}
static int mount_procfs(const MountEntry *m, const NamespaceParameters *p) {
if (fs_fd < 0)
return log_debug_errno(errno, "Failed to fsopen: %m");
- r = send_one_fd(socket_fd, fs_fd, /* flags = */ 0);
+ r = send_one_fd(socket_fd, fs_fd, /* flags= */ 0);
if (r < 0)
return log_debug_errno(r, "Failed to send bpffs fd to child: %m");
- r = pidref_wait_for_terminate_and_check("(sd-bpffs)", pidref, /* flags = */ 0);
+ r = pidref_wait_for_terminate_and_check("(sd-bpffs)", pidref, /* flags= */ 0);
if (r < 0)
return r;
pidref_done(pidref);
- _cleanup_close_ int mnt_fd = fsmount(fs_fd, /* flags = */ 0, /* mount_attrs = */ 0);
+ _cleanup_close_ int mnt_fd = fsmount(fs_fd, /* flags= */ 0, /* mount_attrs= */ 0);
if (mnt_fd < 0)
return log_debug_errno(errno, "Failed to fsmount bpffs: %m");
case MOUNT_READ_WRITE_IMPLICIT:
case MOUNT_EXEC:
case MOUNT_NOEXEC:
- r = path_is_mount_point_full(mount_entry_path(m), root_directory, /* flags = */ 0);
+ r = path_is_mount_point_full(mount_entry_path(m), root_directory, /* flags= */ 0);
if (r == -ENOENT && m->ignore)
return 0;
if (r < 0)
host_os_release_id_like,
host_os_release_version_id,
host_os_release_level,
- /* host_extension_scope = */ NULL, /* Leave empty, we need to accept both system and portable */
+ /* host_extension_scope= */ NULL, /* Leave empty, we need to accept both system and portable */
extension_release,
class);
if (r < 0)
if (r < 0)
return r;
- r = append_private_bpf(&ml, p->private_bpf, p->protect_kernel_tunables, /* ignore_protect = */ false, p);
+ r = append_private_bpf(&ml, p->private_bpf, p->protect_kernel_tunables, /* ignore_protect= */ false, p);
if (r < 0)
return r;
} else if (p->root_directory) {
/* A root directory is specified. Turn its directory into bind mount, if it isn't one yet. */
- r = path_is_mount_point_full(root, /* root = */ NULL, AT_SYMLINK_FOLLOW);
+ r = path_is_mount_point_full(root, /* root= */ NULL, AT_SYMLINK_FOLLOW);
if (r < 0)
return log_debug_errno(r, "Failed to detect that %s is a mount point or not: %m", root);
if (r == 0) {
return r;
/* MS_MOVE does not work on MS_SHARED so the remount MS_SHARED will be done later */
- r = mount_switch_root(root, /* mount_propagation_flag = */ 0);
+ r = mount_switch_root(root, /* mount_propagation_flag= */ 0);
if (r == -EINVAL && p->root_directory) {
/* If we are using root_directory and we don't have privileges (ie: user manager in a user
* namespace) and the root_directory is already a mount point in the parent namespace,
r = mount_nofollow_verbose(LOG_DEBUG, root, root, NULL, MS_BIND|MS_REC, NULL);
if (r < 0)
return r;
- r = mount_switch_root(root, /* mount_propagation_flag = */ 0);
+ r = mount_switch_root(root, /* mount_propagation_flag= */ 0);
}
if (r < 0)
return log_debug_errno(r, "Failed to mount root with MS_MOVE: %m");
for (;;) {
_cleanup_free_ char *word = NULL;
- r = extract_first_word(&s, &word, ",", /* flags = */ 0);
+ r = extract_first_word(&s, &word, ",", /* flags= */ 0);
if (r < 0)
return log_warning_errno(r, "Failed to parse delegate options \"%s\": %m", s);
if (r == 0)
if (state != old_state)
log_unit_debug(UNIT(p), "Changed %s -> %s", path_state_to_string(old_state), path_state_to_string(state));
- unit_notify(UNIT(p), state_translation_table[old_state], state_translation_table[state], /* reload_success = */ true);
+ unit_notify(UNIT(p), state_translation_table[old_state], state_translation_table[state], /* reload_success= */ true);
}
static void path_enter_waiting(Path *p, bool initial, bool from_trigger_notify);
return 0;
}
- path_trigger_notify_impl(UNIT(p), trigger, /* on_defer = */ true);
+ path_trigger_notify_impl(UNIT(p), trigger, /* on_defer= */ true);
return 0;
}
return;
if (on_defer) {
- path_enter_waiting(p, /* initial = */ false, /* from_trigger_notify = */ true);
+ path_enter_waiting(p, /* initial= */ false, /* from_trigger_notify= */ true);
return;
}
}
static void path_trigger_notify(Unit *u, Unit *other) {
- path_trigger_notify_impl(u, other, /* on_defer = */ false);
+ path_trigger_notify_impl(u, other, /* on_defer= */ false);
}
static void path_reset_failed(Unit *u) {
log_unit_debug(UNIT(s), "Changed %s -> %s",
scope_state_to_string(old_state), scope_state_to_string(state));
- unit_notify(UNIT(s), state_translation_table[old_state], state_translation_table[state], /* reload_success = */ true);
+ unit_notify(UNIT(s), state_translation_table[old_state], state_translation_table[state], /* reload_success= */ true);
}
static int scope_add_default_dependencies(Scope *s) {
} else
log_unit_debug(UNIT(s), "Main PID loaded: "PID_FMT, pidref.pid);
- r = service_set_main_pidref(s, TAKE_PIDREF(pidref), /* start_timestamp = */ NULL);
+ r = service_set_main_pidref(s, TAKE_PIDREF(pidref), /* start_timestamp= */ NULL);
if (r < 0)
return r;
return;
log_unit_debug(UNIT(s), "Main PID guessed: "PID_FMT, pid.pid);
- if (service_set_main_pidref(s, TAKE_PIDREF(pid), /* start_timestamp = */ NULL) < 0)
+ if (service_set_main_pidref(s, TAKE_PIDREF(pid), /* start_timestamp= */ NULL) < 0)
return;
r = unit_watch_pidref(UNIT(s), &s->main_pid, /* exclusive= */ false);
}
if (start_only)
- unit_destroy_runtime_data(u, &s->exec_context, /* destroy_runtime_dir = */ false);
+ unit_destroy_runtime_data(u, &s->exec_context, /* destroy_runtime_dir= */ false);
}
if (old_state != state)
&exec_params.fds,
&exec_params.fd_names,
&exec_params.n_socket_fds,
- /* n_stashed_fds = */ NULL);
+ /* n_stashed_fds= */ NULL);
if (r < 0)
return r;
}
if (MANAGER_IS_USER(UNIT(s)->manager) &&
- !exec_needs_pid_namespace(&s->exec_context, /* params = */ NULL)) {
+ !exec_needs_pid_namespace(&s->exec_context, /* params= */ NULL)) {
if (asprintf(our_env + n_env++, "MANAGERPID="PID_FMT, getpid_cached()) < 0)
return -ENOMEM;
end_state = SERVICE_FAILED;
restart_state = SERVICE_FAILED_BEFORE_AUTO_RESTART;
}
- unit_warn_leftover_processes(UNIT(s), /* start = */ false);
+ unit_warn_leftover_processes(UNIT(s), /* start= */ false);
if (!allow_restart)
log_unit_debug(UNIT(s), "Service restart not allowed.");
s->exec_runtime = exec_runtime_destroy(s->exec_runtime);
/* Also, remove the runtime directory */
- unit_destroy_runtime_data(UNIT(s), &s->exec_context, /* destroy_runtime_dir = */ true);
+ unit_destroy_runtime_data(UNIT(s), &s->exec_context, /* destroy_runtime_dir= */ true);
/* Also get rid of the fd store, if that's configured. */
if (s->fd_store_preserve_mode == EXEC_PRESERVE_NO)
r = service_spawn(s,
s->control_command,
- service_exec_flags(s->control_command_id, /* cred_flag = */ 0),
+ service_exec_flags(s->control_command_id, /* cred_flag= */ 0),
s->timeout_stop_usec,
&s->control_pid);
if (r < 0) {
r = service_spawn(s,
s->control_command,
- service_exec_flags(s->control_command_id, /* cred_flag = */ 0),
+ service_exec_flags(s->control_command_id, /* cred_flag= */ 0),
s->timeout_stop_usec,
&s->control_pid);
if (r < 0) {
r = service_spawn(s,
s->control_command,
- service_exec_flags(s->control_command_id, /* cred_flag = */ 0),
+ service_exec_flags(s->control_command_id, /* cred_flag= */ 0),
s->timeout_start_usec,
&s->control_pid);
if (r < 0) {
* instances running, lets not stress the rigor of these. Also ExecStartPre= parts of the service
* aren't as rigoriously written to protect against multiple use. */
- if (unit_warn_leftover_processes(UNIT(s), /* start = */ true) > 0 &&
+ if (unit_warn_leftover_processes(UNIT(s), /* start= */ true) > 0 &&
IN_SET(s->kill_context.kill_mode, KILL_MIXED, KILL_CONTROL_GROUP) &&
!s->kill_context.send_sigkill)
return log_unit_error_errno(UNIT(s), SYNTHETIC_ERRNO(EBUSY),
r = service_spawn(s,
s->control_command,
- service_exec_flags(s->control_command_id, /* cred_flag = */ 0),
+ service_exec_flags(s->control_command_id, /* cred_flag= */ 0),
s->timeout_start_usec,
&s->control_pid);
if (r < 0) {
r = service_spawn(s,
s->control_command,
- service_exec_flags(s->control_command_id, /* cred_flag = */ 0),
+ service_exec_flags(s->control_command_id, /* cred_flag= */ 0),
s->timeout_start_usec,
&s->control_pid);
if (r < 0) {
JOB_START, UNIT(s),
s->restart_mode == SERVICE_RESTART_MODE_DIRECT ? JOB_REPLACE : JOB_RESTART_DEPENDENCIES,
TRANSACTION_REENQUEUE_ANCHOR,
- /* affected_jobs = */ NULL,
- &error, /* ret = */ NULL);
+ /* affected_jobs= */ NULL,
+ &error, /* ret= */ NULL);
if (r < 0) {
log_unit_warning(UNIT(s), "Failed to schedule restart job: %s", bus_error_message(&error, r));
return service_enter_dead(s, SERVICE_FAILURE_RESOURCES, /* allow_restart= */ false);
r = service_spawn(s,
s->control_command,
- service_exec_flags(s->control_command_id, /* cred_flag = */ 0),
+ service_exec_flags(s->control_command_id, /* cred_flag= */ 0),
s->timeout_start_usec,
&s->control_pid);
if (r < 0) {
r = service_spawn(s,
s->control_command,
- service_exec_flags(s->control_command_id, /* cred_flag = */ 0),
+ service_exec_flags(s->control_command_id, /* cred_flag= */ 0),
s->timeout_start_usec,
&s->control_pid);
if (r < 0) {
r = service_spawn(s,
s->control_command,
- service_exec_flags(s->control_command_id, /* cred_flag = */ 0),
+ service_exec_flags(s->control_command_id, /* cred_flag= */ 0),
timeout,
&s->control_pid);
if (r < 0) {
* for auto restart. We need to re-enqueue the job though, as the job type has changed
* (JOB_RESTART_DEPENDENCIES). */
- service_enter_restart(s, /* shortcut = */ true);
+ service_enter_restart(s, /* shortcut= */ true);
return -EAGAIN;
}
PidRef pidref;
if (!pidref_is_set(&s->main_pid) && deserialize_pidref(fds, value, &pidref) >= 0)
- (void) service_set_main_pidref(s, pidref, /* start_timestamp = */ NULL);
+ (void) service_set_main_pidref(s, pidref, /* start_timestamp= */ NULL);
} else if (streq(key, "main-pid-known")) {
r = parse_boolean(value);
log_unit_debug(UNIT(s),
"Service has no hold-off time (RestartSec=0), scheduling restart.");
- service_enter_restart(s, /* shortcut = */ false);
+ service_enter_restart(s, /* shortcut= */ false);
break;
case SERVICE_CLEANING:
log_unit_warning(u, "New main PID "PID_FMT" does not belong to service, refusing.", new_main_pid.pid);
}
if (r > 0) {
- (void) service_set_main_pidref(s, TAKE_PIDREF(new_main_pid), /* start_timestamp = */ NULL);
+ (void) service_set_main_pidref(s, TAKE_PIDREF(new_main_pid), /* start_timestamp= */ NULL);
r = unit_watch_pidref(UNIT(s), &s->main_pid, /* exclusive= */ false);
if (r < 0)
assert(pidref_is_set(child_pidref));
if (pidref_equal(&s->main_pid, parent_pidref)) {
- r = service_set_main_pidref(s, TAKE_PIDREF(*child_pidref), /* start_timestamp = */ NULL);
+ r = service_set_main_pidref(s, TAKE_PIDREF(*child_pidref), /* start_timestamp= */ NULL);
if (r < 0)
return (void) log_unit_warning_errno(u, r, "Failed to set new main pid: %m");
log_unit_debug(UNIT(s), "D-Bus name %s is now owned by process " PID_FMT, s->bus_name, pidref.pid);
- (void) service_set_main_pidref(s, TAKE_PIDREF(pidref), /* start_timestamp = */ NULL);
+ (void) service_set_main_pidref(s, TAKE_PIDREF(pidref), /* start_timestamp= */ NULL);
(void) unit_watch_pidref(UNIT(s), &s->main_pid, /* exclusive= */ false);
return 1;
}
log_unit_debug(UNIT(s), "Changed %s -> %s",
slice_state_to_string(old_state), slice_state_to_string(state));
- unit_notify(UNIT(s), state_translation_table[old_state], state_translation_table[state], /* reload_success = */ true);
+ unit_notify(UNIT(s), state_translation_table[old_state], state_translation_table[state], /* reload_success= */ true);
}
static int slice_add_parent_slice(Slice *s) {
if (state != old_state)
log_unit_debug(UNIT(s), "Changed %s -> %s", socket_state_to_string(old_state), socket_state_to_string(state));
- unit_notify(UNIT(s), state_translation_table[old_state], state_translation_table[state], /* reload_success = */ true);
+ unit_notify(UNIT(s), state_translation_table[old_state], state_translation_table[state], /* reload_success= */ true);
}
static int socket_coldplug(Unit *u) {
else
unit_log_failure(UNIT(s), socket_result_to_string(s->result));
- unit_warn_leftover_processes(UNIT(s), /* start = */ false);
+ unit_warn_leftover_processes(UNIT(s), /* start= */ false);
socket_set_state(s, s->result != SOCKET_SUCCESS ? SOCKET_FAILED : SOCKET_DEAD);
s->exec_runtime = exec_runtime_destroy(s->exec_runtime);
- unit_destroy_runtime_data(UNIT(s), &s->exec_context, /* destroy_runtime_dir = */ true);
+ unit_destroy_runtime_data(UNIT(s), &s->exec_context, /* destroy_runtime_dir= */ true);
unit_unref_uid_gid(UNIT(s), true);
}
socket_unwatch_control_pid(s);
- unit_warn_leftover_processes(UNIT(s), /* start = */ true);
+ unit_warn_leftover_processes(UNIT(s), /* start= */ true);
s->control_command_id = SOCKET_EXEC_START_PRE;
s->control_command = s->exec_command[SOCKET_EXEC_START_PRE];
assert(s->state == SOCKET_DEFERRED);
- r = manager_add_job(u->manager, JOB_START, UNIT_DEREF(s->service), JOB_LENIENT, &error, /* ret = */ NULL);
+ r = manager_add_job(u->manager, JOB_START, UNIT_DEREF(s->service), JOB_LENIENT, &error, /* ret= */ NULL);
if (r >= 0) { /* Yay! */
socket_set_state(s, SOCKET_RUNNING);
return true; /* changed */
* Put a safety net around all this though, i.e. give up if the service still can't be started
* even after all existing jobs have completed, or DeferTriggerMaxSec= is reached. */
- r = socket_arm_timer(s, /* relative = */ true, s->defer_trigger_max_usec);
+ r = socket_arm_timer(s, /* relative= */ true, s->defer_trigger_max_usec);
if (r < 0) {
log_unit_warning_errno(UNIT(s), r, "Failed to install timer: %m");
return socket_enter_stop_pre(s, SOCKET_FAILURE_RESOURCES);
}
if (s->defer_trigger != SOCKET_DEFER_NO) {
- r = manager_add_job(UNIT(s)->manager, JOB_START, UNIT_DEREF(s->service), JOB_LENIENT, &error, /* ret = */ NULL);
+ r = manager_add_job(UNIT(s)->manager, JOB_START, UNIT_DEREF(s->service), JOB_LENIENT, &error, /* ret= */ NULL);
if (r < 0 && sd_bus_error_has_name(&error, BUS_ERROR_TRANSACTION_IS_DESTRUCTIVE) && socket_may_defer(s))
/* We only check BUS_ERROR_TRANSACTION_IS_DESTRUCTIVE here, not
* BUS_ERROR_TRANSACTION_JOBS_CONFLICTING or BUS_ERROR_TRANSACTION_ORDER_IS_CYCLIC,
* Deferring activation probably won't help. */
return socket_enter_deferred(s);
} else
- r = manager_add_job(UNIT(s)->manager, JOB_START, UNIT_DEREF(s->service), JOB_REPLACE, &error, /* ret = */ NULL);
+ r = manager_add_job(UNIT(s)->manager, JOB_START, UNIT_DEREF(s->service), JOB_REPLACE, &error, /* ret= */ NULL);
if (r < 0)
goto queue_error;
}
s->n_connections++;
- r = manager_add_job(UNIT(s)->manager, JOB_START, service, JOB_REPLACE, &error, /* ret = */ NULL);
+ r = manager_add_job(UNIT(s)->manager, JOB_START, service, JOB_REPLACE, &error, /* ret= */ NULL);
if (r < 0) {
/* We failed to activate the new service, but it still exists. Let's make sure the
* service closes and forgets the connection fd again, immediately. */
"Socket service %s not loaded, refusing.", UNIT(service)->id);
/* If the service is already active we cannot start the socket */
- if (SOCKET_SERVICE_IS_ACTIVE(service, /* allow_finalize = */ false))
+ if (SOCKET_SERVICE_IS_ACTIVE(service, /* allow_finalize= */ false))
return log_unit_error_errno(u, SYNTHETIC_ERRNO(EBUSY),
"Socket service %s already active, refusing.", UNIT(service)->id);
}
if (other->job)
return;
- if (!SOCKET_SERVICE_IS_ACTIVE(service, /* allow_finalize = */ true))
+ if (!SOCKET_SERVICE_IS_ACTIVE(service, /* allow_finalize= */ true))
socket_enter_listening(s);
if (SERVICE(other)->state == SERVICE_RUNNING)
assert(u->load_state == UNIT_STUB);
/* Load a .swap file */
- r = unit_load_fragment_and_dropin(u, /* fragment_required = */ !s->from_proc_swaps);
+ r = unit_load_fragment_and_dropin(u, /* fragment_required= */ !s->from_proc_swaps);
/* Add in some extras, and do so either when we successfully loaded something or when /proc/swaps is
* already active. */
if (state != old_state)
log_unit_debug(UNIT(s), "Changed %s -> %s", swap_state_to_string(old_state), swap_state_to_string(state));
- unit_notify(UNIT(s), state_translation_table[old_state], state_translation_table[state], /* reload_success = */ true);
+ unit_notify(UNIT(s), state_translation_table[old_state], state_translation_table[state], /* reload_success= */ true);
/* If there other units for the same device node have a job
queued it might be worth checking again if it is runnable
s->result = f;
unit_log_result(UNIT(s), s->result == SWAP_SUCCESS, swap_result_to_string(s->result));
- unit_warn_leftover_processes(UNIT(s), /* start = */ false);
+ unit_warn_leftover_processes(UNIT(s), /* start= */ false);
swap_set_state(s, s->result != SWAP_SUCCESS ? SWAP_FAILED : SWAP_DEAD);
s->exec_runtime = exec_runtime_destroy(s->exec_runtime);
- unit_destroy_runtime_data(UNIT(s), &s->exec_context, /* destroy_runtime_dir = */ true);
+ unit_destroy_runtime_data(UNIT(s), &s->exec_context, /* destroy_runtime_dir= */ true);
unit_unref_uid_gid(UNIT(s), true);
}
assert(s);
- unit_warn_leftover_processes(UNIT(s), /* start = */ true);
+ unit_warn_leftover_processes(UNIT(s), /* start= */ true);
s->control_command_id = SWAP_EXEC_ACTIVATE;
s->control_command = s->exec_command + SWAP_EXEC_ACTIVATE;
log_unit_debug(UNIT(t), "Changed %s -> %s",
target_state_to_string(old_state), target_state_to_string(state));
- unit_notify(UNIT(t), state_translation_table[old_state], state_translation_table[state], /* reload_success = */ true);
+ unit_notify(UNIT(t), state_translation_table[old_state], state_translation_table[state], /* reload_success= */ true);
}
static int target_add_default_dependencies(Target *t) {
if (state != old_state)
log_unit_debug(UNIT(t), "Changed %s -> %s", timer_state_to_string(old_state), timer_state_to_string(state));
- unit_notify(UNIT(t), state_translation_table[old_state], state_translation_table[state], /* reload_success = */ true);
+ unit_notify(UNIT(t), state_translation_table[old_state], state_translation_table[state], /* reload_success= */ true);
}
static void timer_enter_waiting(Timer *t, bool time_change);
assert(tr);
/* First step, try to drop unmergeable jobs for jobs that matter to anchor. */
- r = transaction_ensure_mergeable(tr, /* matters_to_anchor = */ true, e);
+ r = transaction_ensure_mergeable(tr, /* matters_to_anchor= */ true, e);
if (r < 0)
return r;
/* Second step, do the same for jobs that not matter to anchor. */
- r = transaction_ensure_mergeable(tr, /* matters_to_anchor = */ false, e);
+ r = transaction_ensure_mergeable(tr, /* matters_to_anchor= */ false, e);
if (r < 0)
return r;
fputs("markers=", f);
BIT_FOREACH(m, markers)
- fputs_with_separator(f, unit_marker_to_string(m), /* separator = */ NULL, &space);
+ fputs_with_separator(f, unit_marker_to_string(m), /* separator= */ NULL, &space);
fputc('\n', f);
return 0;
}
* wasn't the case in prior versions with the realized state tracked in a discrete field.
* Patch cgroup_realized == 0 back to no cgroup_path here hence. */
if (crt->deserialized_cgroup_realized == 0)
- unit_release_cgroup(u, /* drop_cgroup_runtime = */ false);
+ unit_release_cgroup(u, /* drop_cgroup_runtime= */ false);
else {
unit_invalidate_cgroup(u, _CGROUP_MASK_ALL);
unit_invalidate_cgroup_bpf_firewall(u);
if (u->on_console)
manager_unref_console(u->manager);
- unit_release_cgroup(u, /* drop_cgroup_runtime = */ true);
+ unit_release_cgroup(u, /* drop_cgroup_runtime= */ true);
if (!MANAGER_IS_RELOADING(u->manager))
unit_unlink_state_files(u);
(void) manager_load_unit_prepare(
u->manager,
p,
- /* path= */NULL,
- /* e= */NULL,
+ /* path= */ NULL,
+ /* e= */ NULL,
&m);
continue;
}
if (!UNIT_VTABLE(u)->reload) {
/* Unit doesn't have a reload function, but we need to propagate the reload anyway */
- unit_notify(u, unit_active_state(u), unit_active_state(u), /* reload_success = */ true);
+ unit_notify(u, unit_active_state(u), unit_active_state(u), /* reload_success= */ true);
return 0;
}
UNIT_FOREACH_DEPENDENCY_SAFE(other, u, UNIT_ATOM_RETROACTIVE_START_REPLACE) /* Requires= + BindsTo= */
if (!unit_has_dependency(u, UNIT_ATOM_AFTER, other) &&
!UNIT_IS_ACTIVE_OR_ACTIVATING(unit_active_state(other)))
- (void) manager_add_job(u->manager, JOB_START, other, JOB_REPLACE, /* reterr_error = */ NULL, /* ret = */ NULL);
+ (void) manager_add_job(u->manager, JOB_START, other, JOB_REPLACE, /* reterr_error= */ NULL, /* ret= */ NULL);
UNIT_FOREACH_DEPENDENCY_SAFE(other, u, UNIT_ATOM_RETROACTIVE_START_FAIL) /* Wants= */
if (!unit_has_dependency(u, UNIT_ATOM_AFTER, other) &&
!UNIT_IS_ACTIVE_OR_ACTIVATING(unit_active_state(other)))
- (void) manager_add_job(u->manager, JOB_START, other, JOB_FAIL, /* reterr_error = */ NULL, /* ret = */ NULL);
+ (void) manager_add_job(u->manager, JOB_START, other, JOB_FAIL, /* reterr_error= */ NULL, /* ret= */ NULL);
UNIT_FOREACH_DEPENDENCY_SAFE(other, u, UNIT_ATOM_RETROACTIVE_STOP_ON_START) /* Conflicts= (and inverse) */
if (!UNIT_IS_INACTIVE_OR_DEACTIVATING(unit_active_state(other)))
- (void) manager_add_job(u->manager, JOB_STOP, other, JOB_REPLACE, /* reterr_error = */ NULL, /* ret = */ NULL);
+ (void) manager_add_job(u->manager, JOB_STOP, other, JOB_REPLACE, /* reterr_error= */ NULL, /* ret= */ NULL);
}
static void retroactively_stop_dependencies(Unit *u) {
/* Pull down units which are bound to us recursively if enabled */
UNIT_FOREACH_DEPENDENCY_SAFE(other, u, UNIT_ATOM_RETROACTIVE_STOP_ON_STOP) /* BoundBy= */
if (!UNIT_IS_INACTIVE_OR_DEACTIVATING(unit_active_state(other)))
- (void) manager_add_job(u->manager, JOB_STOP, other, JOB_REPLACE, /* reterr_error = */ NULL, /* ret = */ NULL);
+ (void) manager_add_job(u->manager, JOB_STOP, other, JOB_REPLACE, /* reterr_error= */ NULL, /* ret= */ NULL);
}
void unit_start_on_termination_deps(Unit *u, UnitDependencyAtom atom) {
if (n_jobs == 0)
log_unit_info(u, "Triggering %s dependencies.", dependency_name);
- r = manager_add_job(u->manager, JOB_START, other, job_mode, &error, /* ret = */ NULL);
+ r = manager_add_job(u->manager, JOB_START, other, job_mode, &error, /* ret= */ NULL);
if (r < 0)
log_unit_warning_errno(u, r, "Failed to enqueue %s%s job, ignoring: %s",
dependency_name, other->id, bus_error_message(&error, r));
case JOB_VERIFY_ACTIVE:
if (UNIT_IS_ACTIVE_OR_RELOADING(ns))
- job_finish_and_invalidate(j, JOB_DONE, /* recursive = */ true, /* already = */ false);
+ job_finish_and_invalidate(j, JOB_DONE, /* recursive= */ true, /* already= */ false);
else if (j->state == JOB_RUNNING && ns != UNIT_ACTIVATING) {
unexpected = true;
if (UNIT_IS_INACTIVE_OR_FAILED(ns))
- job_finish_and_invalidate(j, ns == UNIT_FAILED ? JOB_FAILED : JOB_DONE, /* recursive = */ true, /* already = */ false);
+ job_finish_and_invalidate(j, ns == UNIT_FAILED ? JOB_FAILED : JOB_DONE, /* recursive= */ true, /* already= */ false);
}
break;
if (j->state == JOB_RUNNING) {
if (ns == UNIT_ACTIVE)
- job_finish_and_invalidate(j, reload_success ? JOB_DONE : JOB_FAILED, /* recursive = */ true, /* already = */ false);
+ job_finish_and_invalidate(j, reload_success ? JOB_DONE : JOB_FAILED, /* recursive= */ true, /* already= */ false);
else if (!IN_SET(ns, UNIT_ACTIVATING, UNIT_RELOADING, UNIT_REFRESHING)) {
unexpected = true;
- job_finish_and_invalidate(j, reload_success ? JOB_CANCELED : JOB_FAILED, /* recursive = */ true, /* already = */ false);
+ job_finish_and_invalidate(j, reload_success ? JOB_CANCELED : JOB_FAILED, /* recursive= */ true, /* already= */ false);
}
}
case JOB_RESTART:
if (UNIT_IS_INACTIVE_OR_FAILED(ns))
- job_finish_and_invalidate(j, JOB_DONE, /* recursive = */ true, /* already = */ false);
+ job_finish_and_invalidate(j, JOB_DONE, /* recursive= */ true, /* already= */ false);
else if (j->state == JOB_RUNNING && ns != UNIT_DEACTIVATING) {
unexpected = true;
- job_finish_and_invalidate(j, JOB_FAILED, /* recursive = */ true, /* already = */ false);
+ job_finish_and_invalidate(j, JOB_FAILED, /* recursive= */ true, /* already= */ false);
}
break;
assert(p);
/* This is mostly for debug purposes */
- return RET_NERRNO(setenv("SYSTEMD_UNIT_PATH", p, /* overwrite = */ true));
+ return RET_NERRNO(setenv("SYSTEMD_UNIT_PATH", p, /* overwrite= */ true));
}
char* unit_dbus_path(Unit *u) {
r = bus_add_match_full(
bus,
&u->match_bus_slot,
- /* asynchronous = */ true,
+ /* asynchronous= */ true,
match,
signal_name_owner_changed,
signal_name_owner_changed_install_handler,
if (u->nop_job)
RET_GATHER(r, job_coldplug(u->nop_job));
- unit_modify_nft_set(u, /* add = */ true);
+ unit_modify_nft_set(u, /* add= */ true);
return r;
}
if (u->load_state == UNIT_LOADED) {
_cleanup_strv_free_ char **dropins = NULL;
- (void) unit_find_dropin_paths(u, /* use_unit_path_cache = */ false, &dropins);
+ (void) unit_find_dropin_paths(u, /* use_unit_path_cache= */ false, &dropins);
if (!strv_equal(u->dropin_paths, dropins))
return true;
return log_unit_error_errno(u, SYNTHETIC_ERRNO(ENOEXEC), "WorkingDirectory=~ is not allowed under DynamicUser=yes. Refusing.");
if (ec->working_directory && path_below_api_vfs(ec->working_directory) &&
- exec_needs_mount_namespace(ec, /* params = */ NULL, /* runtime = */ NULL))
+ exec_needs_mount_namespace(ec, /* params= */ NULL, /* runtime= */ NULL))
return log_unit_error_errno(u, SYNTHETIC_ERRNO(ENOEXEC), "WorkingDirectory= may not be below /proc/, /sys/ or /dev/ when using mount namespacing. Refusing.");
if (exec_needs_pid_namespace(ec, /* params= */ NULL) && !UNIT_VTABLE(u)->notify_pidref)
r = unit_kill_context_one(u, main_pid, "main", is_alien, sig, send_sighup, log_func);
wait_for_exit = wait_for_exit || r > 0;
- r = unit_kill_context_one(u, unit_control_pid(u), "control", /* is_alien = */ false, sig, send_sighup, log_func);
+ r = unit_kill_context_one(u, unit_control_pid(u), "control", /* is_alien= */ false, sig, send_sighup, log_func);
wait_for_exit = wait_for_exit || r > 0;
CGroupRuntime *crt = unit_get_cgroup_runtime(u);
static void unit_unref_uid(Unit *u, bool destroy_now) {
assert(u);
- unit_modify_user_nft_set(u, /* add = */ false, NFT_SET_SOURCE_USER, u->ref_uid);
+ unit_modify_user_nft_set(u, /* add= */ false, NFT_SET_SOURCE_USER, u->ref_uid);
unit_unref_uid_internal(u, &u->ref_uid, destroy_now, manager_unref_uid);
}
static void unit_unref_gid(Unit *u, bool destroy_now) {
assert(u);
- unit_modify_user_nft_set(u, /* add = */ false, NFT_SET_SOURCE_GROUP, u->ref_gid);
+ unit_modify_user_nft_set(u, /* add= */ false, NFT_SET_SOURCE_GROUP, u->ref_gid);
unit_unref_uid_internal(u, (uid_t*) &u->ref_gid, destroy_now, manager_unref_gid);
}
if (r < 0)
return log_unit_warning_errno(u, r, "Couldn't add UID/GID reference to unit, proceeding without: %m");
- unit_modify_user_nft_set(u, /* add = */ true, NFT_SET_SOURCE_USER, uid);
- unit_modify_user_nft_set(u, /* add = */ true, NFT_SET_SOURCE_GROUP, gid);
+ unit_modify_user_nft_set(u, /* add= */ true, NFT_SET_SOURCE_USER, uid);
+ unit_modify_user_nft_set(u, /* add= */ true, NFT_SET_SOURCE_GROUP, gid);
return r;
}
freezer_state_to_string(u->freezer_state));
/* If the cgroup's final state is against what's requested by us, report as canceled. */
- bus_unit_send_pending_freezer_message(u, /* canceled = */ !expected);
+ bus_unit_send_pending_freezer_message(u, /* canceled= */ !expected);
}
int unit_freezer_action(Unit *u, FreezerAction action) {
return log_unit_debug_errno(u, errno, "Failed to get exec quota stats: %m");
uint32_t proj_id;
- r = read_fs_xattr_fd(fd, /* ret_xflags = */ NULL, &proj_id);
+ r = read_fs_xattr_fd(fd, /* ret_xflags= */ NULL, &proj_id);
if (r < 0)
return log_unit_debug_errno(u, r, "Failed to get project ID for exec quota stats: %m");
JSON_BUILD_PAIR_STRING_NON_EMPTY("Personality", personality_to_string(c->personality)),
SD_JSON_BUILD_PAIR_BOOLEAN("IgnoreSIGPIPE", c->ignore_sigpipe),
- /* Scheduling */
+ /* Scheduling */
SD_JSON_BUILD_PAIR_INTEGER("Nice", exec_context_get_nice(c)),
SD_JSON_BUILD_PAIR_CALLBACK("CPUSchedulingPolicy", cpu_sched_class_build_json, c),
SD_JSON_BUILD_PAIR_INTEGER("CPUSchedulingPriority", exec_context_get_cpu_sched_priority(c)),
JSON_BUILD_PAIR_CALLBACK_NON_NULL("SystemCallArchitectures", syscall_archs_build_json, c),
JSON_BUILD_PAIR_CALLBACK_NON_NULL("SystemCallLog", syscall_log_build_json, c),
- /* Environment */
+ /* Environment */
JSON_BUILD_PAIR_STRV_NON_EMPTY("Environment", c->environment),
JSON_BUILD_PAIR_CALLBACK_NON_NULL("EnvironmentFiles", environment_files_build_json, c->environment_files),
JSON_BUILD_PAIR_STRV_NON_EMPTY("PassEnvironment", c->pass_environment),
if (r < 0)
return r;
if (unit)
- return list_unit_one_with_selinux_access_check(link, unit, /* more = */ false);
+ return list_unit_one_with_selinux_access_check(link, unit, /* more= */ false);
if (!FLAGS_SET(flags, SD_VARLINK_METHOD_MORE))
return sd_varlink_error(link, SD_VARLINK_ERROR_EXPECTED_MORE, NULL);
continue;
if (previous) {
- r = list_unit_one(link, previous, /* more = */ true);
+ r = list_unit_one(link, previous, /* more= */ true);
if (r < 0)
return r;
}
}
if (previous)
- return list_unit_one(link, previous, /* more = */ false);
+ return list_unit_one(link, previous, /* more= */ false);
return sd_varlink_error(link, "io.systemd.Manager.NoSuchUnit", NULL);
}
assert(m->managed_oom_varlink);
- r = build_managed_oom_cgroups_json(m, /* allow_empty = */ false, &v);
+ r = build_managed_oom_cgroups_json(m, /* allow_empty= */ false, &v);
if (r <= 0)
return r;
if (!streq(u->id, "systemd-oomd.service"))
return sd_varlink_error(link, SD_VARLINK_ERROR_PERMISSION_DENIED, NULL);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
_cleanup_(sd_json_variant_unrefp) sd_json_variant *v = NULL;
- r = build_managed_oom_cgroups_json(m, /* allow_empty = */ true, &v);
+ r = build_managed_oom_cgroups_json(m, /* allow_empty= */ true, &v);
if (r < 0)
return r;
assert(context);
assert(pidref_is_set(&context->pidref));
- r = pidref_in_same_namespace(/* pid1 = */ NULL, &context->pidref, NAMESPACE_PID);
+ r = pidref_in_same_namespace(/* pid1= */ NULL, &context->pidref, NAMESPACE_PID);
if (r < 0)
log_debug_errno(r, "Failed to check pidns of crashing process, ignoring: %m");
}
}
- r = check_password_quality(new_password, /* old = */ NULL, /* user = */ NULL, &error);
+ r = check_password_quality(new_password, /* old= */ NULL, /* user= */ NULL, &error);
if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
log_warning("Password quality check is not supported, proceeding anyway.");
else if (r < 0)
_cleanup_free_ char *device = NULL;
if (streq(optarg, "list"))
- return tpm2_list_devices(/* legend = */ true, /* quiet = */ false);
+ return tpm2_list_devices(/* legend= */ true, /* quiet= */ false);
if (arg_enroll_type >= 0 || arg_tpm2_device)
return log_error_errno(SYNTHETIC_ERRNO(EINVAL),
keydev,
"keydev",
keyfile_timeout_value,
- /* canfail = */ keyfile_can_timeout > 0,
+ /* canfail= */ keyfile_can_timeout > 0,
/* readonly= */ true,
&unit,
&keydev_mount);
headerdev,
"headerdev",
NULL,
- /* canfail= */ false, /* header is always necessary */
+ /* canfail= */ false, /* header is always necessary */
/* readonly= */ false, /* LUKS2 recovery requires rw header access */
&unit,
&headerdev_mount);
_cleanup_strv_free_erase_ char **pins = NULL;
int r;
- r = crypt_activate_by_token_pin(cd, name, type, CRYPT_ANY_TOKEN, /* pin=*/ NULL, /* pin_size= */ 0, userdata, activation_flags);
+ r = crypt_activate_by_token_pin(cd, name, type, CRYPT_ANY_TOKEN, /* pin= */ NULL, /* pin_size= */ 0, userdata, activation_flags);
if (r > 0) /* returns unlocked keyslot id on success */
return 0;
if (r == -EEXIST) /* volume is already active */
continue;
}
- r = write_drop_in(arg_dest, dropin_unit, /* level = */ UINT_MAX, dropin_name, d);
+ r = write_drop_in(arg_dest, dropin_unit, /* level= */ UINT_MAX, dropin_name, d);
if (r < 0) {
log_warning_errno(r, "Failed to write drop-in '%s' for unit '%s' from credential '%s', ignoring: %m",
dropin_name, dropin_unit, de->d_name);
continue;
log_debug("Adding at top: %s %s %s/%s", *file, glyph(GLYPH_ARROW_RIGHT), path, *file);
- r = path_put(top, path, *file, /* override = */ false);
+ r = path_put(top, path, *file, /* override= */ false);
if (r < 0)
return r;
log_debug("Adding at bottom: %s %s %s/%s", *file, glyph(GLYPH_ARROW_RIGHT), path, *file);
- r = path_put(bottom, path, *file, /* override = */ true);
+ r = path_put(bottom, path, *file, /* override= */ true);
if (r < 0)
return r;
log_debug("Adding to drops: %s %s %s %s %s/%s",
unit, glyph(GLYPH_ARROW_RIGHT), *file, glyph(GLYPH_ARROW_RIGHT), path, *file);
- r = path_put(&h, path, *file, /* override = */ false);
+ r = path_put(&h, path, *file, /* override= */ false);
if (r < 0)
return r;
}
STRV_FOREACH(t, files) {
log_debug("Adding at top: %s %s %s/%s", *t, glyph(GLYPH_ARROW_RIGHT), path, *t);
- r = path_put(top, path, *t, /* override = */ false);
+ r = path_put(top, path, *t, /* override= */ false);
if (r < 0)
return r;
log_debug("Adding at bottom: %s %s %s/%s", *t, glyph(GLYPH_ARROW_RIGHT), path, *t);
- r = path_put(bottom, path, *t, /* override = */ true);
+ r = path_put(bottom, path, *t, /* override= */ true);
if (r < 0)
return r;
}
if (r < 0)
return log_error_errno(r, "Failed to enable enumeration of uninitialized devices: %m");
- r = sd_device_enumerator_add_match_subsystem(e, "block", /* match = */ true);
+ r = sd_device_enumerator_add_match_subsystem(e, "block", /* match= */ true);
if (r < 0)
return log_error_errno(r, "Failed to filter device enumeration by 'block' subsystem: %m");
break;
}
- r = check_password_quality(*a, /* old = */ NULL, "root", &error);
+ r = check_password_quality(*a, /* old= */ NULL, "root", &error);
if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
log_warning("Password quality check is not supported, proceeding anyway.");
else if (r < 0)
/* Ensure that passwd and shadow are in the same directory and are not symlinks. */
FOREACH_STRING(s, "passwd", "shadow") {
- r = verify_regular_at(pfd, s, /* follow = */ false);
+ r = verify_regular_at(pfd, s, /* follow= */ false);
if (r < 0 && r != -ENOENT)
return log_error_errno(r, "Verification of /etc/%s being regular file failed: %m", s);
* opposed to some other file system tree/image) */
bool enabled;
- r = proc_cmdline_get_bool("systemd.firstboot", /* flags = */ 0, &enabled);
+ r = proc_cmdline_get_bool("systemd.firstboot", /* flags= */ 0, &enabled);
if (r < 0)
return log_error_errno(r, "Failed to parse systemd.firstboot= kernel command line argument, ignoring: %m");
if (r > 0 && !enabled) {
_cleanup_free_ char *value = NULL;
int r;
- r = read_credential("fsck.mode", (void**) &value, /* ret_size = */ NULL);
+ r = read_credential("fsck.mode", (void**) &value, /* ret_size= */ NULL);
if (r < 0)
log_debug_errno(r, "Failed to read credential 'fsck.mode', ignoring: %m");
else {
value = mfree(value);
- r = read_credential("fsck.repair", (void**) &value, /* ret_size = */ NULL);
+ r = read_credential("fsck.repair", (void**) &value, /* ret_size= */ NULL);
if (r < 0)
log_debug_errno(r, "Failed to read credential 'fsck.repair', ignoring: %m");
else {
log_debug("Parsing %s...", fstab);
- r = libmount_parse_full(fstab, /* source = */ NULL, MNT_ITER_FORWARD, &table, &iter);
+ r = libmount_parse_full(fstab, /* source= */ NULL, MNT_ITER_FORWARD, &table, &iter);
if (r == -ENOENT)
return 0;
if (r < 0)
sym_mnt_fs_get_options(fs),
sym_mnt_fs_get_passno(fs),
prefix_sysroot,
- /* accept_root = */ false,
- /* use_swap_enabled = */ true);
+ /* accept_root= */ false,
+ /* use_swap_enabled= */ true);
if (arg_sysroot_check && r > 0)
return true; /* We found a mount or swap that would be started… */
RET_GATHER(ret, r);
/* Only honor x-systemd.makefs and .validatefs here, others are not relevant in initrd/not used
* at all (also see mandatory_mount_drop_unapplicable_options()) */
- flags = fstab_options_to_flags(combined_options, /* is_swap = */ false) & (MOUNT_MAKEFS|MOUNT_VALIDATEFS);
+ flags = fstab_options_to_flags(combined_options, /* is_swap= */ false) & (MOUNT_MAKEFS|MOUNT_VALIDATEFS);
return add_mount("/proc/cmdline",
arg_dest,
m->where,
m->fstype,
m->options,
- /* passno = */ -1,
- /* prefix_sysroot = */ !m->for_initrd && in_initrd(),
- /* accept_root = */ true,
- /* use_swap_enabled = */ false));
+ /* passno= */ -1,
+ /* prefix_sysroot= */ !m->for_initrd && in_initrd(),
+ /* accept_root= */ true,
+ /* use_swap_enabled= */ false));
}
return r;
sym_mnt_fs_get_options(fs),
sym_mnt_fs_get_passno(fs),
prefix_sysroot,
- /* accept_root = */ true,
- /* use_swap_enabled = */ true));
+ /* accept_root= */ true,
+ /* use_swap_enabled= */ true));
}
}
(void) determine_usr();
if (arg_sysroot_check) {
- r = parse_fstab(/* prefix_sysroot = */ true);
+ r = parse_fstab(/* prefix_sysroot= */ true);
if (r == 0)
log_debug("Nothing interesting found, not doing daemon-reload.");
if (r > 0)
/* Honour /etc/fstab only when that's enabled */
if (arg_fstab_enabled) {
/* Parse the local /etc/fstab, possibly from the initrd */
- RET_GATHER(r, parse_fstab(/* prefix_sysroot = */ false));
+ RET_GATHER(r, parse_fstab(/* prefix_sysroot= */ false));
/* If running in the initrd also parse the /etc/fstab from the host */
if (in_initrd())
- RET_GATHER(r, parse_fstab(/* prefix_sysroot = */ true));
+ RET_GATHER(r, parse_fstab(/* prefix_sysroot= */ true));
else
RET_GATHER(r, generator_enable_remount_fs_service(arg_dest));
}
RET_GATHER(r, add_mounts_from_cmdline());
- RET_GATHER(r, add_mounts_from_creds(/* prefix_sysroot = */ false));
+ RET_GATHER(r, add_mounts_from_creds(/* prefix_sysroot= */ false));
if (in_initrd())
- RET_GATHER(r, add_mounts_from_creds(/* prefix_sysroot = */ true));
+ RET_GATHER(r, add_mounts_from_creds(/* prefix_sysroot= */ true));
return r;
}
}
size_t csize;
- r = compress_blob(alg, h->data, data_len, buf, size, &csize, /* level = */ -1);
+ r = compress_blob(alg, h->data, data_len, buf, size, &csize, /* level= */ -1);
if (r < 0) {
log_error_errno(r, "Compression failed: %m");
return 0;
for (const char *p = s;;) {
_cleanup_free_ char *word = NULL;
- r = extract_first_word(&p, &word, ",", /* flags = */ 0);
+ r = extract_first_word(&p, &word, ",", /* flags= */ 0);
if (r < 0)
return r;
if (r == 0)
_cleanup_free_ char *value = NULL;
int r;
- r = read_credential_with_decryption("getty.auto", (void**) &value, /* ret_size = */ NULL);
+ r = read_credential_with_decryption("getty.auto", (void**) &value, /* ret_size= */ NULL);
if (r < 0)
log_debug_errno(r, "Failed to read credential 'getty.auto', ignoring: %m");
else if (r > 0) {
if (r < 0)
return log_error_errno(r, "Failed to generate unit name: %m");
- r = generator_open_unit_file(arg_dest_late, /* source = */ NULL, n, &f);
+ r = generator_open_unit_file(arg_dest_late, /* source= */ NULL, n, &f);
if (r < 0)
return r;
if (r < 0)
return log_error_errno(r, "Failed to write file %s: %m", n);
- r = generator_write_device_timeout(arg_dest_late, what, mount_opts, /* filtered = */ NULL);
+ r = generator_write_device_timeout(arg_dest_late, what, mount_opts, /* filtered= */ NULL);
if (r < 0)
return r;
if (streq_ptr(fstype, "crypto_LUKS")) {
/* Mount options passed are determined by partition_pick_mount_options(), whose result
* is known to not contain timeout options. */
- r = add_cryptsetup(id, what, /* mount_opts = */ NULL, flags, /* require= */ true, &crypto_what);
+ r = add_cryptsetup(id, what, /* mount_opts= */ NULL, flags, /* require= */ true, &crypto_what);
if (r < 0)
return r;
if (r < 0)
return log_error_errno(r, "Failed to generate unit name: %m");
- r = generator_open_unit_file(arg_dest_late, /* source = */ NULL, unit, &f);
+ r = generator_open_unit_file(arg_dest_late, /* source= */ NULL, unit, &f);
if (r < 0)
return r;
assert(where);
/* already a mountpoint; generators run during reload */
- r = path_is_mount_point_full(where, /* root = */ NULL, AT_SYMLINK_FOLLOW);
+ r = path_is_mount_point_full(where, /* root= */ NULL, AT_SYMLINK_FOLLOW);
if (r > 0)
return false;
/* The directory will be created by the mount or automount unit when it is started. */
}
if (streq_ptr(p->fstype, "crypto_LUKS")) {
- r = add_cryptsetup("swap", p->node, /* mount_opts = */ NULL, MOUNT_RW, /* require= */ true, &crypto_what);
+ r = add_cryptsetup("swap", p->node, /* mount_opts= */ NULL, MOUNT_RW, /* require= */ true, &crypto_what);
if (r < 0)
return r;
what = crypto_what;
if (r < 0)
return log_error_errno(r, "Failed to generate unit name: %m");
- r = generator_open_unit_file(arg_dest_late, /* source = */ NULL, name, &f);
+ r = generator_open_unit_file(arg_dest_late, /* source= */ NULL, name, &f);
if (r < 0)
return r;
if (r < 0)
return log_error_errno(r, "Failed to generate unit name: %m");
- r = generator_open_unit_file(arg_dest_late, /* source = */ NULL, unit, &f);
+ r = generator_open_unit_file(arg_dest_late, /* source= */ NULL, unit, &f);
if (r < 0)
return r;
"/dev/disk/by-designator/usr",
in_initrd() ? "/sysusr/usr" : "/usr",
arg_usr_fstype,
- /* flags = */ 0,
+ /* flags= */ 0,
options,
"/usr/ Partition",
in_initrd() ? SPECIAL_INITRD_USR_FS_TARGET : SPECIAL_LOCAL_FS_TARGET);
return make_filesystem(device,
fstype,
label,
- /* root = */ NULL,
+ /* root= */ NULL,
uuid,
MKFS_DISCARD | MKFS_QUIET,
- /* sector_size = */ 0,
- /* compression = */ NULL,
- /* compression_level = */ NULL,
- /* extra_mkfs_options = */ NULL);
+ /* sector_size= */ 0,
+ /* compression= */ NULL,
+ /* compression_level= */ NULL,
+ /* extra_mkfs_options= */ NULL);
}
DEFINE_MAIN_FUNCTION(run);
* resume from hibernation can be automatically initiated there. This mostly follows what gpt-auto does,
* but operates in initrd. */
- r = generator_open_unit_file(arg_dest_late, /* source = */ NULL, "systemd-cryptsetup@swap.service", &f);
+ r = generator_open_unit_file(arg_dest_late, /* source= */ NULL, "systemd-cryptsetup@swap.service", &f);
if (r < 0)
return r;
- r = generator_write_cryptsetup_unit_section(f, /* source = */ NULL);
+ r = generator_write_cryptsetup_unit_section(f, /* source= */ NULL);
if (r < 0)
return r;
r = generator_write_cryptsetup_service_section(
f, "swap", DISSECTED_SWAP_LUKS_DEVICE,
- /* key_file = */ NULL,
+ /* key_file= */ NULL,
efi_measured_uki(LOG_DEBUG) > 0 ? "tpm2-device=auto" : NULL);
if (r < 0)
return r;
r = generator_write_device_timeout(arg_dest_late,
DISSECTED_SWAP_LUKS_DEVICE,
- arg_resume_options ?: arg_root_options, /* filtered = */ NULL);
+ arg_resume_options ?: arg_root_options, /* filtered= */ NULL);
if (r < 0)
return r;
/* Let's insist that the system identifier is verified still. After all if things don't match,
* the resume wouldn't get triggered in the first place. We should not erase the var if booted
* from LiveCD/portable systems/... */
- r = get_efi_hibernate_location(/* ret = */ NULL);
+ r = get_efi_hibernate_location(/* ret= */ NULL);
if (r <= 0)
return r;
r = acquire_existing_password(
user_name,
secret,
- /* emphasize_current_password = */ false,
+ /* emphasize_current_password= */ false,
ASK_PASSWORD_ACCEPT_CACHED | ASK_PASSWORD_NO_TTY | ASK_PASSWORD_NO_AGENT);
if (r < 0)
return r;
if (r > 0) {
/* As above, this is not for use, just for testing */
- r = user_record_set_password(hr, STRV_MAKE(envpw), /* prepend = */ true);
+ r = user_record_set_password(hr, STRV_MAKE(envpw), /* prepend= */ true);
if (r < 0)
return log_error_errno(r, "Failed to store password: %m");
return log_oom();
}
- r = user_record_set_password(hr, first, /* prepend = */ true);
+ r = user_record_set_password(hr, first, /* prepend= */ true);
if (r < 0)
return log_error_errno(r, "Failed to store password: %m");
_cleanup_(erase_and_freep) char *new_password = NULL;
/* No regular (i.e. non-PKCS#11) hashed passwords set in the record, let's fix that. */
- r = acquire_new_password(hr->user_name, hr, /* suggest = */ true, &new_password);
+ r = acquire_new_password(hr->user_name, hr, /* suggest= */ true, &new_password);
if (r < 0)
return r;
- r = user_record_make_hashed_password(hr, STRV_MAKE(new_password), /* extend = */ false);
+ r = user_record_make_hashed_password(hr, STRV_MAKE(new_password), /* extend= */ false);
if (r < 0)
return log_error_errno(r, "Failed to hash password: %m");
} else {
if (show_enforce_password_policy_hint)
log_info("(Use --enforce-password-policy=no to turn off password quality checks for this account.)");
- r = acquire_new_password(hr->user_name, hr, /* suggest = */ false, &new_password);
+ r = acquire_new_password(hr->user_name, hr, /* suggest= */ false, &new_password);
if (r < 0)
return r;
- r = user_record_make_hashed_password(hr, STRV_MAKE(new_password), /* extend = */ false);
+ r = user_record_make_hashed_password(hr, STRV_MAKE(new_password), /* extend= */ false);
if (r < 0)
return log_error_errno(r, "Failed to hash passwords: %m");
} else {
if (!new_secret)
return log_oom();
- r = acquire_new_password(username, new_secret, /* suggest = */ true, NULL);
+ r = acquire_new_password(username, new_secret, /* suggest= */ true, NULL);
if (r < 0)
return r;
log_error_errno(r, "%s", bus_error_message(&error, r));
- r = acquire_new_password(username, new_secret, /* suggest = */ false, NULL);
+ r = acquire_new_password(username, new_secret, /* suggest= */ false, NULL);
} else if (sd_bus_error_has_name(&error, BUS_ERROR_BAD_PASSWORD_AND_NO_TOKEN))
if (r < 0)
return bus_log_create_error(r);
- r = sd_bus_message_append(m, "b", /* please_suspend = */ getenv_bool("SYSTEMD_PLEASE_SUSPEND_HOME") > 0);
+ r = sd_bus_message_append(m, "b", /* please_suspend= */ getenv_bool("SYSTEMD_PLEASE_SUSPEND_HOME") > 0);
if (r < 0)
return bus_log_create_error(r);
continue;
}
- r = groupdb_by_name(s, /* match= */ NULL, USERDB_SUPPRESS_SHADOW|USERDB_EXCLUDE_DYNAMIC_USER, /*ret=*/ NULL);
+ r = groupdb_by_name(s, /* match= */ NULL, USERDB_SUPPRESS_SHADOW|USERDB_EXCLUDE_DYNAMIC_USER, /* ret= */ NULL);
if (r == -ESRCH) {
log_notice("Specified auxiliary group does not exist, try again: %s", s);
continue;
* tool. */
bool enabled;
- r = proc_cmdline_get_bool("systemd.firstboot", /* flags = */ 0, &enabled);
+ r = proc_cmdline_get_bool("systemd.firstboot", /* flags= */ 0, &enabled);
if (r < 0)
return log_error_errno(r, "Failed to parse systemd.firstboot= kernel command line argument, ignoring: %m");
if (r > 0 && !enabled) {
return log_error_errno(r, "Failed to parse SSH authorized keys list: %m");
}
- r = strv_extend_strv_consume(&l, TAKE_PTR(add), /* filter_duplicates = */ true);
+ r = strv_extend_strv_consume(&l, TAKE_PTR(add), /* filter_duplicates= */ true);
if (r < 0)
return log_oom();
if (r == 0) {
/* Child */
- if (setenv("NOTIFY_SOCKET", h->manager->notify_socket_path, /* overwrite = */ true) < 0) {
+ if (setenv("NOTIFY_SOCKET", h->manager->notify_socket_path, /* overwrite= */ true) < 0) {
log_error_errno(errno, "Failed to set $NOTIFY_SOCKET: %m");
_exit(EXIT_FAILURE);
}
* data. This is useful as a way to propagate updated user records into the LUKS backends
* properly. */
- r = user_record_make_hashed_password(c, new_secret->password, /* extend = */ false);
+ r = user_record_make_hashed_password(c, new_secret->password, /* extend= */ false);
if (r < 0)
return r;
log_full_errno(ERRNO_IS_NOT_SUPPORTED(r) || ERRNO_IS_PRIVILEGE(r) || (r == -EHOSTDOWN) ? LOG_DEBUG : LOG_WARNING, r,
"Failed to allocate memory pressure watch, ignoring: %m");
- r = sd_event_add_signal(m->event, /* ret= */ NULL, (SIGRTMIN+18)|SD_EVENT_SIGNAL_PROCMASK, sigrtmin18_handler, /* userdata = */ NULL);
+ r = sd_event_add_signal(m->event, /* ret= */ NULL, (SIGRTMIN+18)|SD_EVENT_SIGNAL_PROCMASK, sigrtmin18_handler, /* userdata= */ NULL);
if (r < 0)
return r;
* of a client before it exits. */
on_notify_socket,
m,
- /* accept_fds = */ true,
+ /* accept_fds= */ true,
&m->notify_socket_path,
- /* ret_event_source = */ NULL);
+ /* ret_event_source= */ NULL);
if (r < 0)
return log_error_errno(r, "Failed to prepare notify socket: %m");
if (!e)
return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "xattr %s lacks ':' separator.", xa);
- r = unbase64mem_full(value, e - value, /* secure = */ false, &salt, &salt_size);
+ r = unbase64mem_full(value, e - value, /* secure= */ false, &salt, &salt_size);
if (r < 0)
return log_error_errno(r, "Failed to decode salt of %s: %m", xa);
- r = unbase64mem_full(e + 1, vsize - (e - value) - 1, /* secure = */ false, &encrypted, &encrypted_size);
+ r = unbase64mem_full(e + 1, vsize - (e - value) - 1, /* secure= */ false, &encrypted, &encrypted_size);
if (r < 0)
return log_error_errno(r, "Failed to decode encrypted key of %s: %m", xa);
r = make_filesystem(setup->dm_node,
fstype,
user_record_user_name_and_realm(h),
- /* root = */ NULL,
+ /* root= */ NULL,
fs_uuid,
(user_record_luks_discard(h) ? MKFS_DISCARD : 0) | MKFS_QUIET,
- /* sector_size = */ 0,
- /* compression = */ NULL,
+ /* sector_size= */ 0,
+ /* compression= */ NULL,
/* compression_level= */ NULL,
extra_mkfs_options);
if (r < 0)
continue;
/* If there are no old passwords, let's call check_password_quality() without any. */
- r = check_password_quality(*pp, /* old = */ NULL, hr->user_name, &auxerror);
+ r = check_password_quality(*pp, /* old= */ NULL, hr->user_name, &auxerror);
if (r <= 0)
goto error;
}
r = write_env_file(
AT_FDCWD,
etc_machine_info(),
- /* headers= */NULL,
+ /* headers= */ NULL,
l,
WRITE_ENV_FILE_LABEL);
if (r < 0)
(void) vsock_get_local_cid(&local_cid);
(void) load_os_release_pairs(/* root= */ NULL, &os_release_pairs);
- (void) load_env_file_pairs(/* f=*/ NULL, etc_machine_info(), &machine_info_pairs);
+ (void) load_env_file_pairs(/* f= */ NULL, etc_machine_info(), &machine_info_pairs);
r = sd_json_buildo(
&v,
r = copy_tree_at(
source_fd, /* from= */ NULL,
- target_fd, /* to = */ NULL,
+ target_fd, /* to= */ NULL,
/* override_uid= */ UID_INVALID,
/* override_gid= */ GID_INVALID,
COPY_REFLINK|COPY_HARDLINKS|COPY_MERGE_EMPTY|COPY_MERGE_APPLY_STAT|COPY_SAME_MOUNT|COPY_ALL_XATTRS,
return log_error_errno(r, "Failed to build import unit name from '%s': %m", local_path);
_cleanup_fclose_ FILE *f = NULL;
- r = generator_open_unit_file(arg_dest, /* source = */ NULL, service, &f);
+ r = generator_open_unit_file(arg_dest, /* source= */ NULL, service, &f);
if (r < 0)
return r;
"--no-auto-check-trustdb",
"--batch",
"--trust-model=always",
- NULL, /* --homedir= */
+ NULL, /* --homedir= */
NULL, /* --keyring= */
NULL, /* --verify */
NULL, /* signature file */
p->checksum_job,
p->signature_job,
p->settings_job,
- /* roothash_job = */ NULL,
- /* roothash_signature_job = */ NULL,
- /* verity_job = */ NULL);
+ /* roothash_job= */ NULL,
+ /* roothash_signature_job= */ NULL,
+ /* verity_job= */ NULL);
if (r < 0)
goto finish;
}
}
static const char *integrity_algorithm_select(const void *key_file_buf) {
- /* To keep a bit of sanity for end users, the subset of integrity
- algorithms we support will match what is used in integritysetup */
+ /* To keep a bit of sanity for end users, the subset of integrity
+ * algorithms we support will match what is used in integritysetup */
if (arg_integrity_algorithm) {
if (streq(arg_integrity_algorithm, "hmac-sha256"))
return DM_HMAC_256;
range_after_eq = startswith(range, "entries=");
if (range_after_eq)
- return request_parse_range_entries(m, skip_leading_chars(range_after_eq, /* bad = */ NULL));
+ return request_parse_range_entries(m, skip_leading_chars(range_after_eq, /* bad= */ NULL));
range_after_eq = startswith(range, "realtime=");
if (range_after_eq)
- return request_parse_range_time(m, skip_leading_chars(range_after_eq, /* bad = */ NULL));
+ return request_parse_range_time(m, skip_leading_chars(range_after_eq, /* bad= */ NULL));
return 0;
}
m->journal,
LOG_BOOT_ID,
/* boot_id */ SD_ID128_NULL,
- /* unit = */ NULL,
+ /* unit= */ NULL,
m->previous_boot_id,
- /* advance_older = */ true,
+ /* advance_older= */ true,
&boot);
if (r < 0) {
log_error_errno(r, "Failed to advance boot index: %m");
break;
case 'o':
- r = parse_path_argument(optarg, /* suppress_root = */ false, &arg_output);
+ r = parse_path_argument(optarg, /* suppress_root= */ false, &arg_output);
if (r < 0)
return r;
break;
if (!w->mmap)
return -ENOMEM;
- if (is_dir(server->output, /* follow = */ true) > 0) {
+ if (is_dir(server->output, /* follow= */ true) > 0) {
w->output = strdup(server->output);
if (!w->output)
return -ENOMEM;
r = do_rotate(&w->journal, w->mmap, file_flags);
if (r < 0)
return r;
- r = journal_directory_vacuum(w->output, w->metrics.max_use, w->metrics.n_max_files, 0, NULL, /* verbose = */ true);
+ r = journal_directory_vacuum(w->output, w->metrics.max_use, w->metrics.n_max_files, 0, NULL, /* verbose= */ true);
if (r < 0)
return r;
}
return r;
else
log_debug("%s: Successfully rotated journal", w->journal->path);
- r = journal_directory_vacuum(w->output, w->metrics.max_use, w->metrics.n_max_files, 0, NULL, /* verbose = */ true);
+ r = journal_directory_vacuum(w->output, w->metrics.max_use, w->metrics.n_max_files, 0, NULL, /* verbose= */ true);
if (r < 0)
return r;
{ "Upload", "TrustedCertificateFile", config_parse_path_or_ignore, 0, &arg_trust },
{ "Upload", "NetworkTimeoutSec", config_parse_sec, 0, &arg_network_timeout_usec },
{ "Upload", "Header", config_parse_header, 0, &arg_headers },
- { "Upload", "Compression", config_parse_compression, /* with_level = */ true, &arg_compression },
+ { "Upload", "Compression", config_parse_compression, /* with_level= */ true, &arg_compression },
{ "Upload", "ForceCompression", config_parse_bool, 0, &arg_force_compression },
{}
};
"Failed to fstat(%s): %m",
FORMAT_PROC_FD_PATH(STDERR_FILENO));
- r = setenvf("JOURNAL_STREAM", /* overwrite = */ true, DEV_FMT ":" INO_FMT, (dev_t) st.st_dev, st.st_ino);
+ r = setenvf("JOURNAL_STREAM", /* overwrite= */ true, DEV_FMT ":" INO_FMT, (dev_t) st.st_dev, st.st_ino);
if (r < 0)
return log_error_errno(r, "Failed to set environment variable JOURNAL_STREAM: %m");
_cleanup_(manager_freep) Manager *m = NULL;
dummy_manager_new(&m, data, size);
- f(m, m->buffer, size, /* ucred = */ NULL, /* tv = */ NULL, /* label = */ NULL, /* label_len = */ 0);
+ f(m, m->buffer, size, /* ucred= */ NULL, /* tv= */ NULL, /* label= */ NULL, /* label_len= */ 0);
}
assert(arg_action == ACTION_SETUP_KEYS);
- r = is_dir("/var/log/journal/", /* follow = */ false);
+ r = is_dir("/var/log/journal/", /* follow= */ false);
if (r == 0)
return log_error_errno(SYNTHETIC_ERRNO(ENOTDIR),
"/var/log/journal is not a directory, must be using persistent logging for FSS.");
if (r < 0)
return log_error_errno(r, "Failed to write state: %m");
- r = link_tmpfile(fd, tmpfile, path, /* flags = */ 0);
+ r = link_tmpfile(fd, tmpfile, path, /* flags= */ 0);
if (r < 0)
return log_error_errno(r, "Failed to link file: %m");
if (r < 0)
return log_error_errno(r, "Failed to build json object: %m");
- r = sd_json_variant_dump(v, arg_json_format_flags, /* f = */ NULL, /* prefix = */ NULL);
+ r = sd_json_variant_dump(v, arg_json_format_flags, /* f= */ NULL, /* prefix= */ NULL);
if (r < 0)
return log_error_errno(r, "Failed to dump json object: %m");
pager_open(arg_pager_flags);
if (items)
- r = catalog_list_items(/* f = */ NULL, database, oneline, items);
+ r = catalog_list_items(/* f= */ NULL, database, oneline, items);
else
- r = catalog_list(/* f = */ NULL, database, oneline);
+ r = catalog_list(/* f= */ NULL, database, oneline);
if (r < 0)
return log_error_errno(r, "Failed to list catalog: %m");
log_notice("Journal file %s has sealing enabled but verification key has not been passed using --verify-key=.", f->path);
#endif
- k = journal_file_verify(f, arg_verify_key, &first, &validated, &last, /* show_progress = */ !arg_quiet);
+ k = journal_file_verify(f, arg_verify_key, &first, &validated, &last, /* show_progress= */ !arg_quiet);
if (k == -EINVAL)
/* If the key was invalid give up right-away. */
return k;
r = journal_get_boots(
j,
- /* advance_older = */ arg_lines_needs_seek_end(),
- /* max_ids = */ arg_lines >= 0 ? (size_t) arg_lines : SIZE_MAX,
+ /* advance_older= */ arg_lines_needs_seek_end(),
+ /* max_ids= */ arg_lines >= 0 ? (size_t) arg_lines : SIZE_MAX,
&ids, &n_ids);
if (r < 0)
return log_error_errno(r, "Failed to determine boots: %m");
r = journal_get_log_ids(
j, type,
- /* boot_id = */ arg_boot_id, /* unit = */ unit,
- /* advance_older = */ arg_lines_needs_seek_end(),
- /* max_ids = */ arg_lines >= 0 ? (size_t) arg_lines : SIZE_MAX,
+ /* boot_id= */ arg_boot_id, /* unit= */ unit,
+ /* advance_older= */ arg_lines_needs_seek_end(),
+ /* max_ids= */ arg_lines >= 0 ? (size_t) arg_lines : SIZE_MAX,
&ids, &n_ids);
if (r < 0)
return log_error_errno(r, "Failed to list invocation id for %s: %m", unit);
(void) sd_event_add_signal(e, /* ret= */ NULL, SIGTERM | SD_EVENT_SIGNAL_PROCMASK, on_signal, c);
(void) sd_event_add_signal(e, /* ret= */ NULL, SIGINT | SD_EVENT_SIGNAL_PROCMASK, on_signal, c);
- r = sd_event_add_io(e, /* ret = */ NULL, fd, EPOLLIN, &on_journal_event, c);
+ r = sd_event_add_io(e, /* ret= */ NULL, fd, EPOLLIN, &on_journal_event, c);
if (r < 0)
return log_error_errno(r, "Failed to add io event source for journal: %m");
/* Also keeps an eye on STDOUT, and exits as soon as we see a POLLHUP on that, i.e. when it is closed. */
- r = sd_event_add_io(e, /* ret = */ NULL, STDOUT_FILENO, EPOLLHUP|EPOLLERR, /* callback = */ NULL, /* userdata = */ NULL);
+ r = sd_event_add_io(e, /* ret= */ NULL, STDOUT_FILENO, EPOLLHUP|EPOLLERR, /* callback= */ NULL, /* userdata= */ NULL);
if (r == -EPERM)
/* Installing an epoll watch on a regular file doesn't work and fails with EPERM. Which is
* totally OK, handle it gracefully. epoll_ctl() documents EPERM as the error returned when
assert(c);
- r = read_credential("journal.forward_to_socket", (void**) &data, /* ret_size = */ NULL);
+ r = read_credential("journal.forward_to_socket", (void**) &data, /* ret_size= */ NULL);
if (r < 0)
log_debug_errno(r, "Failed to read credential 'journal.forward_to_socket', ignoring: %m");
else {
data = mfree(data);
- r = read_credential("journal.storage", (void**) &data, /* ret_size = */ NULL);
+ r = read_credential("journal.storage", (void**) &data, /* ret_size= */ NULL);
if (r < 0)
log_debug_errno(r, "Failed to read credential journal.storage, ignoring: %m");
else {
manager_reopen_journals(m, &old);
log_info("Config file reloaded.");
- (void) sd_notify(/* unset_environment = */ false, NOTIFY_READY_MESSAGE);
+ (void) sd_notify(/* unset_environment= */ false, NOTIFY_READY_MESSAGE);
return 0;
}
log_ratelimit_info(JOURNAL_LOG_RATELIMIT, "Time jumped backwards, rotating.");
manager_rotate(m);
- manager_vacuum(m, /* verbose = */ false);
+ manager_vacuum(m, /* verbose= */ false);
vacuumed = true;
}
log_debug("%s: Journal header limits reached or header out-of-date, rotating.", f->path);
manager_rotate_journal(m, TAKE_PTR(f), uid);
- manager_vacuum(m, /* verbose = */ false);
+ manager_vacuum(m, /* verbose= */ false);
vacuumed = true;
f = manager_find_journal(m, uid);
}
manager_rotate_journal(m, TAKE_PTR(f), uid);
- manager_vacuum(m, /* verbose = */ false);
+ manager_vacuum(m, /* verbose= */ false);
f = manager_find_journal(m, uid);
if (!f)
if (require_flag_file && !manager_flushed_flag_is_set(m))
return 0;
- (void) manager_system_journal_open(m, /* flush_requested=*/ true, /* relinquish_requested= */ false);
+ (void) manager_system_journal_open(m, /* flush_requested= */ true, /* relinquish_requested= */ false);
if (!m->system_journal)
return 0;
log_ratelimit_info(JOURNAL_LOG_RATELIMIT, "Rotating system journal.");
- manager_rotate_journal(m, m->system_journal, /* uid = */ 0);
- manager_vacuum(m, /* verbose = */ false);
+ manager_rotate_journal(m, m->system_journal, /* uid= */ 0);
+ manager_vacuum(m, /* verbose= */ false);
if (!m->system_journal) {
log_ratelimit_notice(JOURNAL_LOG_RATELIMIT,
log_debug("Relinquishing %s...", m->system_storage.path);
- (void) manager_system_journal_open(m, /* flush_requested = */ false, /* relinquish_requested = */ true);
+ (void) manager_system_journal_open(m, /* flush_requested= */ false, /* relinquish_requested= */ true);
m->system_journal = journal_file_offline_close(m->system_journal);
ordered_hashmap_clear(m->user_journals);
assert(m);
(void) manager_flush_to_var(m, false);
- manager_sync(m, /* wait = */ false);
+ manager_sync(m, /* wait= */ false);
manager_vacuum(m, false);
manager_space_usage_message(m, NULL);
}
log_debug("Received SIGRTMIN1 signal from PID %u, as request to sync.", si->ssi_pid);
- manager_full_sync(m, /* wait = */ false);
+ manager_full_sync(m, /* wait= */ false);
return 0;
}
static int manager_dispatch_sync(sd_event_source *es, usec_t t, void *userdata) {
Manager *m = ASSERT_PTR(userdata);
- manager_sync(m, /* wait = */ false);
+ manager_sync(m, /* wait= */ false);
return 0;
}
if (priority <= LOG_CRIT) {
/* Immediately sync to disk when this is of priority CRIT, ALERT, EMERG */
- manager_sync(m, /* wait = */ false);
+ manager_sync(m, /* wait= */ false);
return 0;
}
if (!m->event || sd_event_get_state(m->event) == SD_EVENT_FINISHED) {
/* Shutting down the server? Let's sync immediately. */
- manager_sync(m, /* wait = */ false);
+ manager_sync(m, /* wait= */ false);
return 0;
}
ordered_hashmap_clear(m->user_journals);
set_clear(m->deferred_closes);
- (void) manager_system_journal_open(m, /* flush_requested = */ false, /* relinquish_requested = */ false);
+ (void) manager_system_journal_open(m, /* flush_requested= */ false, /* relinquish_requested= */ false);
/* To make the storage related settings applied, vacuum the storage. */
cache_space_invalidate(&m->system_storage.space);
cache_space_invalidate(&m->runtime_storage.space);
- manager_vacuum(m, /* verbose = */ false);
+ manager_vacuum(m, /* verbose= */ false);
}
int manager_new(Manager **ret) {
cmsg_close_all(&msghdr);
if (l == 0) {
- (void) stdout_stream_scan(s, s->buffer, s->length, /* force_flush = */ LINE_BREAK_EOF, NULL);
+ (void) stdout_stream_scan(s, s->buffer, s->length, /* force_flush= */ LINE_BREAK_EOF, NULL);
goto terminate;
}
if (ucred && ucred->pid != s->ucred.pid) {
/* Force out any previously half-written lines from a different process, before we switch to
* the new ucred structure for everything we just added */
- r = stdout_stream_scan(s, s->buffer, s->length, /* force_flush = */ LINE_BREAK_PID_CHANGE, NULL);
+ r = stdout_stream_scan(s, s->buffer, s->length, /* force_flush= */ LINE_BREAK_PID_CHANGE, NULL);
if (r < 0)
goto terminate;
* anymore. */
if (req->offline)
- manager_full_sync(req->manager, /* wait = */ true);
+ manager_full_sync(req->manager, /* wait= */ true);
log_debug("Client request to sync journal (%s offlining) completed.", req->offline ? "with" : "without");
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
if (r < 0)
return r;
- manager_vacuum(m, /* verbose = */ false);
- manager_flush_to_var(m, /* require_flag_file = */ true);
+ manager_vacuum(m, /* verbose= */ false);
+ manager_flush_to_var(m, /* require_flag_file= */ true);
manager_flush_dev_kmsg(m);
if (m->namespace)
/* The retention time is reached, so let's vacuum! */
if (t <= 0) {
log_info("Retention time reached, vacuuming.");
- manager_vacuum(m, /* verbose = */ false);
+ manager_vacuum(m, /* verbose= */ false);
continue;
}
} else
return 0;
if (c->rfd >= 0) {
- r = chaseat(c->rfd, s, CHASE_AT_RESOLVE_IN_ROOT, &p, /* ret_fd = */ NULL);
+ r = chaseat(c->rfd, s, CHASE_AT_RESOLVE_IN_ROOT, &p, /* ret_fd= */ NULL);
if (r < 0)
return log_warning_errno(r, "Failed to chase path %s for %s specified via %s, ignoring: %m",
s, name, source);
char *p;
if (c->rfd >= 0) {
- r = chaseat(c->rfd, *s, CHASE_AT_RESOLVE_IN_ROOT, &p, /* ret_fd = */ NULL);
+ r = chaseat(c->rfd, *s, CHASE_AT_RESOLVE_IN_ROOT, &p, /* ret_fd= */ NULL);
if (r < 0)
return log_warning_errno(r, "Failed to chase path %s for %s specified via %s: %m",
*s, name, source);
assert(!c->boot_root);
r = find_xbootldr_and_warn_at(
- /* rfd = */ c->rfd,
- /* path = */ arg_xbootldr_path,
+ /* rfd= */ c->rfd,
+ /* path= */ arg_xbootldr_path,
/* unprivileged_mode= */ -1,
- /* ret_path = */ &c->boot_root,
- /* ret_uuid = */ NULL,
- /* ret_devid = */ NULL);
+ /* ret_path= */ &c->boot_root,
+ /* ret_uuid= */ NULL,
+ /* ret_devid= */ NULL);
if (r == -ENOKEY) {
log_debug_errno(r, "Couldn't find an XBOOTLDR partition.");
return 0;
assert(!c->boot_root);
r = find_esp_and_warn_at(
- /* rfd = */ c->rfd,
- /* path = */ arg_esp_path,
+ /* rfd= */ c->rfd,
+ /* path= */ arg_esp_path,
/* unprivileged_mode= */ -1,
- /* ret_path = */ &c->boot_root,
- /* ret_part = */ NULL,
- /* ret_pstart = */ NULL,
- /* ret_psize = */ NULL,
- /* ret_uuid = */ NULL,
- /* ret_devid = */ NULL);
+ /* ret_path= */ &c->boot_root,
+ /* ret_part= */ NULL,
+ /* ret_pstart= */ NULL,
+ /* ret_psize= */ NULL,
+ /* ret_uuid= */ NULL,
+ /* ret_devid= */ NULL);
if (r == -ENOKEY) {
log_debug_errno(r, "Couldn't find EFI system partition, ignoring.");
return 0;
/* If all else fails, use /boot. */
if (c->rfd >= 0) {
- r = chaseat(c->rfd, "/boot", CHASE_AT_RESOLVE_IN_ROOT, &c->boot_root, /* ret_fd = */ NULL);
+ r = chaseat(c->rfd, "/boot", CHASE_AT_RESOLVE_IN_ROOT, &c->boot_root, /* ret_fd= */ NULL);
if (r < 0)
return log_error_errno(r, "Failed to chase '/boot/': %m");
} else {
if (!entry_token_path)
return log_oom();
- r = is_dir_at(c->rfd, entry_token_path, /* follow = */ false);
+ r = is_dir_at(c->rfd, entry_token_path, /* follow= */ false);
if (r < 0 && r != -ENOENT)
return log_error_errno(r, "Failed to check if '%s' is a directory: %m", entry_token_path);
if (r > 0) {
if (r < 0)
return log_oom();
- r = strv_extend_strv(&a, c->initrds, /* filter_duplicates = */ false);
+ r = strv_extend_strv(&a, c->initrds, /* filter_duplicates= */ false);
if (r < 0)
return log_oom();
return r;
if (DEBUG_LOGGING) {
- _cleanup_free_ char *x = strv_join_full(c->plugins, "", "\n ", /* escape_separator = */ false);
+ _cleanup_free_ char *x = strv_join_full(c->plugins, "", "\n ", /* escape_separator= */ false);
log_debug("Using plugins: %s", strna(x));
- _cleanup_free_ char *y = strv_join_full(c->envp, "", "\n ", /* escape_separator = */ false);
+ _cleanup_free_ char *y = strv_join_full(c->envp, "", "\n ", /* escape_separator= */ false);
log_debug("Plugin environment: %s", strna(y));
_cleanup_free_ char *z = strv_join(strv_skip(c->argv, 1), " ");
ret = execute_strv(
"plugins",
c->plugins,
- /* root = */ NULL,
+ /* root= */ NULL,
USEC_INFINITY,
- /* callbacks = */ NULL,
- /* callback_args = */ NULL,
+ /* callbacks= */ NULL,
+ /* callback_args= */ NULL,
c->argv,
c->envp,
EXEC_DIR_SKIP_REMAINING);
break;
case ARG_ESP_PATH:
- r = parse_path_argument(optarg, /* suppress_root = */ false, &arg_esp_path);
+ r = parse_path_argument(optarg, /* suppress_root= */ false, &arg_esp_path);
if (r < 0)
return log_oom();
break;
case ARG_BOOT_PATH:
- r = parse_path_argument(optarg, /* suppress_root = */ false, &arg_xbootldr_path);
+ r = parse_path_argument(optarg, /* suppress_root= */ false, &arg_xbootldr_path);
if (r < 0)
return log_oom();
break;
break;
case ARG_SIGNATURE:
- r = parse_path_argument(optarg, /*suppress_root=*/ false, &arg_signature);
+ r = parse_path_argument(optarg, /* suppress_root= */ false, &arg_signature);
if (r < 0)
return r;
break;
case ARG_CONTENT:
- r = parse_path_argument(optarg, /*suppress_root=*/ false, &arg_content);
+ r = parse_path_argument(optarg, /* suppress_root= */ false, &arg_content);
if (r < 0)
return r;
break;
case ARG_OUTPUT:
- r = parse_path_argument(optarg, /*suppress_root=*/ false, &arg_output);
+ r = parse_path_argument(optarg, /* suppress_root= */ false, &arg_output);
if (r < 0)
return r;
"No private key specified, use --private-key=.");
if (arg_certificate_source_type == OPENSSL_CERTIFICATE_SOURCE_FILE) {
- r = parse_path_argument(arg_certificate, /*suppress_root=*/ false, &arg_certificate);
+ r = parse_path_argument(arg_certificate, /* suppress_root= */ false, &arg_certificate);
if (r < 0)
return r;
}
_cleanup_(X509_freep) X509 *certificate = NULL;
if (arg_certificate_source_type == OPENSSL_CERTIFICATE_SOURCE_FILE) {
- r = parse_path_argument(arg_certificate, /*suppress_root=*/ false, &arg_certificate);
+ r = parse_path_argument(arg_certificate, /* suppress_root= */ false, &arg_certificate);
if (r < 0)
return r;
}
return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "--output= must be specified");
if (arg_certificate_source_type == OPENSSL_CERTIFICATE_SOURCE_FILE) {
- r = parse_path_argument(arg_certificate, /*suppress_root=*/ false, &arg_certificate);
+ r = parse_path_argument(arg_certificate, /* suppress_root= */ false, &arg_certificate);
if (r < 0)
return r;
}
memcpy(&a->iaaddr, data, sizeof(struct iaaddr));
- lt_valid = be32_sec_to_usec(a->iaaddr.lifetime_valid, /* max_as_infinity = */ true);
- lt_pref = be32_sec_to_usec(a->iaaddr.lifetime_preferred, /* max_as_infinity = */ true);
+ lt_valid = be32_sec_to_usec(a->iaaddr.lifetime_valid, /* max_as_infinity= */ true);
+ lt_pref = be32_sec_to_usec(a->iaaddr.lifetime_preferred, /* max_as_infinity= */ true);
if (lt_valid == 0)
return log_dhcp6_client_errno(client, SYNTHETIC_ERRNO(EINVAL),
memcpy(&a->iapdprefix, data, sizeof(struct iapdprefix));
- lt_valid = be32_sec_to_usec(a->iapdprefix.lifetime_valid, /* max_as_infinity = */ true);
- lt_pref = be32_sec_to_usec(a->iapdprefix.lifetime_preferred, /* max_as_infinity = */ true);
+ lt_valid = be32_sec_to_usec(a->iapdprefix.lifetime_valid, /* max_as_infinity= */ true);
+ lt_pref = be32_sec_to_usec(a->iapdprefix.lifetime_preferred, /* max_as_infinity= */ true);
if (lt_valid == 0)
return log_dhcp6_client_errno(client, SYNTHETIC_ERRNO(EINVAL),
"from the one chosen by the client, ignoring.");
/* It is not necessary to check if the lifetime_t2 is zero here, as in that case it will be updated later. */
- lt_t1 = be32_sec_to_usec(ia->header.lifetime_t1, /* max_as_infinity = */ true);
- lt_t2 = be32_sec_to_usec(ia->header.lifetime_t2, /* max_as_infinity = */ true);
+ lt_t1 = be32_sec_to_usec(ia->header.lifetime_t1, /* max_as_infinity= */ true);
+ lt_t2 = be32_sec_to_usec(ia->header.lifetime_t2, /* max_as_infinity= */ true);
if (lt_t1 > lt_t2)
return log_dhcp6_client_errno(client, SYNTHETIC_ERRNO(EINVAL),
lease->client_id.raw[0] = 2;
lease->client_id.raw[1] = i;
- r = dhcp_server_put_lease(server, lease, /* is_static = */ false);
+ r = dhcp_server_put_lease(server, lease, /* is_static= */ false);
if (r < 0)
return r;
return;
if (ndisc_send(fd_pair[1], &IN6_ADDR_ALL_ROUTERS_MULTICAST,
- icmp6_packet_get_header(packet), options, /* timestamp = */ 0) < 0)
+ icmp6_packet_get_header(packet), options, /* timestamp= */ 0) < 0)
return;
packet = icmp6_packet_unref(packet);
if (pi->nd_opt_pi_type != SD_NDISC_OPTION_PREFIX_INFORMATION)
return -EBADMSG;
- usec_t valid = be32_sec_to_usec(pi->nd_opt_pi_valid_time, /* max_as_infinity = */ true);
- usec_t pref = be32_sec_to_usec(pi->nd_opt_pi_preferred_time, /* max_as_infinity = */ true);
+ usec_t valid = be32_sec_to_usec(pi->nd_opt_pi_valid_time, /* max_as_infinity= */ true);
+ usec_t pref = be32_sec_to_usec(pi->nd_opt_pi_preferred_time, /* max_as_infinity= */ true);
/* We only support 64 bits interface identifier for addrconf. */
uint8_t flags = pi->nd_opt_pi_flags_reserved;
return ndisc_option_add_home_agent(
options, offset,
be16toh(p->nd_opt_home_agent_info_preference),
- be16_sec_to_usec(p->nd_opt_home_agent_info_lifetime, /* max_as_infinity = */ false));
+ be16_sec_to_usec(p->nd_opt_home_agent_info_lifetime, /* max_as_infinity= */ false));
}
static int ndisc_option_build_home_agent(const sd_ndisc_option *option, usec_t timestamp, uint8_t **ret) {
return -EBADMSG;
uint8_t preference = (opt[3] >> 3) & 0x03;
- usec_t lifetime = unaligned_be32_sec_to_usec(opt + 4, /* max_as_infinity = */ true);
+ usec_t lifetime = unaligned_be32_sec_to_usec(opt + 4, /* max_as_infinity= */ true);
struct in6_addr prefix;
memcpy_safe(&prefix, opt + 8, len - 8);
if (opt[0] != SD_NDISC_OPTION_RDNSS)
return -EBADMSG;
- usec_t lifetime = unaligned_be32_sec_to_usec(opt + 4, /* max_as_infinity = */ true);
+ usec_t lifetime = unaligned_be32_sec_to_usec(opt + 4, /* max_as_infinity= */ true);
size_t n_addrs = len / sizeof(struct in6_addr);
return ndisc_option_add_rdnss(options, offset, n_addrs, (const struct in6_addr*) (opt + 8), lifetime);
if (opt[0] != SD_NDISC_OPTION_DNSSL)
return -EBADMSG;
- usec_t lifetime = unaligned_be32_sec_to_usec(opt + 4, /* max_as_infinity = */ true);
+ usec_t lifetime = unaligned_be32_sec_to_usec(opt + 4, /* max_as_infinity= */ true);
_cleanup_strv_free_ char **l = NULL;
_cleanup_free_ char *e = NULL;
uint8_t *p = buf + 8;
STRV_FOREACH(s, option->dnssl.domains) {
- r = dns_name_to_wire_format(*s, p, remaining, /* canonical = */ false);
+ r = dns_name_to_wire_format(*s, p, remaining, /* canonical= */ false);
if (r < 0)
return r;
off += sizeof(uint16_t);
/* Lifetime */
- lifetime = unaligned_be32_sec_to_usec(opt + off, /* max_as_infinity = */ true);
+ lifetime = unaligned_be32_sec_to_usec(opt + off, /* max_as_infinity= */ true);
off += sizeof(uint32_t);
/* adn field (length + dns-name) */
if (!GREEDY_REALLOC(buf, off + sizeof(uint16_t) + ilen))
return -ENOMEM;
- r = dns_name_to_wire_format(res->auth_name, buf + off + sizeof(uint16_t), ilen, /* canonical = */ false);
+ r = dns_name_to_wire_format(res->auth_name, buf + off + sizeof(uint16_t), ilen, /* canonical= */ false);
if (r < 0)
return r;
unaligned_write_be16(buf + off, (uint16_t) r);
if (!iaid_set) {
r = dhcp_identifier_set_iaid(client->dev, &client->hw_addr,
- /* legacy_unstable_byteorder = */ true,
+ /* legacy_unstable_byteorder= */ true,
&iaid);
if (r < 0)
return r;
assert(message);
assert(lease);
- r = dhcp_option_parse(message, len, dhcp_lease_parse_options, lease, /* ret_error_message = */ NULL);
+ r = dhcp_option_parse(message, len, dhcp_lease_parse_options, lease, /* ret_error_message= */ NULL);
if (r == -ENOMSG)
r = DHCP_ACK; /* BOOTP messages don't have a DHCP message type option */
else if (r < 0)
CLOCK_BOOTTIME, 0, 0,
client_timeout_resend, client,
client->event_priority, "dhcp4-resend-timer",
- /* force_reset = */ true);
+ /* force_reset= */ true);
}
static int client_enter_requesting_delayed(sd_event_source *s, uint64_t usec, void *userdata) {
client->lease->ipv6_only_preferred_usec, 0,
client_enter_requesting_delayed, client,
client->event_priority, "dhcp4-ipv6-only-mode-timer",
- /* force_reset = */ true);
+ /* force_reset= */ true);
}
return client_enter_requesting_now(client);
client->lease->ipv6_only_preferred_usec, 0,
client_enter_bound_delayed, client,
client->event_priority, "dhcp4-ipv6-only-mode",
- /* force_reset = */ true);
+ /* force_reset= */ true);
}
return client_enter_bound_now(client, notify_event);
/* If no client identifier exists, construct an RFC 4361-compliant one */
if (!sd_dhcp_client_id_is_set(&client->client_id)) {
- r = sd_dhcp_client_set_iaid_duid_en(client, /* iaid_set = */ false, /* iaid = */ 0);
+ r = sd_dhcp_client_set_iaid_duid_en(client, /* iaid_set= */ false, /* iaid= */ 0);
if (r < 0)
return r;
}
switch (code) {
case SD_DHCP_OPTION_IP_ADDRESS_LEASE_TIME:
- r = lease_parse_be32_seconds(option, len, /* max_as_infinity = */ true, &lease->lifetime);
+ r = lease_parse_be32_seconds(option, len, /* max_as_infinity= */ true, &lease->lifetime);
if (r < 0)
log_debug_errno(r, "Failed to parse lease time, ignoring: %m");
break;
}
case SD_DHCP_OPTION_RENEWAL_TIME:
- r = lease_parse_be32_seconds(option, len, /* max_as_infinity = */ true, &lease->t1);
+ r = lease_parse_be32_seconds(option, len, /* max_as_infinity= */ true, &lease->t1);
if (r < 0)
log_debug_errno(r, "Failed to parse T1 time, ignoring: %m");
break;
case SD_DHCP_OPTION_REBINDING_TIME:
- r = lease_parse_be32_seconds(option, len, /* max_as_infinity = */ true, &lease->t2);
+ r = lease_parse_be32_seconds(option, len, /* max_as_infinity= */ true, &lease->t2);
if (r < 0)
log_debug_errno(r, "Failed to parse T2 time, ignoring: %m");
break;
break;
case SD_DHCP_OPTION_IPV6_ONLY_PREFERRED:
- r = lease_parse_be32_seconds(option, len, /* max_as_infinity = */ false, &lease->ipv6_only_preferred_usec);
+ r = lease_parse_be32_seconds(option, len, /* max_as_infinity= */ false, &lease->ipv6_only_preferred_usec);
if (r < 0)
log_debug_errno(r, "Failed to parse IPv6 only preferred option, ignoring: %m");
return -ENOMEM;
}
- r = dhcp_server_put_lease(server, lease, /* is_static = */ false);
+ r = dhcp_server_put_lease(server, lease, /* is_static= */ false);
if (r < 0)
return r;
if (!client_id_data_size_is_valid(req->message->hlen))
return NULL;
- if (sd_dhcp_client_id_set(&client_id, /* type = */ 1, req->message->chaddr, req->message->hlen) < 0)
+ if (sd_dhcp_client_id_set(&client_id, /* type= */ 1, req->message->chaddr, req->message->hlen) < 0)
return NULL;
static_lease = hashmap_get(server->static_leases_by_client_id, &client_id);
return -ENOMEM;
}
- r = dhcp_server_put_lease(server, lease, /* is_static = */ true);
+ r = dhcp_server_put_lease(server, lease, /* is_static= */ true);
if (r < 0)
return r;
(void) fchmod(fileno(f), 0644);
- r = sd_json_variant_dump(v, SD_JSON_FORMAT_NEWLINE | SD_JSON_FORMAT_FLUSH, f, /* prefix = */ NULL);
+ r = sd_json_variant_dump(v, SD_JSON_FORMAT_NEWLINE | SD_JSON_FORMAT_FLUSH, f, /* prefix= */ NULL);
if (r < 0)
goto failure;
return 0;
failure:
- (void) unlinkat(server->lease_dir_fd, temp_path, /* flags = */ 0);
+ (void) unlinkat(server->lease_dir_fd, temp_path, /* flags= */ 0);
return r;
}
lease->expiration = map_clock_usec_raw(lease->expiration, now_r, now_b);
}
- r = dhcp_server_put_lease(server, lease, /* is_static = */ false);
+ r = dhcp_server_put_lease(server, lease, /* is_static= */ false);
if (r == -EEXIST)
return 0;
if (r < 0)
assert(ret);
r = sd_json_parse_file_at(
- /* f = */ NULL,
+ /* f= */ NULL,
dir_fd,
path,
- /* flags = */ 0,
+ /* flags= */ 0,
&v,
- /* reterr_line = */ NULL,
- /* ret_column = */ NULL);
+ /* reterr_line= */ NULL,
+ /* ret_column= */ NULL);
if (r < 0)
return r;
sd_json_variant *i;
JSON_VARIANT_ARRAY_FOREACH(i, info.leases)
- RET_GATHER(r, json_dispatch_dhcp_lease(server, i, /* use_boottime = */ sd_id128_equal(info.boot_id, boot_id)));
+ RET_GATHER(r, json_dispatch_dhcp_lease(server, i, /* use_boottime= */ sd_id128_equal(info.boot_id, boot_id)));
m = hashmap_size(server->bound_leases_by_client_id);
assert(m >= n);
switch (code) {
case SD_DHCP_OPTION_IP_ADDRESS_LEASE_TIME:
if (len == 4)
- req->lifetime = unaligned_be32_sec_to_usec(option, /* max_as_infinity = */ true);
+ req->lifetime = unaligned_be32_sec_to_usec(option, /* max_as_infinity= */ true);
break;
case SD_DHCP_OPTION_REQUESTED_IP_ADDRESS:
if (!client_id_data_size_is_valid(message->hlen))
return -EBADMSG;
- r = sd_dhcp_client_id_set(&req->client_id, /* type = */ 1, message->chaddr, message->hlen);
+ r = sd_dhcp_client_id_set(&req->client_id, /* type= */ 1, message->chaddr, message->hlen);
if (r < 0)
return r;
}
return 0;
r = dhcp_identifier_set_iaid(client->dev, &client->hw_addr,
- /* legacy_unstable_byteorder = */ true,
+ /* legacy_unstable_byteorder= */ true,
&iaid);
if (r < 0)
return r;
assert(lease->ia_na || lease->ia_pd);
if (lease->ia_na) {
- t1 = MIN(t1, be32_sec_to_usec(lease->ia_na->header.lifetime_t1, /* max_as_infinity = */ true));
- t2 = MIN(t2, be32_sec_to_usec(lease->ia_na->header.lifetime_t2, /* max_as_infinity = */ true));
+ t1 = MIN(t1, be32_sec_to_usec(lease->ia_na->header.lifetime_t1, /* max_as_infinity= */ true));
+ t2 = MIN(t2, be32_sec_to_usec(lease->ia_na->header.lifetime_t2, /* max_as_infinity= */ true));
LIST_FOREACH(addresses, a, lease->ia_na->addresses)
- min_valid_lt = MIN(min_valid_lt, be32_sec_to_usec(a->iaaddr.lifetime_valid, /* max_as_infinity = */ true));
+ min_valid_lt = MIN(min_valid_lt, be32_sec_to_usec(a->iaaddr.lifetime_valid, /* max_as_infinity= */ true));
}
if (lease->ia_pd) {
- t1 = MIN(t1, be32_sec_to_usec(lease->ia_pd->header.lifetime_t1, /* max_as_infinity = */ true));
- t2 = MIN(t2, be32_sec_to_usec(lease->ia_pd->header.lifetime_t2, /* max_as_infinity = */ true));
+ t1 = MIN(t1, be32_sec_to_usec(lease->ia_pd->header.lifetime_t1, /* max_as_infinity= */ true));
+ t2 = MIN(t2, be32_sec_to_usec(lease->ia_pd->header.lifetime_t2, /* max_as_infinity= */ true));
LIST_FOREACH(addresses, a, lease->ia_pd->addresses)
- min_valid_lt = MIN(min_valid_lt, be32_sec_to_usec(a->iapdprefix.lifetime_valid, /* max_as_infinity = */ true));
+ min_valid_lt = MIN(min_valid_lt, be32_sec_to_usec(a->iapdprefix.lifetime_valid, /* max_as_infinity= */ true));
}
if (t2 == 0 || t2 > min_valid_lt) {
a = &lease->addr_iter->iaaddr;
if (ret_lifetime_preferred)
- *ret_lifetime_preferred = be32_sec_to_usec(a->lifetime_preferred, /* max_as_infinity = */ true);
+ *ret_lifetime_preferred = be32_sec_to_usec(a->lifetime_preferred, /* max_as_infinity= */ true);
if (ret_lifetime_valid)
- *ret_lifetime_valid = be32_sec_to_usec(a->lifetime_valid, /* max_as_infinity = */ true);
+ *ret_lifetime_valid = be32_sec_to_usec(a->lifetime_valid, /* max_as_infinity= */ true);
return 0;
}
a = &lease->prefix_iter->iapdprefix;
if (ret_lifetime_preferred)
- *ret_lifetime_preferred = be32_sec_to_usec(a->lifetime_preferred, /* max_as_infinity = */ true);
+ *ret_lifetime_preferred = be32_sec_to_usec(a->lifetime_preferred, /* max_as_infinity= */ true);
if (ret_lifetime_valid)
- *ret_lifetime_valid = be32_sec_to_usec(a->lifetime_valid, /* max_as_infinity = */ true);
+ *ret_lifetime_valid = be32_sec_to_usec(a->lifetime_valid, /* max_as_infinity= */ true);
return 0;
}
if (r < 0)
return r;
- return strv_extend_strv_consume(&lease->domains, TAKE_PTR(domains), /* filter_duplicates = */ true);
+ return strv_extend_strv_consume(&lease->domains, TAKE_PTR(domains), /* filter_duplicates= */ true);
}
int sd_dhcp6_lease_get_domains(sd_dhcp6_lease *lease, char ***ret) {
if (r < 0)
return r;
- return strv_extend_strv_consume(&lease->sip_domains, TAKE_PTR(domains), /* filter_duplicates = */ true);
+ return strv_extend_strv_consume(&lease->sip_domains, TAKE_PTR(domains), /* filter_duplicates= */ true);
}
int sd_dhcp6_lease_get_sip_domains(sd_dhcp6_lease *lease, char ***ret) {
return log_dhcp6_client_errno(client, SYNTHETIC_ERRNO(EINVAL),
"Received information refresh time option with an invalid length (%zu).", optlen);
- irt = unaligned_be32_sec_to_usec(optval, /* max_as_infinity = */ false);
+ irt = unaligned_be32_sec_to_usec(optval, /* max_as_infinity= */ false);
break;
case SD_DHCP6_OPTION_V6_DNR:
assert(ret_packet);
/* If ifname is not set yet, set ifname from ifindex. */
- r = sd_lldp_tx_get_ifname(lldp_tx, /* ret = */ NULL);
+ r = sd_lldp_tx_get_ifname(lldp_tx, /* ret= */ NULL);
if (r < 0)
return r;
rt->hop_limit = a->nd_ra_curhoplimit;
rt->flags = a->nd_ra_flags_reserved; /* the first 8 bits */
- rt->lifetime_usec = be16_sec_to_usec(a->nd_ra_router_lifetime, /* max_as_infinity = */ false);
- rt->reachable_time_usec = be32_msec_to_usec(a->nd_ra_reachable, /* max_as_infinity = */ false);
- rt->retransmission_time_usec = be32_msec_to_usec(a->nd_ra_retransmit, /* max_as_infinity = */ false);
+ rt->lifetime_usec = be16_sec_to_usec(a->nd_ra_router_lifetime, /* max_as_infinity= */ false);
+ rt->reachable_time_usec = be32_msec_to_usec(a->nd_ra_reachable, /* max_as_infinity= */ false);
+ rt->retransmission_time_usec = be32_msec_to_usec(a->nd_ra_retransmit, /* max_as_infinity= */ false);
/* RFC 4191 section 2.2
* Prf (Default Router Preference)
assert(nd->ifindex > 0);
_cleanup_close_ int fd = -EBADF;
- fd = icmp6_bind(nd->ifindex, /* is_router = */ false);
+ fd = icmp6_bind(nd->ifindex, /* is_router= */ false);
if (fd < 0)
return fd;
assert(ra->ifindex > 0);
_cleanup_close_ int fd = -EBADF;
- fd = icmp6_bind(ra->ifindex, /* is_router = */ true);
+ fd = icmp6_bind(ra->ifindex, /* is_router= */ true);
if (fd < 0)
return fd;
uint32_t iaid_legacy;
be32_t iaid;
- assert_se(dhcp_identifier_set_iaid(NULL, &hw_addr, /* legacy_unstable_byteorder = */ true, &iaid_legacy) >= 0);
- assert_se(dhcp_identifier_set_iaid(NULL, &hw_addr, /* legacy_unstable_byteorder = */ false, &iaid) >= 0);
+ assert_se(dhcp_identifier_set_iaid(NULL, &hw_addr, /* legacy_unstable_byteorder= */ true, &iaid_legacy) >= 0);
+ assert_se(dhcp_identifier_set_iaid(NULL, &hw_addr, /* legacy_unstable_byteorder= */ false, &iaid) >= 0);
/* we expect, that the MAC address was hashed. The legacy value is in native
* endianness. */
uint32_t iaid;
assert_se(sd_dhcp_duid_set_en(&duid) >= 0);
- assert_se(dhcp_identifier_set_iaid(NULL, &hw_addr, /* legacy_unstable_byteorder = */ true, &iaid) >= 0);
+ assert_se(dhcp_identifier_set_iaid(NULL, &hw_addr, /* legacy_unstable_byteorder= */ true, &iaid) >= 0);
assert_se(len == sizeof(uint8_t) + sizeof(uint32_t) + duid.size);
assert_se(len == 19);
if (r <= 0)
return r;
- fd = icmp6_bind(arg_ifindex, /* is_router = */ false);
+ fd = icmp6_bind(arg_ifindex, /* is_router= */ false);
if (fd < 0)
return log_error_errno(fd, "Failed to bind socket to interface: %m");
log_debug("sd-bus: connecting bus%s%s to namespace of PID "PID_FMT"...",
b->description ? " " : "", strempty(b->description), b->nspid);
- r = namespace_open(b->nspid, &pidnsfd, &mntnsfd, /* ret_netns_fd = */ NULL, &usernsfd, &rootfd);
+ r = namespace_open(b->nspid, &pidnsfd, &mntnsfd, /* ret_netns_fd= */ NULL, &usernsfd, &rootfd);
if (r < 0)
return log_debug_errno(r, "Failed to open namespace of PID "PID_FMT": %m", b->nspid);
unsigned long g;
int n = 0;
- p = skip_leading_chars(p, /* bad = */ NULL);
+ p = skip_leading_chars(p, /* bad= */ NULL);
if (*p == 0)
break;
default:
return log_debug_errno(SYNTHETIC_ERRNO(EINVAL),
"sd-bus: an invalid message type (signature=%s, type=%c, contents=%s).",
- sd_bus_message_get_signature(m, /* complete = */ false), type, strna(contents));
+ sd_bus_message_get_signature(m, /* complete= */ false), type, strna(contents));
}
}
p = strempty(p);
- if (!signature_is_valid(p, /* allow_dict_entry = */ true))
+ if (!signature_is_valid(p, /* allow_dict_entry= */ true))
return -EINVAL;
align = 1;
return r;
}
- /* Automatic handling if no callback is defined. */
+ /* Automatic handling if no callback is defined. */
assert(signature_is_single(v->x.property.signature, false));
assert(bus_type_is_basic(v->x.property.signature[0]));
if (l % 2 != 0)
return 0;
- r = unhexmem_full(p, l, /* secure = */ false, (void**) &token, &len);
+ r = unhexmem_full(p, l, /* secure= */ false, (void**) &token, &len);
if (r < 0)
return 0;
if (l % 2 != 0)
return 0;
- r = unhexmem_full(p, l, /* secure = */ false, (void**) &token, &len);
+ r = unhexmem_full(p, l, /* secure= */ false, (void**) &token, &len);
if (r < 0)
return 0;
b->rbuffer_size += k;
if (handle_cmsg) {
- r = bus_process_cmsg(b, &mh, /* allow_fds = */ false);
+ r = bus_process_cmsg(b, &mh, /* allow_fds= */ false);
if (r < 0)
return r;
}
/* Are pidfds backed by pidfs where the unique inode id is relevant? Note that the pidfd
* passed to us is extrinsic and hence cannot be trusted to initialize our "have_pidfs" cache,
* instead pidfd_check_pidfs() will allocate one internally. */
- r = pidfd_check_pidfs(/* pid_fd = */ -EBADF);
+ r = pidfd_check_pidfs(/* pid_fd= */ -EBADF);
if (r <= 0)
return -EOPNOTSUPP;
else
hashmap = &enumerator->nomatch_sysattr;
- r = update_match_strv(hashmap, sysattr, value, /* clear_on_null = */ true);
+ r = update_match_strv(hashmap, sysattr, value, /* clear_on_null= */ true);
if (r <= 0)
return r;
assert_return(enumerator, -EINVAL);
assert_return(property, -EINVAL);
- r = update_match_strv(&enumerator->match_property, property, value, /* clear_on_null = */ false);
+ r = update_match_strv(&enumerator->match_property, property, value, /* clear_on_null= */ false);
if (r <= 0)
return r;
assert_return(enumerator, -EINVAL);
assert_return(property, -EINVAL);
- r = update_match_strv(&enumerator->match_property_required, property, value, /* clear_on_null = */ false);
+ r = update_match_strv(&enumerator->match_property_required, property, value, /* clear_on_null= */ false);
if (r <= 0)
return r;
if (r <= 0)
return r;
- if (!match_property(enumerator->match_property, device, /* match_all = */ false))
+ if (!match_property(enumerator->match_property, device, /* match_all= */ false))
return false;
- if (!match_property(enumerator->match_property_required, device, /* match_all = */ true))
+ if (!match_property(enumerator->match_property_required, device, /* match_all= */ true))
return false;
if (!device_match_sysattr(device, enumerator->match_sysattr, enumerator->nomatch_sysattr))
return r;
/* Leave from all multicast groups to prevent the buffer is filled. */
- r = device_monitor_update_multicast_groups(m, /* add = */ false);
+ r = device_monitor_update_multicast_groups(m, /* add= */ false);
if (r < 0)
return r;
return r;
/* Then, join the saved broadcast groups again. */
- r = device_monitor_update_multicast_groups(m, /* add = */ true);
+ r = device_monitor_update_multicast_groups(m, /* add= */ true);
if (r < 0)
return r;
return true;
if (!m->mapped_userns_uid_range) {
- r = uid_range_load_userns(/* path = */ NULL, UID_RANGE_USERNS_INSIDE, &m->mapped_userns_uid_range);
+ r = uid_range_load_userns(/* path= */ NULL, UID_RANGE_USERNS_INSIDE, &m->mapped_userns_uid_range);
if (r < 0)
log_monitor_errno(m, r, "Failed to load UID ranges mapped to the current user namespace, ignoring: %m");
}
hashmap = &m->nomatch_sysattr_filter;
/* TODO: unset m->filter_uptodate on success when we support this filter on BPF. */
- return update_match_strv(hashmap, sysattr, value, /* clear_on_null = */ true);
+ return update_match_strv(hashmap, sysattr, value, /* clear_on_null= */ true);
}
_public_ int sd_device_monitor_filter_add_match_parent(sd_device_monitor *m, sd_device *device, int match) {
}
/* Finally, read the udev database. */
- r = device_read_db_internal(dest, /* force = */ true);
+ r = device_read_db_internal(dest, /* force= */ true);
if (r < 0)
return r;
}
_public_ int sd_device_new_from_syspath(sd_device **ret, const char *syspath) {
- return device_new_from_syspath(ret, syspath, /* strict = */ true);
+ return device_new_from_syspath(ret, syspath, /* strict= */ true);
}
int device_new_from_mode_and_devnum(sd_device **ret, mode_t mode, dev_t devnum) {
if (streq(subsystem, "subsystem")) {
FOREACH_STRING(s, "/sys/bus/", "/sys/class/") {
- r = device_new_from_path_join(&device, subsystem, /* driver_subsystem = */ NULL, sysname, s, name, NULL, NULL);
+ r = device_new_from_path_join(&device, subsystem, /* driver_subsystem= */ NULL, sysname, s, name, NULL, NULL);
if (r < 0)
return r;
}
} else if (streq(subsystem, "module")) {
- r = device_new_from_path_join(&device, subsystem, /* driver_subsystem = */ NULL, sysname, "/sys/module/", name, NULL, NULL);
+ r = device_new_from_path_join(&device, subsystem, /* driver_subsystem= */ NULL, sysname, "/sys/module/", name, NULL, NULL);
if (r < 0)
return r;
}
}
- r = device_new_from_path_join(&device, subsystem, /* driver_subsystem = */ NULL, sysname, "/sys/bus/", subsystem, "/devices/", name);
+ r = device_new_from_path_join(&device, subsystem, /* driver_subsystem= */ NULL, sysname, "/sys/bus/", subsystem, "/devices/", name);
if (r < 0)
return r;
- r = device_new_from_path_join(&device, subsystem, /* driver_subsystem = */ NULL, sysname, "/sys/class/", subsystem, name, NULL);
+ r = device_new_from_path_join(&device, subsystem, /* driver_subsystem= */ NULL, sysname, "/sys/class/", subsystem, name, NULL);
if (r < 0)
return r;
/* Note that devices under /sys/firmware/ (e.g. /sys/firmware/devicetree/base/) do not have
* subsystem. Hence, pass NULL for subsystem. See issue #35861. */
- r = device_new_from_path_join(&device, /* subsystem = */ NULL, /* driver_subsystem = */ NULL, sysname, "/sys/firmware/", subsystem, name, NULL);
+ r = device_new_from_path_join(&device, /* subsystem= */ NULL, /* driver_subsystem= */ NULL, sysname, "/sys/firmware/", subsystem, name, NULL);
if (r < 0)
return r;
_cleanup_free_ char *resolved = NULL;
struct stat st;
- r = chase_and_stat(devname, /* root = */ NULL, /* chase_flags = */ 0, &resolved, &st);
+ r = chase_and_stat(devname, /* root= */ NULL, /* chase_flags= */ 0, &resolved, &st);
if (ERRNO_IS_NEG_DEVICE_ABSENT(r))
return -ENODEV;
if (r < 0)
}
_public_ int sd_device_new_from_devname(sd_device **ret, const char *devname) {
- return device_new_from_devname(ret, devname, /* strict = */ true);
+ return device_new_from_devname(ret, devname, /* strict= */ true);
}
_public_ int sd_device_new_from_path(sd_device **ret, const char *path) {
assert_return(ret, -EINVAL);
assert_return(path, -EINVAL);
- if (device_new_from_devname(ret, path, /* strict = */ false) >= 0)
+ if (device_new_from_devname(ret, path, /* strict= */ false) >= 0)
return 0;
- return device_new_from_syspath(ret, path, /* strict = */ false);
+ return device_new_from_syspath(ret, path, /* strict= */ false);
}
int device_set_devtype(sd_device *device, const char *devtype) {
}
int device_cache_sysattr_value(sd_device *device, char *key, char *value, int error) {
- return device_cache_sysattr_value_full(device, key, value, strlen(value), error, /* ignore_uevent = */ true);
+ return device_cache_sysattr_value_full(device, key, value, strlen(value), error, /* ignore_uevent= */ true);
}
static int device_get_cached_sysattr_value(sd_device *device, const char *key, const char **ret_value, size_t *ret_size) {
_cleanup_free_ char *resolved = NULL;
_cleanup_close_ int fd = -EBADF;
- r = chase(path, /* root = */ NULL, CHASE_NO_AUTOFS | flags, &resolved, ret_fd ? &fd : NULL);
+ r = chase(path, /* root= */ NULL, CHASE_NO_AUTOFS | flags, &resolved, ret_fd ? &fd : NULL);
if (r < 0)
return r;
return RET_GATHER(r, -ENOMEM);
}
- int k = device_cache_sysattr_value_full(device, resolved, value, size, -r, /* ignore_uevent = */ false);
+ int k = device_cache_sysattr_value_full(device, resolved, value, size, -r, /* ignore_uevent= */ false);
if (k < 0) {
if (r < 0)
log_device_debug_errno(device, k,
assert(sysattr);
_cleanup_free_ char *resolved = NULL;
- r = device_chase(device, sysattr, CHASE_PREFIX_ROOT | CHASE_NONEXISTENT, &resolved, /* ret_fd = */ NULL);
+ r = device_chase(device, sysattr, CHASE_PREFIX_ROOT | CHASE_NONEXISTENT, &resolved, /* ret_fd= */ NULL);
if (r < 0)
return r;
{ sd_device_get_sysname, "Qualcomm Atheros AR8031/AR8033" },
};
- ASSERT_OK_ERRNO(setenv("SYSTEMD_DEVICE_VERIFY_SYSFS", "0", /* overwrite = */ false));
+ ASSERT_OK_ERRNO(setenv("SYSTEMD_DEVICE_VERIFY_SYSFS", "0", /* overwrite= */ false));
ASSERT_OK(mount_nofollow_verbose(LOG_ERR, "tmpfs", "/sys/bus/", "tmpfs", 0, NULL));
r = mkdir_p(syspath, 0755);
if (ERRNO_IS_NEG_PRIVILEGE(r)) {
si.si_int = ssi->ssi_int;
si.si_ptr = UINT64_TO_PTR(ssi->ssi_ptr);
- return sd_event_source_send_child_signal(child, ssi->ssi_signo, &si, /* flags = */ 0);
+ return sd_event_source_send_child_signal(child, ssi->ssi_signo, &si, /* flags= */ 0);
}
static void event_forward_signal_destroy(void *userdata) {
* again. */
assert(s->ratelimited);
- r = event_source_leave_ratelimit(s, /* run_callback = */ true);
+ r = event_source_leave_ratelimit(s, /* run_callback= */ true);
if (r < 0)
return r;
else if (r == 1)
/* When ratelimiting is configured we'll always reset the rate limit state first and start fresh,
* non-ratelimited. */
- r = event_source_leave_ratelimit(s, /* run_callback = */ false);
+ r = event_source_leave_ratelimit(s, /* run_callback= */ false);
if (r < 0)
return r;
if (!s->ratelimited)
return 0;
- r = event_source_leave_ratelimit(s, /* run_callback = */ false);
+ r = event_source_leave_ratelimit(s, /* run_callback= */ false);
if (r < 0)
return r;
assert(dir_fd >= 0 || dir_fd == AT_FDCWD);
assert(path);
- fd = xopenat_full(dir_fd, path, O_WRONLY|O_CREAT|O_CLOEXEC|O_NOCTTY|O_TRUNC, /* xopen_flags = */ 0, 0444);
+ fd = xopenat_full(dir_fd, path, O_WRONLY|O_CREAT|O_CLOEXEC|O_NOCTTY|O_TRUNC, /* xopen_flags= */ 0, 0444);
if (fd < 0)
return fd;
if (r < 0)
return r;
- r = namespace_open(pid, &pidnsfd, &mntnsfd, /* ret_netns_fd = */ NULL, /* ret_userns_fd = */ NULL, &rootfd);
+ r = namespace_open(pid, &pidnsfd, &mntnsfd, /* ret_netns_fd= */ NULL, /* ret_userns_fd= */ NULL, &rootfd);
if (r < 0)
return r;
return 0;
}
- r = compress_blob(c, src, size, dst, size - 1, rsize, /* level = */ -1);
+ r = compress_blob(c, src, size, dst, size - 1, rsize, /* level= */ -1);
if (r < 0)
return log_debug_errno(r, "Failed to compress data object using %s, ignoring: %m", compression_to_string(c));
if (r < 0)
return r;
- r = verify_entry(f, o, p, cache_data_fd, n_data, /*last=*/ i + 1 == n);
+ r = verify_entry(f, o, p, cache_data_fd, n_data, /* last= */ i + 1 == n);
if (r < 0)
return r;
if (!path)
return -ENOMEM;
- return add_any_file(j, /* fd = */ -EBADF, path);
+ return add_any_file(j, /* fd= */ -EBADF, path);
}
static int remove_file_by_name(
goto fail;
}
- r = add_directory_impl(j, path, /* is_root = */ false, &m);
+ r = add_directory_impl(j, path, /* is_root= */ false, &m);
if (r < 0)
goto fail;
if (r == 0)
rewinddir(d);
}
- r = add_directory_impl(j, p, /* is_root = */ true, &m);
+ r = add_directory_impl(j, p, /* is_root= */ true, &m);
if (r < 0)
goto fail;
if (r == 0)
return -ENOMEM;
STRV_FOREACH(path, paths) {
- r = add_any_file(j, /* fd = */ -EBADF, *path);
+ r = add_any_file(j, /* fd= */ -EBADF, *path);
if (r < 0)
return r;
}
if (r < 0)
goto fail;
- r = add_any_file(j, fds[i], /* path = */ NULL);
+ r = add_any_file(j, fds[i], /* path= */ NULL);
if (r < 0)
goto fail;
}
/* Archive and offline file. */
assert_se(journal_file_archive(new_journal, NULL) >= 0);
- assert_se(journal_file_set_offline(new_journal, /* wait = */ true) >= 0);
+ assert_se(journal_file_set_offline(new_journal, /* wait= */ true) >= 0);
/* Read the archived and offline journal. */
for (uint64_t q = ALIGN64(p + 1); q < (uint64_t) j->current_file->last_stat.st_size; q = ALIGN64(q + 1)) {
ASSERT_OK(sd_journal_open_directory(&j, t, SD_JOURNAL_ASSUME_IMMUTABLE));
ASSERT_OK(journal_get_boots(
j,
- /* advance_older = */ false, /* max_ids = */ SIZE_MAX,
+ /* advance_older= */ false, /* max_ids= */ SIZE_MAX,
&ids, &n_ids));
ASSERT_NOT_NULL(ids);
ASSERT_EQ(n_ids, n_ids_expected);
ASSERT_OK(journal_get_boots(
j,
- /* advance_older = */ false, /* max_ids = */ i,
+ /* advance_older= */ false, /* max_ids= */ i,
&ids_limited, &n_ids_limited));
ASSERT_TRUE(ids_limited || i == 0);
ASSERT_EQ(n_ids_limited, MIN(i, n_ids_expected));
ASSERT_OK(journal_get_boots(
j,
- /* advance_older = */ true, /* max_ids = */ i,
+ /* advance_older= */ true, /* max_ids= */ i,
&ids_limited, &n_ids_limited));
ASSERT_TRUE(ids_limited || i == 0);
ASSERT_EQ(n_ids_limited, MIN(i, n_ids_expected));
iovec, n_iovec,
seqnum,
seqnum_id,
- /* ret_object = */ NULL,
- /* ret_offset = */ NULL), EREMCHG);
+ /* ret_object= */ NULL,
+ /* ret_offset= */ NULL), EREMCHG);
ASSERT_OK(journal_file_rotate(
f,
m,
- /* file_flags = */ JOURNAL_STRICT_ORDER,
- /* compress_threshold_bytes = */ UINT64_MAX,
- /* deferred_closes = */ NULL));
+ /* file_flags= */ JOURNAL_STRICT_ORDER,
+ /* compress_threshold_bytes= */ UINT64_MAX,
+ /* deferred_closes= */ NULL));
}
ASSERT_OK(journal_file_append_entry(
iovec, n_iovec,
seqnum,
seqnum_id,
- /* ret_object = */ NULL,
- /* ret_offset = */ NULL));
+ /* ret_object= */ NULL,
+ /* ret_offset= */ NULL));
ASSERT_NOT_NULL(GREEDY_REALLOC(*entries, *n_entries + 1));
(*entries)[(*n_entries)++] = (TestEntry) {
unsigned *number,
unsigned data) {
- append_test_entry_full(&f, NULL, entries, n_entries, seqnum, seqnum_id, boot_id, ts, number, data, /* expect_rotate = */ false);
+ append_test_entry_full(&f, NULL, entries, n_entries, seqnum, seqnum_id, boot_id, ts, number, data, /* expect_rotate= */ false);
}
TEST(seek_time) {
O_RDWR|O_CREAT,
JOURNAL_STRICT_ORDER,
0644,
- /* compress_threshold_bytes = */ UINT64_MAX,
- /* metrics = */ NULL,
+ /* compress_threshold_bytes= */ UINT64_MAX,
+ /* metrics= */ NULL,
m,
- /* template = */ NULL,
+ /* template= */ NULL,
&f));
uint64_t seqnum = 1;
/* realtime goes to backward */
ts.realtime -= 100;
ts.monotonic += 10;
- append_test_entry_full(&f, m, &entries, &n_entries, &seqnum, &seqnum_id, &boot_id, &ts, &n, 200, /* expect_rotate = */ true);
+ append_test_entry_full(&f, m, &entries, &n_entries, &seqnum, &seqnum_id, &boot_id, &ts, &n, 200, /* expect_rotate= */ true);
ts.realtime += 10;
ts.monotonic += 10;
}
FOREACH_ARRAY(e, entries, n_entries) {
- test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next = */ true, e->boot_id, e->ts.monotonic - 1, data);
- test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next = */ true, e->boot_id, e->ts.monotonic, data);
- test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next = */ true, e->boot_id, e->ts.monotonic + 1, data);
- test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next = */ false, e->boot_id, e->ts.monotonic - 1, data);
- test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next = */ false, e->boot_id, e->ts.monotonic, data);
- test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next = */ false, e->boot_id, e->ts.monotonic + 1, data);
-
- test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next = */ true, e->ts.monotonic - 1, data);
- test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next = */ true, e->ts.monotonic, data);
- test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next = */ true, e->ts.monotonic + 1, data);
- test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next = */ false, e->ts.monotonic - 1, data);
- test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next = */ false, e->ts.monotonic, data);
- test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next = */ false, e->ts.monotonic + 1, data);
+ test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next= */ true, e->boot_id, e->ts.monotonic - 1, data);
+ test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next= */ true, e->boot_id, e->ts.monotonic, data);
+ test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next= */ true, e->boot_id, e->ts.monotonic + 1, data);
+ test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next= */ false, e->boot_id, e->ts.monotonic - 1, data);
+ test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next= */ false, e->boot_id, e->ts.monotonic, data);
+ test_sd_journal_seek_monotonic_usec(j, entries, n_entries, /* next= */ false, e->boot_id, e->ts.monotonic + 1, data);
+
+ test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next= */ true, e->ts.monotonic - 1, data);
+ test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next= */ true, e->ts.monotonic, data);
+ test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next= */ true, e->ts.monotonic + 1, data);
+ test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next= */ false, e->ts.monotonic - 1, data);
+ test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next= */ false, e->ts.monotonic, data);
+ test_sd_journal_seek_realtime_usec(j, entries, n_entries, /* next= */ false, e->ts.monotonic + 1, data);
}
}
}
assert_return(m, -EINVAL);
return netlink_message_read_impl(
- m, attr_type, /* strict = */ false,
+ m, attr_type, /* strict= */ false,
_NETLINK_TYPE_INVALID, size,
- ret, /* ret_net_byteorder = */ NULL);
+ ret, /* ret_net_byteorder= */ NULL);
}
int sd_netlink_message_read_data(sd_netlink_message *m, uint16_t attr_type, size_t *ret_size, void **ret_data) {
assert_return(m, -EINVAL);
return netlink_message_read_impl(
- m, attr_type, /* strict = */ true,
+ m, attr_type, /* strict= */ true,
NETLINK_TYPE_U8, sizeof(uint8_t),
- ret, /* ret_net_byteorder = */ NULL);
+ ret, /* ret_net_byteorder= */ NULL);
}
int sd_netlink_message_read_u16(sd_netlink_message *m, uint16_t attr_type, uint16_t *ret) {
assert_return(m, -EINVAL);
r = netlink_message_read_impl(
- m, attr_type, /* strict = */ true,
+ m, attr_type, /* strict= */ true,
NETLINK_TYPE_U16, sizeof(uint16_t),
ret ? &u : NULL, &net_byteorder);
if (r < 0)
assert_return(m, -EINVAL);
r = netlink_message_read_impl(
- m, attr_type, /* strict = */ true,
+ m, attr_type, /* strict= */ true,
NETLINK_TYPE_U32, sizeof(uint32_t),
ret ? &u : NULL, &net_byteorder);
if (r < 0)
assert_return(m, -EINVAL);
r = netlink_message_read_impl(
- m, attr_type, /* strict = */ true,
+ m, attr_type, /* strict= */ true,
NETLINK_TYPE_U64, sizeof(uint64_t),
ret ? &u : NULL, &net_byteorder);
if (r < 0)
assert_return(m, -EINVAL);
return netlink_message_read_impl(
- m, attr_type, /* strict = */ true,
+ m, attr_type, /* strict= */ true,
NETLINK_TYPE_ETHER_ADDR, sizeof(struct ether_addr),
- ret, /* ret_net_byteorder = */ NULL);
+ ret, /* ret_net_byteorder= */ NULL);
}
int netlink_message_read_hw_addr(sd_netlink_message *m, uint16_t attr_type, struct hw_addr_data *ret) {
assert_return(m, -EINVAL);
r = netlink_message_read_impl(
- m, attr_type, /* strict = */ false,
+ m, attr_type, /* strict= */ false,
NETLINK_TYPE_ETHER_ADDR, HW_ADDR_MAX_SIZE,
- ret ? ret->bytes : NULL, /* ret_net_byteorder = */ NULL);
+ ret ? ret->bytes : NULL, /* ret_net_byteorder= */ NULL);
if (r < 0)
return r;
assert_return(m, -EINVAL);
return netlink_message_read_impl(
- m, attr_type, /* strict = */ true,
+ m, attr_type, /* strict= */ true,
NETLINK_TYPE_CACHE_INFO, sizeof(struct ifa_cacheinfo),
- ret, /* ret_net_byteorder = */ NULL);
+ ret, /* ret_net_byteorder= */ NULL);
}
int netlink_message_read_in_addr_union(sd_netlink_message *m, uint16_t attr_type, int family, union in_addr_union *ret) {
assert_return(IN_SET(family, AF_INET, AF_INET6), -EINVAL);
r = netlink_message_read_impl(
- m, attr_type, /* strict = */ true,
+ m, attr_type, /* strict= */ true,
NETLINK_TYPE_IN_ADDR, FAMILY_ADDRESS_SIZE(family),
- ret, /* ret_net_byteorder = */ NULL);
+ ret, /* ret_net_byteorder= */ NULL);
if (r < 0)
return r;
assert_return(m, -EINVAL);
return netlink_message_read_impl(
- m, attr_type, /* strict = */ true,
+ m, attr_type, /* strict= */ true,
NETLINK_TYPE_IN_ADDR, sizeof(struct in_addr),
- ret, /* ret_net_byteorder = */ NULL);
+ ret, /* ret_net_byteorder= */ NULL);
}
int sd_netlink_message_read_in6_addr(sd_netlink_message *m, uint16_t attr_type, struct in6_addr *ret) {
assert_return(m, -EINVAL);
return netlink_message_read_impl(
- m, attr_type, /* strict = */ true,
+ m, attr_type, /* strict= */ true,
NETLINK_TYPE_IN_ADDR, sizeof(struct in6_addr),
- ret, /* ret_net_byteorder = */ NULL);
+ ret, /* ret_net_byteorder= */ NULL);
}
int sd_netlink_message_has_flag(sd_netlink_message *m, uint16_t attr_type) {
ifindex,
ret_name,
ret_altnames,
- /* ret_iftype = */ NULL,
- /* ret_flags = */ NULL,
- /* ret_kind = */ NULL,
- /* ret_hw_addr = */ NULL,
- /* ret_permanent_hw_addr = */ NULL);
+ /* ret_iftype= */ NULL,
+ /* ret_flags= */ NULL,
+ /* ret_kind= */ NULL,
+ /* ret_hw_addr= */ NULL,
+ /* ret_permanent_hw_addr= */ NULL);
}
static inline int rtnl_get_ifname(sd_netlink **rtnl, int ifindex, char **ret) {
return rtnl_get_ifname_full(rtnl, ifindex, ret, NULL);
return rtnl_get_link_info_full(
rtnl,
ifindex,
- /* ret_name = */ NULL,
- /* ret_altnames = */ NULL,
+ /* ret_name= */ NULL,
+ /* ret_altnames= */ NULL,
ret_iftype,
ret_flags,
ret_kind,
return rtnl_get_link_info(
rtnl,
ifindex,
- /* ret_iftype = */ NULL,
- /* ret_flags = */ NULL,
- /* ret_kind = */ NULL,
+ /* ret_iftype= */ NULL,
+ /* ret_flags= */ NULL,
+ /* ret_kind= */ NULL,
ret,
- /* ret_permanent_hw_addr = */ NULL);
+ /* ret_permanent_hw_addr= */ NULL);
}
typedef enum ResolveInterfaceNameFlag {
if (!paths)
return NULL;
- if (strv_extend_strv_consume(&paths, TAKE_PTR(config_dirs), /* filter_duplicates = */ false) < 0)
+ if (strv_extend_strv_consume(&paths, TAKE_PTR(config_dirs), /* filter_duplicates= */ false) < 0)
return NULL;
/* global config has lower priority than the user config of the same type */
if (strv_extend(&paths, global_persistent_config) < 0)
return NULL;
- if (strv_extend_strv(&paths, (char* const*) user_config_unit_paths, /* filter_duplicates = */ false) < 0)
+ if (strv_extend_strv(&paths, (char* const*) user_config_unit_paths, /* filter_duplicates= */ false) < 0)
return NULL;
/* strv_extend_many() can deal with NULL-s in arguments */
generator) < 0)
return NULL;
- if (strv_extend_strv_consume(&paths, TAKE_PTR(data_dirs), /* filter_duplicates = */ false) < 0)
+ if (strv_extend_strv_consume(&paths, TAKE_PTR(data_dirs), /* filter_duplicates= */ false) < 0)
return NULL;
if (strv_extend_strv(&paths, (char* const*) user_data_unit_paths, false) < 0)
return -ENOMEM;
/* strv_uniq() below would filter all duplicates against the final strv */
- r = strv_extend_strv_consume(&paths, TAKE_PTR(add), /* filter_duplicates = */ false);
+ r = strv_extend_strv_consume(&paths, TAKE_PTR(add), /* filter_duplicates= */ false);
if (r < 0)
return r;
}
return NULL;
if (!paths || r > 0) {
- r = strv_extend_strv(&paths, (char* const*) generator_paths, /* filter_duplicates = */ true);
+ r = strv_extend_strv(&paths, (char* const*) generator_paths, /* filter_duplicates= */ true);
if (r < 0)
return NULL;
}
const char *s = startswith(p, "$HOME/");
if (s)
- return from_home_dir(/* envname = */ NULL, s, buffer, ret);
+ return from_home_dir(/* envname= */ NULL, s, buffer, ret);
if (path_is_absolute(p)) {
char *c = strdup(p);
fallback:
/* The desktop directory defaults to $HOME/Desktop, the others to $HOME */
if (streq(field, "XDG_DESKTOP_DIR"))
- return from_home_dir(/* envname = */ NULL, "Desktop", buffer, ret);
+ return from_home_dir(/* envname= */ NULL, "Desktop", buffer, ret);
home:
r = get_home_dir(buffer);
assert(link);
assert(link->server);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
else {
_cleanup_free_ struct udev_list_entry **buf = NULL;
- if (hashmap_dump_sorted(list->unique_entries, (void***) &buf, /* ret_n = */ NULL) < 0)
+ if (hashmap_dump_sorted(list->unique_entries, (void***) &buf, /* ret_n= */ NULL) < 0)
return NULL;
for (size_t j = n; j > 0; j--)
_cleanup_free_ char *map = NULL;
ASSERT_OK(get_testdata_dir("test-keymap-util/kbd-model-map", &map));
- ASSERT_OK_ERRNO(setenv("SYSTEMD_KBD_MODEL_MAP", map, /* overwrite = */ true));
+ ASSERT_OK_ERRNO(setenv("SYSTEMD_KBD_MODEL_MAP", map, /* overwrite= */ true));
return EXIT_SUCCESS;
}
&tty,
&idle,
&idle_timestamp_monotonic,
- /* object = */ NULL);
+ /* object= */ NULL);
if (r < 0)
return bus_log_parse_error(r);
if (r == 0)
return table_log_print_error(r);
if (i.scope) {
- show_unit_cgroup(bus, i.scope, i.leader, /* prefix = */ strrepa(" ", STRLEN("Display: ")));
+ show_unit_cgroup(bus, i.scope, i.leader, /* prefix= */ strrepa(" ", STRLEN("Display: ")));
if (arg_transport == BUS_TRANSPORT_LOCAL)
show_journal_by_unit(
stdout,
i.scope,
- /* namespace = */ NULL,
+ /* namespace= */ NULL,
arg_output,
- /* n_columns = */ 0,
+ /* n_columns= */ 0,
i.timestamp.monotonic,
arg_lines,
get_output_flags() | OUTPUT_BEGIN_NEWLINE,
SD_JOURNAL_LOCAL_ONLY,
- /* system_unit = */ true,
- /* ellipsized = */ NULL);
+ /* system_unit= */ true,
+ /* ellipsized= */ NULL);
}
return 0;
return table_log_print_error(r);
if (i.slice) {
- show_unit_cgroup(bus, i.slice, /* leader = */ 0, /* prefix = */ strrepa(" ", STRLEN("Sessions: ")));
+ show_unit_cgroup(bus, i.slice, /* leader= */ 0, /* prefix= */ strrepa(" ", STRLEN("Sessions: ")));
if (arg_transport == BUS_TRANSPORT_LOCAL)
show_journal_by_unit(
stdout,
i.slice,
- /* namespace = */ NULL,
+ /* namespace= */ NULL,
arg_output,
- /* n_columns = */ 0,
+ /* n_columns= */ 0,
i.timestamp.monotonic,
arg_lines,
get_output_flags() | OUTPUT_BEGIN_NEWLINE,
SD_JOURNAL_LOCAL_ONLY,
- /* system_unit = */ true,
- /* ellipsized = */ NULL);
+ /* system_unit= */ true,
+ /* ellipsized= */ NULL);
}
return 0;
error,
uid,
leader_pid,
- /* leader_pidfd = */ -EBADF,
+ /* leader_pidfd= */ -EBADF,
service,
type,
class,
remote,
remote_user,
remote_host,
- /* flags = */ 0);
+ /* flags= */ 0);
}
static int method_create_session_pidfd(sd_bus_message *message, void *userdata, sd_bus_error *error) {
message,
error,
uid,
- /* leader_pid = */ 0,
+ /* leader_pid= */ 0,
leader_fd,
service,
type,
r = event_reset_time_relative(
m->event, &m->inhibit_timeout_source,
- CLOCK_MONOTONIC, m->inhibit_delay_max, /* accuracy = */ 0,
+ CLOCK_MONOTONIC, m->inhibit_delay_max, /* accuracy= */ 0,
manager_inhibit_timeout_handler, m,
- /* priority = */ 0, "inhibit-timeout", /* force_reset = */ true);
+ /* priority= */ 0, "inhibit-timeout", /* force_reset= */ true);
if (r < 0)
return log_error_errno(r, "Failed to reset timer event source for inhibit timeout: %m");
return method_do_shutdown_or_sleep(
m, message,
HANDLE_SLEEP,
- /* with_flags = */ true,
+ /* with_flags= */ true,
error);
}
LIST_FOREACH(sessions_by_user, s, user->sessions)
/* Don't propagate user service failures to the client */
- session_jobs_reply(s, id, unit, /* result = */ NULL);
+ session_jobs_reply(s, id, unit, /* result= */ NULL);
user_save(user);
break;
manager,
scope,
pidref,
- /* allow_pidfd = */ false,
+ /* allow_pidfd= */ false,
slice,
description,
requires,
if (r == 0)
return 1; /* Will call us back */
- r = seat_stop_sessions(s, /* force = */ true);
+ r = seat_stop_sessions(s, /* force= */ true);
if (r < 0)
return r;
RET_GATHER(ret, log_debug_errno(r, "Failed to apply ACL on '%s': %m", node ?: de->d_name));
/* Better be safe than sorry and reset ACL */
- r = devnode_acl(fd, /* uid = */ 0);
+ r = devnode_acl(fd, /* uid= */ 0);
if (r >= 0 || r == -ENOENT)
continue;
}
if (r == 0)
return 1; /* Will call us back */
- r = session_stop(s, /* force = */ true);
+ r = session_stop(s, /* force= */ true);
if (r < 0)
return r;
free(s->scope_job);
- session_reset_leader(s, /* keep_fdstore = */ true);
+ session_reset_leader(s, /* keep_fdstore= */ true);
sd_bus_message_unref(s->create_message);
sd_bus_message_unref(s->upgrade_message);
if (pidref_equal(&s->leader, &pidref))
return 0;
- session_reset_leader(s, /* keep_fdstore = */ false);
+ session_reset_leader(s, /* keep_fdstore= */ false);
s->leader = TAKE_PIDREF(pidref);
}
/* The file descriptors for loaded devices will be reattached later. */
- RET_GATHER(r, session_device_new(s, dev, /* open_device = */ false, /* ret = */ NULL));
+ RET_GATHER(r, session_device_new(s, dev, /* open_device= */ false, /* ret= */ NULL));
}
if (r < 0)
s->manager,
scope,
&s->leader,
- /* allow_pidfd = */ true,
+ /* allow_pidfd= */ true,
s->user->slice,
description,
/* These should have been pulled in explicitly in user_start(). Just to be sure. */
- /* requires = */ STRV_MAKE_CONST(s->user->runtime_dir_unit),
- /* wants = */ STRV_MAKE_CONST(SESSION_CLASS_WANTS_SERVICE_MANAGER(s->class) ? s->user->service_manager_unit : NULL),
+ /* requires= */ STRV_MAKE_CONST(s->user->runtime_dir_unit),
+ /* wants= */ STRV_MAKE_CONST(SESSION_CLASS_WANTS_SERVICE_MANAGER(s->class) ? s->user->service_manager_unit : NULL),
/* We usually want to order session scopes after systemd-user-sessions.service
* since the unit is used as login session barrier for unprivileged users. However
* the barrier doesn't apply for root as sysadmin should always be able to log in
* (and without waiting for any timeout to expire) in case something goes wrong
* during the boot process. */
- /* extra_after = */ STRV_MAKE_CONST("systemd-logind.service",
+ /* extra_after= */ STRV_MAKE_CONST("systemd-logind.service",
SESSION_CLASS_IS_EARLY(s->class) ? NULL : "systemd-user-sessions.service"),
user_record_home_directory(s->user->user_record),
properties,
if (idle) {
log_info("Session \"%s\" of user \"%s\" is idle, stopping.", s->id, s->user->user_record->user_name);
- return session_stop(s, /* force = */ true);
+ return session_stop(s, /* force= */ true);
}
r = sd_event_source_set_time(
seat_save(s->seat);
}
- session_reset_leader(s, /* keep_fdstore = */ false);
+ session_reset_leader(s, /* keep_fdstore= */ false);
(void) user_save(s->user);
(void) user_send_changed(s->user, "Display");
assert(es);
- session_stop(s, /* force = */ false);
+ session_stop(s, /* force= */ false);
return 0;
}
if (s->vtnr < 1)
return 0;
- vt = session_open_vt(s, /* reopen = */ false);
+ vt = session_open_vt(s, /* reopen= */ false);
if (vt < 0)
return vt;
/* We do a little dance to avoid having the terminal be available
* for reuse before we've cleaned it up. */
- int fd = session_open_vt(s, /* reopen = */ true);
+ int fd = session_open_vt(s, /* reopen= */ true);
if (fd >= 0)
r = vt_restore(fd);
}
return;
session_device_pause_all(s);
- r = vt_release(s->vtfd, /* restore = */ false);
+ r = vt_release(s->vtfd, /* restore= */ false);
if (r == -EIO) {
/* Handle the same VT hung-up case as in session_restore_vt */
- int fd = session_open_vt(s, /* reopen = */ true);
+ int fd = session_open_vt(s, /* reopen= */ true);
if (fd >= 0)
- r = vt_release(fd, /* restore = */ false);
+ r = vt_release(fd, /* restore= */ false);
}
if (r < 0)
log_debug_errno(r, "Cannot release VT of session %s: %m", s->id);
if (r == 0)
return 1; /* Will call us back */
- r = user_stop(u, /* force = */ true);
+ r = user_stop(u, /* force= */ true);
if (r < 0)
return r;
assert(m);
assert(ret_varlink_fd);
- n = sd_listen_fds_with_names(/* unset_environment = */ true, &fdnames);
+ n = sd_listen_fds_with_names(/* unset_environment= */ true, &fdnames);
if (n < 0)
return log_error_errno(n, "Failed to acquire passed fd list: %m");
return 0;
}
- r = vt_release(fd, /* restore = */ true);
+ r = vt_release(fd, /* restore= */ true);
if (r < 0)
log_warning_errno(r, "Failed to release current VT, ignoring: %m");
return r;
FOREACH_STRING(s, "input", "graphics", "drm") {
- r = sd_device_monitor_filter_add_match_subsystem_devtype(m->device_monitor, s, /* devtype = */ NULL);
+ r = sd_device_monitor_filter_add_match_subsystem_devtype(m->device_monitor, s, /* devtype= */ NULL);
if (r < 0)
return r;
}
seat->in_gc_queue = false;
if (seat_may_gc(seat, drop_not_started)) {
- seat_stop(seat, /* force = */ false);
+ seat_stop(seat, /* force= */ false);
seat_free(seat);
}
}
/* First, if we are not closing yet, initiate stopping. */
if (session_may_gc(session, drop_not_started) &&
session_get_state(session) != SESSION_CLOSING)
- (void) session_stop(session, /* force = */ false);
+ (void) session_stop(session, /* force= */ false);
/* Normally, this should make the session referenced again, if it doesn't then let's get rid
* of it immediately. */
handle,
ur,
c,
- /* avoid_pidfd = */ false,
+ /* avoid_pidfd= */ false,
&m);
if (r < 0)
return pam_bus_log_create_error(handle, r);
handle,
ur,
c,
- /* avoid_pidfd = */ true,
+ /* avoid_pidfd= */ true,
&m);
if (r < 0)
return pam_bus_log_create_error(handle, r);
&id,
&object_path,
&runtime_path,
- /* session_fd = */ NULL,
+ /* session_fd= */ NULL,
&original_uid,
&real_seat,
&real_vtnr,
} else {
sd_id128_t id;
- r = machine_id_setup(arg_root, SD_ID128_NULL, /* flags = */ 0, &id);
+ r = machine_id_setup(arg_root, SD_ID128_NULL, /* flags= */ 0, &id);
if (r < 0)
return r;
assert(operation);
assert(operation->link);
- r = clean_pool_read_first_entry(file, child_error, /* error = */ NULL);
+ r = clean_pool_read_first_entry(file, child_error, /* error= */ NULL);
if (r < 0)
return log_debug_errno(r, "Failed to read first entry from tmp file: %m");
break;
if (previous_name) {
- r = clean_pool_list_one_image(operation->link, previous_name, previous_usage, /* more = */ true);
+ r = clean_pool_list_one_image(operation->link, previous_name, previous_usage, /* more= */ true);
if (r < 0)
return r;
/* freeing memory to avoid memleak at the following assignment */
}
if (previous_name)
- return clean_pool_list_one_image(operation->link, previous_name, previous_usage, /* more = */ false);
+ return clean_pool_list_one_image(operation->link, previous_name, previous_usage, /* more= */ false);
return sd_varlink_error(operation->link, "io.systemd.MachineImage.NoSuchImage", NULL);
}
errno_pipe_fd[0] = safe_close(errno_pipe_fd[0]);
_cleanup_hashmap_free_ Hashmap *images = NULL;
- r = image_discover(manager->runtime_scope, IMAGE_MACHINE, /* root = */ NULL, &images);
+ r = image_discover(manager->runtime_scope, IMAGE_MACHINE, /* root= */ NULL, &images);
if (r < 0) {
log_debug_errno(r, "Failed to discover images: %m");
report_errno_and_exit(errno_pipe_fd[1], r);
break;
case MACHINE_OPEN_MODE_LOGIN:
- r = machine_start_getty(machine, ptmx_name, /* error = */ NULL);
+ r = machine_start_getty(machine, ptmx_name, /* error= */ NULL);
if (r == -ENOENT)
return sd_varlink_error(link, VARLINK_ERROR_MACHINE_NO_IPC, NULL);
if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
case MACHINE_OPEN_MODE_SHELL: {
assert(user && path && args); /* to avoid gcc complaining about possible uninitialized variables */
- r = machine_start_shell(machine, ptmx_fd, ptmx_name, user, path, args, p.env, /* error = */ NULL);
+ r = machine_start_shell(machine, ptmx_fd, ptmx_name, user, path, args, p.env, /* error= */ NULL);
if (r == -ENOENT)
return sd_varlink_error(link, VARLINK_ERROR_MACHINE_NO_IPC, NULL);
if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
* doesn't support PIDFDs yet, let's try without. */
if (allow_pidfd &&
sd_bus_error_has_names(&e, SD_BUS_ERROR_UNKNOWN_PROPERTY, SD_BUS_ERROR_PROPERTY_READ_ONLY))
- return machine_start_scope(machine, /* allow_pidfd = */ false, more_properties, error);
+ return machine_start_scope(machine, /* allow_pidfd= */ false, more_properties, error);
return sd_bus_error_move(error, &e);
}
assert(m->class != MACHINE_HOST);
if (!m->unit) {
- r = machine_start_scope(m, /* allow_pidfd = */ true, properties, error);
+ r = machine_start_scope(m, /* allow_pidfd= */ true, properties, error);
if (r < 0)
return log_error_errno(r, "Failed to start machine scope: %s", bus_error_message(error, r));
}
container_bus = allocated_bus ?: m->manager->system_bus;
getty = strjoina("container-getty@", p, ".service");
- r = bus_call_method(container_bus, bus_systemd_mgr, "StartUnit", error, /* ret_reply = */ NULL, "ss", getty, "replace");
+ r = bus_call_method(container_bus, bus_systemd_mgr, "StartUnit", error, /* ret_reply= */ NULL, "ss", getty, "replace");
if (r < 0)
return log_debug_errno(r, "Failed to StartUnit '%s' in container '%s': %m", getty, m->name);
r = namespace_fork("(sd-copyns)",
"(sd-copy)",
- /* except_fds = */ NULL,
- /* n_except_fds = */ 0,
+ /* except_fds= */ NULL,
+ /* n_except_fds= */ 0,
FORK_RESET_SIGNALS|FORK_DEATHSIG_SIGKILL,
- /* pidns_fd = */ -EBADF,
+ /* pidns_fd= */ -EBADF,
target_mntns_fd,
- /* netns_fd = */ -EBADF,
- /* userns_fd = */ -EBADF,
- /* root_fd = */ -EBADF,
+ /* netns_fd= */ -EBADF,
+ /* userns_fd= */ -EBADF,
+ /* root_fd= */ -EBADF,
&child);
if (r < 0)
return log_debug_errno(r, "Failed to fork into mount namespace of machine '%s': %m", machine->name);
uid_shift == 0 ? UID_INVALID : 0,
uid_shift == 0 ? GID_INVALID : 0,
copy_flags,
- /* denylist = */ NULL,
- /* subvolumes = */ NULL);
+ /* denylist= */ NULL,
+ /* subvolumes= */ NULL);
else
r = copy_tree_at(
host_fd,
uid_shift == 0 ? UID_INVALID : uid_shift,
uid_shift == 0 ? GID_INVALID : uid_shift,
copy_flags,
- /* denylist = */ NULL,
- /* subvolumes = */ NULL);
+ /* denylist= */ NULL,
+ /* subvolumes= */ NULL);
if (r < 0)
log_debug_errno(r, "Failed to copy tree: %m");
pid_t child;
r = pidref_namespace_open(&machine->leader,
- /* ret_pidns_fd = */ NULL,
+ /* ret_pidns_fd= */ NULL,
&mntns_fd,
- /* ret_netns_fd = */ NULL,
- /* ret_userns_fd = */ NULL,
+ /* ret_netns_fd= */ NULL,
+ /* ret_userns_fd= */ NULL,
&root_fd);
if (r < 0)
return log_debug_errno(r, "Failed to open mount namespace of machine '%s': %m", machine->name);
r = namespace_fork(
"(sd-openrootns)",
"(sd-openroot)",
- /* except_fds = */ NULL,
- /* n_except_fds = */ 0,
+ /* except_fds= */ NULL,
+ /* n_except_fds= */ 0,
FORK_RESET_SIGNALS|FORK_DEATHSIG_SIGKILL,
- /* pidns_fd = */ -EBADF,
+ /* pidns_fd= */ -EBADF,
mntns_fd,
- /* netns_fd = */ -EBADF,
- /* userns_fd = */ -EBADF,
+ /* netns_fd= */ -EBADF,
+ /* userns_fd= */ -EBADF,
root_fd,
&child);
if (r < 0)
report_errno_and_exit(errno_pipe_fd[1], -errno);
}
- r = send_one_fd(fd_pass_socket[1], dfd, /* flags = */ 0);
+ r = send_one_fd(fd_pass_socket[1], dfd, /* flags= */ 0);
dfd = safe_close(dfd);
if (r < 0) {
log_debug_errno(r, "Failed to send FD over socket: %m");
errno_pipe_fd[1] = safe_close(errno_pipe_fd[1]);
fd_pass_socket[1] = safe_close(fd_pass_socket[1]);
- r = wait_for_terminate_and_check("(sd-openrootns)", child, /* flags = */ 0);
+ r = wait_for_terminate_and_check("(sd-openrootns)", child, /* flags= */ 0);
if (r < 0)
return log_debug_errno(r, "Failed to wait for child: %m");
show_journal_by_unit(
stdout,
i->unit,
- /* namespace = */ NULL,
+ /* namespace= */ NULL,
arg_output,
- /* n_columns = */ 0,
+ /* n_columns= */ 0,
i->timestamp.monotonic,
arg_lines,
get_output_flags() | OUTPUT_BEGIN_NEWLINE,
SD_JOURNAL_LOCAL_ONLY,
- /* system_unit = */ true,
- /* ellipsized = */ NULL);
+ /* system_unit= */ true,
+ /* ellipsized= */ NULL);
}
}
if (r < 0)
return bus_log_parse_error(r);
- return process_forward(event, slot, master, /* flags = */ 0, machine);
+ return process_forward(event, slot, master, /* flags= */ 0, machine);
}
static int normalize_nspawn_filename(const char *name, char **ret_file) {
"Invalid settings file path '%s'.",
*name);
- q = cat_files(*name, /* dropins = */ NULL, /* flags = */ CAT_FORMAT_HAS_SECTIONS);
+ q = cat_files(*name, /* dropins= */ NULL, /* flags= */ CAT_FORMAT_HAS_SECTIONS);
if (q < 0)
return r < 0 ? r : q;
continue;
return r < 0 ? r : q;
}
- q = cat_files(path, /* dropins = */ NULL, /* flags = */ CAT_FORMAT_HAS_SECTIONS);
+ q = cat_files(path, /* dropins= */ NULL, /* flags= */ CAT_FORMAT_HAS_SECTIONS);
if (q < 0)
return r < 0 ? r : q;
}
if (!new_args)
return log_oom();
- r = strv_extend_strv(&new_args, argv + 1, /* filter_duplicates = */ false);
+ r = strv_extend_strv(&new_args, argv + 1, /* filter_duplicates= */ false);
if (r < 0)
return log_oom();
_cleanup_free_ struct local_address *addresses = NULL;
int n;
- n = local_addresses(/* context = */ NULL, /* ifindex = */ 0, AF_UNSPEC, &addresses);
+ n = local_addresses(/* context= */ NULL, /* ifindex= */ 0, AF_UNSPEC, &addresses);
if (n < 0)
return log_debug_errno(n, "Failed to get local addresses: %m");
pid_t child;
int r;
- r = pidref_in_same_namespace(/* pid1 = */ NULL, &machine->leader, NAMESPACE_NET);
+ r = pidref_in_same_namespace(/* pid1= */ NULL, &machine->leader, NAMESPACE_NET);
if (r < 0)
return log_debug_errno(r, "Failed to check if container has private network: %m");
if (r > 0)
return -ENONET;
r = pidref_namespace_open(&machine->leader,
- /* ret_pidns_fd = */ NULL,
- /* ret_mntns_fd = */ NULL,
+ /* ret_pidns_fd= */ NULL,
+ /* ret_mntns_fd= */ NULL,
&netns_fd,
- /* ret_userns_fd = */ NULL,
- /* ret_root_fd = */ NULL);
+ /* ret_userns_fd= */ NULL,
+ /* ret_root_fd= */ NULL);
if (r < 0)
return log_debug_errno(r, "Failed to open namespace: %m");
r = namespace_fork("(sd-addrns)",
"(sd-addr)",
- /* except_fds = */ NULL,
- /* n_except_fds = */ 0,
+ /* except_fds= */ NULL,
+ /* n_except_fds= */ 0,
FORK_RESET_SIGNALS|FORK_DEATHSIG_SIGKILL,
- /* pidns_fd = */ -EBADF,
- /* mntns_fd = */ -EBADF,
+ /* pidns_fd= */ -EBADF,
+ /* mntns_fd= */ -EBADF,
netns_fd,
- /* userns_fd = */ -EBADF,
- /* root_fd = */ -EBADF,
+ /* userns_fd= */ -EBADF,
+ /* root_fd= */ -EBADF,
&child);
if (r < 0)
return log_debug_errno(r, "Failed to fork(): %m");
pair[0] = safe_close(pair[0]);
- int n = local_addresses(/* context = */ NULL, /* ifindex = */ 0, AF_UNSPEC, &addresses);
+ int n = local_addresses(/* context= */ NULL, /* ifindex= */ 0, AF_UNSPEC, &addresses);
if (n < 0) {
log_debug_errno(n, "Failed to get local addresses: %m");
_exit(EXIT_FAILURE);
return log_debug_errno(r, "Failed to add local address: %m");
}
- r = wait_for_terminate_and_check("(sd-addrns)", child, /* flags = */ 0);
+ r = wait_for_terminate_and_check("(sd-addrns)", child, /* flags= */ 0);
if (r < 0)
return log_debug_errno(r, "Failed to wait for child: %m");
if (r != EXIT_SUCCESS)
switch (machine->class) {
case MACHINE_HOST:
- r = load_os_release_pairs(/* root = */ NULL, &l);
+ r = load_os_release_pairs(/* root= */ NULL, &l);
if (r < 0)
return log_debug_errno(r, "Failed to load OS release information: %m");
r = pidref_namespace_open(&machine->leader,
&pidns_fd,
&mntns_fd,
- /* ret_netns_fd = */ NULL,
- /* ret_userns_fd = */ NULL,
+ /* ret_netns_fd= */ NULL,
+ /* ret_userns_fd= */ NULL,
&root_fd);
if (r < 0)
return log_debug_errno(r, "Failed to open namespace: %m");
r = namespace_fork("(sd-osrelns)",
"(sd-osrel)",
- /* except_fds = */ NULL,
- /* n_except_fds = */ 0,
+ /* except_fds= */ NULL,
+ /* n_except_fds= */ 0,
FORK_RESET_SIGNALS|FORK_DEATHSIG_SIGKILL,
pidns_fd,
mntns_fd,
- /* netns_fd = */ -EBADF,
- /* userns_fd = */ -EBADF,
+ /* netns_fd= */ -EBADF,
+ /* userns_fd= */ -EBADF,
root_fd,
&child);
if (r < 0)
pair[0] = safe_close(pair[0]);
- r = open_os_release(/* root = */ NULL, /* ret_path = */ NULL, &fd);
+ r = open_os_release(/* root= */ NULL, /* ret_path= */ NULL, &fd);
if (r == -ENOENT)
_exit(EXIT_NOT_FOUND);
if (r < 0) {
_exit(EXIT_FAILURE);
}
- r = copy_bytes(fd, pair[1], UINT64_MAX, /* copy_flags = */ 0);
+ r = copy_bytes(fd, pair[1], UINT64_MAX, /* copy_flags= */ 0);
if (r < 0) {
log_debug_errno(r, "Failed to write to fd: %m");
_exit(EXIT_FAILURE);
if (r < 0)
return log_debug_errno(r, "Failed to load OS release information: %m");
- r = wait_for_terminate_and_check("(sd-osrelns)", child, /* flags = */ 0);
+ r = wait_for_terminate_and_check("(sd-osrelns)", child, /* flags= */ 0);
if (r < 0)
return log_debug_errno(r, "Failed to wait for child: %m");
if (r == EXIT_NOT_FOUND)
if (r < 0)
return r;
- return list_machine_one_and_maybe_read_metadata(link, machine, /* more = */ false, p.acquire_metadata);
+ return list_machine_one_and_maybe_read_metadata(link, machine, /* more= */ false, p.acquire_metadata);
}
if (!FLAGS_SET(flags, SD_VARLINK_METHOD_MORE))
Machine *previous = NULL, *i;
HASHMAP_FOREACH(i, m->machines) {
if (previous) {
- r = list_machine_one_and_maybe_read_metadata(link, previous, /* more = */ true, p.acquire_metadata);
+ r = list_machine_one_and_maybe_read_metadata(link, previous, /* more= */ true, p.acquire_metadata);
if (r < 0)
return r;
}
}
if (previous)
- return list_machine_one_and_maybe_read_metadata(link, previous, /* more = */ false, p.acquire_metadata);
+ return list_machine_one_and_maybe_read_metadata(link, previous, /* more= */ false, p.acquire_metadata);
return sd_varlink_error(link, VARLINK_ERROR_MACHINE_NO_SUCH_MACHINE, NULL);
}
}
static int vl_method_copy_from(sd_varlink *link, sd_json_variant *parameters, sd_varlink_method_flags_t flags, void *userdata) {
- return vl_method_copy_internal(link, parameters, flags, userdata, /* copy_from = */ true);
+ return vl_method_copy_internal(link, parameters, flags, userdata, /* copy_from= */ true);
}
static int vl_method_copy_to(sd_varlink *link, sd_json_variant *parameters, sd_varlink_method_flags_t flags, void *userdata) {
- return vl_method_copy_internal(link, parameters, flags, userdata, /* copy_from = */ false);
+ return vl_method_copy_internal(link, parameters, flags, userdata, /* copy_from= */ false);
}
static int vl_method_open_root_directory(sd_varlink *link, sd_json_variant *parameters, sd_varlink_method_flags_t flags, void *userdata) {
if (!image_name_is_valid(p.image_name))
return sd_varlink_error_invalid_parameter_name(link, "name");
- r = image_find(m->runtime_scope, IMAGE_MACHINE, p.image_name, /* root = */ NULL, &found);
+ r = image_find(m->runtime_scope, IMAGE_MACHINE, p.image_name, /* root= */ NULL, &found);
if (r == -ENOENT)
return sd_varlink_error(link, VARLINK_ERROR_MACHINE_IMAGE_NO_SUCH_IMAGE, NULL);
if (r < 0)
return log_debug_errno(r, "Failed to find image: %m");
- return list_image_one_and_maybe_read_metadata(m, link, found, /* more = */ false, p.acquire_metadata);
+ return list_image_one_and_maybe_read_metadata(m, link, found, /* more= */ false, p.acquire_metadata);
}
if (!FLAGS_SET(flags, SD_VARLINK_METHOD_MORE))
return sd_varlink_error(link, SD_VARLINK_ERROR_EXPECTED_MORE, NULL);
_cleanup_hashmap_free_ Hashmap *images = NULL;
- r = image_discover(m->runtime_scope, IMAGE_MACHINE, /* root = */ NULL, &images);
+ r = image_discover(m->runtime_scope, IMAGE_MACHINE, /* root= */ NULL, &images);
if (r < 0)
return log_debug_errno(r, "Failed to discover images: %m");
Image *image, *previous = NULL;
HASHMAP_FOREACH(image, images) {
if (previous) {
- r = list_image_one_and_maybe_read_metadata(m, link, previous, /* more = */ true, p.acquire_metadata);
+ r = list_image_one_and_maybe_read_metadata(m, link, previous, /* more= */ true, p.acquire_metadata);
if (r < 0)
return r;
}
}
if (previous)
- return list_image_one_and_maybe_read_metadata(m, link, previous, /* more = */ false, p.acquire_metadata);
+ return list_image_one_and_maybe_read_metadata(m, link, previous, /* more= */ false, p.acquire_metadata);
return sd_varlink_error(link, VARLINK_ERROR_MACHINE_IMAGE_NO_SUCH_IMAGE, NULL);
}
* an error on failure or an empty success message on success. */
if (o->done)
- (void) o->done(o, r, /* error = */ NULL);
+ (void) o->done(o, r, /* error= */ NULL);
else if (r < 0)
(void) sd_varlink_error_errno(o->link, r);
else
_cleanup_free_ char *device = NULL;
if (streq(optarg, "list"))
- return tpm2_list_devices(/* legend = */ true, /* quiet = */ false);
+ return tpm2_list_devices(/* legend= */ true, /* quiet= */ false);
if (!streq(optarg, "auto")) {
device = strdup(optarg);
/* This must be done before openssl_load_private_key() otherwise it will get stuck */
if (arg_certificate) {
if (arg_certificate_source_type == OPENSSL_CERTIFICATE_SOURCE_FILE) {
- r = parse_path_argument(arg_certificate, /*suppress_root=*/ false, &arg_certificate);
+ r = parse_path_argument(arg_certificate, /* suppress_root= */ false, &arg_certificate);
if (r < 0)
return r;
}
if (proc_cmdline_value_missing(key, value))
return 0;
- r = strv_split_and_extend(&arg_proc_cmdline_modules, value, ",", /* filter_duplicates = */ true);
+ r = strv_split_and_extend(&arg_proc_cmdline_modules, value, ",", /* filter_duplicates= */ true);
if (r < 0)
return log_error_errno(r, "Failed to parse modules_load= kernel command line option: %m");
}
return log_error_errno(r, "Failed to initialize libkmod context: %m");
ORDERED_SET_FOREACH(module, module_set) {
- r = module_load_and_warn(ctx, module, /* verbose = */ true);
+ r = module_load_and_warn(ctx, module, /* verbose= */ true);
if (r != -ENOENT)
RET_GATHER(ret, r);
}
assert(sock >= 0);
assert(module);
- bytes = send(sock, module, strlen(module), /* flags = */ 0);
+ bytes = send(sock, module, strlen(module), /* flags= */ 0);
if (bytes < 0)
return log_error_errno(errno, "Failed to send '%s' to thread pool: %m", module);
/* Dequeue one module to be loaded from the socket pair. In case no more
* modules are present, recv() will return 0. */
- bytes = recv(sock, buffer, buffer_len, /* flags = */ 0);
+ bytes = recv(sock, buffer, buffer_len, /* flags= */ 0);
if (bytes == 0)
return 0;
if (bytes < 0)
break;
}
- r = module_load_and_warn(ctx, buffer, /* verbose = */ true);
+ r = module_load_and_warn(ctx, buffer, /* verbose= */ true);
if (r != -ENOENT)
RET_GATHER(ret, r);
}
return log_error_errno(r, "Failed to mask signals for workers: %m");
for (created_threads = 0; created_threads < n_threads; ++created_threads) {
- r = pthread_create(&new_threads[created_threads], /* attr = */ NULL, prober_thread, arg);
+ r = pthread_create(&new_threads[created_threads], /* attr= */ NULL, prober_thread, arg);
if (r != 0) {
log_error_errno(r, "Failed to create worker thread %zu: %m", created_threads);
break;
umask(0022);
- r = proc_cmdline_parse(parse_proc_cmdline_item, /* userdata = */ NULL, PROC_CMDLINE_STRIP_RD_PREFIX);
+ r = proc_cmdline_parse(parse_proc_cmdline_item, /* userdata= */ NULL, PROC_CMDLINE_STRIP_RD_PREFIX);
if (r < 0)
log_warning_errno(r, "Failed to parse kernel command line, ignoring: %m");
STRV_FOREACH(i, arg_proc_cmdline_modules)
RET_GATHER(ret, modules_list_append_dup(&module_set, *i));
- r = conf_files_list_nulstr_full(".conf", /* root = */ NULL,
+ r = conf_files_list_nulstr_full(".conf", /* root= */ NULL,
CONF_FILES_REGULAR | CONF_FILES_FILTER_MASKED,
conf_file_dirs, &files, &n_files);
if (r < 0)
}
/* Create a socketpair for communication with probe workers */
- r = RET_NERRNO(socketpair(AF_UNIX, SOCK_SEQPACKET | SOCK_CLOEXEC, /* protocol = */ 0, pair));
+ r = RET_NERRNO(socketpair(AF_UNIX, SOCK_SEQPACKET | SOCK_CLOEXEC, /* protocol= */ 0, pair));
if (r < 0)
return log_error_errno(r, "Failed to create socket pair: %m");
_cleanup_free_ char *dev_bound = NULL;
r = fstab_filter_options(arg_mount_options, "x-systemd.device-bound\0",
- /* ret_namefound = */ NULL, &dev_bound, /* ret_values = */ NULL, /* ret_filtered = */ NULL);
+ /* ret_namefound= */ NULL, &dev_bound, /* ret_values= */ NULL, /* ret_filtered= */ NULL);
if (r < 0)
return log_error_errno(r, "Failed to parse mount options for x-systemd.device-bound=: %m");
if (r > 0 && !isempty(dev_bound)) {
/* Obtain all mount points with source being "what" from /proc/self/mountinfo, return value shows
* the total number of them. */
- r = libmount_parse_mountinfo(/* source = */ NULL, &table, &iter);
+ r = libmount_parse_mountinfo(/* source= */ NULL, &table, &iter);
if (r < 0)
return log_error_errno(r, "Failed to parse /proc/self/mountinfo: %m");
if (r < 0)
return log_oom();
- r = sd_device_enumerator_add_match_subsystem(e, "block", /* match = */ true);
+ r = sd_device_enumerator_add_match_subsystem(e, "block", /* match= */ true);
if (r < 0)
return log_error_errno(r, "Failed to add subsystem match: %m");
if (r < 0)
return log_error_errno(r, "Failed to add sysname match: %m");
- r = sd_device_enumerator_add_match_sysattr(e, "loop/backing_file", /* value = */ NULL, /* match = */ true);
+ r = sd_device_enumerator_add_match_sysattr(e, "loop/backing_file", /* value= */ NULL, /* match= */ true);
if (r < 0)
return log_error_errno(r, "Failed to add sysattr match: %m");
assert_se(fwrite(data, size, 1, f) == 1);
fflush(f);
- assert_se(manager_new(&manager, /* test_mode = */ true) >= 0);
+ assert_se(manager_new(&manager, /* test_mode= */ true) >= 0);
(void) netdev_load_one(manager, netdev_config, &netdev);
return 0;
}
assert_se(fwrite(data, size, 1, f) == 1);
fflush(f);
- assert_se(manager_new(&manager, /* test_mode = */ true) >= 0);
+ assert_se(manager_new(&manager, /* test_mode= */ true) >= 0);
(void) network_load_one(manager, &manager->networks, network_config);
return 0;
}
if (r < 0)
return r;
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ false))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ false))
return -EBUSY;
}
return link_get_l2tp_local_address(link, t, ret);
HASHMAP_FOREACH(link, netdev->manager->links_by_index) {
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ false))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ false))
continue;
if (link_get_l2tp_local_address(link, t, ret) >= 0)
dest = a ? &a->sa : &b->sa;
- r = unhexmem_full(rvalue, SIZE_MAX, /* secure = */ true, &p, &l);
+ r = unhexmem_full(rvalue, SIZE_MAX, /* secure= */ true, &p, &l);
if (r < 0) {
log_syntax(unit, LOG_WARNING, filename, line, r, "Failed to parse key. Ignoring assignment: %m");
return 0;
Tunnel.SerializeTunneledPackets, config_parse_tristate, 0, offsetof(Tunnel, gre_erspan_sequence)
Tunnel.ISATAP, config_parse_tristate, 0, offsetof(Tunnel, isatap)
Tunnel.External, config_parse_bool, 0, offsetof(Tunnel, external)
-FooOverUDP.Protocol, config_parse_ip_protocol, /* relax = */ true, offsetof(FouTunnel, fou_protocol)
+FooOverUDP.Protocol, config_parse_ip_protocol, /* relax= */ true, offsetof(FouTunnel, fou_protocol)
FooOverUDP.Encapsulation, config_parse_fou_encap_type, 0, offsetof(FouTunnel, fou_encap_type)
FooOverUDP.Port, config_parse_ip_port, 0, offsetof(FouTunnel, port)
FooOverUDP.PeerPort, config_parse_ip_port, 0, offsetof(FouTunnel, peer_port)
assert_not_reached();
}
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ false))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ false))
return -EBUSY;
SET_FOREACH(a, link->addresses) {
}
static bool link_is_ready_to_create_stacked_netdev(Link *link) {
- return check_ready_for_all_sr_iov_ports(link, /* allow_unmanaged = */ false,
+ return check_ready_for_all_sr_iov_ports(link, /* allow_unmanaged= */ false,
link_is_ready_to_create_stacked_netdev_one);
}
dropin_dirname = strjoina(file_basename, ".d");
r = config_parse_many(
- STRV_MAKE_CONST(filename), NETWORK_DIRS, dropin_dirname, /* root = */ NULL,
+ STRV_MAKE_CONST(filename), NETWORK_DIRS, dropin_dirname, /* root= */ NULL,
NETDEV_COMMON_SECTIONS NETDEV_OTHER_SECTIONS,
config_item_perf_lookup, network_netdev_gperf_lookup,
CONFIG_PARSE_WARN,
NETDEV_VTABLE(netdev)->init(netdev);
r = config_parse_many(
- STRV_MAKE_CONST(filename), NETWORK_DIRS, dropin_dirname, /* root = */ NULL,
+ STRV_MAKE_CONST(filename), NETWORK_DIRS, dropin_dirname, /* root= */ NULL,
NETDEV_VTABLE(netdev)->sections,
config_item_perf_lookup, network_netdev_gperf_lookup,
CONFIG_PARSE_WARN,
if (!netdev->filename)
return log_oom();
- log_syntax(/* unit = */ NULL, LOG_DEBUG, filename, /* config_line = */ 0, /* error = */ 0, "Successfully loaded.");
+ log_syntax(/* unit= */ NULL, LOG_DEBUG, filename, /* config_line= */ 0, /* error= */ 0, "Successfully loaded.");
*ret = TAKE_PTR(netdev);
return 0;
VxLan *v = ASSERT_PTR(userdata);
int r;
- r = parse_ip_port_range(rvalue, &v->port_range.low, &v->port_range.high, /* allow_zero = */ false);
+ r = parse_ip_port_range(rvalue, &v->port_range.low, &v->port_range.high, /* allow_zero= */ false);
if (r < 0)
log_syntax(unit, LOG_WARNING, filename, line, r,
"Failed to parse VXLAN port range '%s'. Port should be greater than 0 and less than 65535.", rvalue);
cred_name = startswith(rvalue, "@");
if (cred_name) {
- r = read_credential(cred_name, (void**) &cred, /* ret_size = */ NULL);
+ r = read_credential(cred_name, (void**) &cred, /* ret_size= */ NULL);
if (r == -ENOMEM)
return log_oom();
if (r < 0) {
} else if (!streq(lvalue, "PublicKey"))
(void) warn_file_is_world_accessible(filename, NULL, unit, line);
- r = unbase64mem_full(cred ?: rvalue, SIZE_MAX, /* secure = */ true, &key, &len);
+ r = unbase64mem_full(cred ?: rvalue, SIZE_MAX, /* secure= */ true, &key, &len);
if (r == -ENOMEM)
return log_oom();
if (r < 0) {
cred_name = startswith(rvalue, "@");
if (cred_name) {
- r = read_credential(cred_name, (void**) &cred, /* ret_size = */ NULL);
+ r = read_credential(cred_name, (void**) &cred, /* ret_size= */ NULL);
if (r == -ENOMEM)
return log_oom();
if (r < 0) {
_cleanup_(erase_and_freep) char *cred = NULL;
- r = read_credential(strjoina("network.wireguard.private.", config_name), (void**) &cred, /* ret_size = */ NULL);
+ r = read_credential(strjoina("network.wireguard.private.", config_name), (void**) &cred, /* ret_size= */ NULL);
if (r < 0)
return log_netdev_error_errno(netdev, r,
"%s: No private key specified and default key isn't available, "
_cleanup_(erase_and_freep) void *key = NULL;
size_t len;
- r = unbase64mem_full(cred, SIZE_MAX, /* secure = */ true, &key, &len);
+ r = unbase64mem_full(cred, SIZE_MAX, /* secure= */ true, &key, &len);
if (r < 0)
return log_netdev_error_errno(netdev, r,
"%s: No private key specified and default key cannot be parsed, "
if (!dropin_dirname)
return -ENOMEM;
- r = conf_files_list_dropins(ret_dropins, dropin_dirname, /* root = */ NULL, NETWORK_DIRS);
+ r = conf_files_list_dropins(ret_dropins, dropin_dirname, /* root= */ NULL, NETWORK_DIRS);
if (r < 0)
return r;
}
if (!comment_paths)
return log_oom();
- r = strv_extend_strv(&comment_paths, dropins, /* filter_duplicates = */ false);
+ r = strv_extend_strv(&comment_paths, dropins, /* filter_duplicates= */ false);
if (r < 0)
return log_oom();
if (r < 0)
return bus_log_parse_error(r);
- r = bus_wait_for_jobs_one(w, job_path, /* flags = */ 0, NULL);
+ r = bus_wait_for_jobs_one(w, job_path, /* flags= */ 0, NULL);
if (r == -ENOEXEC) {
log_debug("systemd-udevd is not running, skipping reload.");
return 0;
"Config type 'all' cannot be used with 'edit'.");
r = get_config_files_by_link_config(ifname, type,
- /* ignore_missing = */ false,
+ /* ignore_missing= */ false,
&rtnl,
&path, &dropins);
if (r < 0)
else
return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Network config of unknown type: %s", *name);
- r = get_config_files_by_name(*name, /* allow_masked = */ false, &path, &dropins);
+ r = get_config_files_by_name(*name, /* allow_masked= */ false, &path, &dropins);
if (r == -ERFKILL)
return log_error_errno(r, "Network config '%s' is masked.", *name);
if (r == -ENOENT) {
if (!*first)
putchar('\n');
- r = cat_files(path, dropins, /* flags = */ CAT_FORMAT_HAS_SECTIONS);
+ r = cat_files(path, dropins, /* flags= */ CAT_FORMAT_HAS_SECTIONS);
if (r < 0)
return r;
if (type == _CONFIG_MAX) {
for (LinkConfigType i = 0; i < _CONFIG_MAX; i++) {
- r = cat_files_by_link_one(ifname, i, rtnl, /* ignore_missing = */ true, first);
+ r = cat_files_by_link_one(ifname, i, rtnl, /* ignore_missing= */ true, first);
if (r < 0)
return r;
}
return 0;
}
- return cat_files_by_link_one(ifname, type, rtnl, /* ignore_missing = */ false, first);
+ return cat_files_by_link_one(ifname, type, rtnl, /* ignore_missing= */ false, first);
}
int verb_cat(int argc, char *argv[], void *userdata) {
_cleanup_strv_free_ char **dropins = NULL;
_cleanup_free_ char *path = NULL;
- r = get_config_files_by_name(*name, /* allow_masked = */ false, &path, &dropins);
+ r = get_config_files_by_name(*name, /* allow_masked= */ false, &path, &dropins);
if (r == -ENOENT) {
RET_GATHER(ret, log_error_errno(r, "Cannot find network config file '%s'.", *name));
continue;
if (!first)
putchar('\n');
- r = cat_files(path, dropins, /* flags = */ CAT_FORMAT_HAS_SECTIONS);
+ r = cat_files(path, dropins, /* flags= */ CAT_FORMAT_HAS_SECTIONS);
if (r < 0)
return r;
else
return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Network config of unknown type: %s", *name);
- r = get_config_files_by_name(*name, /* allow_masked = */ true, &config_path, /* ret_dropins = */ NULL);
+ r = get_config_files_by_name(*name, /* allow_masked= */ true, &config_path, /* ret_dropins= */ NULL);
if (r == -ENOENT)
log_warning("No existing network config '%s' found, proceeding anyway.", *name);
else if (r < 0)
else
return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "Network config of unknown type: %s", *name);
- r = get_config_files_by_name(*name, /* allow_masked = */ true, &path, /* ret_dropins = */ NULL);
+ r = get_config_files_by_name(*name, /* allow_masked= */ true, &path, /* ret_dropins= */ NULL);
if (r == -ENOENT) {
log_debug_errno(r, "Network configuration '%s' doesn't exist, skipping.", *name);
continue;
assert(vl);
- r = varlink_call_and_log(vl, "io.systemd.Network.Describe", /* parameters = */ NULL, &v);
+ r = varlink_call_and_log(vl, "io.systemd.Network.Describe", /* parameters= */ NULL, &v);
if (r < 0)
return r;
- r = sd_json_variant_dump(v, arg_json_format_flags, /* f = */ NULL, /* prefix = */ NULL);
+ r = sd_json_variant_dump(v, arg_json_format_flags, /* f= */ NULL, /* prefix= */ NULL);
if (r < 0)
return log_error_errno(r, "Failed to dump json object: %m");
return 0;
assert(vl);
assert(patterns);
- r = varlink_call_and_log(vl, "io.systemd.Network.Describe", /* parameters = */ NULL, &v);
+ r = varlink_call_and_log(vl, "io.systemd.Network.Describe", /* parameters= */ NULL, &v);
if (r < 0)
return r;
(void) sd_bus_set_allow_interactive_authorization(bus, arg_ask_password);
if (networkd_is_running()) {
- r = varlink_connect_networkd(/* ret_varlink = */ NULL);
+ r = varlink_connect_networkd(/* ret_varlink= */ NULL);
if (r < 0)
return r;
} else
if (in6_addr_is_set(&j->address) && !in6_addr_equal(&j->address, &masked))
continue;
- if (generate_stable_private_address(link, app_id, &j->secret_key, &masked, /* previous = */ NULL, &addr) < 0)
+ if (generate_stable_private_address(link, app_id, &j->secret_key, &masked, /* previous= */ NULL, &addr) < 0)
continue;
break;
r = generate_eui64_address(link, &masked, &addr);
} else {
type = ADDRESS_GENERATION_PREFIXSTABLE;
- r = generate_stable_private_address(link, app_id, &SD_ID128_NULL, &masked, /* previous = */ NULL, &addr);
+ r = generate_stable_private_address(link, app_id, &SD_ID128_NULL, &masked, /* previous= */ NULL, &addr);
}
if (r < 0)
return r;
assert(link);
assert(link->manager);
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ false))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ false))
return 0;
if (!link->manager->static_address_labels_configured)
if (IN_SET(link->state, LINK_STATE_FAILED, LINK_STATE_LINGER))
return 0;
- r = address_set_masquerade(address, /* add = */ true);
+ r = address_set_masquerade(address, /* add= */ true);
if (r < 0)
return log_link_warning_errno(link, r, "Could not enable IP masquerading: %m");
address_add_netlabel(address);
- address_modify_nft_set(address, /* add = */ true);
+ address_modify_nft_set(address, /* add= */ true);
if (address_is_ready(address) && address->callback) {
r = address->callback(address);
return r;
}
- link_update_operstate(link, /* also_update_master = */ true);
+ link_update_operstate(link, /* also_update_master= */ true);
link_check_ready(link);
return 0;
}
Link *link = ASSERT_PTR(address->link);
int r;
- r = address_set_masquerade(address, /* add = */ false);
+ r = address_set_masquerade(address, /* add= */ false);
if (r < 0)
log_link_warning_errno(link, r, "Failed to disable IP masquerading, ignoring: %m");
- address_modify_nft_set(address, /* add = */ false);
+ address_modify_nft_set(address, /* add= */ false);
address_del_netlabel(address);
}
}
- link_update_operstate(link, /* also_update_master = */ true);
+ link_update_operstate(link, /* also_update_master= */ true);
link_check_ready(link);
return 0;
}
r, "Could not drop address");
/* If the address cannot be removed, then assume the address is already removed. */
- address_forget(link, address, /* removed_by_us = */ true, "Forgetting");
+ address_forget(link, address, /* removed_by_us= */ true, "Forgetting");
}
return 1;
if (type == RTM_DELADDR) {
if (address)
address_forget(link, address,
- /* removed_by_us = */ FLAGS_SET(address->state, NETWORK_CONFIG_STATE_REMOVING),
+ /* removed_by_us= */ FLAGS_SET(address->state, NETWORK_CONFIG_STATE_REMOVING),
"Forgetting removed");
else
log_address_debug(tmp, "Kernel removed unknown", link);
r = config_parse_in_addr_non_null(
unit, filename, line, section, section_line,
- lvalue, /* ltype = */ AF_INET, rvalue,
- &address->broadcast, /* userdata = */ NULL);
+ lvalue, /* ltype= */ AF_INET, rvalue,
+ &address->broadcast, /* userdata= */ NULL);
if (r <= 0)
return r;
return 1;
}
- r = config_parse_in_addr_prefix(unit, filename, line, section, section_line, lvalue, /* ltype = */ true, rvalue, &prefix, /* userdata = */ NULL);
+ r = config_parse_in_addr_prefix(unit, filename, line, section, section_line, lvalue, /* ltype= */ true, rvalue, &prefix, /* userdata= */ NULL);
if (r <= 0)
return r;
assert(end < BRIDGE_VLAN_BITMAP_MAX);
if (begin == end)
- return add_single(m, begin, untagged, /* is_pvid = */ false, str);
+ return add_single(m, begin, untagged, /* is_pvid= */ false, str);
if (DEBUG_LOGGING)
(void) strextendf_with_separator(str, ",", "%u-%u%s", begin, end, untagged ? "(untagged)" : "");
begin = UINT16_MAX;
}
- r = add_single(m, pvid, pvid_is_untagged, /* is_pvid = */ true, &str);
+ r = add_single(m, pvid, pvid_is_untagged, /* is_pvid= */ true, &str);
if (r < 0)
return r;
if (begin != UINT16_MAX) {
assert(begin < k);
- r = add_range(m, begin, k - 1, /* untagged = */ false, &str);
+ r = add_range(m, begin, k - 1, /* untagged= */ false, &str);
if (r < 0)
return r;
log_link_debug(link, "DHCP-PD addresses and routes set.");
- r = dhcp_pd_remove(link, /* only_marked = */ true);
+ r = dhcp_pd_remove(link, /* only_marked= */ true);
if (r < 0)
return r;
if (link->dhcp_pd_messages == 0) {
link->dhcp_pd_configured = false;
- r = dhcp_pd_remove(link, /* only_marked = */ true);
+ r = dhcp_pd_remove(link, /* only_marked= */ true);
if (r < 0)
return r;
}
assert(uplink->manager);
HASHMAP_FOREACH(link, uplink->manager->links_by_index) {
- if (!dhcp_pd_is_uplink(link, uplink, /* accept_auto = */ true))
+ if (!dhcp_pd_is_uplink(link, uplink, /* accept_auto= */ true))
continue;
- r = dhcp_pd_remove(link, /* only_marked = */ false);
+ r = dhcp_pd_remove(link, /* only_marked= */ false);
if (r < 0)
link_enter_failed(link);
}
- (void) dhcp_pd_remove_unreachable_route(uplink->manager, source, /* only_marked = */ false);
+ (void) dhcp_pd_remove_unreachable_route(uplink->manager, source, /* only_marked= */ false);
set_clear(uplink->dhcp_pd_prefixes);
}
return r;
}
- r = dhcp_pd_assign_subnet_prefix(link, &pd_prefix, pd_prefixlen, lifetime_usec, lifetime_usec, /* is_uplink = */ false);
+ r = dhcp_pd_assign_subnet_prefix(link, &pd_prefix, pd_prefixlen, lifetime_usec, lifetime_usec, /* is_uplink= */ false);
if (r < 0)
return r;
r = dhcp4_request_unreachable_route(uplink, &pd_prefix, pd_prefixlen, lifetime_usec, &server_address);
if (r < 0)
return r;
- (void) dhcp_pd_remove_unreachable_route(uplink->manager, NETWORK_CONFIG_SOURCE_DHCP4, /* only_marked = */ true);
+ (void) dhcp_pd_remove_unreachable_route(uplink->manager, NETWORK_CONFIG_SOURCE_DHCP4, /* only_marked= */ true);
/* Create or update 6rd SIT tunnel device. */
r = dhcp4_pd_create_6rd_tunnel(uplink, dhcp4_pd_6rd_tunnel_create_handler);
/* Then, assign subnet prefixes to downstream interfaces. */
HASHMAP_FOREACH(link, uplink->manager->links_by_index) {
- if (!dhcp_pd_is_uplink(link, uplink, /* accept_auto = */ true))
+ if (!dhcp_pd_is_uplink(link, uplink, /* accept_auto= */ true))
continue;
r = dhcp4_pd_assign_subnet_prefix(link, uplink);
r = dhcp_pd_assign_subnet_prefix(link, &pd_prefix, pd_prefix_len,
lifetime_preferred_usec, lifetime_valid_usec,
- /* is_uplink = */ link == uplink);
+ /* is_uplink= */ link == uplink);
if (r < 0)
return r;
}
return r;
}
- (void) dhcp_pd_remove_unreachable_route(uplink->manager, NETWORK_CONFIG_SOURCE_DHCP6, /* only_marked = */ true);
+ (void) dhcp_pd_remove_unreachable_route(uplink->manager, NETWORK_CONFIG_SOURCE_DHCP6, /* only_marked= */ true);
/* Then, assign subnet prefixes. */
HASHMAP_FOREACH(link, uplink->manager->links_by_index) {
- if (!dhcp_pd_is_uplink(link, uplink, /* accept_auto = */ true))
+ if (!dhcp_pd_is_uplink(link, uplink, /* accept_auto= */ true))
continue;
r = dhcp6_pd_assign_subnet_prefixes(link, uplink);
return 0; /* .network file is unchanged. It is not necessary to reconfigure the client. */
if (!link_dhcp_pd_is_enabled(link)) /* Disabled now, drop all configs. */
- return dhcp_pd_remove(link, /* only_marked = */ false);
+ return dhcp_pd_remove(link, /* only_marked= */ false);
/* If previously explicitly disabled, then there is nothing we need to drop.
* If this is called on start up, we do not know the previous settings, assume nothing changed. */
link->network->dhcp_pd_route_metric != network->dhcp_pd_route_metric ||
link->network->dhcp_pd_uplink_index != network->dhcp_pd_uplink_index ||
!streq_ptr(link->network->dhcp_pd_uplink_name, network->dhcp_pd_uplink_name))
- return dhcp_pd_remove(link, /* only_marked = */ false);
+ return dhcp_pd_remove(link, /* only_marked= */ false);
return 0;
}
assert(link->network);
assert(link->network->dhcp_server_address);
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ false))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ false))
return false;
if (!link_has_carrier(link))
log_link_debug(link, "DHCPv4 address and routes set.");
/* New address and routes are configured now. Let's release old lease. */
- r = dhcp4_remove_address_and_routes(link, /* only_marked = */ true);
+ r = dhcp4_remove_address_and_routes(link, /* only_marked= */ true);
if (r < 0)
return r;
assert(link);
assert(link->dhcp_lease);
- r = dhcp4_request_prefix_route(link, /* rt = */ NULL);
+ r = dhcp4_request_prefix_route(link, /* rt= */ NULL);
if (r < 0)
return log_link_error_errno(link, r, "DHCP error: Could not request prefix route: %m");
sd_dhcp_lease_has_6rd(link->dhcp_lease))
dhcp4_pd_prefix_lost(link);
- RET_GATHER(r, dhcp4_remove_address_and_routes(link, /* only_marked = */ false));
+ RET_GATHER(r, dhcp4_remove_address_and_routes(link, /* only_marked= */ false));
RET_GATHER(r, dhcp_reset_mtu(link));
RET_GATHER(r, dhcp_reset_hostname(link));
if (link_has_ipv6_connectivity(link))
return 0;
- return dhcp4_start_full(link, /* set_ipv6_connectivity = */ false);
+ return dhcp4_start_full(link, /* set_ipv6_connectivity= */ false);
}
int dhcp4_start_full(Link *link, bool set_ipv6_connectivity) {
assert(link);
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ false))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ false))
return 0;
r = dhcp4_configure_duid(link);
* client was enabled on the previous invocation of networkd, but when it is restarted, a new
* .network file may match to the interface, and DHCPv4 client may be disabled. In that case,
* the DHCPv4 client is not running, hence sd_dhcp_client_stop() in the above does nothing. */
- RET_GATHER(ret, dhcp4_remove_address_and_routes(link, /* only_marked = */ false));
+ RET_GATHER(ret, dhcp4_remove_address_and_routes(link, /* only_marked= */ false));
}
if (link->dhcp_client && link->network->dhcp_use_bootp &&
return link->network->dhcp6_client_start_mode;
/* When this interface itself is an uplink interface, then start dhcp6 client in solicit mode. */
- if (dhcp_pd_is_uplink(link, link, /* accept_auto = */ false))
+ if (dhcp_pd_is_uplink(link, link, /* accept_auto= */ false))
return DHCP6_CLIENT_START_MODE_SOLICIT;
/* Otherwise, start dhcp6 client when RA is received. */
link->dhcp6_configured = true;
log_link_debug(link, "DHCPv6 addresses and routes set.");
- r = dhcp6_remove(link, /* only_marked = */ true);
+ r = dhcp6_remove(link, /* only_marked= */ true);
if (r < 0)
return r;
if (link->dhcp6_messages == 0) {
link->dhcp6_configured = true;
- r = dhcp6_remove(link, /* only_marked = */ true);
+ r = dhcp6_remove(link, /* only_marked= */ true);
if (r < 0)
return r;
} else
link->dhcp6_lease = sd_dhcp6_lease_unref(link->dhcp6_lease);
- r = dhcp6_remove(link, /* only_marked = */ false);
+ r = dhcp6_remove(link, /* only_marked= */ false);
if (r < 0)
return r;
assert(link);
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ false))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ false))
return 0;
r = dhcp_configure_duid(link, link_get_dhcp6_duid(link));
ret = sd_dhcp6_client_stop(link->dhcp6_client);
/* Also explicitly drop DHCPv6 addresses and routes. See also link_drop_dhcp4_config(). */
- RET_GATHER(ret, dhcp6_remove(link, /* only_marked = */ false));
+ RET_GATHER(ret, dhcp6_remove(link, /* only_marked= */ false));
}
/* Even if the client is currently enabled and also enabled in the new .network file, detailed
switch (event) {
case SD_IPV4ACD_EVENT_STOP:
if (address->source == NETWORK_CONFIG_SOURCE_STATIC) {
- r = static_ipv4acd_address_remove(link, address, /* on_conflict = */ false);
+ r = static_ipv4acd_address_remove(link, address, /* on_conflict= */ false);
if (r < 0)
link_enter_failed(link);
}
log_link_warning(link, "Dropping address %s, as an address conflict was detected.", IN4_ADDR_TO_STRING(&address->in_addr.in));
if (address->source == NETWORK_CONFIG_SOURCE_STATIC)
- r = static_ipv4acd_address_remove(link, address, /* on_conflict = */ true);
+ r = static_ipv4acd_address_remove(link, address, /* on_conflict= */ true);
else
r = dhcp4_address_on_conflict(link);
if (r < 0)
if (!link_has_carrier(link))
return 0;
- return sd_ipv4acd_start(acd, /* reset_conflicts = */ true);
+ return sd_ipv4acd_start(acd, /* reset_conflicts= */ true);
}
int ipv4acd_configure(Link *link, const Address *address) {
log_nexthop_debug(nexthop, "Serializing", manager);
}
- r = nexthop_append_json(nexthop, /* serializing = */ ifindex < 0, &array);
+ r = nexthop_append_json(nexthop, /* serializing= */ ifindex < 0, &array);
if (r < 0)
return r;
}
if (r < 0)
return r;
- r = manager_get_route_table_to_string(route->manager, route->table, /* append_num = */ false, &table);
+ r = manager_get_route_table_to_string(route->manager, route->table, /* append_num= */ false, &table);
if (r < 0)
return r;
log_route_debug(route, "Serializing", manager);
}
- r = route_append_json(route, /* serializing = */ ifindex < 0, &array);
+ r = route_append_json(route, /* serializing= */ ifindex < 0, &array);
if (r < 0)
return r;
}
assert(rule->manager);
assert(array);
- r = manager_get_route_table_to_string(rule->manager, rule->table, /* append_num = */ false, &table);
+ r = manager_get_route_table_to_string(rule->manager, rule->table, /* append_num= */ false, &table);
if (r < 0 && r != -EINVAL)
return r;
if (r < 0)
return r;
- r = domains_append_json(link, /* is_route = */ false, &v);
+ r = domains_append_json(link, /* is_route= */ false, &v);
if (r < 0)
return r;
- r = domains_append_json(link, /* is_route = */ true, &v);
+ r = domains_append_json(link, /* is_route= */ true, &v);
if (r < 0)
return r;
if (r < 0)
return r;
- r = addresses_append_json(link, /* serializing = */ false, &v);
+ r = addresses_append_json(link, /* serializing= */ false, &v);
if (r < 0)
return r;
if (r < 0)
return r;
- r = nexthops_append_json(manager, /* ifindex = */ 0, &v);
+ r = nexthops_append_json(manager, /* ifindex= */ 0, &v);
if (r < 0)
return r;
- r = routes_append_json(manager, /* ifindex = */ 0, &v);
+ r = routes_append_json(manager, /* ifindex= */ 0, &v);
if (r < 0)
return r;
strv_free_and_replace(l->ntp, ntp);
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
free_and_replace(l->dns, dns);
l->n_dns = n;
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
l->search_domains = TAKE_PTR(search_domains);
l->route_domains = TAKE_PTR(route_domains);
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
if (l->dns_default_route != b) {
l->dns_default_route = b;
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
}
if (l->llmnr != mode) {
l->llmnr = mode;
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
}
if (l->mdns != mode) {
l->mdns = mode;
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
}
if (l->dns_over_tls_mode != mode) {
l->dns_over_tls_mode = mode;
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
}
if (l->dnssec_mode != mode) {
l->dnssec_mode = mode;
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
}
set_free_and_replace(l->dnssec_negative_trust_anchors, ns);
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
link_ntp_settings_clear(l);
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
link_dns_settings_clear(l);
- r = link_save_and_clean_full(l, /* also_save_manager = */ true);
+ r = link_save_and_clean_full(l, /* also_save_manager= */ true);
if (r < 0)
return r;
if (r == 0)
return 1; /* Polkit will call us back */
- r = link_reconfigure_full(l, LINK_RECONFIGURE_UNCONDITIONALLY | LINK_RECONFIGURE_CLEANLY, message, /* counter = */ NULL);
+ r = link_reconfigure_full(l, LINK_RECONFIGURE_UNCONDITIONALLY | LINK_RECONFIGURE_CLEANLY, message, /* counter= */ NULL);
if (r != 0)
return r; /* Will reply later when r > 0. */
if (r < 0)
RET_GATHER(ret, log_link_warning_errno(link, r, "Could not stop DHCPv6 client: %m"));
- r = dhcp_pd_remove(link, /* only_marked = */ false);
+ r = dhcp_pd_remove(link, /* only_marked= */ false);
if (r < 0)
RET_GATHER(ret, log_link_warning_errno(link, r, "Could not remove DHCPv6 PD addresses and routes: %m"));
return;
stop:
- (void) link_stop_engines(link, /* may_keep_dynamic = */ false);
+ (void) link_stop_engines(link, /* may_keep_dynamic= */ false);
}
void link_check_ready(Link *link) {
link_check_addresses_ready(link, NETWORK_CONFIG_SOURCE_NDISC));
/* If the uplink for PD is self, then request the corresponding DHCP protocol is also ready. */
- if (dhcp_pd_is_uplink(link, link, /* accept_auto = */ false)) {
+ if (dhcp_pd_is_uplink(link, link, /* accept_auto= */ false)) {
if (link_dhcp4_enabled(link) && link->network->dhcp_use_6rd &&
sd_dhcp_lease_has_6rd(link->dhcp_lease)) {
if (!link->dhcp4_configured)
}
if (!required_up && link_is_up)
- return link_request_to_bring_up_or_down(link, /* up = */ false);
+ return link_request_to_bring_up_or_down(link, /* up= */ false);
if (required_up && !link_is_up)
- return link_request_to_bring_up_or_down(link, /* up = */ true);
+ return link_request_to_bring_up_or_down(link, /* up= */ true);
return 0;
}
if (r < 0)
return r;
- r = link_request_to_set_mac(link, /* allow_retry = */ true);
+ r = link_request_to_set_mac(link, /* allow_retry= */ true);
if (r < 0)
return r;
log_link_full(link, link->state == LINK_STATE_INITIALIZED ? LOG_DEBUG : LOG_INFO,
"Unmanaging interface.");
- (void) link_stop_engines(link, /* may_keep_dynamic = */ false);
+ (void) link_stop_engines(link, /* may_keep_dynamic= */ false);
(void) link_drop_requests(link);
(void) link_drop_static_config(link);
} else {
/* Otherwise, stop DHCP client and friends unconditionally, and drop all dynamic
* configurations like DHCP address and routes. */
- r = link_stop_engines(link, /* may_keep_dynamic = */ false);
+ r = link_stop_engines(link, /* may_keep_dynamic= */ false);
if (r < 0)
return r;
return r;
}
- return link_reconfigure_impl(link, /* flags = */ 0);
+ return link_reconfigure_impl(link, /* flags= */ 0);
}
static int link_initialized_handler(sd_netlink *rtnl, sd_netlink_message *m, Link *link) {
log_link_warning_errno(link, r, "Failed to manage SR-IOV PF and VF ports, ignoring: %m");
if (link->state != LINK_STATE_PENDING)
- return link_reconfigure(link, /* flags = */ 0);
+ return link_reconfigure(link, /* flags= */ 0);
log_link_debug(link, "udev initialized link");
if (!link->network)
return ret;
- RET_GATHER(ret, link_stop_engines(link, /* may_keep_dynamic = */ false));
+ RET_GATHER(ret, link_stop_engines(link, /* may_keep_dynamic= */ false));
RET_GATHER(ret, link_drop_static_config(link));
return ret;
if (link->activated && link->network->activation_policy == ACTIVATION_POLICY_ALWAYS_DOWN) {
log_link_info(link, "Activation policy is \"always-down\", forcing link down.");
- return link_request_to_bring_up_or_down(link, /* up = */ false);
+ return link_request_to_bring_up_or_down(link, /* up= */ false);
}
/* We set the ipv6 mtu after the device mtu, but the kernel resets
if (link->activated && link->network->activation_policy == ACTIVATION_POLICY_ALWAYS_UP) {
log_link_info(link, "Activation policy is \"always-up\", forcing link up.");
- return link_request_to_bring_up_or_down(link, /* up = */ true);
+ return link_request_to_bring_up_or_down(link, /* up= */ true);
}
return 0;
if (manager->enumerating)
return 0;
- r = link_reconfigure_impl(link, /* flags = */ 0);
+ r = link_reconfigure_impl(link, /* flags= */ 0);
if (r < 0) {
log_link_warning_errno(link, r, "Failed to reconfigure interface: %m");
link_enter_failed(link);
assert(parameters);
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
assert(ret_varlink_fd);
assert(ret_resolve_hook_fd);
- n = sd_listen_fds_with_names(/* unset_environment = */ true, &names);
+ n = sd_listen_fds_with_names(/* unset_environment= */ true, &names);
if (n < 0)
return n;
Link *link;
HASHMAP_FOREACH(link, manager->links_by_index)
- (void) link_stop_engines(link, /* may_keep_dynamic = */ true);
+ (void) link_stop_engines(link, /* may_keep_dynamic= */ true);
return 0;
}
static int signal_reload_callback(sd_event_source *s, const struct signalfd_siginfo *si, void *userdata) {
Manager *m = ASSERT_PTR(userdata);
- (void) manager_reload(m, /* message = */ NULL);
+ (void) manager_reload(m, /* message= */ NULL);
return 0;
}
}
HASHMAP_FOREACH(link, m->links_by_index)
- (void) link_reconfigure_full(link, /* flags = */ 0, message,
- /* counter = */ message ? &m->reloading : NULL);
+ (void) link_reconfigure_full(link, /* flags= */ 0, message,
+ /* counter= */ message ? &m->reloading : NULL);
log_debug("Reloaded.");
r = 0;
if (r < 0)
return r;
- r = ndisc_set_route_nexthop(route, link, /* request = */ true);
+ r = ndisc_set_route_nexthop(route, link, /* request= */ true);
if (r < 0)
return r;
assert(link);
assert(link->manager);
- r = ndisc_set_route_nexthop(route, link, /* request = */ false);
+ r = ndisc_set_route_nexthop(route, link, /* request= */ false);
if (r < 0)
return r;
if (r < 0)
return r;
- r = ndisc_drop_outdated(link, /* router = */ NULL, now_usec);
+ r = ndisc_drop_outdated(link, /* router= */ NULL, now_usec);
if (r < 0)
return r;
assert_se(sd_event_now(link->manager->event, CLOCK_BOOTTIME, &now_usec) >= 0);
- (void) ndisc_drop_outdated(link, /* router = */ NULL, now_usec);
+ (void) ndisc_drop_outdated(link, /* router= */ NULL, now_usec);
(void) ndisc_setup_expire(link);
return 0;
}
case IPV6_ACCEPT_RA_START_DHCP6_CLIENT_ALWAYS:
/* When IPv6AcceptRA.DHCPv6Client=always, start dhcp6 client in solicit mode
* even if the router flags have neither M nor O flags. */
- r = dhcp6_start_on_ra(link, /* information_request = */ false);
+ r = dhcp6_start_on_ra(link, /* information_request= */ false);
break;
default:
if (r < 0)
return r;
- r = ndisc_drop_outdated(link, /* router = */ NULL, timestamp_usec);
+ r = ndisc_drop_outdated(link, /* router= */ NULL, timestamp_usec);
if (r < 0)
return r;
if (r < 0)
return r;
- r = ndisc_router_process_options(link, rt, /* zero_lifetime = */ true);
+ r = ndisc_router_process_options(link, rt, /* zero_lifetime= */ true);
if (r < 0)
return r;
if (r < 0)
return r;
- r = ndisc_router_process_options(link, rt, /* zero_lifetime = */ false);
+ r = ndisc_router_process_options(link, rt, /* zero_lifetime= */ false);
if (r < 0)
return r;
assert(link);
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ false))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ false))
return 0;
r = ndisc_configure(link);
/* Redirect messages will be ignored. Drop configurations based on the previously received redirect
* messages. */
if (!network->ndisc_use_redirect)
- (void) ndisc_drop_redirect(link, /* router = */ NULL);
+ (void) ndisc_drop_redirect(link, /* router= */ NULL);
/* If one of the route setting is changed, drop all routes. */
if (link->network->ndisc_use_gateway != network->ndisc_use_gateway ||
assert(link);
/* Remove all addresses, routes, RDNSS, DNSSL, DNR, and Captive Portal entries, without exception. */
- (void) ndisc_drop_outdated(link, /* router = */ NULL, /* timestamp_usec = */ USEC_INFINITY);
- (void) ndisc_drop_redirect(link, /* router = */ NULL);
+ (void) ndisc_drop_outdated(link, /* router= */ NULL, /* timestamp_usec= */ USEC_INFINITY);
+ (void) ndisc_drop_redirect(link, /* router= */ NULL);
link->ndisc_routers_by_sender = hashmap_free(link->ndisc_routers_by_sender);
link->ndisc_rdnss = set_free(link->ndisc_rdnss);
if (!neighbor_exists(neighbor))
continue;
- if (!link_should_mark_config(link, /* only_static = */ false, neighbor->source, RTPROT_STATIC))
+ if (!link_should_mark_config(link, /* only_static= */ false, neighbor->source, RTPROT_STATIC))
continue;
neighbor_mark(neighbor);
};
r = config_parse_many(
- STRV_MAKE_CONST(filename), NETWORK_DIRS, dropin_dirname, /* root = */ NULL,
+ STRV_MAKE_CONST(filename), NETWORK_DIRS, dropin_dirname, /* root= */ NULL,
"Match\0"
"Link\0"
"SR-IOV\0"
return log_warning_errno(r, "%s: Failed to store configuration into hashmap: %m", filename);
TAKE_PTR(network);
- log_syntax(/* unit = */ NULL, LOG_DEBUG, filename, /* config_line = */ 0, /* error = */ 0, "Successfully loaded.");
+ log_syntax(/* unit= */ NULL, LOG_DEBUG, filename, /* config_line= */ 0, /* error= */ 0, "Successfully loaded.");
return 0;
}
int link_drop_nexthops(Link *link, bool only_static);
static inline int link_drop_unmanaged_nexthops(Link *link) {
- return link_drop_nexthops(link, /* only_static = */ false);
+ return link_drop_nexthops(link, /* only_static= */ false);
}
static inline int link_drop_static_nexthops(Link *link) {
- return link_drop_nexthops(link, /* only_static = */ true);
+ return link_drop_nexthops(link, /* only_static= */ true);
}
void link_forget_nexthops(Link *link);
n_dns,
dns,
link->network->router_dns_lifetime_usec,
- /* valid_until = */ USEC_INFINITY);
+ /* valid_until= */ USEC_INFINITY);
}
static int radv_set_domains(Link *link, Link *uplink) {
link->radv,
s,
link->network->router_dns_lifetime_usec,
- /* valid_until = */ USEC_INFINITY);
+ /* valid_until= */ USEC_INFINITY);
}
static int radv_find_uplink(Link *link, Link **ret) {
link->radv,
link->network->router_home_agent_preference,
link->network->home_agent_lifetime_usec,
- /* valid_until = */ USEC_INFINITY);
+ /* valid_until= */ USEC_INFINITY);
if (r < 0)
return r;
}
assert(link);
assert(link->network);
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ false))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ false))
return false;
if (in6_addr_is_null(&link->ipv6ll_address))
if (metric->n_metrics_set > attr)
metric->metrics_set[attr] = false;
- assert_se(route_metric_set_full(metric, attr, 0, /* force = */ false) >= 0);
+ assert_se(route_metric_set_full(metric, attr, 0, /* force= */ false) >= 0);
}
uint32_t route_metric_get(const RouteMetric *metric, uint16_t attr) {
&route->metric,
ltype,
k,
- /* force = */ true) < 0)
+ /* force= */ true) < 0)
return log_oom();
return 1;
}
static void route_nexthop_hash_func(const RouteNextHop *nh, struct siphash *state) {
- route_nexthop_hash_func_full(nh, state, /* with_weight = */ true);
+ route_nexthop_hash_func_full(nh, state, /* with_weight= */ true);
}
static int route_nexthop_compare_func(const RouteNextHop *a, const RouteNextHop *b) {
- return route_nexthop_compare_func_full(a, b, /* with_weight = */ true);
+ return route_nexthop_compare_func_full(a, b, /* with_weight= */ true);
}
DEFINE_PRIVATE_HASH_OPS_WITH_KEY_DESTRUCTOR(
return;
case 1:
- route_nexthop_hash_func_full(&route->nexthop, state, /* with_weight = */ false);
+ route_nexthop_hash_func_full(&route->nexthop, state, /* with_weight= */ false);
return;
default: {
return CMP(a->nexthop_id, b->nexthop_id);
case 1:
- return route_nexthop_compare_func_full(&a->nexthop, &b->nexthop, /* with_weight = */ false);
+ return route_nexthop_compare_func_full(&a->nexthop, &b->nexthop, /* with_weight= */ false);
default: {
RouteNextHop *nh;
if (route_nexthop_get_link(manager, nh, &link) < 0)
return false;
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ true))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ true))
return false;
/* If the interface is not managed by us, we request that the interface has carrier.
/* The kernel internally stores these maximum size in int. */
- if (sysctl_read_ip_property_int(AF_INET, /* ifname = */ NULL, "route/max_size", &val4) >= 0)
+ if (sysctl_read_ip_property_int(AF_INET, /* ifname= */ NULL, "route/max_size", &val4) >= 0)
if (val4 == INT_MAX)
/* This is the default "no limit" value in the kernel */
val4 = ROUTES_DEFAULT_MAX_PER_FAMILY;
- if (sysctl_read_ip_property_int(AF_INET6, /* ifname = */ NULL, "route/max_size", &val6) >= 0)
+ if (sysctl_read_ip_property_int(AF_INET6, /* ifname= */ NULL, "route/max_size", &val6) >= 0)
if (val6 == INT_MAX)
/* This is the default "no limit" value in the kernel */
val6 = ROUTES_DEFAULT_MAX_PER_FAMILY;
if (in_addr_is_set(route->family, &route->prefsrc))
(void) in_addr_to_string(route->family, &route->prefsrc, &prefsrc);
(void) route_scope_to_string_alloc(route->scope, &scope);
- (void) manager_get_route_table_to_string(manager, route->table, /* append_num = */ true, &table);
+ (void) manager_get_route_table_to_string(manager, route->table, /* append_num= */ true, &table);
(void) route_protocol_full_to_string_alloc(route->protocol, &proto);
(void) route_flags_to_string_alloc(route->flags, &flags);
assert(route);
assert(link);
- if (!link_is_ready_to_configure(link, /* allow_unmanaged = */ false))
+ if (!link_is_ready_to_configure(link, /* allow_unmanaged= */ false))
return false;
if (in_addr_is_set(route->family, &route->prefsrc) > 0) {
}
static int routing_policy_rule_compare_func(const RoutingPolicyRule *a, const RoutingPolicyRule *b) {
- return routing_policy_rule_compare_func_full(a, b, /* all = */ true);
+ return routing_policy_rule_compare_func_full(a, b, /* all= */ true);
}
static bool routing_policy_rule_equal(const RoutingPolicyRule *a, const RoutingPolicyRule *b, int family, uint32_t priority) {
if (b->priority_set && b->priority != priority)
return false;
- return routing_policy_rule_compare_func_full(a, b, /* all = */ false) == 0;
+ return routing_policy_rule_compare_func_full(a, b, /* all= */ false) == 0;
}
static bool routing_policy_rule_can_update(const RoutingPolicyRule *existing, const RoutingPolicyRule *requesting) {
return;
(void) network_config_state_to_string_alloc(rule->state, &state);
- (void) manager_get_route_table_to_string(m, rule->table, /* append_num = */ true, &table);
+ (void) manager_get_route_table_to_string(m, rule->table, /* append_num= */ true, &table);
log_link_debug(link,
"%s %s routing policy rule (%s): priority: %"PRIu32", %s -> %s, iif: %s, oif: %s, table: %s",
* shows [detached] for such rules, that may confuse users. Let's postpone to configure if one of
* IIF/OIF does not exist. */
- if (rule->iif && !link_is_ready_to_configure_by_name(link->manager, rule->iif, /* allow_unmanaged = */ true))
+ if (rule->iif && !link_is_ready_to_configure_by_name(link->manager, rule->iif, /* allow_unmanaged= */ true))
return false;
- if (rule->oif && !link_is_ready_to_configure_by_name(link->manager, rule->oif, /* allow_unmanaged = */ true))
+ if (rule->oif && !link_is_ready_to_configure_by_name(link->manager, rule->oif, /* allow_unmanaged= */ true))
return false;
return true;
assert(rvalue);
- r = parse_ip_port_range(rvalue, &p->start, &p->end, /* allow_zero = */ false);
+ r = parse_ip_port_range(rvalue, &p->start, &p->end, /* allow_zero= */ false);
if (r < 0) {
log_syntax(unit, LOG_WARNING, filename, line, r, "Failed to parse routing policy rule port range '%s'", rvalue);
return 0;
if (r < 0)
return r;
- r = addresses_append_json(link, /* serializing = */ true, &e);
+ r = addresses_append_json(link, /* serializing= */ true, &e);
if (r < 0)
return r;
if (r < 0)
return r;
- r = nexthops_append_json(manager, /* ifindex = */ -1, &v);
+ r = nexthops_append_json(manager, /* ifindex= */ -1, &v);
if (r < 0)
return r;
- r = routes_append_json(manager, /* ifindex = */ -1, &v);
+ r = routes_append_json(manager, /* ifindex= */ -1, &v);
if (r < 0)
return r;
}
_cleanup_free_ char *dump = NULL;
- r = sd_json_variant_format(v, /* flags = */ 0, &dump);
+ r = sd_json_variant_format(v, /* flags= */ 0, &dump);
if (r < 0)
return r;
unsigned err_line = 0, err_column = 0;
r = sd_json_parse_file(
f,
- /* path = */ NULL,
- /* flags = */ 0,
+ /* path= */ NULL,
+ /* flags= */ 0,
&v,
&err_line,
&err_column);
static int link_set_addrgen_mode_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
int r;
- r = set_link_handler_internal(rtnl, m, req, link, /* ignore = */ true, NULL);
+ r = set_link_handler_internal(rtnl, m, req, link, /* ignore= */ true, NULL);
if (r <= 0)
return r;
}
static int link_set_bond_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ false, NULL);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ false, NULL);
}
static int link_set_bridge_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ true, NULL);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ true, NULL);
}
static int link_set_bridge_vlan_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
assert(link);
- r = set_link_handler_internal(rtnl, m, req, link, /* ignore = */ false, NULL);
+ r = set_link_handler_internal(rtnl, m, req, link, /* ignore= */ false, NULL);
if (r <= 0)
return r;
}
static int link_del_bridge_vlan_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ false, NULL);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ false, NULL);
}
static int link_set_can_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ false, NULL);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ false, NULL);
}
static int link_set_flags_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ false, get_link_default_handler);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ false, get_link_default_handler);
}
static int link_set_group_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ false, NULL);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ false, NULL);
}
static int link_set_ipoib_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ true, NULL);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ true, NULL);
}
static int link_set_mac_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ true, get_link_default_handler);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ true, get_link_default_handler);
}
static int link_set_mac_allow_retry_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
log_link_message_debug_errno(link, m, r, "Failed to set MAC address, retrying again");
- r = link_request_to_set_mac(link, /* allow_retry = */ false);
+ r = link_request_to_set_mac(link, /* allow_retry= */ false);
if (r < 0)
link_enter_failed(link);
}
static int link_set_master_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ false, get_link_master_handler);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ false, get_link_master_handler);
}
static int link_unset_master_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
/* Some devices do not support setting master ifindex. Let's ignore error on unsetting master ifindex. */
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ true, get_link_master_handler);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ true, get_link_master_handler);
}
static int link_set_mtu_handler(sd_netlink *rtnl, sd_netlink_message *m, Request *req, Link *link, void *userdata) {
- return set_link_handler_internal(rtnl, m, req, link, /* ignore = */ true, get_link_default_handler);
+ return set_link_handler_internal(rtnl, m, req, link, /* ignore= */ true, get_link_default_handler);
}
static int link_get_arp(Link *link) {
return r;
break;
case REQUEST_TYPE_SET_LINK_BRIDGE_VLAN:
- r = bridge_vlan_set_message(link, req, /* is_set = */ true);
+ r = bridge_vlan_set_message(link, req, /* is_set= */ true);
if (r < 0)
return r;
break;
case REQUEST_TYPE_DEL_LINK_BRIDGE_VLAN:
- r = bridge_vlan_set_message(link, req, /* is_set = */ false);
+ r = bridge_vlan_set_message(link, req, /* is_set= */ false);
if (r < 0)
return r;
break;
return 0;
link->requested_hw_addr = link->network->hw_addr;
- r = net_verify_hardware_address(link->ifname, /* is_static = */ true,
+ r = net_verify_hardware_address(link->ifname, /* is_static= */ true,
link->iftype, &link->hw_addr, &link->requested_hw_addr);
if (r < 0)
return r;
if (master->state == LINK_STATE_UNMANAGED) {
/* If the DSA master interface is unmanaged, then it will never become up.
* Let's request to bring up the master. */
- r = link_request_to_bring_up_or_down(master, /* up = */ true);
+ r = link_request_to_bring_up_or_down(master, /* up= */ true);
if (r < 0)
return r;
}
- r = link_request_to_bring_up_or_down(link, /* up = */ true);
+ r = link_request_to_bring_up_or_down(link, /* up= */ true);
if (r < 0)
return r;
static bool link_is_ready_to_activate(Link *link, bool up) {
assert(link);
- if (!check_ready_for_all_sr_iov_ports(link, /* allow_unmanaged = */ false,
+ if (!check_ready_for_all_sr_iov_ports(link, /* allow_unmanaged= */ false,
link_is_ready_to_activate_one))
return false;
}
static int link_up_now_handler(sd_netlink *rtnl, sd_netlink_message *m, Link *link) {
- return link_up_or_down_now_handler(rtnl, m, link, /* up = */ true);
+ return link_up_or_down_now_handler(rtnl, m, link, /* up= */ true);
}
static int link_down_now_handler(sd_netlink *rtnl, sd_netlink_message *m, Link *link) {
- return link_up_or_down_now_handler(rtnl, m, link, /* up = */ false);
+ return link_up_or_down_now_handler(rtnl, m, link, /* up= */ false);
}
int link_up_or_down_now(Link *link, bool up) {
/* If this is a VF port, then also check the PF port. */
if (link->sr_iov_phys_port_ifindex > 0) {
if (link_get_by_index(link->manager, link->sr_iov_phys_port_ifindex, &phys_link) < 0 ||
- !check_one(phys_link, /* allow_unmanaged = */ true))
+ !check_one(phys_link, /* allow_unmanaged= */ true))
return false;
} else
phys_link = link;
if (link_get_by_index(link->manager, ifindex, &virt_link) < 0)
return false;
- if (!check_one(virt_link, /* allow_unmanaged = */ true))
+ if (!check_one(virt_link, /* allow_unmanaged= */ true))
return false;
}
if (r < 0)
return r;
- r = link_put_domains(link, /* is_route = */ false, &search_domains);
+ r = link_put_domains(link, /* is_route= */ false, &search_domains);
if (r < 0)
return r;
- r = link_put_domains(link, /* is_route = */ true, &route_domains);
+ r = link_put_domains(link, /* is_route= */ true, &route_domains);
if (r < 0)
return r;
}
if (!IN_SET(link->state, LINK_STATE_CONFIGURING, LINK_STATE_CONFIGURED))
return 0;
- if (sd_event_source_get_enabled(link->ipv6_mtu_wait_synced_event_source, /* ret = */ NULL) > 0) {
+ if (sd_event_source_get_enabled(link->ipv6_mtu_wait_synced_event_source, /* ret= */ NULL) > 0) {
log_link_debug(link, "Waiting for IPv6 MTU is synced to link MTU, delaying to set IPv6 MTU.");
return 0;
}
link->manager->event, &link->ipv6_mtu_wait_synced_event_source,
CLOCK_BOOTTIME, 100 * USEC_PER_MSEC, 0,
ipv6_mtu_wait_synced_handler, link,
- /* priority = */ 0, "ipv6-mtu-wait-synced", /* force_reset = */ true);
+ /* priority= */ 0, "ipv6-mtu-wait-synced", /* force_reset= */ true);
if (r < 0)
return log_link_warning_errno(link, r, "Failed to configure timer event source for waiting for IPv6 MTU being synced: %m");
* To make SSID= or other WiFi related settings in [Match] section work, let's try to
* reconfigure the interface. */
if (link->ssid && link_has_carrier(link)) {
- r = link_reconfigure_impl(link, /* flags = */ 0);
+ r = link_reconfigure_impl(link, /* flags= */ 0);
if (r < 0) {
log_link_warning_errno(link, r, "Failed to reconfigure interface: %m");
link_enter_failed(link);
}
/* If necessary, reconfigure based on those new properties */
- r = link_reconfigure_impl(link, /* flags = */ 0);
+ r = link_reconfigure_impl(link, /* flags= */ 0);
if (r < 0) {
log_link_warning_errno(link, r, "Failed to reconfigure interface: %m");
link_enter_failed(link);
log_warning_errno(r, "Could not create directory '%s': %m", p);
}
- r = manager_new(&m, /* test_mode = */ false);
+ r = manager_new(&m, /* test_mode= */ false);
if (r < 0)
return log_error_errno(r, "Could not create manager: %m");
if (link_get_by_name(link->manager, qdisc->tca_kind, &teql) < 0)
return false;
- return link_is_ready_to_configure(teql, /* allow_unmanaged = */ true);
+ return link_is_ready_to_configure(teql, /* allow_unmanaged= */ true);
}
const QDiscVTable teql_vtable = {
}
ASSERT_OK(asprintf(&expected, "%s(%" PRIu32 ")", name, number));
- ASSERT_OK(manager_get_route_table_to_string(manager, number, /* append_num = */ true, &str));
+ ASSERT_OK(manager_get_route_table_to_string(manager, number, /* append_num= */ true, &str));
ASSERT_STREQ(str, expected);
str = mfree(str);
- ASSERT_OK(manager_get_route_table_to_string(manager, number, /* append_num = */ false, &str));
+ ASSERT_OK(manager_get_route_table_to_string(manager, number, /* append_num= */ false, &str));
ASSERT_STREQ(str, name);
ASSERT_OK(manager_get_route_table_from_string(manager, name, &t));
TEST(route_tables) {
_cleanup_(manager_freep) Manager *manager = NULL;
- ASSERT_OK(manager_new(&manager, /* test_mode = */ true));
+ ASSERT_OK(manager_new(&manager, /* test_mode= */ true));
ASSERT_OK(manager_setup(manager));
ASSERT_OK(config_parse_route_table_names("manager", "filename", 1, "section", 1, "RouteTable", 0, "hoge:123 foo:456 aaa:111", manager, manager));
TEST(manager_enumerate) {
_cleanup_(manager_freep) Manager *manager = NULL;
- ASSERT_OK(manager_new(&manager, /* test_mode = */ true));
+ ASSERT_OK(manager_new(&manager, /* test_mode= */ true));
ASSERT_OK(manager_setup(manager));
/* TODO: should_reload, is false if the config dirs do not exist, so we can't do this test here, move
_cleanup_(manager_freep) Manager *manager = NULL;
_cleanup_(network_unrefp) Network *network = NULL;
- assert_se(manager_new(&manager, /* test_mode = */ true) >= 0);
+ assert_se(manager_new(&manager, /* test_mode= */ true) >= 0);
assert_se(network = new0(Network, 1));
network->n_ref = 1;
network->manager = manager;
continue;
}
- range = get_state_range(m, l, /* from_cmdline = */ NULL);
+ range = get_state_range(m, l, /* from_cmdline= */ NULL);
r = manager_link_is_online(m, l, range);
/* Unlike the above loop, unmanaged interfaces are ignored here. Also, Configured but offline
return log_error_errno(r, "Failed to add cgroup %s to userns: %m", payload);
} else {
_cleanup_free_ char *fs = NULL;
- r = cg_get_path(payload, /* suffix = */ NULL, &fs);
+ r = cg_get_path(payload, /* suffix= */ NULL, &fs);
if (r < 0)
return log_error_errno(r, "Failed to get file system path for container cgroup: %m");
if (r < 0)
return log_error_errno(r, "Failed to chase %s/sys/fs/cgroup: %m", strempty(dest));
- r = is_mount_point_at(fd, /* filename = */ NULL, /* flags = */ 0);
+ r = is_mount_point_at(fd, /* filename= */ NULL, /* flags= */ 0);
if (r < 0)
return log_error_errno(r, "Failed to determine if %s is mounted already: %m", p);
if (r > 0) {
if (!accept_existing)
return log_error_errno(SYNTHETIC_ERRNO(EEXIST), "Refusing existing cgroupfs mount: %s", p);
- if (faccessat(fd, "cgroup.procs", F_OK, /* flags = */ 0) >= 0)
+ if (faccessat(fd, "cgroup.procs", F_OK, /* flags= */ 0) >= 0)
return 0;
if (errno != ENOENT)
return log_error_errno(errno, "Failed to determine if mount point %s contains the unified cgroup hierarchy: %m", p);
LIST_FOREACH(ports, p, l) {
r = fw_nftables_add_local_dnat(
nfnl,
- /* add = */ false,
+ /* add= */ false,
af,
p->protocol,
p->host_port,
exposed,
p->container_port,
- /* previous_remote = */ NULL);
+ /* previous_remote= */ NULL);
if (r < 0)
log_warning_errno(r, "Failed to modify %s firewall: %m", af_to_name(af));
}
LIST_FOREACH(ports, p, l) {
r = fw_nftables_add_local_dnat(
nfnl,
- /* add = */ true,
+ /* add= */ true,
af,
p->protocol,
p->host_port,
if (orig_mntns_fd < 0)
return log_error_errno(orig_mntns_fd, "Failed to pin originating mount namespace: %m");
- r = namespace_enter(/* pidns_fd = */ -EBADF,
+ r = namespace_enter(/* pidns_fd= */ -EBADF,
mntns_fd,
- /* netns_fd = */ -EBADF,
- /* userns_fd = */ -EBADF,
- /* root_fd = */ -EBADF);
+ /* netns_fd= */ -EBADF,
+ /* userns_fd= */ -EBADF,
+ /* root_fd= */ -EBADF);
if (r < 0)
return log_error_errno(r, "Failed to enter mount namespace: %m");
rr = do_wipe_fully_visible_api_fs();
- r = namespace_enter(/* pidns_fd = */ -EBADF,
+ r = namespace_enter(/* pidns_fd= */ -EBADF,
orig_mntns_fd,
- /* netns_fd = */ -EBADF,
- /* userns_fd = */ -EBADF,
- /* root_fd = */ -EBADF);
+ /* netns_fd= */ -EBADF,
+ /* userns_fd= */ -EBADF,
+ /* root_fd= */ -EBADF);
if (r < 0)
return log_error_errno(r, "Failed to enter original mount namespace: %m");
return log_error_errno(original_netns_fd, "Failed to open original network namespace: %m");
}
- r = namespace_enter(/* pidns_fd = */ -EBADF,
- /* mntns_fd = */ -EBADF,
+ r = namespace_enter(/* pidns_fd= */ -EBADF,
+ /* mntns_fd= */ -EBADF,
netns_fd,
- /* userns_fd = */ -EBADF,
- /* root_fd = */ -EBADF);
+ /* userns_fd= */ -EBADF,
+ /* root_fd= */ -EBADF);
if (r < 0)
return log_error_errno(r, "Failed to enter child network namespace: %m");
- r = umount_recursive("/sys/", /* flags = */ 0);
+ r = umount_recursive("/sys/", /* flags= */ 0);
if (r < 0)
log_debug_errno(r, "Failed to unmount directories below /sys/, ignoring: %m");
/* Populate new sysfs instance associated with the client netns, to make sd_device usable. */
r = mount_nofollow_verbose(LOG_ERR, "sysfs", "/sys/", "sysfs",
- MS_RDONLY|MS_NOSUID|MS_NOEXEC|MS_NODEV, /* options = */ NULL);
+ MS_RDONLY|MS_NOSUID|MS_NOEXEC|MS_NODEV, /* options= */ NULL);
if (r < 0)
return log_error_errno(r, "Failed to mount sysfs on /sys/: %m");
/* Required basic device nodes. */
FOREACH_STRING(node, "null", "zero", "full", "random", "urandom", "tty") {
- r = copy_devnode_one(dest, node, /* check = */ false);
+ r = copy_devnode_one(dest, node, /* check= */ false);
if (r < 0)
return r;
}
/* Optional device nodes. */
FOREACH_STRING(node, "fuse", "net/tun") {
- r = copy_devnode_one(dest, node, /* check = */ true);
+ r = copy_devnode_one(dest, node, /* check= */ true);
if (r < 0)
return r;
}
.destination = p,
.destination_uid = UID_INVALID,
},
- /* n = */ 1,
+ /* n= */ 1,
uid_shift,
uid_range,
arg_selinux_apifs_context,
if (r < 0)
return log_error_errno(errno, "Failed to unshare cgroup namespace: %m");
- r = mount_cgroups(/* dest = */ NULL, /* accept_existing = */ false);
+ r = mount_cgroups(/* dest= */ NULL, /* accept_existing= */ false);
} else
r = bind_mount_cgroup_hierarchy();
if (r < 0)
(void) write_string_filef(p, WRITE_STRING_FILE_CREATE|WRITE_STRING_FILE_MODE_0444, SD_ID128_UUID_FORMAT_STR, SD_ID128_FORMAT_VAL(arg_uuid));
if (!arg_use_cgns) {
- r = mount_cgroups(directory, /* accept_existing = */ true);
+ r = mount_cgroups(directory, /* accept_existing= */ true);
if (r < 0)
return r;
}
* user if user namespaces are turned on. */
if (arg_network_namespace_path) {
- r = namespace_enter(/* pidns_fd = */ -EBADF,
- /* mntns_fd = */ -EBADF,
+ r = namespace_enter(/* pidns_fd= */ -EBADF,
+ /* mntns_fd= */ -EBADF,
netns_fd,
- /* userns_fd = */ -EBADF,
- /* root_fd = */ -EBADF);
+ /* userns_fd= */ -EBADF,
+ /* root_fd= */ -EBADF);
if (r < 0)
return log_error_errno(r, "Failed to join network namespace: %m");
}
} else if (!isempty(arg_background))
(void) pty_forward_set_background_color(forward, arg_background);
- (void) pty_forward_set_window_title(forward, GLYPH_BLUE_CIRCLE, /* hostname = */ NULL,
+ (void) pty_forward_set_window_title(forward, GLYPH_BLUE_CIRCLE, /* hostname= */ NULL,
STRV_MAKE("Container", arg_machine));
pty_forward_set_hotkey_handler(forward, ptyfwd_hotkey, pid);
* so just turning this off here means we only turn it off in nspawn itself, not any children. */
(void) ignore_signals(SIGPIPE);
- r = fdset_new_listen_fds(&fds, /* unset = */ false);
+ r = fdset_new_listen_fds(&fds, /* unset= */ false);
if (r < 0) {
log_error_errno(r, "Failed to collect file descriptors: %m");
goto finish;
assert(s);
- (void) start_workers(m, /* explicit_request=*/ true); /* Workers told us there's more work, let's add one more worker as long as we are below the high watermark */
+ (void) start_workers(m, /* explicit_request= */ true); /* Workers told us there's more work, let's add one more worker as long as we are below the high watermark */
return 0;
}
m->deferred_start_worker_event_source = sd_event_source_unref(m->deferred_start_worker_event_source);
- (void) start_workers(m, /* explicit_request=*/ false);
+ (void) start_workers(m, /* explicit_request= */ false);
return 0;
}
if (dry_run) {
_cleanup_free_ char *cg_path = NULL;
- r = cg_get_path(path, /* suffix = */ NULL, &cg_path);
+ r = cg_get_path(path, /* suffix= */ NULL, &cg_path);
if (r < 0)
return r;
pid_t pid;
int r;
- ASSERT_OK(r = safe_fork("(test-oom-child)", /* flags = */ 0, &pid));
+ ASSERT_OK(r = safe_fork("(test-oom-child)", /* flags= */ 0, &pid));
if (r == 0) {
usec_t timeout = usec_add(now(CLOCK_MONOTONIC), sleep_min * USEC_PER_MINUTE);
for (;;) {
_cleanup_free_ char *device = NULL;
if (streq(optarg, "list"))
- return tpm2_list_devices(/* legend = */ true, /* quiet = */ false);
+ return tpm2_list_devices(/* legend= */ true, /* quiet= */ false);
if (!streq(optarg, "auto")) {
device = strdup(optarg);
return 0;
}
- r = table_print_with_pager(table, arg_json_format_flags, arg_pager_flags, /* show_header= */true);
+ r = table_print_with_pager(table, arg_json_format_flags, arg_pager_flags, /* show_header= */ true);
if (r < 0)
return r;
/* root= */ NULL,
/* conf_root= */ NULL,
machine_id,
- /* machine_id_is_random = */ false,
+ /* machine_id_is_random= */ false,
&arg_entry_token_type,
&arg_entry_token);
if (r < 0)
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
e = strv_env_pairs_get(extension_release, "PORTABLE_PREFIXES");
if (e) {
- r = strv_split_and_extend(&valid_prefixes, e, WHITESPACE, /* filter_duplicates = */ true);
+ r = strv_split_and_extend(&valid_prefixes, e, WHITESPACE, /* filter_duplicates= */ true);
if (r < 0)
return r;
}
if (!name)
return -ENOMEM;
- /* A slightly reduced version of what's permitted in unit names. With ':' and '\' are removed, as well as '_'
- * which we use as delimiter for the second part of the image string, which we ignore for now. */
+ /* A slightly reduced version of what's permitted in unit names. With ':' and '\' are removed, as well as '_'
+ * which we use as delimiter for the second part of the image string, which we ignore for now. */
if (!in_charset(name, DIGITS LETTERS "-."))
return -EINVAL;
log_setup();
- assert_se(sigprocmask_many(SIG_BLOCK, /*ret_old_mask=*/ NULL, SIGCHLD) >= 0);
+ assert_se(sigprocmask_many(SIG_BLOCK, /* ret_old_mask= */ NULL, SIGCHLD) >= 0);
r = parse_argv(argc, argv);
if (r <= 0)
if (r < 0)
return log_error_errno(r, "Failed to get event loop: %m");
- pty_fd = openpt_allocate(O_RDWR|O_NOCTTY|O_NONBLOCK|O_CLOEXEC, /*ret_peer_path=*/ NULL);
+ pty_fd = openpt_allocate(O_RDWR|O_NOCTTY|O_NONBLOCK|O_CLOEXEC, /* ret_peer_path= */ NULL);
if (pty_fd < 0)
return log_error_errno(pty_fd, "Failed to acquire pseudo tty: %m");
_cleanup_free_ char *value = NULL;
int r;
- r = read_credential("quotacheck.mode", (void**) &value, /* ret_size = */ NULL);
+ r = read_credential("quotacheck.mode", (void**) &value, /* ret_size= */ NULL);
if (r < 0)
log_debug_errno(r, "Failed to read credential 'quotacheck.mode', ignoring: %m");
else {
else if (!path_equal(target, "/usr") && !mount_point_is_api(target))
continue;
- r = do_remount(target, /* force_rw = */ false, &pids);
+ r = do_remount(target, /* force_rw= */ false, &pids);
if (r < 0)
return r;
}
log_warning_errno(r, "Failed to parse $SYSTEMD_REMOUNT_ROOT_RW, ignoring: %m");
if (r > 0) {
- r = do_remount("/", /* force_rw = */ true, &pids);
+ r = do_remount("/", /* force_rw= */ true, &pids);
if (r < 0)
return r;
}
continue;
}
- r = specifier_printf(path, PATH_MAX-1, system_and_tmp_specifier_table, arg_root, /*userdata=*/ NULL, &d);
+ r = specifier_printf(path, PATH_MAX-1, system_and_tmp_specifier_table, arg_root, /* userdata= */ NULL, &d);
if (r < 0) {
log_syntax(unit, LOG_WARNING, filename, line, r,
"Failed to expand specifiers in Subvolumes= parameter, ignoring: %s", path);
continue;
}
- r = specifier_printf(path, PATH_MAX-1, system_and_tmp_specifier_table, arg_root, /*userdata=*/ NULL, &d);
+ r = specifier_printf(path, PATH_MAX-1, system_and_tmp_specifier_table, arg_root, /* userdata= */ NULL, &d);
if (r < 0) {
log_syntax(unit, LOG_WARNING, filename, line, r,
"Failed to expand specifiers in Subvolumes= parameter, ignoring: %s", path);
if (r < 0)
return log_error_errno(r, "%s is not a file nor a block device: %m", src);
- r = fdisk_new_context_at(fd, /* path = */ NULL, /* read_only = */ true, /* sector_size = */ UINT32_MAX, &c);
+ r = fdisk_new_context_at(fd, /* path= */ NULL, /* read_only= */ true, /* sector_size= */ UINT32_MAX, &c);
if (r < 0)
return log_error_errno(r, "Failed to create fdisk context: %m");
context->sector_size = fdisk_get_sector_size(c);
context->default_fs_sector_size = fs_secsz;
context->grain_size = MAX(context->sector_size, 4096U);
- return /* from_scratch = */ true;
+ return /* from_scratch= */ true;
}
r = -EINVAL;
return log_error_errno(r, "libcryptsetup not found, cannot setup verity: %m");
if (!node) {
- r = partition_target_prepare(context, p, p->new_size, /*need_path=*/ true, &t);
+ r = partition_target_prepare(context, p, p->new_size, /* need_path= */ true, &t);
if (r < 0)
return r;
usec_t start_timestamp = now(CLOCK_MONOTONIC);
r = partition_target_prepare(context, p, p->new_size,
- /*need_path=*/ p->encrypt != ENCRYPT_OFF || p->siblings[VERITY_HASH],
+ /* need_path= */ p->encrypt != ENCRYPT_OFF || p->siblings[VERITY_HASH],
&t);
if (r < 0)
return r;
if (p->encrypt != ENCRYPT_OFF && t->loop) {
- r = partition_encrypt(context, p, t, /* offline = */ false);
+ r = partition_encrypt(context, p, t, /* offline= */ false);
if (r < 0)
return r;
}
log_info("Copying in of '%s' on block level completed.", p->copy_blocks_path);
if (p->encrypt != ENCRYPT_OFF && !t->loop) {
- r = partition_encrypt(context, p, t, /* offline = */ true);
+ r = partition_encrypt(context, p, t, /* offline= */ true);
if (r < 0)
return r;
}
if (p->siblings[VERITY_HASH] && !partition_defer(context, p->siblings[VERITY_HASH])) {
r = partition_format_verity_hash(context, p->siblings[VERITY_HASH],
- /* node = */ NULL, partition_target_path(t));
+ /* node= */ NULL, partition_target_path(t));
if (r < 0)
return r;
}
struct stat st, rst;
int r;
- r = chase_and_stat(source, arg_copy_source, CHASE_PREFIX_ROOT, /*ret_path=*/ NULL, &st);
+ r = chase_and_stat(source, arg_copy_source, CHASE_PREFIX_ROOT, /* ret_path= */ NULL, &st);
if (r < 0)
return log_error_errno(r, "Failed to stat source file '%s/%s': %m", strempty(arg_copy_source), source);
if (stat(empty_to_root(arg_copy_source), &rst) < 0)
return log_error_errno(errno, "Failed to stat '%s': %m", empty_to_root(arg_copy_source));
- pfd = chase_and_open_parent(source, arg_copy_source, CHASE_PREFIX_ROOT, /*ret_filename=*/ NULL);
+ pfd = chase_and_open_parent(source, arg_copy_source, CHASE_PREFIX_ROOT, /* ret_filename= */ NULL);
if (pfd < 0)
return log_error_errno(pfd, "Failed to chase '%s/%s': %m", strempty(arg_copy_source), source);
* for cryptsetup's offline encryption. */
r = partition_target_prepare(context, p,
p->new_size - (p->encrypt != ENCRYPT_OFF ? LUKS2_METADATA_KEEP_FREE : 0),
- /*need_path=*/ true,
+ /* need_path= */ true,
&t);
if (r < 0)
return r;
if (r < 0)
return r;
- r = partition_encrypt(context, p, t, /* offline = */ false);
+ r = partition_encrypt(context, p, t, /* offline= */ false);
if (r < 0)
return log_error_errno(r, "Failed to encrypt device: %m");
}
if (r < 0)
return r;
- r = partition_encrypt(context, p, t, /* offline = */ true);
+ r = partition_encrypt(context, p, t, /* offline= */ true);
if (r < 0)
return log_error_errno(r, "Failed to encrypt device: %m");
}
if (p->siblings[VERITY_HASH] && !partition_defer(context, p->siblings[VERITY_HASH])) {
r = partition_format_verity_hash(context, p->siblings[VERITY_HASH],
- /* node = */ NULL, partition_target_path(t));
+ /* node= */ NULL, partition_target_path(t));
if (r < 0)
return r;
}
if (arg_certificate) {
if (arg_certificate_source_type == OPENSSL_CERTIFICATE_SOURCE_FILE) {
- r = parse_path_argument(arg_certificate, /*suppress_root=*/ false, &arg_certificate);
+ r = parse_path_argument(arg_certificate, /* suppress_root= */ false, &arg_certificate);
if (r < 0)
return r;
}
if (arg_private_key) {
if (arg_private_key_source_type == OPENSSL_KEY_SOURCE_FILE) {
- r = parse_path_argument(arg_private_key, /*suppress_root=*/ false, &arg_private_key);
+ r = parse_path_argument(arg_private_key, /* suppress_root= */ false, &arg_private_key);
if (r < 0)
return r;
}
_cleanup_free_ char *device = NULL;
if (streq(optarg, "list"))
- return tpm2_list_devices(/* legend = */ true, /* quiet = */ false);
+ return tpm2_list_devices(/* legend= */ true, /* quiet= */ false);
if (!streq(optarg, "auto")) {
device = strdup(optarg);
if (r < 0)
return r;
- (void) context_dump(context, /*late=*/ false);
+ (void) context_dump(context, /* late= */ false);
r = context_write_partition_table(context);
if (r < 0)
if (r < 0)
return r;
- (void) context_dump(context, /*late=*/ true);
+ (void) context_dump(context, /* late= */ true);
context_disarm_auto_removal(context);
}
static int map_link_dns_servers(sd_bus *bus, const char *member, sd_bus_message *m, sd_bus_error *error, void *userdata) {
- return map_dns_servers_internal(bus, member, m, /* flags = */ 0, error, userdata);
+ return map_dns_servers_internal(bus, member, m, /* flags= */ 0, error, userdata);
}
static int map_link_dns_servers_ex(sd_bus *bus, const char *member, sd_bus_message *m, sd_bus_error *error, void *userdata) {
assert(m);
assert(userdata);
- return read_dns_server_one(m, /* flags = */ 0, userdata);
+ return read_dns_server_one(m, /* flags= */ 0, userdata);
}
static int map_link_current_dns_server_ex(sd_bus *bus, const char *member, sd_bus_message *m, sd_bus_error *error, void *userdata) {
{}
};
- return dispatch_verb(argc, argv, verbs, /* userdata = */ NULL);
+ return dispatch_verb(argc, argv, verbs, /* userdata= */ NULL);
}
static int translate(const char *verb, const char *single_arg, size_t num_args, char **args) {
if (ifindex < 0)
return sd_bus_error_set(error, SD_BUS_ERROR_INVALID_ARGS, "Invalid interface index");
- if (validate_and_mangle_query_flags(m, &flags, /* name = */ NULL, /* ok = */ 0) < 0)
+ if (validate_and_mangle_query_flags(m, &flags, /* name= */ NULL, /* ok= */ 0) < 0)
return sd_bus_error_set(error, SD_BUS_ERROR_INVALID_ARGS, "Invalid flags parameter");
r = dns_question_new_reverse(&question, family, &a);
RefuseRecordTypeResult result = test_refuse_record_types(manager->refuse_record_types, *question);
if (result == REFUSE_BAD)
- return -ENOANO; /* All bad, refuse.*/
+ return -ENOANO; /* All bad, refuse. */
if (result == REFUSE_GOOD) {
*ret_allocated = NULL;
return 0; /* All good. Not necessary to filter. */
log_debug("Announcing packet size %zu in egress EDNS(0) packet.", packet_size);
- return dns_packet_append_opt(packet, packet_size, edns_do, /* include_rfc6975 = */ true, NULL, 0, NULL);
+ return dns_packet_append_opt(packet, packet_size, edns_do, /* include_rfc6975= */ true, NULL, 0, NULL);
}
int dns_server_ifindex(const DnsServer *s) {
assert(p);
if (add_opt) {
- r = dns_packet_append_opt(p, max_udp_size, edns0_do, /* include_rfc6975 = */ false, nsid ? nsid_string() : NULL, rcode, NULL);
+ r = dns_packet_append_opt(p, max_udp_size, edns0_do, /* include_rfc6975= */ false, nsid ? nsid_string() : NULL, rcode, NULL);
if (r == -EMSGSIZE) /* Hit the size limit? then indicate truncation */
tc = true;
else if (r < 0)
_cleanup_(dns_packet_unrefp) DnsPacket *reply = NULL;
r = dns_stub_patch_bypass_reply_packet(&reply, q->answer_full_packet, q->request_packet,
- /* validated = */ !FLAGS_SET(q->flags, SD_RESOLVED_NO_VALIDATE),
+ /* validated= */ !FLAGS_SET(q->flags, SD_RESOLVED_NO_VALIDATE),
FLAGS_SET(q->answer_query_flags, SD_RESOLVED_AUTHENTICATED));
if (r < 0)
log_debug_errno(r, "Failed to patch bypass reply packet: %m");
if (t->answer_dnssec_result == DNSSEC_INCOMPATIBLE_SERVER &&
t->scope->dnssec_mode == DNSSEC_YES) {
- /* We are not in automatic downgrade mode, and the server is bad. Let's try a different server, maybe
- * that works. */
+ /* We are not in automatic downgrade mode, and the server is bad. Let's try a different server, maybe
+ * that works. */
if (dns_transaction_limited_retry(t))
return;
assert_se(sd_event_now(t->scope->manager->event, CLOCK_BOOTTIME, &usec) >= 0);
dns_server_packet_lost(t->server, IPPROTO_UDP, t->current_feature_level);
- dns_transaction_close_connection(t, /* use_graveyard = */ false);
+ dns_transaction_close_connection(t, /* use_graveyard= */ false);
if (dns_transaction_limited_retry(t)) /* Try a different server */
return 0;
} else {
r = dns_packet_new_query(
&p, t->scope->protocol,
- /* min_alloc_dsize = */ 0,
- /* dnssec_checking_disabled = */ !FLAGS_SET(t->query_flags, SD_RESOLVED_NO_VALIDATE) &&
+ /* min_alloc_dsize= */ 0,
+ /* dnssec_checking_disabled= */ !FLAGS_SET(t->query_flags, SD_RESOLVED_NO_VALIDATE) &&
t->scope->dnssec_mode != DNSSEC_NO);
if (r < 0)
return r;
else {
_cleanup_free_ char **l = NULL, *j = NULL;
- if (set_dump_sorted(d->negative_by_name, (void***) &l, /* ret_n = */ NULL) < 0)
+ if (set_dump_sorted(d->negative_by_name, (void***) &l, /* ret_n= */ NULL) < 0)
return log_oom();
j = strv_join(l, " ");
return log_oom();
r = config_parse_many(
- STRV_MAKE_CONST(path), DNSSD_SERVICE_DIRS, dropin_dirname, /* root = */ NULL,
+ STRV_MAKE_CONST(path), DNSSD_SERVICE_DIRS, dropin_dirname, /* root= */ NULL,
"Service\0",
config_item_perf_lookup, resolved_dnssd_gperf_lookup,
CONFIG_PARSE_WARN,
return r;
return dns_configuration_json_append(
- /* ifname = */ NULL,
- /* ifindex = */ 0,
- /* delegate = */ NULL,
- /* default_route = */ -1,
+ /* ifname= */ NULL,
+ /* ifindex= */ 0,
+ /* delegate= */ NULL,
+ /* default_route= */ -1,
manager_get_dns_server(m),
m->dns_servers,
m->fallback_dns_servers,
return dns_configuration_json_append(
l->ifname,
l->ifindex,
- /* delegate = */ NULL,
+ /* delegate= */ NULL,
link_get_default_route(l),
link_get_dns_server(l),
l->dns_servers,
- /* fallback_dns_servers = */ NULL,
+ /* fallback_dns_servers= */ NULL,
l->search_domains,
l->dnssec_negative_trust_anchors,
scopes,
link_get_dns_over_tls_mode(l),
link_get_llmnr_support(l),
link_get_mdns_support(l),
- /* resolv_conf_mode = */ _RESOLV_CONF_MODE_INVALID,
+ /* resolv_conf_mode= */ _RESOLV_CONF_MODE_INVALID,
configuration);
}
return r;
return dns_configuration_json_append(
- /* ifname = */ NULL,
- /* ifindex = */ 0,
+ /* ifname= */ NULL,
+ /* ifindex= */ 0,
d->id,
d->default_route > 0, /* Defaults to false. See dns_scope_is_default_route(). */
dns_delegate_get_dns_server(d),
d->dns_servers,
- /* fallback_dns_servers = */ NULL,
+ /* fallback_dns_servers= */ NULL,
d->search_domains,
- /* negative_trust_anchors = */ NULL,
+ /* negative_trust_anchors= */ NULL,
scopes,
- /* dnssec_mode = */ _DNSSEC_MODE_INVALID,
- /* dns_over_tls_mode = */ _DNS_OVER_TLS_MODE_INVALID,
- /* llmnr_support = */ _RESOLVE_SUPPORT_INVALID,
- /* mdns_support = */ _RESOLVE_SUPPORT_INVALID,
- /* resolv_conf_mode = */ _RESOLV_CONF_MODE_INVALID,
+ /* dnssec_mode= */ _DNSSEC_MODE_INVALID,
+ /* dns_over_tls_mode= */ _DNS_OVER_TLS_MODE_INVALID,
+ /* llmnr_support= */ _RESOLVE_SUPPORT_INVALID,
+ /* mdns_support= */ _RESOLVE_SUPPORT_INVALID,
+ /* resolv_conf_mode= */ _RESOLV_CONF_MODE_INVALID,
configuration);
}
struct stat etc_hosts_stat;
bool read_etc_hosts;
- /* List of refused DNS Record Types*/
+ /* List of refused DNS Record Types */
Set *refuse_record_types;
OrderedSet *dns_extra_stub_listeners;
if (FAMILY_ADDRESS_SIZE(p.family) != p.address.iov_len)
return sd_varlink_error(link, "io.systemd.Resolve.BadAddressSize", NULL);
- if (validate_and_mangle_query_flags(m, &p.flags, /* name = */ NULL, /* ok = */ 0) < 0)
+ if (validate_and_mangle_query_flags(m, &p.flags, /* name= */ NULL, /* ok= */ 0) < 0)
return sd_varlink_error_invalid_parameter(link, JSON_VARIANT_STRING_CONST("flags"));
union in_addr_union a = IN_ADDR_NULL;
if (r != 0)
return r;
- if (validate_and_mangle_query_flags(m, &p.flags, /* name = */ NULL, /* ok = */ 0))
+ if (validate_and_mangle_query_flags(m, &p.flags, /* name= */ NULL, /* ok= */ 0))
return sd_varlink_error_invalid_parameter_name(link, "flags");
r = dns_subscribe_browse_service(m, link, p.domain, p.type, p.ifindex, p.flags);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
rr->a.in_addr.s_addr = htobe32(0xc0a8017f);
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
ASSERT_TRUE(dns_answer_contains(answer, rr));
}
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
rr->a.in_addr.s_addr = htobe32(0xc0a8017f);
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(answer), 1u);
- ASSERT_OK_POSITIVE(dns_answer_match_key(answer, rr->key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(answer, rr->key, /* ret_flags= */ NULL));
ASSERT_OK_POSITIVE(dns_answer_match_key(answer, rr->key, &flags));
ASSERT_EQ((int)flags, DNS_ANSWER_CACHEABLE);
/* ANY class matches */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_ANY, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK_POSITIVE(dns_answer_match_key(answer, key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(answer, key, /* ret_flags= */ NULL));
dns_resource_key_unref(key);
/* ANY type matches */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_ANY, "www.example.com"));
- ASSERT_OK_POSITIVE(dns_answer_match_key(answer, key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(answer, key, /* ret_flags= */ NULL));
dns_resource_key_unref(key);
/* non-matching type */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com"));
- ASSERT_OK_ZERO(dns_answer_match_key(answer, key, /* ret_flags = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_match_key(answer, key, /* ret_flags= */ NULL));
dns_resource_key_unref(key);
/* name is case-insensitive */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "WWW.EXAMPLE.COM"));
- ASSERT_OK_POSITIVE(dns_answer_match_key(answer, key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(answer, key, /* ret_flags= */ NULL));
dns_resource_key_unref(key);
/* non-matching name */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "example.com"));
- ASSERT_OK_ZERO(dns_answer_match_key(answer, key, /* ret_flags = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_match_key(answer, key, /* ret_flags= */ NULL));
dns_resource_key_unref(key);
/* name containing an error */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.\\example.com"));
- ASSERT_ERROR(dns_answer_match_key(answer, key, /* ret_flags = */ NULL), EINVAL);
+ ASSERT_ERROR(dns_answer_match_key(answer, key, /* ret_flags= */ NULL), EINVAL);
dns_resource_key_unref(key);
}
ASSERT_NOT_NULL(answer = dns_answer_new(0));
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_TXT, "www.example.com"));
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_SECTION_ANSWER | DNS_ANSWER_AUTHENTICATED, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_SECTION_ANSWER | DNS_ANSWER_AUTHENTICATED, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
rr->a.in_addr.s_addr = htobe32(0xc0a8017f);
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_SECTION_ANSWER | DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_SECTION_ANSWER | DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
ASSERT_EQ(dns_answer_size(answer), 2u);
ASSERT_NOT_NULL(rr_a = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
rr_a->a.in_addr.s_addr = htobe32(0xc0a8017f);
- ASSERT_OK_POSITIVE(dns_answer_add(a, rr_a, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(a, rr_a, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
ASSERT_NOT_NULL(rr_b = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "b.example.com"));
rr_b->a.in_addr.s_addr = htobe32(0xc0a80180);
- ASSERT_OK_POSITIVE(dns_answer_add(b, rr_b, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(b, rr_b, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
ASSERT_OK(dns_answer_merge(a, b, &ret));
ASSERT_TRUE(ret != a);
ASSERT_TRUE(ret != b);
- ASSERT_OK_POSITIVE(dns_answer_match_key(a, rr_a->key, /* ret_flags = */ NULL));
- ASSERT_OK_ZERO(dns_answer_match_key(a, rr_b->key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(a, rr_a->key, /* ret_flags= */ NULL));
+ ASSERT_OK_ZERO(dns_answer_match_key(a, rr_b->key, /* ret_flags= */ NULL));
- ASSERT_OK_ZERO(dns_answer_match_key(b, rr_a->key, /* ret_flags = */ NULL));
- ASSERT_OK_POSITIVE(dns_answer_match_key(b, rr_b->key, /* ret_flags = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_match_key(b, rr_a->key, /* ret_flags= */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(b, rr_b->key, /* ret_flags= */ NULL));
- ASSERT_OK_POSITIVE(dns_answer_match_key(ret, rr_a->key, /* ret_flags = */ NULL));
- ASSERT_OK_POSITIVE(dns_answer_match_key(ret, rr_b->key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(ret, rr_a->key, /* ret_flags= */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(ret, rr_b->key, /* ret_flags= */ NULL));
}
/* ================================================================
ASSERT_NOT_NULL(rr_a = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
rr_a->a.in_addr.s_addr = htobe32(0xc0a8017f);
- ASSERT_OK_POSITIVE(dns_answer_add(a, rr_a, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(a, rr_a, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
ASSERT_NOT_NULL(rr_b = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "b.example.com"));
rr_b->a.in_addr.s_addr = htobe32(0xc0a80180);
- ASSERT_OK_POSITIVE(dns_answer_add(b, rr_b, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(b, rr_b, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
ASSERT_OK(dns_answer_extend(&a, b));
ASSERT_TRUE(a != b);
- ASSERT_OK_POSITIVE(dns_answer_match_key(a, rr_a->key, /* ret_flags = */ NULL));
- ASSERT_OK_POSITIVE(dns_answer_match_key(a, rr_b->key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(a, rr_a->key, /* ret_flags= */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(a, rr_b->key, /* ret_flags= */ NULL));
}
/* ================================================================
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, *h));
rr->a.in_addr.s_addr = htobe32(0xc0a8017f);
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
}
return TAKE_PTR(answer);
n--;
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, *h));
- ASSERT_OK_POSITIVE(dns_answer_match_key(answer, key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(answer, key, /* ret_flags= */ NULL));
ASSERT_OK_POSITIVE(dns_answer_remove_by_key(&answer, key));
ASSERT_EQ(dns_answer_size(answer), n);
- ASSERT_OK_ZERO(dns_answer_match_key(answer, key, /* ret_flags = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_match_key(answer, key, /* ret_flags= */ NULL));
ASSERT_OK_ZERO(dns_answer_remove_by_key(&answer, key));
ASSERT_EQ(dns_answer_size(answer), n);
dns_resource_key_unref(key);
_cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL;
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, *h));
- ASSERT_OK_POSITIVE(dns_answer_match_key(answer, key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(answer, key, /* ret_flags= */ NULL));
/* remove nothing if the payload does not match */
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, *h));
ASSERT_OK_POSITIVE(dns_answer_remove_by_rr(&answer, rr));
ASSERT_EQ(dns_answer_size(answer), --n);
- ASSERT_OK_ZERO(dns_answer_match_key(answer, key, /* ret_flags = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_match_key(answer, key, /* ret_flags= */ NULL));
}
ASSERT_NULL(answer);
ASSERT_EQ(dns_answer_size(b), 2u);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
- ASSERT_OK_ZERO(dns_answer_match_key(a, key, /* ret_flags = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_match_key(a, key, /* ret_flags= */ NULL));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "b.example.com"));
- ASSERT_OK_POSITIVE(dns_answer_match_key(a, key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(a, key, /* ret_flags= */ NULL));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "c.example.com"));
- ASSERT_OK_ZERO(dns_answer_match_key(a, key, /* ret_flags = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_match_key(a, key, /* ret_flags= */ NULL));
dns_resource_key_unref(key);
}
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
rr->a.in_addr.s_addr = htobe32(0xc0a8017f);
- ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
rr = dns_resource_record_unref(rr);
/* non-matching class */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_ANY, DNS_TYPE_A, "a.example.com"));
- ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(target), 0u);
dns_resource_key_unref(key);
/* non-matching type */
key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_AAAA, "a.example.com");
ASSERT_NOT_NULL(key);
- ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(target), 0u);
dns_resource_key_unref(key);
/* non-matching name */
key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "b.example.com");
ASSERT_NOT_NULL(key);
- ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(target), 0u);
dns_resource_key_unref(key);
/* matching key */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
- ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(target), 1u);
- ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags= */ NULL));
/* add one more record with the same key */
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
rr->a.in_addr.s_addr = htobe32(0x7f000001);
- ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
/* check if the two records are copied */
- ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(target), 2u);
- ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags= */ NULL));
/* try again with an empty target */
target = dns_answer_unref(target);
- ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK(dns_answer_copy_by_key(&target, source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(target), 2u);
- ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags= */ NULL));
dns_resource_key_unref(key);
/* add one more record */
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "b.example.com"));
rr->a.in_addr.s_addr = htobe32(0x7f000001);
- ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
/* copy with flags */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "b.example.com"));
- ASSERT_OK(dns_answer_copy_by_key(&target, source, key, DNS_ANSWER_SECTION_ANSWER, /* rrsig = */ NULL));
+ ASSERT_OK(dns_answer_copy_by_key(&target, source, key, DNS_ANSWER_SECTION_ANSWER, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(target), 3u);
ASSERT_TRUE(dns_answer_match_key(target, key, &flags));
ASSERT_EQ((int) flags, DNS_ANSWER_CACHEABLE | DNS_ANSWER_SECTION_ANSWER);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
rr->a.in_addr.s_addr = htobe32(0xc0a8017f);
- ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
/* non-matching class */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_ANY, DNS_TYPE_A, "a.example.com"));
- ASSERT_OK_ZERO(dns_answer_move_by_key(&target, &source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_move_by_key(&target, &source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(source), 1u);
ASSERT_EQ(dns_answer_size(target), 0u);
dns_resource_key_unref(key);
/* non-matching type */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_AAAA, "a.example.com"));
- ASSERT_OK_ZERO(dns_answer_move_by_key(&target, &source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_move_by_key(&target, &source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(source), 1u);
ASSERT_EQ(dns_answer_size(target), 0u);
dns_resource_key_unref(key);
/* non-matching name */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "b.example.com"));
- ASSERT_OK_ZERO(dns_answer_move_by_key(&target, &source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_move_by_key(&target, &source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(source), 1u);
ASSERT_EQ(dns_answer_size(target), 0u);
dns_resource_key_unref(key);
/* matching key */
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
- ASSERT_OK_POSITIVE(dns_answer_move_by_key(&target, &source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_move_by_key(&target, &source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_NULL(source);
ASSERT_EQ(dns_answer_size(target), 1u);
- ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags= */ NULL));
/* move the record back to the source */
source = TAKE_PTR(target);
/* add one more record */
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "b.example.com"));
rr->a.in_addr.s_addr = htobe32(0x7f000001);
- ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
/* move only a.example.com */
- ASSERT_OK_POSITIVE(dns_answer_move_by_key(&target, &source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_move_by_key(&target, &source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(source), 1u);
ASSERT_EQ(dns_answer_size(target), 1u);
- ASSERT_OK_ZERO(dns_answer_match_key(source, key, /* ret_flags = */ NULL));
- ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_match_key(source, key, /* ret_flags= */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags= */ NULL));
/* move the record back to the source */
- ASSERT_OK_POSITIVE(dns_answer_move_by_key(&source, &target, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_move_by_key(&source, &target, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(source), 2u);
ASSERT_EQ(dns_answer_size(target), 0u);
/* add one more record */
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
rr->a.in_addr.s_addr = htobe32(0xc0a80180);
- ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(source, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
/* move two records for a.example.com */
- ASSERT_OK_POSITIVE(dns_answer_move_by_key(&target, &source, key, /* or_flags = */ 0, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_move_by_key(&target, &source, key, /* or_flags= */ 0, /* rrsig= */ NULL));
ASSERT_EQ(dns_answer_size(source), 1u);
ASSERT_EQ(dns_answer_size(target), 2u);
- ASSERT_OK_ZERO(dns_answer_match_key(source, key, /* ret_flags = */ NULL));
- ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags = */ NULL));
+ ASSERT_OK_ZERO(dns_answer_match_key(source, key, /* ret_flags= */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_match_key(target, key, /* ret_flags= */ NULL));
dns_resource_key_unref(key);
}
/* has matching dname */
ASSERT_NOT_NULL(dname = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_DNAME, "example.com"));
ASSERT_NOT_NULL(dname->dname.name = strdup("v2.example.com"));
- ASSERT_OK_POSITIVE(dns_answer_add(answer, dname, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, dname, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
/* no matching old suffix */
ASSERT_OK(free_and_strdup(&dname->dname.name, "www.v2.examples.com"));
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
rr->ttl = 1200;
rr->a.in_addr.s_addr = htobe32(0xc0a8017f);
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE | DNS_ANSWER_SECTION_ADDITIONAL, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE | DNS_ANSWER_SECTION_ADDITIONAL, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "b.example.com"));
rr->ttl = 2400;
rr->a.in_addr.s_addr = htobe32(0xc0a80180);
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 2, 0, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 2, 0, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "c.example.com"));
rr->a.in_addr.s_addr = htobe32(0xc0a80181);
ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 3,
DNS_ANSWER_AUTHENTICATED | DNS_ANSWER_SHARED_OWNER | DNS_ANSWER_SECTION_AUTHORITY | DNS_ANSWER_CACHE_FLUSH,
- /* rrsig = */ NULL));
+ /* rrsig= */ NULL));
dns_resource_record_unref(rr);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "d.example.com"));
rr->ttl = 4800;
rr->cname.name = strdup("www.example.com");
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 4, DNS_ANSWER_GOODBYE | DNS_ANSWER_SECTION_ANSWER, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 4, DNS_ANSWER_GOODBYE | DNS_ANSWER_SECTION_ANSWER, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
ASSERT_EQ(dns_answer_size(answer), 4u);
ASSERT_NOT_NULL(f = memstream_init(&ms));
dns_answer_dump(answer, f);
- ASSERT_OK(memstream_finalize(&ms, &buf, /* ret_size = */ NULL));
+ ASSERT_OK(memstream_finalize(&ms, &buf, /* ret_size= */ NULL));
ASSERT_STREQ(buf,
"\ta.example.com IN A 192.168.1.127\t; ttl=1200 ifindex=1 cacheable section-additional\n"
"\tb.example.com IN A 192.168.1.128\t; ttl=2400 ifindex=2\n"
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "a.example.com"));
rr->ttl = 3600;
rr->a.in_addr.s_addr = htobe32(0xa9fe0100);
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 1, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "b.example.com"));
rr->ttl = 3600;
rr->a.in_addr.s_addr = htobe32(0xc0a80404);
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 2, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 2, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "c.example.com"));
rr->ttl = 3600;
rr->a.in_addr.s_addr = htobe32(0xa9fefeff);
- ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 3, DNS_ANSWER_CACHEABLE, /* rrsig = */ NULL));
+ ASSERT_OK_POSITIVE(dns_answer_add(answer, rr, 3, DNS_ANSWER_CACHEABLE, /* rrsig= */ NULL));
dns_resource_record_unref(rr);
- dns_answer_order_by_scope(answer, /* prefer_link_local = */ true);
+ dns_answer_order_by_scope(answer, /* prefer_link_local= */ true);
ASSERT_NOT_NULL(f = memstream_init(&ms));
dns_answer_dump(answer, f);
- ASSERT_OK(memstream_finalize(&ms, &buf, /* ret_size = */ NULL));
+ ASSERT_OK(memstream_finalize(&ms, &buf, /* ret_size= */ NULL));
ASSERT_STREQ(buf,
"\ta.example.com IN A 169.254.1.0\t; ttl=3600 ifindex=1 cacheable\n"
"\tc.example.com IN A 169.254.254.255\t; ttl=3600 ifindex=3 cacheable\n"
buf = mfree(buf);
memstream_done(&ms);
- dns_answer_order_by_scope(answer, /* prefer_link_local = */ false);
+ dns_answer_order_by_scope(answer, /* prefer_link_local= */ false);
ASSERT_NOT_NULL(f = memstream_init(&ms));
dns_answer_dump(answer, f);
- ASSERT_OK(memstream_finalize(&ms, &buf, /* ret_size = */ NULL));
+ ASSERT_OK(memstream_finalize(&ms, &buf, /* ret_size= */ NULL));
ASSERT_STREQ(buf,
"\tb.example.com IN A 192.168.4.4\t; ttl=3600 ifindex=2 cacheable\n"
"\ta.example.com IN A 169.254.1.0\t; ttl=3600 ifindex=1 cacheable\n"
/* zero-size question */
ASSERT_NOT_NULL(question = dns_question_new(0));
- ASSERT_ERROR(dns_question_add(question, key, /* flags = */ 0), ENOSPC);
+ ASSERT_ERROR(dns_question_add(question, key, /* flags= */ 0), ENOSPC);
ASSERT_OK_ZERO(dns_question_contains_key(question, key));
ASSERT_EQ(dns_question_size(question), 0u);
ASSERT_TRUE(dns_question_isempty(question));
/* single question */
ASSERT_NOT_NULL(question = dns_question_new(1));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
ASSERT_OK_POSITIVE(dns_question_contains_key(question, key));
ASSERT_EQ(dns_question_size(question), 1u);
ASSERT_FALSE(dns_question_isempty(question));
/* no domain */
ASSERT_ERROR(dns_question_new_service(
&question,
- /* service = */ NULL,
+ /* service= */ NULL,
"_xmpp._tcp",
- /* domain = */ NULL,
- /* with_txt = */ false,
- /* convert_idna = */ false), EINVAL);
+ /* domain= */ NULL,
+ /* with_txt= */ false,
+ /* convert_idna= */ false), EINVAL);
ASSERT_NULL(question);
/* domain only */
ASSERT_OK(dns_question_new_service(
&question,
- /* service = */ NULL,
- /* type = */ NULL,
+ /* service= */ NULL,
+ /* type= */ NULL,
"www.example.com",
- /* with_txt = */ false,
- /* convert_idna = */ false));
+ /* with_txt= */ false,
+ /* convert_idna= */ false));
ASSERT_NOT_NULL(question);
ASSERT_EQ(dns_question_size(question), 1u);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_SRV, "www.example.com"));
/* convert idna without type -> ignored */
ASSERT_OK(dns_question_new_service(
&question,
- /* service = */ NULL,
- /* type = */ NULL,
+ /* service= */ NULL,
+ /* type= */ NULL,
"\xF0\x9F\x98\xB1.com",
- /* with_txt = */ false,
- /* convert_idna = */ true));
+ /* with_txt= */ false,
+ /* convert_idna= */ true));
ASSERT_NOT_NULL(question);
ASSERT_EQ(dns_question_size(question), 1u);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_SRV, "\xF0\x9F\x98\xB1.com"));
/* with type */
ASSERT_OK(dns_question_new_service(
&question,
- /* service = */ NULL,
+ /* service= */ NULL,
"_xmpp._tcp",
"example.com",
- /* with_txt = */ false,
- /* convert_idna = */ false));
+ /* with_txt= */ false,
+ /* convert_idna= */ false));
ASSERT_NOT_NULL(question);
ASSERT_EQ(dns_question_size(question), 1u);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_SRV, "_xmpp._tcp.example.com"));
/* convert idna with type */
ASSERT_OK(dns_question_new_service(
&question,
- /* service = */ NULL,
+ /* service= */ NULL,
"_xmpp._tcp",
"\xF0\x9F\x98\xB1.com",
- /* with_txt = */ false,
- /* convert_idna = */ true));
+ /* with_txt= */ false,
+ /* convert_idna= */ true));
ASSERT_NOT_NULL(question);
ASSERT_EQ(dns_question_size(question), 1u);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_SRV, "_xmpp._tcp.xn--s38h.com"));
/* with txt */
ASSERT_OK(dns_question_new_service(
&question,
- /* service = */ NULL,
+ /* service= */ NULL,
"_xmpp._tcp",
"\xF0\x9F\x98\xB1.com",
- /* with_txt = */ true,
- /* convert_idna = */ true));
+ /* with_txt= */ true,
+ /* convert_idna= */ true));
ASSERT_NOT_NULL(question);
ASSERT_EQ(dns_question_size(question), 2u);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_SRV, "_xmpp._tcp.xn--s38h.com"));
/* invalid type */
ASSERT_ERROR(dns_question_new_service(
&question,
- /* service = */ NULL,
+ /* service= */ NULL,
"_xmpp.tcp",
"example.com",
- /* with_txt = */ false,
- /* convert_idna = */ false), EINVAL);
+ /* with_txt= */ false,
+ /* convert_idna= */ false), EINVAL);
ASSERT_NULL(question);
/* invalid type (too short) */
ASSERT_ERROR(dns_question_new_service(
&question,
- /* service = */ NULL,
+ /* service= */ NULL,
"_xmpp",
"example.com",
- /* with_txt = */ false,
- /* convert_idna = */ false), EINVAL);
+ /* with_txt= */ false,
+ /* convert_idna= */ false), EINVAL);
ASSERT_NULL(question);
/* invalid type (too long) */
ASSERT_ERROR(dns_question_new_service(
&question,
- /* service = */ NULL,
+ /* service= */ NULL,
"_xmpp._tcp._extra",
"example.com",
- /* with_txt = */ false,
- /* convert_idna = */ false), EINVAL);
+ /* with_txt= */ false,
+ /* convert_idna= */ false), EINVAL);
ASSERT_NULL(question);
/* with service and type */
"service",
"_xmpp._tcp",
"example.com",
- /* with_txt = */ false,
- /* convert_idna = */ false));
+ /* with_txt= */ false,
+ /* convert_idna= */ false));
ASSERT_NOT_NULL(question);
ASSERT_EQ(dns_question_size(question), 1u);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_SRV, "service._xmpp._tcp.example.com"));
ASSERT_ERROR(dns_question_new_service(
&question,
"service",
- /* type = */ NULL,
+ /* type= */ NULL,
"example.com",
- /* with_txt = */ false,
- /* convert_idna = */ false), EINVAL);
+ /* with_txt= */ false,
+ /* convert_idna= */ false), EINVAL);
ASSERT_NULL(question);
}
ASSERT_NOT_NULL(question = dns_question_new(2));
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "mail.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK_POSITIVE(dns_question_matches_rr(question, rr, /* search_domain = */ NULL));
+ ASSERT_OK_POSITIVE(dns_question_matches_rr(question, rr, /* search_domain= */ NULL));
dns_resource_record_unref(rr);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "mail.example.com"));
- ASSERT_OK_POSITIVE(dns_question_matches_rr(question, rr, /* search_domain = */ NULL));
+ ASSERT_OK_POSITIVE(dns_question_matches_rr(question, rr, /* search_domain= */ NULL));
dns_resource_record_unref(rr);
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "mail.example.com"));
- ASSERT_OK_ZERO(dns_question_matches_rr(question, rr, /* search_domain = */ NULL));
+ ASSERT_OK_ZERO(dns_question_matches_rr(question, rr, /* search_domain= */ NULL));
dns_resource_record_unref(rr);
}
ASSERT_NOT_NULL(question = dns_question_new(1));
ASSERT_NOT_NULL(keya = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK(dns_question_add(question, keya, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, keya, /* flags= */ 0));
/* cname */
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com"));
- ASSERT_OK_POSITIVE(dns_question_matches_cname_or_dname(question, rr, /* search_domain = */ NULL));
+ ASSERT_OK_POSITIVE(dns_question_matches_cname_or_dname(question, rr, /* search_domain= */ NULL));
dns_resource_record_unref(rr);
/* dname */
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_DNAME, "example.com"));
- ASSERT_OK_POSITIVE(dns_question_matches_cname_or_dname(question, rr, /* search_domain = */ NULL));
+ ASSERT_OK_POSITIVE(dns_question_matches_cname_or_dname(question, rr, /* search_domain= */ NULL));
dns_resource_record_unref(rr);
/* A record -> fail */
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK_ZERO(dns_question_matches_cname_or_dname(question, rr, /* search_domain = */ NULL));
+ ASSERT_OK_ZERO(dns_question_matches_cname_or_dname(question, rr, /* search_domain= */ NULL));
dns_resource_record_unref(rr);
dns_question_unref(question);
ASSERT_NOT_NULL(question = dns_question_new(2));
ASSERT_NOT_NULL(keyc = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_CNAME, "example.com"));
- ASSERT_OK(dns_question_add(question, keyc, /* flags = */ 0));
- ASSERT_OK(dns_question_add(question, keya, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, keyc, /* flags= */ 0));
+ ASSERT_OK(dns_question_add(question, keya, /* flags= */ 0));
/* refuse cname if question has cname */
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com"));
- ASSERT_OK_ZERO(dns_question_matches_cname_or_dname(question, rr, /* search_domain = */ NULL));
+ ASSERT_OK_ZERO(dns_question_matches_cname_or_dname(question, rr, /* search_domain= */ NULL));
dns_resource_record_unref(rr);
}
/* single key */
ASSERT_NOT_NULL(question = dns_question_new(1));
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
ASSERT_OK_POSITIVE(dns_question_is_valid_for_query(question));
question = dns_question_unref(question);
/* invalid type */
ASSERT_NOT_NULL(question = dns_question_new(1));
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_OPT, "www.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
ASSERT_OK_ZERO(dns_question_is_valid_for_query(question));
question = dns_question_unref(question);
/* multiple keys with the same name */
ASSERT_NOT_NULL(question = dns_question_new(2));
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_AAAA, "www.EXAMPLE.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
ASSERT_OK_POSITIVE(dns_question_is_valid_for_query(question));
question = dns_question_unref(question);
/* multiple keys with different names */
ASSERT_NOT_NULL(question = dns_question_new(2));
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_AAAA, "www.example.org"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
ASSERT_OK_ZERO(dns_question_is_valid_for_query(question));
}
a = dns_question_unref(a);
/* an address question (with NULL, self, and an empty) */
- ASSERT_OK(dns_question_new_address(&a, AF_INET, "www.example.com", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&a, AF_INET, "www.example.com", /* convert_idna= */ false));
ASSERT_NOT_NULL(a);
ASSERT_OK_ZERO(dns_question_is_equal(a, NULL));
ASSERT_OK_ZERO(dns_question_is_equal(NULL, a));
b = dns_question_unref(b);
/* an address question (with same name) */
- ASSERT_OK(dns_question_new_address(&b, AF_INET, "www.EXAMPLE.com", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&b, AF_INET, "www.EXAMPLE.com", /* convert_idna= */ false));
ASSERT_NOT_NULL(b);
ASSERT_OK_POSITIVE(dns_question_is_equal(a, b));
ASSERT_OK_POSITIVE(dns_question_is_equal(b, a));
b = dns_question_unref(b);
/* an address question (with different name) */
- ASSERT_OK(dns_question_new_address(&b, AF_INET, "www.EXAMPLE.org", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&b, AF_INET, "www.EXAMPLE.org", /* convert_idna= */ false));
ASSERT_NOT_NULL(b);
ASSERT_OK_ZERO(dns_question_is_equal(a, b));
ASSERT_OK_ZERO(dns_question_is_equal(b, a));
b = dns_question_unref(b);
/* an address question (with different type) */
- ASSERT_OK(dns_question_new_address(&b, AF_INET6, "www.example.com", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&b, AF_INET6, "www.example.com", /* convert_idna= */ false));
ASSERT_NOT_NULL(b);
ASSERT_OK_ZERO(dns_question_is_equal(a, b));
ASSERT_OK_ZERO(dns_question_is_equal(b, a));
ASSERT_NOT_NULL(b = dns_question_new(2));
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK(dns_question_add(b, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(b, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_AAAA, "www.example.com"));
- ASSERT_OK(dns_question_add(b, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(b, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_OK_ZERO(dns_question_is_equal(a, b));
ASSERT_NOT_NULL(a = dns_question_new(2));
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_AAAA, "www.example.com"));
- ASSERT_OK(dns_question_add(a, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(a, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK(dns_question_add(a, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(a, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_OK_POSITIVE(dns_question_is_equal(a, b));
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_CNAME, "www.example.com"));
rr->cname.name = strdup("example.com");
- ASSERT_OK(dns_question_new_address(&expected, AF_INET, "example.com", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&expected, AF_INET, "example.com", /* convert_idna= */ false));
ASSERT_NOT_NULL(expected);
/* NULL */
question = dns_question_unref(question);
/* match cname */
- ASSERT_OK(dns_question_new_address(&question, AF_INET, "www.example.com", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&question, AF_INET, "www.example.com", /* convert_idna= */ false));
ASSERT_OK_POSITIVE(dns_question_cname_redirect(question, rr, &ret));
ASSERT_OK_POSITIVE(dns_question_is_equal(ret, expected));
ret = dns_question_unref(ret);
/* same name */
- ASSERT_OK(dns_question_new_address(&question, AF_INET, "example.com", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&question, AF_INET, "example.com", /* convert_idna= */ false));
ASSERT_OK_ZERO(dns_question_cname_redirect(question, rr, &ret));
ASSERT_NULL(ret);
question = dns_question_unref(question);
/* no match (same domain) */
- ASSERT_OK(dns_question_new_address(&question, AF_INET, "mail.example.com", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&question, AF_INET, "mail.example.com", /* convert_idna= */ false));
ASSERT_OK_POSITIVE(dns_question_cname_redirect(question, rr, &ret));
ASSERT_OK_POSITIVE(dns_question_is_equal(ret, expected));
ret = dns_question_unref(ret);
/* no match (different domain) */
- ASSERT_OK(dns_question_new_address(&question, AF_INET, "www.example.org", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&question, AF_INET, "www.example.org", /* convert_idna= */ false));
ASSERT_OK_POSITIVE(dns_question_cname_redirect(question, rr, &ret));
ASSERT_OK_POSITIVE(dns_question_is_equal(ret, expected));
ASSERT_NOT_NULL(rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_DNAME, "example.com"));
rr->dname.name = strdup("v2.example.com");
- ASSERT_OK(dns_question_new_address(&expected, AF_INET, "www.v2.example.com", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&expected, AF_INET, "www.v2.example.com", /* convert_idna= */ false));
/* match dname */
- ASSERT_OK(dns_question_new_address(&question, AF_INET, "www.example.com", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&question, AF_INET, "www.example.com", /* convert_idna= */ false));
ASSERT_OK_POSITIVE(dns_question_cname_redirect(question, rr, &ret));
ASSERT_OK_POSITIVE(dns_question_is_equal(ret, expected));
ASSERT_NOT_NULL(question = dns_question_new(2));
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "mail.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_OK_POSITIVE(dns_question_cname_redirect(question, rr, &ret));
_cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL;
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, type, "www.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
}
ASSERT_EQ(dns_question_size(question), 3u);
ASSERT_NOT_NULL(f = memstream_init(&ms));
dns_question_dump(question, f);
- ASSERT_OK(memstream_finalize(&ms, &buf, /* ret_size = */ NULL));
+ ASSERT_OK(memstream_finalize(&ms, &buf, /* ret_size= */ NULL));
ASSERT_STREQ(buf,
"\twww.example.com IN A\n"
"\twww.example.com IN AAAA\n"
ASSERT_NOT_NULL(question = dns_question_new(2));
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "mail.example.com"));
- ASSERT_OK(dns_question_add(question, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(question, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_STREQ(dns_question_first_name(question), "www.example.com");
a = dns_question_unref(a);
/* single question */
- ASSERT_OK(dns_question_new_address(&a, AF_INET, "www.example.com", /* convert_idna = */ false));
+ ASSERT_OK(dns_question_new_address(&a, AF_INET, "www.example.com", /* convert_idna= */ false));
ASSERT_OK(dns_question_merge(NULL, a, &ret));
ASSERT_PTR_EQ(ret, a);
ret = dns_question_unref(ret);
ASSERT_NOT_NULL(b = dns_question_new(2));
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_AAAA, "www.example.com"));
- ASSERT_OK(dns_question_add(b, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(b, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_NOT_NULL(key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_TXT, "www.example.com"));
- ASSERT_OK(dns_question_add(b, key, /* flags = */ 0));
+ ASSERT_OK(dns_question_add(b, key, /* flags= */ 0));
dns_resource_key_unref(key);
ASSERT_OK(dns_question_merge(a, b, &ret));
if (strv_isempty(arg_commands) && !arg_success_action)
return 0;
- r = generator_open_unit_file(arg_dest, /* source = */ NULL, "kernel-command-line.service", &f);
+ r = generator_open_unit_file(arg_dest, /* source= */ NULL, "kernel-command-line.service", &f);
if (r < 0)
return r;
"org.freedesktop.systemd1.Unit",
"Ref",
&error,
- /* ret_reply = */ NULL, NULL);
+ /* ret_reply= */ NULL,
+ /* types= */ NULL);
if (r < 0) {
/* Hmm, the service manager probably hasn't finished reexecution just yet? Try again later. */
if (bus_error_is_connection(&error) || bus_error_is_unknown_service(&error))
if (r < 0)
return bus_log_create_error(r);
- r = transient_service_set_properties(m, /* pty_path = */ NULL, /* pty_fd = */ -EBADF);
+ r = transient_service_set_properties(m, /* pty_path= */ NULL, /* pty_fd= */ -EBADF);
if (r < 0)
return r;
return version();
case ARG_OUTPUT:
- r = parse_path_argument(optarg, /*suppress_root=*/ false, &arg_output);
+ r = parse_path_argument(optarg, /* suppress_root= */ false, &arg_output);
if (r < 0)
return r;
if (!idc->data->value->value.sequence)
return log_oom();
- idc->data->type = OBJ_txt2obj(SPC_PE_IMAGE_DATA_OBJID, /*no_name=*/ 1);
+ idc->data->type = OBJ_txt2obj(SPC_PE_IMAGE_DATA_OBJID, /* no_name= */ 1);
if (!idc->data->type)
return log_error_errno(SYNTHETIC_ERRNO(EIO), "Failed to get SpcPeImageData object: %s",
ERR_error_string(ERR_get_error(), NULL));
return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "No output specified, use --output=");
if (arg_certificate_source_type == OPENSSL_CERTIFICATE_SOURCE_FILE) {
- r = parse_path_argument(arg_certificate, /*suppress_root=*/ false, &arg_certificate);
+ r = parse_path_argument(arg_certificate, /* suppress_root= */ false, &arg_certificate);
if (r < 0)
return r;
}
if (r < 0)
return r;
- r = sd_device_enumerator_add_match_subsystem(e, "power_supply", /* match = */ true);
+ r = sd_device_enumerator_add_match_subsystem(e, "power_supply", /* match= */ true);
if (r < 0)
return r;
if (r < 0)
return r;
- r = sd_device_enumerator_add_match_sysattr(e, "type", "Battery", /* match = */ true);
+ r = sd_device_enumerator_add_match_sysattr(e, "type", "Battery", /* match= */ true);
if (r < 0)
return r;
- r = sd_device_enumerator_add_match_sysattr(e, "present", "1", /* match = */ true);
+ r = sd_device_enumerator_add_match_sysattr(e, "present", "1", /* match= */ true);
if (r < 0)
return r;
- r = sd_device_enumerator_add_match_sysattr(e, "scope", "Device", /* match = */ false);
+ r = sd_device_enumerator_add_match_sysattr(e, "scope", "Device", /* match= */ false);
if (r < 0)
return r;
if (sd_device_enumerator_new(&e) < 0)
return log_oom();
- r = sd_device_enumerator_add_match_subsystem(e, "block", /* match = */ true);
+ r = sd_device_enumerator_add_match_subsystem(e, "block", /* match= */ true);
if (r < 0)
return log_error_errno(r, "Failed to add subsystem match: %m");
if (r < 0)
return r;
- r = sd_device_enumerator_add_match_subsystem(e, "block", /* match = */ true);
+ r = sd_device_enumerator_add_match_subsystem(e, "block", /* match= */ true);
if (r < 0)
return r;
return false;
/* Pass invalid cgroup fd intentionally. */
- link = sym_bpf_program__attach_cgroup(prog, /*cgroup_fd=*/-1);
+ link = sym_bpf_program__attach_cgroup(prog, /* cgroup_fd= */ -1);
/* EBADF indicates that bpf_link is supported by kernel. */
return bpf_get_error_translated(link) == -EBADF;
* As our baseline on the kernel is v5.4, it is enough to check if one BPF program can be created and loaded. */
_cleanup_(bpf_program_freep) BPFProgram *program = NULL;
- r = bpf_program_new(BPF_PROG_TYPE_CGROUP_SKB, /* prog_name = */ NULL, &program);
+ r = bpf_program_new(BPF_PROG_TYPE_CGROUP_SKB, /* prog_name= */ NULL, &program);
if (r < 0)
return cached = log_debug_errno(r, "Can't allocate CGROUP SKB BPF program, assuming BPF is not supported: %m");
if (r < 0)
return cached = log_debug_errno(r, "Can't add trivial instructions to CGROUP SKB BPF program, assuming BPF is not supported: %m");
- r = bpf_program_load_kernel(program, /* log_buf = */ NULL, /* log_size = */ 0);
+ r = bpf_program_load_kernel(program, /* log_buf= */ NULL, /* log_size= */ 0);
if (r < 0)
return cached = log_debug_errno(r, "Can't load kernel CGROUP SKB BPF program, assuming BPF is not supported: %m");
assert(m);
- return sd_bus_message_read(m, "(uo)", p, /* path = */ NULL);
+ return sd_bus_message_read(m, "(uo)", p, /* path= */ NULL);
}
static int map_basic(sd_bus_message *m, unsigned flags, void *userdata) {
_cleanup_(sd_bus_message_unrefp) sd_bus_message *request = NULL, *reply = NULL;
int authorized = false, challenge = false;
- r = bus_message_new_polkit_auth_call_for_bus(call, action, details, /* flags = */ 0, &request);
+ r = bus_message_new_polkit_auth_call_for_bus(call, action, details, /* flags= */ 0, &request);
if (r < 0)
return r;
r = bus_call_method(f->bus, bus_systemd_mgr,
freeze ? "FreezeUnit" : "ThawUnit",
&error,
- /* ret_reply = */ NULL,
+ /* ret_reply= */ NULL,
"s",
f->name);
if (r < 0) {
r = sd_bus_call_method(bus,
"org.freedesktop.DBus", "/org/freedesktop/DBus", "org.freedesktop.DBus", "GetId",
- /* reterr_error = */ NULL, &reply, NULL);
+ /* reterr_error= */ NULL, &reply, NULL);
if (r < 0)
return r;
assert(m);
- r = sd_bus_message_read(m, "uoss", /* id = */ NULL, &path, &unit, &result);
+ r = sd_bus_message_read(m, "uoss", /* id= */ NULL, &path, &unit, &result);
if (r < 0) {
bus_log_parse_error(r);
return 0;
}
static void format_chain(FILE *f, int space, const CalendarComponent *c, bool usec) {
- _format_chain(f, space, c, /* start = */ true, usec);
+ _format_chain(f, space, c, /* start= */ true, usec);
}
int calendar_spec_to_string(const CalendarSpec *c, char **ret) {
SAVE_TIMEZONE;
- r = RET_NERRNO(setenv("TZ", spec->timezone, /* overwrite = */ true));
+ r = RET_NERRNO(setenv("TZ", spec->timezone, /* overwrite= */ true));
if (r < 0)
return r;
_cleanup_free_ char *fs = NULL;
int r;
- r = cg_get_path(path, /* suffix = */ NULL, &fs);
+ r = cg_get_path(path, /* suffix= */ NULL, &fs);
if (r < 0)
return r;
r = recurse_dir_at(
AT_FDCWD,
fs,
- /* statx_mask = */ 0,
- /* n_depth_max = */ UINT_MAX,
+ /* statx_mask= */ 0,
+ /* n_depth_max= */ UINT_MAX,
RECURSE_DIR_ENSURE_TYPE,
trim_cb,
- /* userdata = */ NULL);
+ /* userdata= */ NULL);
if (r == -ENOENT) /* non-existing is the ultimate trimming, hence no error */
r = 0;
else if (r < 0)
_cleanup_free_ char *fs = NULL;
int r;
- r = cg_get_path(path, /* suffix = */ NULL, &fs);
+ r = cg_get_path(path, /* suffix= */ NULL, &fs);
if (r < 0)
return r;
return 0;
/* Configure access to the cgroup itself */
- r = cg_get_path(path, /* suffix = */ NULL, &fs);
+ r = cg_get_path(path, /* suffix= */ NULL, &fs);
if (r < 0)
return r;
if (!uid_is_valid(uid) && !gid_is_valid(gid))
return 0;
- r = cg_get_path(path, /* suffix = */ NULL, &fs);
+ r = cg_get_path(path, /* suffix= */ NULL, &fs);
if (r < 0)
return r;
done = false;
- r = set_ensure_put(&s, /* hash_ops = */ NULL, PID_TO_PTR(pid));
+ r = set_ensure_put(&s, /* hash_ops= */ NULL, PID_TO_PTR(pid));
if (r < 0)
return RET_GATHER(ret, r);
}
*
* ENODEV is generated when we enumerate processes from a cgroup and the cgroup is removed
* concurrently. */
- r = cg_read_pid(f, &pid, /* flags = */ 0);
+ r = cg_read_pid(f, &pid, /* flags= */ 0);
if (IN_SET(r, 0, -EOPNOTSUPP, -ENODEV))
break;
if (r < 0)
assert(path);
- r = cg_get_path(path, /* suffix = */ NULL, &p);
+ r = cg_get_path(path, /* suffix= */ NULL, &p);
if (r < 0)
return r;
/* Drop any ACL if there is one */
FOREACH_STRING(n, "system.posix_acl_access", "system.posix_acl_default") {
- r = xremovexattr(fd, /* path = */ NULL, AT_EMPTY_PATH, n);
+ r = xremovexattr(fd, /* path= */ NULL, AT_EMPTY_PATH, n);
if (r < 0 && !ERRNO_IS_NEG_XATTR_ABSENT(r))
return r;
}
assert(c->parameter);
assert(c->type == CONDITION_NEEDS_UPDATE);
- r = proc_cmdline_get_bool("systemd.condition_needs_update", /* flags = */ 0, &b);
+ r = proc_cmdline_get_bool("systemd.condition_needs_update", /* flags= */ 0, &b);
if (r < 0)
log_debug_errno(r, "Failed to parse systemd.condition_needs_update= kernel command line argument, ignoring: %m");
if (r > 0)
assert(c->parameter);
assert(c->type == CONDITION_PATH_IS_MOUNT_POINT);
- return path_is_mount_point_full(c->parameter, /* root = */ NULL, AT_SYMLINK_FOLLOW) > 0;
+ return path_is_mount_point_full(c->parameter, /* root= */ NULL, AT_SYMLINK_FOLLOW) > 0;
}
static int condition_test_path_is_read_write(Condition *c, char **env) {
if (!strextend(&dropin_dirname, ".d"))
return -ENOMEM;
- r = conf_files_list_dropins(&files, dropin_dirname, /* root = */ NULL, conf_file_dirs);
+ r = conf_files_list_dropins(&files, dropin_dirname, /* root= */ NULL, conf_file_dirs);
if (r < 0)
return r;
return log_oom();
}
- r = strv_extend_strv_consume(sv, TAKE_PTR(strv), /* filter_duplicates = */ ltype);
+ r = strv_extend_strv_consume(sv, TAKE_PTR(strv), /* filter_duplicates= */ ltype);
if (r < 0)
return log_oom();
return ignoring ? 0 : r;
}
if (r < 0)
- return log_syntax_parse_error_full(unit, filename, line, r, /* critical = */ !ignoring, lvalue, rvalue);
+ return log_syntax_parse_error_full(unit, filename, line, r, /* critical= */ !ignoring, lvalue, rvalue);
return 1; /* Return 1 if something was set */
}
#define log_section_full_errno_zerook(section, level, error, ...) \
({ \
const ConfigSection *_s = (section); \
- log_syntax(/* unit = */ NULL, \
+ log_syntax(/* unit= */ NULL, \
level, \
_s ? _s->filename : NULL, \
_s ? _s->line : 0, \
if (fdt < 0)
return -errno;
- r = prepare_nocow(fdf, /*from=*/ NULL, fdt, /*chattr_mask=*/ NULL, /*chattr_flags=*/ NULL);
+ r = prepare_nocow(fdf, /* from= */ NULL, fdt, /* chattr_mask= */ NULL, /* chattr_flags= */ NULL);
if (r < 0)
return r;
return fdt;
}
- r = prepare_nocow(fdf, /*from=*/ NULL, fdt, &chattr_mask, &chattr_flags);
+ r = prepare_nocow(fdf, /* from= */ NULL, fdt, &chattr_mask, &chattr_flags);
if (r < 0)
return r;
if (r < 0)
return r;
- RET_GATHER(ret, xsetxattr_full(dt, to, /* at_flags = */ 0, p, value, value_size, /* xattr_flags = */ 0));
+ RET_GATHER(ret, xsetxattr_full(dt, to, /* at_flags= */ 0, p, value, value_size, /* xattr_flags= */ 0));
}
return ret;
assert(ret);
r = config_parse_cpu_set(
- /* unit = */ NULL,
- /* filename = */ NULL,
- /* line = */ 0,
- /* section = */ NULL,
- /* section_line = */ 0,
- /* lvalue = */ NULL,
- /* ltype = */ 1,
- /* rvalue = */ s,
- /* data = */ &c,
- /* userdata = */ NULL);
+ /* unit= */ NULL,
+ /* filename= */ NULL,
+ /* line= */ 0,
+ /* section= */ NULL,
+ /* section_line= */ 0,
+ /* lvalue= */ NULL,
+ /* ltype= */ 1,
+ /* rvalue= */ s,
+ /* data= */ &c,
+ /* userdata= */ NULL);
if (r < 0)
return r;
assert(name);
- r = sd_notifyf(/* unset_environment = */ false,
+ r = sd_notifyf(/* unset_environment= */ false,
"FDSTOREREMOVE=1\n"
"FDNAME=%s", name);
if (r < 0)
/* Remove existing fds with the same name in fdstore. */
(void) notify_remove_fd_warn(name);
- return sd_pid_notify_with_fds(0, /* unset_environment = */ false, state, &fd, 1);
+ return sd_pid_notify_with_fds(0, /* unset_environment= */ false, state, &fd, 1);
}
int notify_push_fdf(int fd, const char *format, ...) {
int notify_reloading_full(const char *status) {
int r;
- r = sd_notifyf(/* unset_environment = */ false,
+ r = sd_notifyf(/* unset_environment= */ false,
"RELOADING=1\n"
"MONOTONIC_USEC=" USEC_FMT
"%s%s",
if (r < 0)
return r;
- r = btrfs_qgroup_set_limit(pool, /* qgroupid = */ 0, referenced_max);
+ r = btrfs_qgroup_set_limit(pool, /* qgroupid= */ 0, referenced_max);
if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
return r;
if (r < 0)
log_debug_errno(r, "Failed to set limit on btrfs quota group for '%s', ignoring: %m", pool);
- r = btrfs_subvol_set_subtree_quota_limit(pool, /* subvol_id = */ 0, referenced_max);
+ r = btrfs_subvol_set_subtree_quota_limit(pool, /* subvol_id= */ 0, referenced_max);
if (ERRNO_IS_NEG_NOT_SUPPORTED(r))
return r;
if (r < 0)
return r;
if (FLAGS_SET(flags, DISSECT_IMAGE_PIN_PARTITION_DEVICES)) {
- mount_node_fd = open_partition(devname, /* is_partition = */ false, m->loop);
+ mount_node_fd = open_partition(devname, /* is_partition= */ false, m->loop);
if (mount_node_fd < 0)
return mount_node_fd;
}
if (FLAGS_SET(flags, DISSECT_IMAGE_PIN_PARTITION_DEVICES) &&
type.designator != PARTITION_SWAP) {
- mount_node_fd = open_partition(node, /* is_partition = */ true, m->loop);
+ mount_node_fd = open_partition(node, /* is_partition= */ true, m->loop);
if (mount_node_fd < 0)
return mount_node_fd;
}
continue;
if (FLAGS_SET(flags, DISSECT_IMAGE_PIN_PARTITION_DEVICES)) {
- mount_node_fd = open_partition(node, /* is_partition = */ true, m->loop);
+ mount_node_fd = open_partition(node, /* is_partition= */ true, m->loop);
if (mount_node_fd < 0)
return mount_node_fd;
}
const char *options;
if (FLAGS_SET(flags, DISSECT_IMAGE_PIN_PARTITION_DEVICES)) {
- mount_node_fd = open_partition(generic_node, /* is_partition = */ true, m->loop);
+ mount_node_fd = open_partition(generic_node, /* is_partition= */ true, m->loop);
if (mount_node_fd < 0)
return mount_node_fd;
}
int slash_boot_is_available = 0;
if (where) {
- r = slash_boot_is_available = mount_point_is_available(where, "/boot", /* missing_ok = */ true);
+ r = slash_boot_is_available = mount_point_is_available(where, "/boot", /* missing_ok= */ true);
if (r < 0)
return r;
}
* and is empty. */
if (slash_boot_is_available) {
- r = mount_point_is_available(where, "/boot", /* missing_ok = */ false);
+ r = mount_point_is_available(where, "/boot", /* missing_ok= */ false);
if (r < 0)
return r;
if (r > 0)
}
if (!esp_path) {
- r = mount_point_is_available(where, "/efi", /* missing_ok = */ true);
+ r = mount_point_is_available(where, "/efi", /* missing_ok= */ true);
if (r < 0)
return r;
if (r > 0)
}
if (!ja)
- return sd_json_variant_new_array(ret, /* array=*/ NULL, /* n= */ 0);
+ return sd_json_variant_new_array(ret, /* array= */ NULL, /* n= */ 0);
*ret = TAKE_PTR(ja);
return 0;
return log_error_errno(r, "Failed to read stdin: %m");
} else {
FOREACH_ARRAY(editfile, context->files, context->n_files) {
- r = create_edit_temp_file(editfile, /* contents = */ NULL, /* contents_size = */ 0);
+ r = create_edit_temp_file(editfile, /* contents= */ NULL, /* contents_size= */ 0);
if (r < 0)
return r;
}
return 0;
}
- return execute_strv(name, paths, /* root = */ NULL, timeout, callbacks, callback_args, argv, envp, flags);
+ return execute_strv(name, paths, /* root= */ NULL, timeout, callbacks, callback_args, argv, envp, flags);
}
static int gather_environment_generate(int fd, void *arg) {
if (r < 0)
return r;
- if (setenv(*x, *y, /* overwrite = */ true) < 0)
+ if (setenv(*x, *y, /* overwrite= */ true) < 0)
return -errno;
}
* This replicated here and each element gets added to the set
* one-by-one.
*/
- r = sd_nfnl_nft_message_new_setelems(nfnl, &m, /* add = */ true, nfproto, table_name, set_name);
+ r = sd_nfnl_nft_message_new_setelems(nfnl, &m, /* add= */ true, nfproto, table_name, set_name);
if (r < 0)
return r;
assert(key);
assert(data || dlen == 0);
- r = sd_nfnl_nft_message_new_setelems(nfnl, &m, /* add = */ false, nfproto, table_name, set_name);
+ r = sd_nfnl_nft_message_new_setelems(nfnl, &m, /* add= */ false, nfproto, table_name, set_name);
if (r < 0)
return r;
SD_EVENT_PRIORITY_NORMAL-10, /* We want the notification message from the child before the SIGCHLD */
on_child_notify,
&child,
- /* accept_fds = */ false,
+ /* accept_fds= */ false,
&addr_string,
¬ify_event_source);
if (r < 0)
else
ret = format_timestamp_relative_full(p, FORMAT_TIMESTAMP_RELATIVE_MAX,
d->timestamp, CLOCK_REALTIME,
- /* implicit_left = */ d->type == TABLE_TIMESTAMP_LEFT);
+ /* implicit_left= */ d->type == TABLE_TIMESTAMP_LEFT);
if (!ret)
return "-";
}
if (ret_filtered) {
- filtered = strv_join_full(filtered_strv, ",", NULL, /* escape_separator = */ true);
+ filtered = strv_join_full(filtered_strv, ",", NULL, /* escape_separator= */ true);
if (!filtered)
return -ENOMEM;
}
if (r < 0)
return log_error_errno(r, "Failed to convert device \"%s\" to unit name: %m", what);
- r = generator_open_unit_file(dir, /* source = */ NULL, unit, &f);
+ r = generator_open_unit_file(dir, /* source= */ NULL, unit, &f);
if (r < 0)
return r;
return log_error_errno(r, "Failed to make unit name from path \"%s\": %m",
what);
- r = generator_open_unit_file(dir, /* source = */ NULL, unit, &f);
+ r = generator_open_unit_file(dir, /* source= */ NULL, unit, &f);
if (r < 0)
return r;
return log_error_errno(r, "Failed to make unit name from path \"%s\": %m",
where);
- r = generator_open_unit_file(dir, /* source = */ NULL, unit, &f);
+ r = generator_open_unit_file(dir, /* source= */ NULL, unit, &f);
if (r < 0)
return r;
if (!result_fiemap)
return -ENOMEM;
- /* XFS filesystem has incorrect implementation of fiemap ioctl and
- * returns extents for only one block-group at a time, so we need
- * to handle it manually, starting the next fiemap call from the end
- * of the last extent
- */
+ /* XFS filesystem has incorrect implementation of fiemap ioctl and
+ * returns extents for only one block-group at a time, so we need
+ * to handle it manually, starting the next fiemap call from the end
+ * of the last extent. */
while (fiemap_start < fiemap_length) {
*fiemap = (struct fiemap) {
.fm_start = fiemap_start,
assert(ret_devno);
assert(ret_offset);
- r = proc_cmdline_get_key("noresume", /* flags = */ 0, /* ret_value = */ NULL);
+ r = proc_cmdline_get_key("noresume", /* flags= */ 0, /* ret_value= */ NULL);
if (r < 0)
return log_debug_errno(r, "Failed to check if 'noresume' kernel command line option is set: %m");
if (r > 0)
return r;
char buf[LINUX_HOST_NAME_MAX+1];
- ssize_t n = loop_read(result_pipe[0], buf, sizeof(buf), /* do_poll = */ false);
+ ssize_t n = loop_read(result_pipe[0], buf, sizeof(buf), /* do_poll= */ false);
if (n < 0)
return n;
if (n == 0 || buf[n - 1] != '\0')
assert(verb);
- r = install_change_dump_error(i, &err_message, /* ret_bus_error = */ NULL);
+ r = install_change_dump_error(i, &err_message, /* ret_bus_error= */ NULL);
if (r == -ENOMEM)
return (void) log_oom();
if (r < 0)
}
bool broken;
- r = chase(alias_path, lp->root_dir, CHASE_NONEXISTENT, /* ret_path = */ NULL, /* ret_fd = */ NULL);
+ r = chase(alias_path, lp->root_dir, CHASE_NONEXISTENT, /* ret_path= */ NULL, /* ret_fd= */ NULL);
if (r < 0 && r != -ENOENT) {
RET_GATHER(ret, r);
continue;
if (!path)
return -ENOMEM;
- q = create_symlink(lp, info->path, path, /* force = */ true, changes, n_changes);
+ q = create_symlink(lp, info->path, path, /* force= */ true, changes, n_changes);
if (q != 0 && r >= 0)
r = q;
if (!full)
return -ENOMEM;
- r = verify_regular_at(AT_FDCWD, full, /* follow = */ false);
+ r = verify_regular_at(AT_FDCWD, full, /* follow= */ false);
if (r < 0)
return install_changes_add(changes, n_changes, r, *file, NULL);
compress_threshold_bytes,
metrics,
mmap_cache,
- /* template = */ NULL,
+ /* template= */ NULL,
ret);
if (!IN_SET(r,
-EBADMSG, /* Corrupted */
r = journal_file_open(-EBADF, fname,
(open_flags & ~(O_ACCMODE_STRICT|O_CREAT|O_EXCL)) | O_RDONLY,
file_flags, 0, compress_threshold_bytes, NULL,
- mmap_cache, /* template = */ NULL, &old_file);
+ mmap_cache, /* template= */ NULL, &old_file);
if (r < 0)
log_debug_errno(r, "Failed to continue sequence from file %s, ignoring: %m", fname);
return r;
return journal_file_open(-EBADF, fname, open_flags, file_flags, mode, compress_threshold_bytes, metrics,
- mmap_cache, /* template = */ old_file, ret);
+ mmap_cache, /* template= */ old_file, ret);
}
DEFINE_HASH_OPS_WITH_VALUE_DESTRUCTOR(
pe_header,
sections,
".osrel",
- /* max_size=*/ PE_SECTION_READ_MAX,
+ /* max_size= */ PE_SECTION_READ_MAX,
&osrel,
&osrel_size);
if (r == -ENXIO) { /* Section not found */
}
int mac_init_lazy(void) {
- return init_internal(/* lazy=*/ true);
+ return init_internal(/* lazy= */ true);
}
int mac_init(void) {
- return init_internal(/* lazy=*/ false);
+ return init_internal(/* lazy= */ false);
}
return add_local_address_full(
list, n_list, ifindex,
- scope, /* priority = */ 0, /* weight = */ 0,
- family, address, /* prefsrc = */ NULL);
+ scope, /* priority= */ 0, /* weight= */ 0,
+ family, address, /* prefsrc= */ NULL);
}
int local_addresses(
return add_local_address_full(
list, n_list,
ifindex,
- /* scope = */ 0, priority, weight,
+ /* scope= */ 0, priority, weight,
family, address, prefsrc);
}
r = add_local_gateway(list, n_list, rtnh->rtnh_ifindex, priority, rtnh->rtnh_hops, via->family,
&(union in_addr_union) { .in6 = via->address.in6 },
- /* prefsrc = */ NULL);
+ /* prefsrc= */ NULL);
if (r < 0)
return r;
/* Ignore prefsrc, and let's take the source address by socket command, if necessary. */
r = add_local_gateway(&list, &n_list, ifi, priority, 0, via.family,
&(union in_addr_union) { .in6 = via.address.in6 },
- /* prefsrc = */ NULL);
+ /* prefsrc= */ NULL);
if (r < 0)
return r;
}
return add_local_address_full(
list, n_list, ifindex,
- /* scope = */ 0, /* priority = */ 0, /* weight = */ 0,
- family, address, /* prefsrc = */ NULL);
+ /* scope= */ 0, /* priority= */ 0, /* weight= */ 0,
+ family, address, /* prefsrc= */ NULL);
}
static int add_local_outbound_by_prefsrc(
return add_matches_for_invocation_id(j, id);
if (type == LOG_SYSTEM_UNIT_INVOCATION_ID)
- return add_matches_for_unit_full(j, /* flags = */ 0, unit);
+ return add_matches_for_unit_full(j, /* flags= */ 0, unit);
if (type == LOG_USER_UNIT_INVOCATION_ID)
- return add_matches_for_user_unit_full(j, /* flags = */ 0, unit);
+ return add_matches_for_user_unit_full(j, /* flags= */ 0, unit);
return -EINVAL;
}
sd_id128_t *ret) {
return journal_find_log_id(j, LOG_BOOT_ID,
- /* boot_id = */ SD_ID128_NULL, /* unit = */ NULL,
+ /* boot_id= */ SD_ID128_NULL, /* unit= */ NULL,
id, offset, ret);
}
size_t *ret_n_ids) {
return journal_get_log_ids(j, LOG_BOOT_ID,
- /* boot_id = */ SD_ID128_NULL, /* unit = */ NULL,
+ /* boot_id= */ SD_ID128_NULL, /* unit= */ NULL,
advance_older, max_ids,
ret_ids, ret_n_ids);
}
dir_fd == AT_FDCWD ? path : NULL,
fd,
open_flags,
- /* offset = */ 0,
- /* size = */ 0,
+ /* offset= */ 0,
+ /* size= */ 0,
sector_size,
loop_flags,
lock_op,
WITH_UMASK(0022) {
r = id128_write_at(run_fd, "machine-id", ID128_FORMAT_PLAIN, machine_id);
if (r < 0) {
- (void) unlinkat(run_fd, "machine-id", /* flags = */ 0);
+ (void) unlinkat(run_fd, "machine-id", /* flags= */ 0);
return log_error_errno(r, "Cannot write '%s': %m", run_machine_id);
}
}
r = mount_follow_verbose(LOG_ERR, run_machine_id, FORMAT_PROC_FD_PATH(fd), /* fstype= */ NULL, MS_BIND, /* options= */ NULL);
if (r < 0) {
if (unlink_run_machine_id)
- (void) unlinkat(ASSERT_FD(run_fd), "machine-id", /* flags = */ 0);
+ (void) unlinkat(ASSERT_FD(run_fd), "machine-id", /* flags= */ 0);
return r;
}
etc_fd_again = safe_close(etc_fd_again);
/* Return to initial namespace and proceed a lazy tmpfs unmount */
- r = namespace_enter(/* pidns_fd = */ -EBADF,
+ r = namespace_enter(/* pidns_fd= */ -EBADF,
initial_mntns_fd,
- /* netns_fd = */ -EBADF,
- /* userns_fd = */ -EBADF,
- /* root_fd = */ -EBADF);
+ /* netns_fd= */ -EBADF,
+ /* userns_fd= */ -EBADF,
+ /* root_fd= */ -EBADF);
if (r < 0)
return log_warning_errno(r,
"Failed to switch back to initial mount namespace: %m.\n"
assert(root);
/* Return early if there's nothing to copy. */
- if (dir_is_empty(root, /*ignore_hidden_or_backup=*/ false))
+ if (dir_is_empty(root, /* ignore_hidden_or_backup= */ false))
return 0;
r = find_executable("mcopy", &mcopy);
r = safe_fork_full(
"(mkfs)",
stdio_fds,
- /*except_fds=*/ NULL,
- /*n_except_fds=*/ 0,
+ /* except_fds= */ NULL,
+ /* n_except_fds= */ 0,
fork_flags,
- /*ret_pid=*/ NULL);
+ /* ret_pid= */ NULL);
if (r < 0)
return r;
if (r == 0) {
/* Child */
STRV_FOREACH_PAIR(k, v, env)
- if (setenv(*k, *v, /* replace = */ true) < 0) {
+ if (setenv(*k, *v, /* replace= */ true) < 0) {
log_error_errno(r, "Failed to set %s=%s environment variable: %m", *k, *v);
_exit(EXIT_FAILURE);
}
if (proc_cmdline_value_missing(key, value))
return 0;
- r = strv_split_and_extend(denylist, value, ",", /* filter_duplicates = */ true);
+ r = strv_split_and_extend(denylist, value, ",", /* filter_duplicates= */ true);
if (r < 0)
return r;
}
_cleanup_free_ char *opts = NULL;
FOREACH_STRING(o, "memory_recursiveprot", "memory_hugetlb_accounting") {
- r = mount_option_supported("cgroup2", o, /* value = */ NULL);
+ r = mount_option_supported("cgroup2", o, /* value= */ NULL);
if (r < 0)
log_full_errno(priority, r, "Failed to determine whether cgroupfs supports '%s' mount option, assuming not: %m", o);
else if (r == 0)
if (relabel)
(void) label_fix(p->where, LABEL_IGNORE_ENOENT|LABEL_IGNORE_EROFS);
- r = path_is_mount_point_full(p->where, /* root = */ NULL, AT_SYMLINK_FOLLOW);
+ r = path_is_mount_point_full(p->where, /* root= */ NULL, AT_SYMLINK_FOLLOW);
if (r < 0 && r != -ENOENT) {
log_full_errno(priority, r, "Failed to determine whether %s is a mount point: %m", p->where);
return FLAGS_SET(p->mode, MNT_FATAL) ? r : 0;
* this is not supported (minimum kernel v6.5), or if there is no mount on the mountpoint, we get
* -EINVAL and then we fallback to normal mounting. */
- r = RET_NERRNO(move_mount(fsmount_fd, /* from_path = */ "",
- /* to_fd = */ -EBADF, dest,
+ r = RET_NERRNO(move_mount(fsmount_fd, /* from_path= */ "",
+ /* to_fd= */ -EBADF, dest,
MOVE_MOUNT_F_EMPTY_PATH | (mount_beneath ? MOVE_MOUNT_BENEATH : 0)));
if (mount_beneath) {
if (r >= 0) /* Mounting beneath worked! Now unmount the upper mount. */
log_debug_errno(r,
"Cannot mount beneath '%s', falling back to overmount: %m",
dest);
- return mount_exchange_graceful(fsmount_fd, dest, /* mount_beneath = */ false);
+ return mount_exchange_graceful(fsmount_fd, dest, /* mount_beneath= */ false);
}
}
if (!pidref_is_set(target))
return -ESRCH;
- r = pidref_namespace_open(target, &pidns_fd, &mntns_fd, /* ret_netns_fd = */ NULL, /* ret_userns_fd = */ NULL, &root_fd);
+ r = pidref_namespace_open(target, &pidns_fd, &mntns_fd, /* ret_netns_fd= */ NULL, /* ret_userns_fd= */ NULL, &root_fd);
if (r < 0)
return log_debug_errno(r, "Failed to retrieve FDs of the target process' namespace: %m");
src,
dest,
flags & ~MOUNT_IN_NAMESPACE_IS_IMAGE,
- /* options = */ NULL,
- /* image_policy = */ NULL);
+ /* options= */ NULL,
+ /* image_policy= */ NULL);
}
int mount_image_in_namespace(
assert(ret_mounts);
assert(ret_n_mounts);
- r = libmount_parse_mountinfo(/* source = */ NULL, &table, &iter);
+ r = libmount_parse_mountinfo(/* source= */ NULL, &table, &iter);
if (r < 0)
return log_debug_errno(r, "Failed to parse /proc/self/mountinfo: %m");
return -errno;
int mfd = fsmount(fs_fd, FSMOUNT_CLOEXEC,
- ms_flags_to_mount_attr(credentials_fs_mount_flags(/* ro = */ false)));
+ ms_flags_to_mount_attr(credentials_fs_mount_flags(/* ro= */ false)));
if (mfd < 0)
return -errno;
assert(path);
- mfd = fsmount_credentials_fs(/* ret_fsfd = */ NULL);
+ mfd = fsmount_credentials_fs(/* ret_fsfd= */ NULL);
if (mfd < 0)
return mfd;
if (ret_options)
r = libmount_parse_with_utab(&table, &iter);
else
- r = libmount_parse_mountinfo(/* source = */ NULL, &table, &iter);
+ r = libmount_parse_mountinfo(/* source= */ NULL, &table, &iter);
if (r < 0)
return log_debug_errno(r, "Failed to parse /proc/self/mountinfo: %m");
return r;
_cleanup_free_ char *fstype = NULL, *options = NULL;
- r = path_get_mount_info_at(fd, /* path = */ NULL, &fstype, &options, /* ret_source = */ NULL);
+ r = path_get_mount_info_at(fd, /* path= */ NULL, &fstype, &options, /* ret_source= */ NULL);
if (r < 0)
return r;
_cleanup_(OSSL_STORE_closep) OSSL_STORE_CTX *store = OSSL_STORE_open(
private_key_uri,
- /*ui_method=*/ NULL,
- /*ui_method=*/ NULL,
+ /* ui_method= */ NULL,
+ /* ui_method= */ NULL,
/* post_process= */ NULL,
/* post_process_data= */ NULL);
if (!store)
if (ENGINE_init(e) == 0)
return log_openssl_errors("Failed to initialize signing engine '%s'", engine);
- _cleanup_(EVP_PKEY_freep) EVP_PKEY *private_key = ENGINE_load_private_key(e, private_key_uri, /*ui_method=*/ NULL, /*callback_data=*/ NULL);
+ _cleanup_(EVP_PKEY_freep) EVP_PKEY *private_key = ENGINE_load_private_key(e, private_key_uri, /* ui_method= */ NULL, /* callback_data= */ NULL);
if (!private_key)
return log_openssl_errors("Failed to load private key from '%s'", private_key_uri);
REENABLE_WARNING;
_cleanup_(OSSL_STORE_closep) OSSL_STORE_CTX *store = OSSL_STORE_open(
certificate_uri,
- /*ui_method=*/ NULL,
- /*ui_method=*/ NULL,
+ /* ui_method= */ NULL,
+ /* ui_method= */ NULL,
/* post_process= */ NULL,
/* post_process_data= */ NULL);
if (!store)
*nr_ports = *port_min = 0;
else {
uint16_t mn = 0, mx = 0;
- r = parse_ip_port_range(token, &mn, &mx, /* allow_zero = */ true);
+ r = parse_ip_port_range(token, &mn, &mx, /* allow_zero= */ true);
if (r < 0)
return r;
check_reason = sym_passwdqc_check(¶ms->qc, password, old, &pw);
} else
- check_reason = sym_passwdqc_check(¶ms->qc, password, old, /* pw = */ NULL);
+ check_reason = sym_passwdqc_check(¶ms->qc, password, old, /* pw= */ NULL);
if (check_reason) {
if (ret_error) {
assert(p);
- r = conf_file_new(p, /* root = */ NULL, CHASE_MUST_BE_REGULAR, &c);
+ r = conf_file_new(p, /* root= */ NULL, CHASE_MUST_BE_REGULAR, &c);
if (r < 0)
return log_error_errno(r, "Failed to chase '%s': %m", p);
if (r < 0)
return log_device_debug_errno(d, r, "Failed to remove kernel partition device '%s' in order to recreate it: %m", subnode);
- /* And now add it the partition anew*/
+ /* And now add it the partition anew */
log_device_debug(d, "Successfully removed kernel partition device '%s' in order to recreate it.", subnode);
}
if (errno != EACCES || !FLAGS_SET(remove_flags, REMOVE_CHMOD))
return -errno;
- r = patch_dirfd_mode(dfd, /* refuse_already_set = */ true, &old_mode);
+ r = patch_dirfd_mode(dfd, /* refuse_already_set= */ true, &old_mode);
if (r < 0)
return r;
if (errno != EACCES || !FLAGS_SET(remove_flags, REMOVE_CHMOD))
return -errno;
- r = patch_dirfd_mode(dfd, /* refuse_already_set = */ true, &old_mode);
+ r = patch_dirfd_mode(dfd, /* refuse_already_set= */ true, &old_mode);
if (r < 0)
return r;
return pfd;
if (FLAGS_SET(remove_flags, REMOVE_CHMOD)) {
- r = patch_dirfd_mode(pfd, /* refuse_already_set = */ false, &old_mode);
+ r = patch_dirfd_mode(pfd, /* refuse_already_set= */ false, &old_mode);
if (r < 0)
return r;
_cleanup_free_ char *fdstr = NULL, *pidstr = NULL;
_cleanup_close_ int fd = -EBADF;
- r = extract_many_words(&e, ":", /* flags = */ 0, &fdstr, &pidstr);
+ r = extract_many_words(&e, ":", /* flags= */ 0, &fdstr, &pidstr);
if (r < 0)
return log_debug_errno(r, "Failed to deserialize pidref '%s': %m", e);
if (r == 0)
}
FOREACH_ELEMENT(i, operations) {
- r = sleep_supported_internal(sleep_config, *i, /* check_allowed = */ false, &support);
+ r = sleep_supported_internal(sleep_config, *i, /* check_allowed= */ false, &support);
if (r < 0)
return r;
if (r == 0) {
if (r < 0)
return r;
- r = sleep_supported_internal(sleep_config, operation, /* check_allowed = */ true, &support);
+ r = sleep_supported_internal(sleep_config, operation, /* check_allowed= */ true, &support);
if (r < 0)
return r;
return 0;
}
- return getxattr_at_malloc(fd, path, smack_attr_to_string(attr), /* at_flags = */ 0, ret, /* ret_size= */ NULL);
+ return getxattr_at_malloc(fd, path, smack_attr_to_string(attr), /* at_flags= */ 0, ret, /* ret_size= */ NULL);
#else
return -EOPNOTSUPP;
#endif
return 0;
if (!label)
- return xremovexattr(fd, path, /* at_flags = */ 0, smack_attr_to_string(attr));
+ return xremovexattr(fd, path, /* at_flags= */ 0, smack_attr_to_string(attr));
- return xsetxattr(fd, path, /* at_flags = */ 0, smack_attr_to_string(attr), label);
+ return xsetxattr(fd, path, /* at_flags= */ 0, smack_attr_to_string(attr), label);
#else
return 0;
#endif
else
return 0;
- r = xsetxattr(fd, /* path = */ NULL, AT_EMPTY_PATH, "security.SMACK64", label);
+ r = xsetxattr(fd, /* path= */ NULL, AT_EMPTY_PATH, "security.SMACK64", label);
if (ERRNO_IS_NEG_NOT_SUPPORTED(r)) /* If the FS doesn't support labels, then exit without warning */
return 0;
if (r == -EROFS && FLAGS_SET(flags, LABEL_IGNORE_EROFS)) /* If the FS is read-only and we were told
* file. Since the SMBIOS data is immutable after boot, it's safe to use read_full_file_full() here. */
r = read_full_file_full(
AT_FDCWD, p,
- /* offset = */ UINT64_MAX,
+ /* offset= */ UINT64_MAX,
size_add(offsetof(struct dmi_field_header, contents), max_size),
- /* flags = */ 0,
- /* bind_name = */ NULL,
+ /* flags= */ 0,
+ /* bind_name= */ NULL,
(char**) &data, &size);
if (r < 0)
return r;
char *t;
ASSERT_OK(mkdtemp_malloc("/tmp/fake-xdg-runtime-XXXXXX", &t));
- ASSERT_OK(setenv("XDG_RUNTIME_DIR", t, /* overwrite = */ true));
+ ASSERT_OK(setenv("XDG_RUNTIME_DIR", t, /* overwrite= */ true));
return t;
}
}
STRV_FOREACH_PAIR(k, v, pairs)
- ASSERT_OK(setenv(*k, *v, /* overwrite = */ false));
+ ASSERT_OK(setenv(*k, *v, /* overwrite= */ false));
}
int get_testdata_dir(const char *suffix, char **ret) {
/* Checks whether namespaces are available. In some cases they aren't. We do this by calling unshare(), and we
* do so in a child process in order not to affect our own process. */
- ASSERT_OK(r = pidref_safe_fork("(have_namespace)", /* flags = */ 0, &pid));
+ ASSERT_OK(r = pidref_safe_fork("(have_namespace)", /* flags= */ 0, &pid));
if (r == 0) {
/* child */
if (detach_mount_namespace() < 0)
_exit(EXIT_SUCCESS);
}
- ASSERT_OK(r = pidref_wait_for_terminate_and_check("(have_namespace)", &pid, /* flags = */ 0));
+ ASSERT_OK(r = pidref_wait_for_terminate_and_check("(have_namespace)", &pid, /* flags= */ 0));
if (r == EXIT_SUCCESS)
return true;
#include "shared-forward.h"
#include "log.h"
#include "log-assert-critical.h"
-#include "static-destruct.h" /* IWYU pragma: keep*/
-#include "signal-util.h" /* IWYU pragma: keep*/
+#include "static-destruct.h" /* IWYU pragma: keep */
+#include "signal-util.h" /* IWYU pragma: keep */
#include "stdio-util.h"
#include "string-util.h" /* IWYU pragma: keep */
/* root= */ NULL,
/* conf_root= */ NULL,
machine_id,
- /* machine_id_is_random = */ false,
+ /* machine_id_is_random= */ false,
&entry_token_type,
&entry_token);
if (r < 0)
r = sd_json_parse_file(
f,
discovered_path,
- /* flags = */ 0,
+ /* flags= */ 0,
&v,
/* reterr_line= */ NULL,
/* ret_column= */ NULL);
r = config_parse_standard_file_with_dropins(
"udev/udev.conf",
- /* sections = */ NULL,
+ /* sections= */ NULL,
config_item_table_lookup, config_table,
CONFIG_PARSE_WARN,
- /* userdata = */ NULL);
+ /* userdata= */ NULL);
if (r == -ENOENT)
return 0;
return r;
continue;
}
- r = is_dir(target, /* follow = */ true);
+ r = is_dir(target, /* follow= */ true);
if (r <= 0)
continue;
return json_log(e, flags, r, "Failed to append array element: %m");
}
- r = strv_extend_strv_consume(list, TAKE_PTR(l), /* filter_duplicates = */ true);
+ r = strv_extend_strv_consume(list, TAKE_PTR(l), /* filter_duplicates= */ true);
if (r < 0)
return json_log(variant, flags, r, "Failed to merge user/group arrays: %m");
if (!action)
action = sleep_operation_to_string(operation);
- if (setenv("SYSTEMD_SLEEP_ACTION", action, /* overwrite = */ 1) < 0)
+ if (setenv("SYSTEMD_SLEEP_ACTION", action, /* overwrite= */ 1) < 0)
log_warning_errno(errno, "Failed to set SYSTEMD_SLEEP_ACTION=%s, ignoring: %m", action);
(void) execute_directories(
r = event_reset_time_relative(
context->event, &context->idle_time, CLOCK_MONOTONIC,
arg_exit_idle_time, 0, idle_time_cb, context,
- SD_EVENT_PRIORITY_NORMAL, "idle-timer", /* force_reset = */ true);
+ SD_EVENT_PRIORITY_NORMAL, "idle-timer", /* force_reset= */ true);
if (r < 0)
log_warning_errno(r, "Failed to reset idle timer, ignoring: %m");
}
/* We look the argument in the kernel cmdline under the same name as the environment variable
* to express that this is not supported at the same level as the regular kernel cmdline
* switches. */
- r = proc_cmdline_get_bool("SYSTEMD_SULOGIN_FORCE", /* flags = */ 0, &force);
+ r = proc_cmdline_get_bool("SYSTEMD_SULOGIN_FORCE", /* flags= */ 0, &force);
if (r < 0)
log_debug_errno(r, "Failed to parse SYSTEMD_SULOGIN_FORCE from kernel command line, ignoring: %m");
}
}
return sysctl_write_or_warn(key, option->value,
- /* ignore_failure = */ option->ignore_failure,
- /* ignore_enoent = */ true);
+ /* ignore_failure= */ option->ignore_failure,
+ /* ignore_enoent= */ true);
}
pattern = path_join("/proc/sys", key);
RET_GATHER(r,
sysctl_write_or_warn(key, option->value,
- /* ignore_failure = */ option->ignore_failure,
- /* ignore_enoent = */ !arg_strict));
+ /* ignore_failure= */ option->ignore_failure,
+ /* ignore_enoent= */ !arg_strict));
}
return r;
k = apply_glob_option(sysctl_options, option);
else
k = sysctl_write_or_warn(option->key, option->value,
- /* ignore_failure = */ option->ignore_failure,
- /* ignore_enoent = */ !arg_strict);
+ /* ignore_failure= */ option->ignore_failure,
+ /* ignore_enoent= */ !arg_strict);
RET_GATHER(r, k);
}
static int parse_file(OrderedHashmap **sysctl_options, const char *path, bool ignore_enoent) {
return conf_file_read(
- /* root = */ NULL,
+ /* root= */ NULL,
(const char**) CONF_PATHS_STRV("sysctl.d"),
path,
parse_line,
sysctl_options,
ignore_enoent,
- /* invalid_config = */ NULL);
+ /* invalid_config= */ NULL);
}
static int read_credential_lines(OrderedHashmap **sysctl_options) {
STRV_FOREACH(arg, strv_skip(argv, optind)) {
if (arg_inline)
/* Use (argument):n, where n==1 for the first positional arg */
- RET_GATHER(r, parse_line("(argument)", ++pos, *arg, /* invalid_config = */ NULL, &sysctl_options));
+ RET_GATHER(r, parse_line("(argument)", ++pos, *arg, /* invalid_config= */ NULL, &sysctl_options));
else
RET_GATHER(r, parse_file(&sysctl_options, *arg, false));
}
image_class == IMAGE_SYSEXT ? "SysExt\0" : "ConfExt\0",
config_item_table_lookup, items,
CONFIG_PARSE_WARN,
- /* userdata = */ NULL,
- /* ret_stats_by_path = */ NULL,
- /* ret_dropin_files = */ NULL);
+ /* userdata= */ NULL,
+ /* ret_stats_by_path= */ NULL,
+ /* ret_dropin_files= */ NULL);
if (r < 0)
return r;
const char *extension_reload_manager = NULL;
int b;
- r = load_extension_release_pairs(arg_root, image_class, *extension, /* relax_extension_release_check = */ true, &extension_release);
+ r = load_extension_release_pairs(arg_root, image_class, *extension, /* relax_extension_release_check= */ true, &extension_release);
if (r < 0) {
log_debug_errno(r, "Failed to parse extension-release metadata of %s, ignoring: %m", *extension);
continue;
assert(!STR_IN_SET(start_verb, "start", "restart"));
- r = unit_name_replace_instance_full(unit_name, "*", /* accept_glob = */ true, &globbed);
+ r = unit_name_replace_instance_full(unit_name, "*", /* accept_glob= */ true, &globbed);
if (r < 0)
return log_error_errno(r, "Failed to glob unit name '%s': %m", unit_name);
continue;
}
- r = list_dependencies_print(*c, active_state, level, branches, /* last = */ c[1] == NULL && !circular);
+ r = list_dependencies_print(*c, active_state, level, branches, /* last= */ c[1] == NULL && !circular);
if (r < 0)
return r;
}
if (circular && !arg_plain) {
- r = list_dependencies_print("...", _UNIT_ACTIVE_STATE_INVALID, level, branches, /* last = */ true);
+ r = list_dependencies_print("...", _UNIT_ACTIVE_STATE_INVALID, level, branches, /* last= */ true);
if (r < 0)
return r;
}
if (!actions[a])
return -EINVAL;
- r = acquire_bus_full(BUS_FULL, /* graceful = */ true, &bus);
+ r = acquire_bus_full(BUS_FULL, /* graceful= */ true, &bus);
if (r < 0)
return r;
if (arg_transport != BUS_TRANSPORT_LOCAL)
return 0;
- r = acquire_bus_full(BUS_FULL, /* graceful = */ true, &bus);
+ r = acquire_bus_full(BUS_FULL, /* graceful= */ true, &bus);
if ((ERRNO_IS_NEG_DISCONNECT(r) || r == -ENOENT) && geteuid() == 0)
return 0; /* When D-Bus is not running (ECONNREFUSED) or D-Bus socket is not created (ENOENT),
* allow root to force a shutdown. E.g. when running at the emergency console. */
i->id,
i->log_namespace,
arg_output,
- /* n_columns = */ 0,
+ /* n_columns= */ 0,
i->inactive_exit_timestamp_monotonic,
arg_lines,
get_output_flags() | OUTPUT_BEGIN_NEWLINE,
* another active unit (socket, path, timer) */
if (!arg_quiet && !arg_no_warn)
STRV_FOREACH(unit, stopped_units)
- warn_triggering_units(bus, *unit, "Stopping", /* ignore_masked = */ true);
+ warn_triggering_units(bus, *unit, "Stopping", /* ignore_masked= */ true);
}
if (arg_wait) {
(void) unit_get_dependencies(bus, *name, &deps);
- if (strv_extend_strv_consume(&with_deps, deps, /* filter_duplicates = */ true) < 0)
+ if (strv_extend_strv_consume(&with_deps, deps, /* filter_duplicates= */ true) < 0)
return log_oom();
}
/* Our own process can never go away while querying, hence no need to go through pidfd. */
- r = get_unit_by_pid(bus, 0, &unit, /* ret_path = */ NULL);
+ r = get_unit_by_pid(bus, 0, &unit, /* ret_path= */ NULL);
if (r < 0)
return r;
if (r < 0)
return log_error_errno(r, "Invalid PID specified: %s", *pidstr);
- r = lookup_unit_by_pidref(bus, pid, &unit, /* ret_path = */ NULL);
+ r = lookup_unit_by_pidref(bus, pid, &unit, /* ret_path= */ NULL);
if (r < 0)
RET_GATHER(ret, r);
else
***/
#include "_sd-common.h"
-#include "sd-lldp.h" /* IWYU pragma: export*/
+#include "sd-lldp.h" /* IWYU pragma: export */
_SD_BEGIN_DECLARATIONS;
#include "_sd-common.h"
#include "sd-json.h"
-#include "sd-lldp.h" /* IWYU pragma: export*/
+#include "sd-lldp.h" /* IWYU pragma: export */
_SD_BEGIN_DECLARATIONS;
if (strlen(t) != sizeof(found.sha256sum) * 2)
goto nope;
- r = unhexmem_full(t, sizeof(found.sha256sum) * 2, /* secure = */ false, &d, &l);
+ r = unhexmem_full(t, sizeof(found.sha256sum) * 2, /* secure= */ false, &d, &l);
if (r == -ENOMEM)
return r;
if (r < 0)
if (p[0] == '\\')
return log_error_errno(SYNTHETIC_ERRNO(EOPNOTSUPP), "File names with escapes not supported in manifest at line %zu, refusing.", line_nr);
- r = unhexmem_full(p, 64, /* secure = */ false, &h, &hlen);
+ r = unhexmem_full(p, 64, /* secure= */ false, &h, &hlen);
if (r < 0)
return log_error_errno(r, "Failed to parse digest at manifest line %zu, refusing.", line_nr);
if (r < 0)
return r;
- r = resource_resolve_path(&t->target, root, /*relative_to_directory=*/ NULL, node);
+ r = resource_resolve_path(&t->target, root, /* relative_to_directory= */ NULL, node);
if (r < 0)
return r;
assert(overall <= 100);
log_debug("Transfer %zu/%zu is %u%% complete (%u%% overall).", i+1, n, percentage, overall);
- return sd_notifyf(/* unset_environment=*/ false, "X_SYSUPDATE_PROGRESS=%u\n"
+ return sd_notifyf(/* unset_environment= */ false, "X_SYSUPDATE_PROGRESS=%u\n"
"X_SYSUPDATE_TRANSFERS_LEFT=%zu\n"
"X_SYSUPDATE_TRANSFERS_DONE=%zu\n"
"STATUS=Updating to '%s' (%u%% complete).",
log_info("Selected update '%s' for install.", us->version);
- (void) sd_notifyf(/* unset_environment=*/ false,
+ (void) sd_notifyf(/* unset_environment= */ false,
"READY=1\n"
"X_SYSUPDATE_VERSION=%s\n"
"STATUS=Making room for '%s'.", us->version, us->version);
* download succeeded already, in which case we shouldn't remove it just to acquire it again */
r = context_vacuum(
c,
- /* space = */ 1,
- /* extra_protected_version = */ us->version);
+ /* space= */ 1,
+ /* extra_protected_version= */ us->version);
if (r < 0)
return r;
if (arg_sync)
sync();
- (void) sd_notifyf(/* unset_environment=*/ false,
+ (void) sd_notifyf(/* unset_environment= */ false,
"STATUS=Updating to '%s'.", us->version);
/* There should now be one instance picked for each transfer, and the order is the same */
if (arg_sync)
sync();
- (void) sd_notifyf(/* unset_environment=*/ false,
+ (void) sd_notifyf(/* unset_environment= */ false,
"STATUS=Installing '%s'.", us->version);
for (size_t i = 0; i < c->n_transfers; i++) {
log_info("%s Successfully installed update '%s'.", glyph(GLYPH_SPARKLES), us->version);
- (void) sd_notifyf(/* unset_environment=*/ false,
+ (void) sd_notifyf(/* unset_environment= */ false,
"STATUS=Installed '%s'.", us->version);
if (ret_applied)
return 0;
}
- r = sd_json_parse_file_at(/* f = */ NULL, fd, /* path = */ NULL, /* flags = */ 0,
- &v, /* reterr_line = */ NULL, /* reterr_column = */ NULL);
+ r = sd_json_parse_file_at(/* f= */ NULL, fd, /* path= */ NULL, /* flags= */ 0,
+ &v, /* reterr_line= */ NULL, /* reterr_column= */ NULL);
if (r < 0)
return log_debug_errno(r, "Failed to parse child output as JSON: %m");
if (r < 0)
return r;
- r = strv_extend_strv_consume(&urls, target_appstream, /* filter_duplicates = */ true);
+ r = strv_extend_strv_consume(&urls, target_appstream, /* filter_duplicates= */ true);
if (r < 0)
return r;
}
assert_se(sd_device_enumerator_new(&e) >= 0);
assert_se(sd_device_enumerator_allow_uninitialized(e) >= 0);
- assert_se(sd_device_enumerator_add_match_subsystem(e, "block", /* match = */ true) >= 0);
+ assert_se(sd_device_enumerator_add_match_subsystem(e, "block", /* match= */ true) >= 0);
FOREACH_DEVICE(e, dev) {
_cleanup_close_ int fd = -EBADF;
if (r < 0)
return log_tests_skipped_errno(r, "Failed to prepare cgroup subtree");
- r = cg_get_path(cgroup, /* suffix = */ NULL, &controller_path);
+ r = cg_get_path(cgroup, /* suffix= */ NULL, &controller_path);
ASSERT_OK(r);
_cleanup_(bpf_program_freep) BPFProgram *prog = NULL;
if (!can_memlock())
return log_tests_skipped("Can't use mlock()");
- if (!bpf_restrict_fs_supported(/* initialize = */ true))
+ if (!bpf_restrict_fs_supported(/* initialize= */ true))
return log_tests_skipped("LSM BPF hooks are not supported");
r = enter_cgroup_subroot(NULL);
if (bpffs_fd < 0)
return log_error_errno(errno, "Failed to open '/sys/fs/bpf': %m");
- _cleanup_close_ int token_fd = bpf_token_create(bpffs_fd, /* opts = */ NULL);
+ _cleanup_close_ int token_fd = bpf_token_create(bpffs_fd, /* opts= */ NULL);
if (token_fd < 0)
return log_error_errno(errno, "Failed to create bpf token: %m");
ASSERT_TRUE(path_equal(path, test_d));
free(path);
- ASSERT_OK_ZERO(cg_get_path(test_d, /* suffix = */ NULL, &path));
+ ASSERT_OK_ZERO(cg_get_path(test_d, /* suffix= */ NULL, &path));
log_debug("test_d: %s", path);
ASSERT_TRUE(path_equal(path, strjoina("/sys/fs/cgroup", test_d)));
free(path);
memzero(buf, MIN(size + 1000, MAX_SIZE));
- r = compress(text, size, buf, size, &j, /* level = */ -1);
+ r = compress(text, size, buf, size, &j, /* level= */ -1);
/* assume compression must be successful except for small or random inputs */
assert_se(r >= 0 || (size < 2048 && r == -ENOBUFS) || streq(type, "random"));
log_info("/* testing %s %s blob compression/decompression */",
compression, data);
- r = compress(data, data_len, compressed, sizeof(compressed), &csize, /* level = */ -1);
+ r = compress(data, data_len, compressed, sizeof(compressed), &csize, /* level= */ -1);
if (r == -ENOBUFS) {
log_info_errno(r, "compression failed: %m");
assert_se(may_fail);
compressed = compressed1 = malloc(BUFSIZE_1);
assert_se(compressed1);
- r = compress(data, data_len, compressed, BUFSIZE_1, &csize, /* level = */ -1);
+ r = compress(data, data_len, compressed, BUFSIZE_1, &csize, /* level= */ -1);
if (r == -ENOBUFS) {
log_info_errno(r, "compression failed: %m");
assert_se(may_fail);
compressed = compressed2 = malloc(BUFSIZE_2);
assert_se(compressed2);
- r = compress(data, data_len, compressed, BUFSIZE_2, &csize, /* level = */ -1);
+ r = compress(data, data_len, compressed, BUFSIZE_2, &csize, /* level= */ -1);
}
assert_se(r >= 0);
log_info("/* %s with %s */", __func__, compression);
- r = compress(TEXT, sizeof TEXT, buf, sizeof buf, &csize, /* level = */ -1);
+ r = compress(TEXT, sizeof TEXT, buf, sizeof buf, &csize, /* level= */ -1);
assert_se(r >= 0);
for (size_t i = 1; i < strlen(TEXT); i++) {
}
ASSERT_OK(touch(strjoina(t2, "/absolute-empty.real")));
- ASSERT_OK(symlinkat_atomic_full(strjoina(t2, "/absolute-empty.real"), AT_FDCWD, strjoina(search3, "absolute-empty.conf"), /* flags = */ 0));
+ ASSERT_OK(symlinkat_atomic_full(strjoina(t2, "/absolute-empty.real"), AT_FDCWD, strjoina(search3, "absolute-empty.conf"), /* flags= */ 0));
ASSERT_OK(write_string_file_at(tfd2, "absolute-non-empty.real", "absolute-non-empty", WRITE_STRING_FILE_CREATE));
- ASSERT_OK(symlinkat_atomic_full(strjoina(t2, "/absolute-non-empty.real"), AT_FDCWD, strjoina(search3, "absolute-non-empty.conf"), /* flags = */ 0));
+ ASSERT_OK(symlinkat_atomic_full(strjoina(t2, "/absolute-non-empty.real"), AT_FDCWD, strjoina(search3, "absolute-non-empty.conf"), /* flags= */ 0));
ASSERT_OK(touch(strjoina(t2, "/relative-empty.real")));
ASSERT_OK(symlinkat_atomic_full(strjoina(t2, "/relative-empty.real"), AT_FDCWD, strjoina(search3, "relative-empty.conf"), SYMLINK_MAKE_RELATIVE));
ASSERT_OK(symlinkat_atomic_full(strjoina(t2, "/relative-non-empty.real"), AT_FDCWD, strjoina(search3, "relative-non-empty.conf"), SYMLINK_MAKE_RELATIVE));
ASSERT_OK(touch(strjoina(t, "/absolute-empty-for-root.real")));
- ASSERT_OK(symlinkat_atomic_full("/absolute-empty-for-root.real", AT_FDCWD, strjoina(search3, "absolute-empty-for-root.conf"), /* flags = */ 0));
+ ASSERT_OK(symlinkat_atomic_full("/absolute-empty-for-root.real", AT_FDCWD, strjoina(search3, "absolute-empty-for-root.conf"), /* flags= */ 0));
ASSERT_OK(write_string_file_at(tfd, "absolute-non-empty-for-root.real", "absolute-non-empty", WRITE_STRING_FILE_CREATE));
- ASSERT_OK(symlinkat_atomic_full("/absolute-non-empty-for-root.real", AT_FDCWD, strjoina(search3, "absolute-non-empty-for-root.conf"), /* flags = */ 0));
+ ASSERT_OK(symlinkat_atomic_full("/absolute-non-empty-for-root.real", AT_FDCWD, strjoina(search3, "absolute-non-empty-for-root.conf"), /* flags= */ 0));
ASSERT_OK(touch(strjoina(t, "/relative-empty-for-root.real")));
- ASSERT_OK(symlinkat_atomic_full("../../../../relative-empty-for-root.real", AT_FDCWD, strjoina(search3, "relative-empty-for-root.conf"), /* flags = */ 0));
+ ASSERT_OK(symlinkat_atomic_full("../../../../relative-empty-for-root.real", AT_FDCWD, strjoina(search3, "relative-empty-for-root.conf"), /* flags= */ 0));
ASSERT_OK(write_string_file_at(tfd, "relative-non-empty-for-root.real", "relative-non-empty", WRITE_STRING_FILE_CREATE));
- ASSERT_OK(symlinkat_atomic_full("../../../../relative-non-empty-for-root.real", AT_FDCWD, strjoina(search3, "relative-non-empty-for-root.conf"), /* flags = */ 0));
+ ASSERT_OK(symlinkat_atomic_full("../../../../relative-non-empty-for-root.real", AT_FDCWD, strjoina(search3, "relative-non-empty-for-root.conf"), /* flags= */ 0));
search1_a = strjoina(search1, "a.conf");
search1_b = strjoina(search1, "b.conf");
result = strv_free(result);
/* search dir3 */
- ASSERT_OK(conf_files_list(&result, /* suffix = */ NULL, /* root = */ NULL, CONF_FILES_FILTER_MASKED, search3));
+ ASSERT_OK(conf_files_list(&result, /* suffix= */ NULL, /* root= */ NULL, CONF_FILES_FILTER_MASKED, search3));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-non-empty.conf"),
strjoina(search3, "relative-non-empty.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list(&result, /* suffix = */ NULL, /* root = */ NULL, CONF_FILES_FILTER_MASKED_BY_EMPTY, search3));
+ ASSERT_OK(conf_files_list(&result, /* suffix= */ NULL, /* root= */ NULL, CONF_FILES_FILTER_MASKED_BY_EMPTY, search3));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-non-empty.conf"),
strjoina(search3, "relative-non-empty.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list(&result, /* suffix = */ NULL, /* root = */ NULL, CONF_FILES_FILTER_MASKED_BY_SYMLINK, search3));
+ ASSERT_OK(conf_files_list(&result, /* suffix= */ NULL, /* root= */ NULL, CONF_FILES_FILTER_MASKED_BY_SYMLINK, search3));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-empty.conf"),
strjoina(search3, "absolute-non-empty.conf"),
strjoina(search3, "relative-non-empty.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list(&result, /* suffix = */ NULL, /* root = */ NULL, CONF_FILES_REGULAR, search3));
+ ASSERT_OK(conf_files_list(&result, /* suffix= */ NULL, /* root= */ NULL, CONF_FILES_REGULAR, search3));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-empty.conf"),
strjoina(search3, "absolute-non-empty.conf"),
strjoina(search3, "relative-non-empty.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list(&result, /* suffix = */ NULL, t, CONF_FILES_FILTER_MASKED, "/dir3/"));
+ ASSERT_OK(conf_files_list(&result, /* suffix= */ NULL, t, CONF_FILES_FILTER_MASKED, "/dir3/"));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-non-empty-for-root.conf"),
strjoina(search3, "relative-non-empty-for-root.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list(&result, /* suffix = */ NULL, t, CONF_FILES_FILTER_MASKED_BY_EMPTY, "/dir3/"));
+ ASSERT_OK(conf_files_list(&result, /* suffix= */ NULL, t, CONF_FILES_FILTER_MASKED_BY_EMPTY, "/dir3/"));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-non-empty-for-root.conf"),
strjoina(search3, "relative-non-empty-for-root.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list(&result, /* suffix = */ NULL, t, CONF_FILES_FILTER_MASKED_BY_SYMLINK, "/dir3/"));
+ ASSERT_OK(conf_files_list(&result, /* suffix= */ NULL, t, CONF_FILES_FILTER_MASKED_BY_SYMLINK, "/dir3/"));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-empty-for-root.conf"),
strjoina(search3, "absolute-non-empty-for-root.conf"),
strjoina(search3, "relative-non-empty-for-root.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list(&result, /* suffix = */ NULL, t, CONF_FILES_REGULAR, "/dir3/"));
+ ASSERT_OK(conf_files_list(&result, /* suffix= */ NULL, t, CONF_FILES_REGULAR, "/dir3/"));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-empty-for-root.conf"),
strjoina(search3, "absolute-non-empty-for-root.conf"),
strjoina(search3, "relative-non-empty-for-root.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list_at(&result, /* suffix = */ NULL, AT_FDCWD, CONF_FILES_FILTER_MASKED, search3));
+ ASSERT_OK(conf_files_list_at(&result, /* suffix= */ NULL, AT_FDCWD, CONF_FILES_FILTER_MASKED, search3));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-non-empty.conf"),
strjoina(search3, "relative-non-empty.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list_at(&result, /* suffix = */ NULL, AT_FDCWD, CONF_FILES_FILTER_MASKED_BY_EMPTY, search3));
+ ASSERT_OK(conf_files_list_at(&result, /* suffix= */ NULL, AT_FDCWD, CONF_FILES_FILTER_MASKED_BY_EMPTY, search3));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-non-empty.conf"),
strjoina(search3, "relative-non-empty.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list_at(&result, /* suffix = */ NULL, AT_FDCWD, CONF_FILES_FILTER_MASKED_BY_SYMLINK, search3));
+ ASSERT_OK(conf_files_list_at(&result, /* suffix= */ NULL, AT_FDCWD, CONF_FILES_FILTER_MASKED_BY_SYMLINK, search3));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-empty.conf"),
strjoina(search3, "absolute-non-empty.conf"),
strjoina(search3, "relative-non-empty.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list_at(&result, /* suffix = */ NULL, AT_FDCWD, CONF_FILES_REGULAR, search3));
+ ASSERT_OK(conf_files_list_at(&result, /* suffix= */ NULL, AT_FDCWD, CONF_FILES_REGULAR, search3));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(strjoina(search3, "absolute-empty.conf"),
strjoina(search3, "absolute-non-empty.conf"),
strjoina(search3, "relative-non-empty.conf"))));
result = strv_free(result);
- ASSERT_OK(conf_files_list_at(&result, /* suffix = */ NULL, tfd, CONF_FILES_FILTER_MASKED, "/dir3/"));
+ ASSERT_OK(conf_files_list_at(&result, /* suffix= */ NULL, tfd, CONF_FILES_FILTER_MASKED, "/dir3/"));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE("dir3/absolute-non-empty-for-root.conf",
"dir3/relative-non-empty-for-root.conf")));
result = strv_free(result);
- ASSERT_OK(conf_files_list_at(&result, /* suffix = */ NULL, tfd, CONF_FILES_FILTER_MASKED_BY_EMPTY, "/dir3/"));
+ ASSERT_OK(conf_files_list_at(&result, /* suffix= */ NULL, tfd, CONF_FILES_FILTER_MASKED_BY_EMPTY, "/dir3/"));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE("dir3/absolute-non-empty-for-root.conf",
"dir3/relative-non-empty-for-root.conf")));
result = strv_free(result);
- ASSERT_OK(conf_files_list_at(&result, /* suffix = */ NULL, tfd, CONF_FILES_FILTER_MASKED_BY_SYMLINK, "/dir3/"));
+ ASSERT_OK(conf_files_list_at(&result, /* suffix= */ NULL, tfd, CONF_FILES_FILTER_MASKED_BY_SYMLINK, "/dir3/"));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE("dir3/absolute-empty-for-root.conf",
"dir3/absolute-non-empty-for-root.conf",
"dir3/relative-non-empty-for-root.conf")));
result = strv_free(result);
- ASSERT_OK(conf_files_list_at(&result, /* suffix = */ NULL, tfd, CONF_FILES_REGULAR, "/dir3/"));
+ ASSERT_OK(conf_files_list_at(&result, /* suffix= */ NULL, tfd, CONF_FILES_REGULAR, "/dir3/"));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE("dir3/absolute-empty-for-root.conf",
"dir3/absolute-non-empty-for-root.conf",
/* with replacement */
_cleanup_free_ char *inserted = NULL;
- ASSERT_OK(conf_files_list_with_replacement(/* root = */ NULL, STRV_MAKE(search1, search2, search3), search1_a, &result, &inserted));
+ ASSERT_OK(conf_files_list_with_replacement(/* root= */ NULL, STRV_MAKE(search1, search2, search3), search1_a, &result, &inserted));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(search1_a,
search2_aa,
result = strv_free(result);
inserted = mfree(inserted);
- ASSERT_OK(conf_files_list_with_replacement(/* root = */ NULL, STRV_MAKE(search1, search2, search3), strjoina(t, "/dir1/aa.conf"), &result, &inserted));
+ ASSERT_OK(conf_files_list_with_replacement(/* root= */ NULL, STRV_MAKE(search1, search2, search3), strjoina(t, "/dir1/aa.conf"), &result, &inserted));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(search1_a,
strjoina(search1, "aa.conf"),
result = strv_free(result);
inserted = mfree(inserted);
- ASSERT_OK(conf_files_list_with_replacement(/* root = */ NULL, STRV_MAKE(search1, search2, search3), strjoina(t, "/dir2/a.conf"), &result, &inserted));
+ ASSERT_OK(conf_files_list_with_replacement(/* root= */ NULL, STRV_MAKE(search1, search2, search3), strjoina(t, "/dir2/a.conf"), &result, &inserted));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(search1_a,
search2_aa,
result = strv_free(result);
inserted = mfree(inserted);
- ASSERT_OK(conf_files_list_with_replacement(/* root = */ NULL, STRV_MAKE(search1, search2, search3), strjoina(t, "/dir4/a.conf"), &result, &inserted));
+ ASSERT_OK(conf_files_list_with_replacement(/* root= */ NULL, STRV_MAKE(search1, search2, search3), strjoina(t, "/dir4/a.conf"), &result, &inserted));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(search1_a,
search2_aa,
result = strv_free(result);
inserted = mfree(inserted);
- ASSERT_OK(conf_files_list_with_replacement(/* root = */ NULL, STRV_MAKE(search1, search2, search3), strjoina(t, "/dir4/x.conf"), &result, &inserted));
+ ASSERT_OK(conf_files_list_with_replacement(/* root= */ NULL, STRV_MAKE(search1, search2, search3), strjoina(t, "/dir4/x.conf"), &result, &inserted));
strv_print(result);
ASSERT_TRUE(strv_equal(result, STRV_MAKE(search1_a,
search2_aa,
config_parse_cpu_set( \
"unit", \
"filename", \
- /* line = */ 0, \
+ /* line= */ 0, \
"[Section]", \
- /* section_line = */ 0, \
+ /* section_line= */ 0, \
"CPUAffinity", \
- /* ltype = */ 0, \
+ /* ltype= */ 0, \
str, \
c, \
- /* userdata = */ NULL)
+ /* userdata= */ NULL)
TEST(config_parse_cpu_set) {
CPUSet c = {};
mode,
"foo",
/* timestamp= */ USEC_INFINITY,
- /* not_after=*/ USEC_INFINITY,
+ /* not_after= */ USEC_INFINITY,
/* tpm2_device= */ NULL,
/* tpm2_hash_pcr_mask= */ 0,
/* tpm2_pubkey_path= */ NULL,
r = execute_directories(__func__,
dirs, DEFAULT_TIMEOUT_USEC,
- /* callbacks = */ NULL, /* callback_args = */ NULL,
- /* argv = */ NULL, /* envp = */ NULL, /* flags = */ 0);
+ /* callbacks= */ NULL, /* callback_args= */ NULL,
+ /* argv= */ NULL, /* envp= */ NULL, /* flags= */ 0);
/* we should exit with the error code of the first script that failed */
assert_se(r == 42);
* configured to make CLONE_NEWUSER require CAP_SYS_ADMIN.
* Additionally, AppArmor may restrict unprivileged user
* namespace creation. */
- r = capability_bounding_set_drop(UINT64_C(1) << CAP_SYS_ADMIN, /* right_now = */ true);
+ r = capability_bounding_set_drop(UINT64_C(1) << CAP_SYS_ADMIN, /* right_now= */ true);
if (r < 0) {
log_debug_errno(r, "Failed to drop capabilities: %m");
_exit(2);
ASSERT_NOT_NULL((filters = strv_copy(strv_skip(saved_argv, 1))));
if (prepare_ns("(test-execute-unprivileged)") == 0) {
- ASSERT_OK(capability_bounding_set_drop(0, /* right_now = */ true));
+ ASSERT_OK(capability_bounding_set_drop(0, /* right_now= */ true));
can_unshare = false;
run_tests(RUNTIME_SCOPE_USER, filters);
static int intro(void) {
int r;
- ASSERT_OK_ERRNO(setenv("SYSTEMD_FIREWALL_UTIL_NFT_TABLE_NAME", "io.systemd-test.nat", /* overwrite = */ true));
- ASSERT_OK_ERRNO(setenv("SYSTEMD_FIREWALL_UTIL_DNAT_MAP_NAME", "test_map_port_ipport", /* overwrite = */ true));
+ ASSERT_OK_ERRNO(setenv("SYSTEMD_FIREWALL_UTIL_NFT_TABLE_NAME", "io.systemd-test.nat", /* overwrite= */ true));
+ ASSERT_OK_ERRNO(setenv("SYSTEMD_FIREWALL_UTIL_DNAT_MAP_NAME", "test_map_port_ipport", /* overwrite= */ true));
r = sd_nfnl_socket_open(&nfnl);
if (r < 0)
_cleanup_(sd_json_variant_unrefp) sd_json_variant *a = NULL, *b = NULL;
ASSERT_OK(table_to_json(t, &a));
- table_print_json(t, /*f=*/ NULL, SD_JSON_FORMAT_NEWLINE);
+ table_print_json(t, /* f= */ NULL, SD_JSON_FORMAT_NEWLINE);
ASSERT_OK(sd_json_build(&b,
SD_JSON_BUILD_ARRAY(
_cleanup_(sd_json_variant_unrefp) sd_json_variant *a = NULL, *b = NULL;
ASSERT_OK(table_to_json(t, &a));
- table_print_json(t, /*f=*/ NULL, SD_JSON_FORMAT_NEWLINE);
+ table_print_json(t, /* f= */ NULL, SD_JSON_FORMAT_NEWLINE);
ASSERT_OK(sd_json_build(&b,
SD_JSON_BUILD_ARRAY(
ASSERT_NOT_NULL(mkdtemp(template));
fn = strjoina(template, "/*");
- ASSERT_ERROR(safe_glob(fn, /* flags = */ 0, &v), ENOENT);
+ ASSERT_ERROR(safe_glob(fn, /* flags= */ 0, &v), ENOENT);
fn2 = strjoina(template, "/.*");
ASSERT_ERROR(safe_glob(fn2, GLOB_NOSORT|GLOB_BRACE, &v), ENOENT);
fname = strjoina(template, "/.foobar");
ASSERT_OK(touch(fname));
- ASSERT_ERROR(safe_glob(fn, /* flags = */ 0, &v), ENOENT);
+ ASSERT_ERROR(safe_glob(fn, /* flags= */ 0, &v), ENOENT);
ASSERT_OK(safe_glob(fn2, GLOB_NOSORT|GLOB_BRACE, &v));
ASSERT_EQ(strv_length(v), 1u);
_cleanup_free_ void *mem = NULL;
size_t len;
- assert_se(unhexmem_full(s, l, /* secure = */ false, &mem, &len) == retval);
+ assert_se(unhexmem_full(s, l, /* secure= */ false, &mem, &len) == retval);
if (retval == 0) {
char *answer;
buffer = mfree(buffer);
size = 0;
- assert_se(unbase64mem_full(input, SIZE_MAX, /* secure=*/ true, &buffer, &size) == ret);
+ assert_se(unbase64mem_full(input, SIZE_MAX, /* secure= */ true, &buffer, &size) == ret);
if (ret >= 0) {
assert_se(size == strlen(output));
assert_se(memcmp(buffer, output, size) == 0);
reply = sd_netlink_message_unref(reply);
/* Enable IPv6 for the case that it is disabled by default. */
- ASSERT_OK(sysctl_write_ip_property_boolean(AF_INET6, "test-local-addr", "disable_ipv6", false, /* shadow = */ NULL));
+ ASSERT_OK(sysctl_write_ip_property_boolean(AF_INET6, "test-local-addr", "disable_ipv6", false, /* shadow= */ NULL));
/* Bring the interface up */
ASSERT_OK(sd_rtnl_message_new_link(rtnl, &message, RTM_SETLINK, ifindex));
va_start(ap, format);
DISABLE_WARNING_FORMAT_NONLITERAL;
- ASSERT_OK(log_format_iovec(iovec, iovec_len, &n, /* newline_separator = */ false, ENOANO, format, ap));
+ ASSERT_OK(log_format_iovec(iovec, iovec_len, &n, /* newline_separator= */ false, ENOANO, format, ap));
REENABLE_WARNING;
va_end(ap);
va_start(ap, format);
DISABLE_WARNING_FORMAT_NONLITERAL;
- ASSERT_OK(log_format_iovec(iovec, iovec_len, &n, /* newline_separator = */ true, ENOANO, format, ap));
+ ASSERT_OK(log_format_iovec(iovec, iovec_len, &n, /* newline_separator= */ true, ENOANO, format, ap));
REENABLE_WARNING;
va_end(ap);
_cleanup_(log_context_unrefp) LogContext *ctx = NULL;
char **strv = STRV_MAKE("SIXTH=ijn", "SEVENTH=PRP");
- ASSERT_NOT_NULL(ctx = log_context_new_strv(strv, /*owned=*/ false));
+ ASSERT_NOT_NULL(ctx = log_context_new_strv(strv, /* owned= */ false));
ASSERT_EQ(log_context_num_contexts(), 1U);
ASSERT_EQ(log_context_num_fields(), 2U);
ASSERT_OK(mkdir_parents_safe(tmp, p, 0000, UID_INVALID, GID_INVALID, 0));
ASSERT_OK(r = safe_fork("(test-mkdir-no-cap)", FORK_DEATHSIG_SIGTERM | FORK_WAIT | FORK_LOG, NULL));
if (r == 0) {
- (void) capability_bounding_set_drop(0, /* right_now = */ true);
+ (void) capability_bounding_set_drop(0, /* right_now= */ true);
ASSERT_ERROR(mkdir_p_safe(tmp, p, 0000, UID_INVALID, GID_INVALID, 0), EACCES);
_exit(EXIT_SUCCESS);
}
ASSERT_OK(r = pidref_safe_fork("(test-notify-recv-child)", FORK_DEATHSIG_SIGTERM|FORK_LOG, &c.pidref));
if (r == 0) {
- ASSERT_OK_ERRNO(setenv("NOTIFY_SOCKET", path, /* overwrite = */ true));
- ASSERT_OK_POSITIVE(sd_notify(/* unset_environment = */ false, "FIRST_MESSAGE=1"));
+ ASSERT_OK_ERRNO(setenv("NOTIFY_SOCKET", path, /* overwrite= */ true));
+ ASSERT_OK_POSITIVE(sd_notify(/* unset_environment= */ false, "FIRST_MESSAGE=1"));
_cleanup_close_ int fd1 = open("/tmp", O_RDONLY|O_CLOEXEC|O_DIRECTORY);
ASSERT_OK_ERRNO(fd1);
ASSERT_OK_POSITIVE(
sd_pid_notify_with_fds(
- 0, /* unset_environment = */ false,
+ 0, /* unset_environment= */ false,
"SECOND_MESSAGE=1\nADDITIONAL_DATA=hoge", (int[]) { fd1, fd2 }, 2));
_exit(EXIT_SUCCESS);
}
/* Testing with several syscalls filtered, and check if the nss modules gracefully handle failures in
* masked syscalls. See issue #38582. */
- ASSERT_OK(r = safe_fork("(with-seccomp)", FORK_LOG | FORK_WAIT, /* ret_pid = */ NULL));
+ ASSERT_OK(r = safe_fork("(with-seccomp)", FORK_LOG | FORK_WAIT, /* ret_pid= */ NULL));
if (r == 0) {
_cleanup_hashmap_free_ Hashmap *filter = NULL;
ASSERT_NOT_NULL(filter = hashmap_new(NULL));
FOREACH_STRING(s, "uname", "olduname", "oldolduname", "sigprocmask", "rt_sigprocmask", "osf_sigprocmask")
- ASSERT_OK(seccomp_filter_set_add_by_name(filter, /* add = */ true, s));
- ASSERT_OK(seccomp_load_syscall_filter_set_raw(SCMP_ACT_ALLOW, filter, SCMP_ACT_ERRNO(ENOSYS), /* log_missing = */ true));
+ ASSERT_OK(seccomp_filter_set_add_by_name(filter, /* add= */ true, s));
+ ASSERT_OK(seccomp_load_syscall_filter_set_raw(SCMP_ACT_ALLOW, filter, SCMP_ACT_ERRNO(ENOSYS), /* log_missing= */ true));
/* To make assert_return() and friends not call abort(), even built as developer mode. */
- ASSERT_OK_ERRNO(setenv("SYSTEMD_ASSERT_RETURN_IS_CRITICAL", "0", /* overwrite = */ true));
+ ASSERT_OK_ERRNO(setenv("SYSTEMD_ASSERT_RETURN_IS_CRITICAL", "0", /* overwrite= */ true));
/* Let's also make nss modules output debugging logs. */
- ASSERT_OK_ERRNO(setenv("SYSTEMD_LOG_LEVEL", "debug", /* overwrite = */ true));
+ ASSERT_OK_ERRNO(setenv("SYSTEMD_LOG_LEVEL", "debug", /* overwrite= */ true));
STRV_FOREACH(module, modules)
ASSERT_OK(test_one_module(dir, *module, names, addresses, n_addresses));
log_info("boot");
ASSERT_OK(osc_context_open_boot(&seq));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
ASSERT_OK(osc_context_close(SD_ID128_ALLF, &seq));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
log_info("container");
sd_id128_t id;
ASSERT_OK(osc_context_open_container("foobar", &seq, &id));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
ASSERT_OK(osc_context_close(id, &seq));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
log_info("vm");
ASSERT_OK(osc_context_open_vm("foobar", &seq, &id));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
ASSERT_OK(osc_context_close(id, &seq));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
log_info("chpriv → root");
ASSERT_OK(osc_context_open_chpriv("root", &seq, &id));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
ASSERT_OK(osc_context_close(id, &seq));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
log_info("chpriv → userxyz");
ASSERT_OK(osc_context_open_chpriv("userxyz", &seq, &id));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
ASSERT_OK(osc_context_close(id, &seq));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
log_info("chpriv → self");
_cleanup_free_ char *self = ASSERT_PTR(getusername_malloc());
ASSERT_OK(osc_context_open_chpriv(self, &seq, &id));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
ASSERT_OK(osc_context_close(id, &seq));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
log_info("session");
ASSERT_OK(osc_context_open_session("foobaruser", "session1", &seq, &id));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
ASSERT_OK(osc_context_close(id, &seq));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
log_info("service");
sd_id128_t invocation_id;
ASSERT_OK(sd_id128_randomize(&invocation_id));
ASSERT_OK(osc_context_open_service("getty@tty1.service", invocation_id, &seq));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
ASSERT_OK(osc_context_id_from_invocation_id(invocation_id, &id));
ASSERT_OK(osc_context_close(id, &seq));
- hexdump(/* f = */ NULL, seq, SIZE_MAX);
+ hexdump(/* f= */ NULL, seq, SIZE_MAX);
seq = mfree(seq);
}
assert_se(putenv((char*) "SYSTEMD_PROC_CMDLINE=foo_bar bar-waldo=1 x_y-z=0 quux=miep\nda=yes\nthe=1") == 0);
- assert_se(proc_cmdline_get_bool("", /* flags = */ 0, &value) == -EINVAL);
- assert_se(proc_cmdline_get_bool("abc", /* flags = */ 0, &value) == 0 && value == false);
+ assert_se(proc_cmdline_get_bool("", /* flags= */ 0, &value) == -EINVAL);
+ assert_se(proc_cmdline_get_bool("abc", /* flags= */ 0, &value) == 0 && value == false);
assert_se(proc_cmdline_get_bool("unspecified", PROC_CMDLINE_TRUE_WHEN_MISSING, &value) == 0 && value == true);
- assert_se(proc_cmdline_get_bool("foo_bar", /* flags = */ 0, &value) > 0 && value == true);
- assert_se(proc_cmdline_get_bool("foo-bar", /* flags = */ 0, &value) > 0 && value == true);
- assert_se(proc_cmdline_get_bool("bar-waldo", /* flags = */ 0, &value) > 0 && value == true);
- assert_se(proc_cmdline_get_bool("bar_waldo", /* flags = */ 0, &value) > 0 && value == true);
- assert_se(proc_cmdline_get_bool("x_y-z", /* flags = */ 0, &value) > 0 && value == false);
- assert_se(proc_cmdline_get_bool("x-y-z", /* flags = */ 0, &value) > 0 && value == false);
- assert_se(proc_cmdline_get_bool("x-y_z", /* flags = */ 0, &value) > 0 && value == false);
- assert_se(proc_cmdline_get_bool("x_y_z", /* flags = */ 0, &value) > 0 && value == false);
- assert_se(proc_cmdline_get_bool("quux", /* flags = */ 0, &value) == -EINVAL && value == false);
- assert_se(proc_cmdline_get_bool("da", /* flags = */ 0, &value) > 0 && value == true);
- assert_se(proc_cmdline_get_bool("the", /* flags = */ 0, &value) > 0 && value == true);
+ assert_se(proc_cmdline_get_bool("foo_bar", /* flags= */ 0, &value) > 0 && value == true);
+ assert_se(proc_cmdline_get_bool("foo-bar", /* flags= */ 0, &value) > 0 && value == true);
+ assert_se(proc_cmdline_get_bool("bar-waldo", /* flags= */ 0, &value) > 0 && value == true);
+ assert_se(proc_cmdline_get_bool("bar_waldo", /* flags= */ 0, &value) > 0 && value == true);
+ assert_se(proc_cmdline_get_bool("x_y-z", /* flags= */ 0, &value) > 0 && value == false);
+ assert_se(proc_cmdline_get_bool("x-y-z", /* flags= */ 0, &value) > 0 && value == false);
+ assert_se(proc_cmdline_get_bool("x-y_z", /* flags= */ 0, &value) > 0 && value == false);
+ assert_se(proc_cmdline_get_bool("x_y_z", /* flags= */ 0, &value) > 0 && value == false);
+ assert_se(proc_cmdline_get_bool("quux", /* flags= */ 0, &value) == -EINVAL && value == false);
+ assert_se(proc_cmdline_get_bool("da", /* flags= */ 0, &value) > 0 && value == true);
+ assert_se(proc_cmdline_get_bool("the", /* flags= */ 0, &value) > 0 && value == true);
}
TEST(proc_cmdline_get_key_many) {
\
/* This emulates pid_get_cmdline_strv(). */ \
assert_se(a = strv_parse_nulstr_full(s, ELEMENTSOF(s), \
- /* drop_trailing_nuls = */ true)); \
+ /* drop_trailing_nuls= */ true)); \
assert_se(proc_cmdline_filter_pid1_args(a, &b) >= 0); \
assert_se(strv_equal(b, expected)); \
})
TEST(filter_sets) {
int r;
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
for (unsigned i = 0; i < _SYSCALL_FILTER_SET_MAX; i++) {
assert_se(namespace_flags_from_string(s, &ul) == 0 && ul == NAMESPACE_FLAGS_ALL);
s = mfree(s);
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
ASSERT_OK(r = safe_fork("(restrict-namespace)", FORK_LOG | FORK_WAIT, NULL));
if (r == 0) {
int r;
/* in containers _sysctl() is likely missing anyway */
- CHECK_SECCOMP(/* skip_container = */ true);
+ CHECK_SECCOMP(/* skip_container= */ true);
_cleanup_free_ char *seccomp = NULL;
assert_se(get_proc_field("/proc/self/status", "Seccomp", &seccomp) == 0);
int r;
/* in containers syslog() is likely missing anyway */
- CHECK_SECCOMP(/* skip_container = */ true);
+ CHECK_SECCOMP(/* skip_container= */ true);
ASSERT_OK(r = safe_fork("(protect-syslog)", FORK_LOG | FORK_WAIT, NULL));
if (r == 0) {
TEST(restrict_address_families) {
int r;
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
ASSERT_OK(r = safe_fork("(restrict-address-families)", FORK_LOG | FORK_WAIT, NULL));
if (r == 0) {
int r;
/* in containers RT privs are likely missing anyway */
- CHECK_SECCOMP(/* skip_container = */ true);
+ CHECK_SECCOMP(/* skip_container= */ true);
ASSERT_OK(r = safe_fork("(restrict-realtime)", FORK_LOG | FORK_WAIT, NULL));
if (r == 0) {
TEST(memory_deny_write_execute_mmap) {
int r;
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
#if HAVE_VALGRIND_VALGRIND_H
if (RUNNING_ON_VALGRIND) {
log_debug("arch %s: SCMP_SYS(shmdt) = %d", seccomp_arch_to_string(arch), SCMP_SYS(shmdt));
}
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
#if HAVE_VALGRIND_VALGRIND_H
if (RUNNING_ON_VALGRIND) {
TEST(restrict_archs) {
int r;
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
ASSERT_OK(r = safe_fork("(restrict-archs)", FORK_LOG | FORK_WAIT, NULL));
if (r == 0) {
TEST(load_syscall_filter_set_raw) {
int r;
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
ASSERT_OK(r = safe_fork("(load-filter)", FORK_LOG | FORK_WAIT, NULL));
if (r == 0) {
TEST(native_syscalls_filtered) {
int r;
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
ASSERT_OK(r = safe_fork("(native-syscalls)", FORK_LOG | FORK_WAIT, NULL));
if (r == 0) {
unsigned long current_opinionated;
int r;
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
assert_se(opinionated_personality(¤t_opinionated) >= 0);
TEST(restrict_suid_sgid) {
int r;
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
ASSERT_OK(r = safe_fork("(suid-sgid)", FORK_LOG | FORK_WAIT, NULL));
if (r == 0) {
TEST(seccomp_suppress_sync) {
int r;
- CHECK_SECCOMP(/* skip_container = */ false);
+ CHECK_SECCOMP(/* skip_container= */ false);
ASSERT_OK(r = safe_fork("(suppress-sync)", FORK_LOG | FORK_WAIT, NULL));
if (r == 0) {
#define TRIAL 100u
static void set_timezone(const char *tz) {
- ASSERT_OK(set_unset_env("TZ", tz, /* overwrite = */ true));
+ ASSERT_OK(set_unset_env("TZ", tz, /* overwrite= */ true));
tzset();
log_info("TZ=%s, tzname[0]=%s, tzname[1]=%s", strna(getenv("TZ")), strempty(get_tzname(/* dst= */ false)), strempty(get_tzname(/* dst= */ true)));
}
usec_t y_sec = y / USEC_PER_SEC;
if (x_sec == y_sec && streq(xx, yy))
- return; /* Yay!*/
+ return; /* Yay! */
/* When the timezone is built with rearguard being enabled (e.g. old Ubuntu and RHEL), the following
* timezone may provide time shifted 1 hour from the original. See
_cleanup_(uid_range_freep) UIDRange *p = NULL;
for (size_t i = 0; i < 10; i++) {
- assert_se(uid_range_add_internal(&p, i * 10, 10, /* coalesce = */ false) >= 0);
- assert_se(uid_range_add_internal(&p, i * 10 + 5, 10, /* coalesce = */ false) >= 0);
+ assert_se(uid_range_add_internal(&p, i * 10, 10, /* coalesce= */ false) >= 0);
+ assert_se(uid_range_add_internal(&p, i * 10 + 5, 10, /* coalesce= */ false) >= 0);
}
- assert_se(uid_range_add_internal(&p, 100, 1, /* coalesce = */ true) >= 0);
+ assert_se(uid_range_add_internal(&p, 100, 1, /* coalesce= */ true) >= 0);
assert_se(p->n_entries == 1);
assert_se(p->entries[0].start == 0);
assert_se(p->entries[0].nr == 105);
p = uid_range_free(p);
for (size_t i = 0; i < 10; i++) {
- assert_se(uid_range_add_internal(&p, (10 - i) * 10, 10, /* coalesce = */ false) >= 0);
- assert_se(uid_range_add_internal(&p, (10 - i) * 10 + 5, 10, /* coalesce = */ false) >= 0);
+ assert_se(uid_range_add_internal(&p, (10 - i) * 10, 10, /* coalesce= */ false) >= 0);
+ assert_se(uid_range_add_internal(&p, (10 - i) * 10 + 5, 10, /* coalesce= */ false) >= 0);
}
- assert_se(uid_range_add_internal(&p, 100, 1, /* coalesce = */ true) >= 0);
+ assert_se(uid_range_add_internal(&p, 100, 1, /* coalesce= */ true) >= 0);
assert_se(p->n_entries == 1);
assert_se(p->entries[0].start == 10);
assert_se(p->entries[0].nr == 105);
p = uid_range_free(p);
for (size_t i = 0; i < 10; i++) {
- assert_se(uid_range_add_internal(&p, i * 10, 10, /* coalesce = */ false) >= 0);
- assert_se(uid_range_add_internal(&p, i * 10 + 5, 10, /* coalesce = */ false) >= 0);
- assert_se(uid_range_add_internal(&p, (10 - i) * 10, 10, /* coalesce = */ false) >= 0);
- assert_se(uid_range_add_internal(&p, (10 - i) * 10 + 5, 10, /* coalesce = */ false) >= 0);
+ assert_se(uid_range_add_internal(&p, i * 10, 10, /* coalesce= */ false) >= 0);
+ assert_se(uid_range_add_internal(&p, i * 10 + 5, 10, /* coalesce= */ false) >= 0);
+ assert_se(uid_range_add_internal(&p, (10 - i) * 10, 10, /* coalesce= */ false) >= 0);
+ assert_se(uid_range_add_internal(&p, (10 - i) * 10 + 5, 10, /* coalesce= */ false) >= 0);
}
- assert_se(uid_range_add_internal(&p, 100, 1, /* coalesce = */ true) >= 0);
+ assert_se(uid_range_add_internal(&p, 100, 1, /* coalesce= */ true) >= 0);
assert_se(p->n_entries == 1);
assert_se(p->entries[0].start == 0);
assert_se(p->entries[0].nr == 115);
SAVE_TIMEZONE;
/* Set the new $TZ */
- if (setenv("TZ", isempty(i->timezone) ? "UTC" : i->timezone, /* overwrite = */ true) < 0)
+ if (setenv("TZ", isempty(i->timezone) ? "UTC" : i->timezone, /* overwrite= */ true) < 0)
log_warning_errno(errno, "Failed to set TZ environment variable, ignoring: %m");
else
tzset();
} else
timespec_store(&ts, (usec_t) utc);
- /* refuse the request when the time is before systemd build date time*/
+ /* refuse the request when the time is before systemd build date time */
if (ts.tv_sec < TIME_EPOCH)
return sd_bus_error_set(error, SD_BUS_ERROR_INVALID_ARGS, "Requested to set the clock to time before build time, refusing.");
m,
SD_EVENT_PRIORITY_NORMAL,
"save-time",
- /* force_reset = */ false);
+ /* force_reset= */ false);
if (r < 0)
return log_error_errno(r, "Failed to reset event source for saving time: %m");
* clock, but otherwise uses the specified timestamp. Note that whenever we acquire an NTP sync the
* specified timestamp value might be more accurate than the system clock, since the latter is
* subject to slow adjustments. */
- r = touch_file(TIMESYNCD_CLOCK_FILE, /* parents = */ false, t, UID_INVALID, GID_INVALID, MODE_INVALID);
+ r = touch_file(TIMESYNCD_CLOCK_FILE, /* parents= */ false, t, UID_INVALID, GID_INVALID, MODE_INVALID);
if (r < 0)
log_debug_errno(r, "Failed to update "TIMESYNCD_CLOCK_FILE", ignoring: %m");
if (r < 0)
return r;
- r = strv_extend_strv_consume(&config_dirs, TAKE_PTR(data_dirs), /* filter_duplicates = */ true);
+ r = strv_extend_strv_consume(&config_dirs, TAKE_PTR(data_dirs), /* filter_duplicates= */ true);
if (r < 0)
return r;
"%s extended attribute '%s=%s' on %s", *name, *value, path);
if (!arg_dry_run) {
- r = xsetxattr(fd, /* path = */ NULL, AT_EMPTY_PATH, *name, *value);
+ r = xsetxattr(fd, /* path= */ NULL, AT_EMPTY_PATH, *name, *value);
if (r < 0)
return log_error_errno(r, "Failed to set extended attribute %s=%s on '%s': %m",
*name, *value, path);
if (fd < 0)
return fd;
- return fd_set_xattrs(c, i, fd, path, /* st = */ NULL, creation);
+ return fd_set_xattrs(c, i, fd, path, /* st= */ NULL, creation);
}
static int parse_acls_from_arg(Item *item) {
return 0;
}
- fd = create_directory_or_subvolume(path, i->mode, /* subvol = */ true, i->allow_failure, &st, &creation);
+ fd = create_directory_or_subvolume(path, i->mode, /* subvol= */ true, i->allow_failure, &st, &creation);
if (fd == -EEXIST)
return 0;
if (fd < 0)
assert(i);
if (i->ignore_if_target_missing) {
- r = chase(i->argument, arg_root, CHASE_SAFE|CHASE_PREFIX_ROOT|CHASE_NOFOLLOW, /* ret_path = */ NULL, /* ret_fd = */ NULL);
+ r = chase(i->argument, arg_root, CHASE_SAFE|CHASE_PREFIX_ROOT|CHASE_NOFOLLOW, /* ret_path= */ NULL, /* ret_fd= */ NULL);
if (r == -ENOENT) {
/* Silently skip over lines where the source file is missing. */
log_info("Symlink source path '%s/%s' does not exist, skipping line.",
_cleanup_free_ void *data = NULL;
size_t data_size = 0;
- r = unbase64mem_full(item_binary_argument(&i), item_binary_argument_size(&i), /* secure = */ false,
+ r = unbase64mem_full(item_binary_argument(&i), item_binary_argument_size(&i), /* secure= */ false,
&data, &data_size);
if (r < 0)
return log_syntax(NULL, LOG_ERR, fname, line, r, "Failed to base64 decode specified argument '%s': %m", i.argument);
case ARG_TPM2_DEVICE:
if (streq(optarg, "list"))
- return tpm2_list_devices(/* legend = */ true, /* quiet = */ false);
+ return tpm2_list_devices(/* legend= */ true, /* quiet= */ false);
if (free_and_strdup(&arg_tpm2_device, streq(optarg, "auto") ? NULL : optarg) < 0)
return log_oom();
*
* Note that when any agent exits STOPPING=1 would also be sent, but that's utterly what we want,
* i.e. the password is answered on one console and other agents get killed below. */
- (void) sd_notify(/* unset_environment = */ false, "NOTIFYACCESS=all");
+ (void) sd_notify(/* unset_environment= */ false, "NOTIFYACCESS=all");
/* Start an agent on each console. */
STRV_FOREACH(tty, consoles) {
assert_se(rules = udev_rules_new(RESOLVE_NAME_EARLY));
_cleanup_(conf_file_freep) ConfFile *c = NULL;
- ASSERT_OK(conf_file_new(filename, /* root = */ NULL, CHASE_MUST_BE_REGULAR, &c));
+ ASSERT_OK(conf_file_new(filename, /* root= */ NULL, CHASE_MUST_BE_REGULAR, &c));
- r = udev_rules_parse_file(rules, c, /* extra_checks = */ false, /* ret = */ NULL);
+ r = udev_rules_parse_file(rules, c, /* extra_checks= */ false, /* ret= */ NULL);
log_info_errno(r, "Parsing %s: %m", filename);
assert_se(r >= 0 || /* OK */
r == -ENOBUFS); /* line length exceeded */
"\tio.cost.model: %s\n",
path, name, qos, model);
- r = cg_set_attribute(/* path = */ NULL, "io.cost.qos", qos);
+ r = cg_set_attribute(/* path= */ NULL, "io.cost.qos", qos);
if (r < 0) {
log_device_full_errno(device, r == -ENOENT ? LOG_DEBUG : LOG_ERR, r, "Failed to set io.cost.qos: %m");
return r == -ENOENT ? 0 : r;
}
- r = cg_set_attribute(/* path = */ NULL, "io.cost.model", model);
+ r = cg_set_attribute(/* path= */ NULL, "io.cost.model", model);
if (r < 0) {
log_device_full_errno(device, r == -ENOENT ? LOG_DEBUG : LOG_ERR, r, "Failed to set io.cost.model: %m");
return r == -ENOENT ? 0 : r;
STRV_MAKE_CONST(filename),
NETWORK_DIRS,
dropin_dirname,
- /* root = */ NULL,
+ /* root= */ NULL,
"Match\0"
"Link\0"
"SR-IOV\0"
assert(ctx);
- r = config_get_stats_by_path(".link", NULL, 0, NETWORK_DIRS, /* check_dropins = */ true, &stats_by_path);
+ r = config_get_stats_by_path(".link", NULL, 0, NETWORK_DIRS, /* check_dropins= */ true, &stats_by_path);
if (r < 0) {
log_warning_errno(r, "Failed to get stats of .link files, ignoring: %m");
return true;
link->iftype,
link->kind,
link->ifname,
- /* alternative_names = */ NULL,
- /* wlan_iftype = */ 0,
- /* ssid = */ NULL,
- /* bssid = */ NULL);
+ /* alternative_names= */ NULL,
+ /* wlan_iftype= */ 0,
+ /* ssid= */ NULL,
+ /* bssid= */ NULL);
if (r < 0)
return r;
if (r == 0)
if (cached >= 0)
return cached;
- r = proc_cmdline_get_bool("net.ifnames", /* flags = */ 0, &b);
+ r = proc_cmdline_get_bool("net.ifnames", /* flags= */ 0, &b);
if (r < 0)
log_warning_errno(r, "Failed to parse net.ifnames= kernel command line option, ignoring: %m");
if (r <= 0)
usleep_safe(us);
}
- assert_se(udev_rules_load(&rules, RESOLVE_NAME_EARLY, /* extra = */ NULL) == 0);
+ assert_se(udev_rules_load(&rules, RESOLVE_NAME_EARLY, /* extra= */ NULL) == 0);
const char *syspath = strjoina("/sys", devpath);
r = device_new_from_synthetic_event(&dev, syspath, action);
* parsed: valid operand
* use the following command to help generate textual C strings:
* python3 -c 'import json; print(json.dumps(input()))' */
- test_udev_rule_parse_value_one("\"valid operand\"", "valid operand", /* expected_case_insensitive = */ false, 0);
+ test_udev_rule_parse_value_one("\"valid operand\"", "valid operand", /* expected_case_insensitive= */ false, 0);
/* input: "va'l\'id\"op\"erand"
* parsed: va'l\'id"op"erand */
- test_udev_rule_parse_value_one("\"va'l\\'id\\\"op\\\"erand\"", "va'l\\'id\"op\"erand", /* expected_case_insensitive = */ false, 0);
- test_udev_rule_parse_value_one("no quotes", NULL, /* expected_case_insensitive = */ false, -EINVAL);
- test_udev_rule_parse_value_one("\"\\\\a\\b\\x\\y\"", "\\\\a\\b\\x\\y", /* expected_case_insensitive = */ false, 0);
- test_udev_rule_parse_value_one("\"reject\0nul\"", NULL, /* expected_case_insensitive = */ false, -EINVAL);
+ test_udev_rule_parse_value_one("\"va'l\\'id\\\"op\\\"erand\"", "va'l\\'id\"op\"erand", /* expected_case_insensitive= */ false, 0);
+ test_udev_rule_parse_value_one("no quotes", NULL, /* expected_case_insensitive= */ false, -EINVAL);
+ test_udev_rule_parse_value_one("\"\\\\a\\b\\x\\y\"", "\\\\a\\b\\x\\y", /* expected_case_insensitive= */ false, 0);
+ test_udev_rule_parse_value_one("\"reject\0nul\"", NULL, /* expected_case_insensitive= */ false, -EINVAL);
/* input: e"" */
- test_udev_rule_parse_value_one("e\"\"", "", /* expected_case_insensitive = */ false, 0);
+ test_udev_rule_parse_value_one("e\"\"", "", /* expected_case_insensitive= */ false, 0);
/* input: e"1234" */
- test_udev_rule_parse_value_one("e\"1234\"", "1234", /* expected_case_insensitive = */ false, 0);
+ test_udev_rule_parse_value_one("e\"1234\"", "1234", /* expected_case_insensitive= */ false, 0);
/* input: e"\"" */
- test_udev_rule_parse_value_one("e\"\\\"\"", "\"", /* expected_case_insensitive = */ false, 0);
+ test_udev_rule_parse_value_one("e\"\\\"\"", "\"", /* expected_case_insensitive= */ false, 0);
/* input: e"\ */
- test_udev_rule_parse_value_one("e\"\\", NULL, /* expected_case_insensitive = */ false, -EINVAL);
+ test_udev_rule_parse_value_one("e\"\\", NULL, /* expected_case_insensitive= */ false, -EINVAL);
/* input: e"\" */
- test_udev_rule_parse_value_one("e\"\\\"", NULL, /* expected_case_insensitive = */ false, -EINVAL);
+ test_udev_rule_parse_value_one("e\"\\\"", NULL, /* expected_case_insensitive= */ false, -EINVAL);
/* input: e"\\" */
- test_udev_rule_parse_value_one("e\"\\\\\"", "\\", /* expected_case_insensitive = */ false, 0);
+ test_udev_rule_parse_value_one("e\"\\\\\"", "\\", /* expected_case_insensitive= */ false, 0);
/* input: e"\\\" */
- test_udev_rule_parse_value_one("e\"\\\\\\\"", NULL, /* expected_case_insensitive = */ false, -EINVAL);
+ test_udev_rule_parse_value_one("e\"\\\\\\\"", NULL, /* expected_case_insensitive= */ false, -EINVAL);
/* input: e"\\\"" */
- test_udev_rule_parse_value_one("e\"\\\\\\\"\"", "\\\"", /* expected_case_insensitive = */ false, 0);
+ test_udev_rule_parse_value_one("e\"\\\\\\\"\"", "\\\"", /* expected_case_insensitive= */ false, 0);
/* input: e"\\\\" */
- test_udev_rule_parse_value_one("e\"\\\\\\\\\"", "\\\\", /* expected_case_insensitive = */ false, 0);
+ test_udev_rule_parse_value_one("e\"\\\\\\\\\"", "\\\\", /* expected_case_insensitive= */ false, 0);
/* input: e"operand with newline\n" */
- test_udev_rule_parse_value_one("e\"operand with newline\\n\"", "operand with newline\n", /* expected_case_insensitive = */ false, 0);
+ test_udev_rule_parse_value_one("e\"operand with newline\\n\"", "operand with newline\n", /* expected_case_insensitive= */ false, 0);
/* input: e"single\rcharacter\t\aescape\bsequence" */
test_udev_rule_parse_value_one(
- "e\"single\\rcharacter\\t\\aescape\\bsequence\"", "single\rcharacter\t\aescape\bsequence", /* expected_case_insensitive = */ false, 0);
+ "e\"single\\rcharacter\\t\\aescape\\bsequence\"", "single\rcharacter\t\aescape\bsequence", /* expected_case_insensitive= */ false, 0);
/* input: e"reject\invalid escape sequence" */
- test_udev_rule_parse_value_one("e\"reject\\invalid escape sequence", NULL, /* expected_case_insensitive = */ false, -EINVAL);
+ test_udev_rule_parse_value_one("e\"reject\\invalid escape sequence", NULL, /* expected_case_insensitive= */ false, -EINVAL);
/* input: e"\ */
- test_udev_rule_parse_value_one("e\"\\", NULL, /* expected_case_insensitive = */ false, -EINVAL);
+ test_udev_rule_parse_value_one("e\"\\", NULL, /* expected_case_insensitive= */ false, -EINVAL);
/* input: "s\u1d1c\u1d04\u029c \u1d1c\u0274\u026a\u1d04\u1d0f\u1d05\u1d07 \U0001d568\U0001d560\U0001d568" */
test_udev_rule_parse_value_one(
"e\"s\\u1d1c\\u1d04\\u029c \\u1d1c\\u0274\\u026a\\u1d04\\u1d0f\\u1d05\\u1d07 \\U0001d568\\U0001d560\\U0001d568\"",
"s\xe1\xb4\x9c\xe1\xb4\x84\xca\x9c \xe1\xb4\x9c\xc9\xb4\xc9\xaa\xe1\xb4\x84\xe1\xb4\x8f\xe1\xb4\x85\xe1\xb4\x87 \xf0\x9d\x95\xa8\xf0\x9d\x95\xa0\xf0\x9d\x95\xa8",
- /* expected_case_insensitive = */ false, 0);
+ /* expected_case_insensitive= */ false, 0);
/* input: i"ABCD1234" */
- test_udev_rule_parse_value_one("i\"ABCD1234\"", "ABCD1234", /* expected_case_insensitive = */ true, 0);
+ test_udev_rule_parse_value_one("i\"ABCD1234\"", "ABCD1234", /* expected_case_insensitive= */ true, 0);
/* input: i"ABCD1234" */
- test_udev_rule_parse_value_one("e\"ABCD1234\"", "ABCD1234", /* expected_case_insensitive = */ false, 0);
+ test_udev_rule_parse_value_one("e\"ABCD1234\"", "ABCD1234", /* expected_case_insensitive= */ false, 0);
/* input: ei"\\"ABCD1234 */
- test_udev_rule_parse_value_one("ei\"\\\\ABCD1234\"", "\\ABCD1234", /* expected_case_insensitive = */ true, 0);
+ test_udev_rule_parse_value_one("ei\"\\\\ABCD1234\"", "\\ABCD1234", /* expected_case_insensitive= */ true, 0);
/* input: ie"\\"ABCD1234 */
- test_udev_rule_parse_value_one("ie\"\\\\ABCD1234\"", "\\ABCD1234", /* expected_case_insensitive = */ true, 0);
+ test_udev_rule_parse_value_one("ie\"\\\\ABCD1234\"", "\\ABCD1234", /* expected_case_insensitive= */ true, 0);
/* input: i */
- test_udev_rule_parse_value_one("i", NULL, /* expected_case_insensitive = */ false, -EINVAL);
+ test_udev_rule_parse_value_one("i", NULL, /* expected_case_insensitive= */ false, -EINVAL);
/* input: ee"" */
- test_udev_rule_parse_value_one("ee\"\"", NULL, /* expected_case_insensitive = */ false, -EINVAL);
+ test_udev_rule_parse_value_one("ee\"\"", NULL, /* expected_case_insensitive= */ false, -EINVAL);
/* input: iei"" */
- test_udev_rule_parse_value_one("iei\"\"", NULL, /* expected_case_insensitive = */ false, -EINVAL);
+ test_udev_rule_parse_value_one("iei\"\"", NULL, /* expected_case_insensitive= */ false, -EINVAL);
/* input: a"" */
- test_udev_rule_parse_value_one("a\"\"", NULL, /* expected_case_insensitive = */ false, -EINVAL);
+ test_udev_rule_parse_value_one("a\"\"", NULL, /* expected_case_insensitive= */ false, -EINVAL);
}
DEFINE_TEST_MAIN(LOG_DEBUG);
char **modules = strv_skip(argv, 2);
if (modules)
STRV_FOREACH(module, modules)
- (void) module_load_and_warn(ctx, *module, /* verbose = */ false);
+ (void) module_load_and_warn(ctx, *module, /* verbose= */ false);
else {
const char *modalias;
if (r < 0)
return log_device_warning_errno(dev, r, "Failed to read property \"MODALIAS\": %m");
- (void) module_load_and_warn(ctx, modalias, /* verbose = */ false);
+ (void) module_load_and_warn(ctx, modalias, /* verbose= */ false);
}
return 0;
if (!p)
return -EINVAL;
- r = path_find_first_component(&p, /* accept_dot_dot = */ false, &q);
+ r = path_find_first_component(&p, /* accept_dot_dot= */ false, &q);
if (r < 0)
return r;
/* get ibmveth/ibmvnic slot-based names. */
/* check if our direct parent is a VIO device with no other bus in-between */
- if (get_matching_parent(dev, STRV_MAKE("vio"), /* skip_virtio = */ false, NULL) < 0)
+ if (get_matching_parent(dev, STRV_MAKE("vio"), /* skip_virtio= */ false, NULL) < 0)
return 0;
log_device_debug(dev, "Parent device is in the vio subsystem.");
/* get ACPI path names for ARM64 platform devices */
/* check if our direct parent is a platform device with no other bus in-between */
- if (get_matching_parent(dev, STRV_MAKE("platform"), /* skip_virtio = */ false, NULL) < 0)
+ if (get_matching_parent(dev, STRV_MAKE("platform"), /* skip_virtio= */ false, NULL) < 0)
return 0;
log_device_debug(dev, "Parent device is in the platform subsystem.");
assert(prefix);
/* check if our direct parent is a PCI device with no other bus in-between */
- if (get_matching_parent(dev, STRV_MAKE("pci"), /* skip_virtio = */ true, &parent) < 0)
+ if (get_matching_parent(dev, STRV_MAKE("pci"), /* skip_virtio= */ true, &parent) < 0)
return 0;
/* If this is an SR-IOV virtual device, get base name using physical device and add virtfn suffix. */
/* get path names for Linux on System z network devices */
- if (get_matching_parent(dev, STRV_MAKE("ccwgroup", "ccw"), /* skip_virtio = */ true, &cdev) < 0)
+ if (get_matching_parent(dev, STRV_MAKE("ccwgroup", "ccw"), /* skip_virtio= */ true, &cdev) < 0)
return 0;
log_device_debug(dev, "Device is CCW.");
return 0;
/* check if our direct parent is a Xen VIF device with no other bus in-between */
- if (get_matching_parent(dev, STRV_MAKE("xen"), /* skip_virtio = */ false, NULL) < 0)
+ if (get_matching_parent(dev, STRV_MAKE("xen"), /* skip_virtio= */ false, NULL) < 0)
return 0;
/* Use the vif-n name to extract "n" */
return log_device_error_errno(dev, r, "Failed to get seat: %m");
uid_t uid;
- r = sd_seat_get_active(seat, /* ret_session = */ NULL, &uid);
+ r = sd_seat_get_active(seat, /* ret_session= */ NULL, &uid);
if (r < 0) {
if (IN_SET(r, -ENXIO, -ENODATA))
/* No active session on this seat */
reset:
/* Better be safe than sorry and reset ACL */
- k = devnode_acl(fd, /* uid = */ 0);
+ k = devnode_acl(fd, /* uid= */ 0);
if (k < 0)
RET_GATHER(r, log_device_full_errno(dev, k == -ENOENT ? LOG_DEBUG : LOG_ERR, k, "Failed to flush ACLs: %m"));
if (r < 0)
return r;
- return sd_json_variant_dump(v, flags, f, /* prefix = */ NULL);
+ return sd_json_variant_dump(v, flags, f, /* prefix= */ NULL);
}
int dump_event(UdevEvent *event, sd_json_format_flags_t flags, FILE *f) {
/* delete state from disk */
(void) device_delete_db(dev);
- (void) device_tag_index(dev, /* device_old = */ NULL, /* add = */ false);
+ (void) device_tag_index(dev, /* device_old= */ NULL, /* add= */ false);
- r = device_monitor_send(monitor, /* destination = */ NULL, dev);
+ r = device_monitor_send(monitor, /* destination= */ NULL, dev);
if (r < 0) {
uint64_t seqnum = 0;
/* At the time this is called, the renamed device may not exist yet. Hence, we cannot validate
* the new syspath. */
- r = device_set_syspath(device, new_syspath, /* verify = */ false);
+ r = device_set_syspath(device, new_syspath, /* verify= */ false);
if (r < 0)
return r;
(void) device_update_db(event->dev_db_clone);
/* Restore 'dev' */
- (void) device_set_syspath(dev, old_syspath, /* verify = */ false);
+ (void) device_set_syspath(dev, old_syspath, /* verify= */ false);
if (sd_device_get_property_value(dev, "INTERFACE_OLD", &s) >= 0) {
(void) device_add_property_internal(dev, "INTERFACE", s);
(void) device_add_property_internal(dev, "INTERFACE_OLD", NULL);
break;
case UDEV_CTRL_RELOAD:
log_debug("Received udev control message (RELOAD)");
- manager_reload(manager, /* force = */ true);
+ manager_reload(manager, /* force= */ true);
break;
case UDEV_CTRL_SET_ENV:
if (!udev_property_assignment_is_valid(value->buf)) {
manager,
EVENT_PRIORITY_WORKER_TIMER,
"kill-workers-event",
- /* force_reset = */ false);
+ /* force_reset= */ false);
if (r < 0)
return log_warning_errno(r, "Failed to enable timer event source for cleaning up workers: %m");
}
udev_builtin_reload(flags);
if (FLAGS_SET(flags, UDEV_RELOAD_RULES)) {
- r = udev_rules_load(&rules, manager->config.resolve_name_timing, /* extra = */ NULL);
+ r = udev_rules_load(&rules, manager->config.resolve_name_timing, /* extra= */ NULL);
if (r < 0)
log_warning_errno(r, "Failed to read udev rules, using the previously loaded rules, ignoring: %m");
else
worker,
EVENT_PRIORITY_WORKER_TIMER,
"worker-timeout-warn",
- /* force_reset = */ true);
+ /* force_reset= */ true);
(void) event_reset_time_relative(
manager->event,
worker,
EVENT_PRIORITY_WORKER_TIMER,
"worker-timeout-kill",
- /* force_reset = */ true);
+ /* force_reset= */ true);
}
static Event* worker_detach_event(Worker *worker) {
.manager_pid = manager_pid,
};
- if (setenv("NOTIFY_SOCKET", manager->worker_notify_socket_path, /* overwrite = */ true) < 0) {
+ if (setenv("NOTIFY_SOCKET", manager->worker_notify_socket_path, /* overwrite= */ true) < 0) {
log_error_errno(errno, "Failed to set $NOTIFY_SOCKET: %m");
_exit(EXIT_FAILURE);
}
if (r < 0)
log_warning_errno(r, "Failed to disable event source for cleaning up idle workers, ignoring: %m");
- manager_reload(manager, /* force = */ false);
+ manager_reload(manager, /* force= */ false);
/* manager_reload() may kill idle workers, hence we may not be possible to start processing an event.
* Let's check that and return earlier if we cannot. */
event->requeue_next_usec,
USEC_PER_SEC,
on_requeue_locked_events,
- /* userdata = */ NULL,
+ /* userdata= */ NULL,
EVENT_PRIORITY_REQUEUE_EVENT,
"requeue-locked-events",
- /* force_reset = */ true);
+ /* force_reset= */ true);
assert_se(prioq_pop(manager->locked_events_by_time) == event);
event_unset_whole_disk(event);
if (manager->events)
return log_warning_errno(SYNTHETIC_ERRNO(EALREADY), "Received multiple event storage socket (%i).", *fd);
- r = sd_is_socket(*fd, AF_NETLINK, SOCK_RAW, /* listening = */ -1);
+ r = sd_is_socket(*fd, AF_NETLINK, SOCK_RAW, /* listening= */ -1);
if (r < 0)
return log_warning_errno(r, "Failed to verify type of event storage socket (%i): %m", *fd);
if (r == 0)
if (manager->monitor)
return log_warning_errno(SYNTHETIC_ERRNO(EALREADY), "Received multiple netlink socket (%i), ignoring.", fd);
- r = sd_is_socket(fd, AF_NETLINK, SOCK_RAW, /* listening = */ -1);
+ r = sd_is_socket(fd, AF_NETLINK, SOCK_RAW, /* listening= */ -1);
if (r < 0)
return log_warning_errno(r, "Failed to verify socket type of %i, ignoring: %m", fd);
if (r == 0)
static int on_sighup(sd_event_source *s, const struct signalfd_siginfo *si, void *userdata) {
Manager *manager = ASSERT_PTR(userdata);
- manager_reload(manager, /* force = */ true);
+ manager_reload(manager, /* force= */ true);
return 1;
}
if (manager->cgroup && set_isempty(manager->synthesize_change_child_event_sources))
/* cleanup possible left-over processes in our cgroup */
- (void) cg_kill(manager->cgroup, SIGKILL, CGROUP_IGNORE_SELF, /* killed_pids=*/ NULL, /* log_kill= */ NULL, /* userdata= */ NULL);
+ (void) cg_kill(manager->cgroup, SIGKILL, CGROUP_IGNORE_SELF, /* killed_pids= */ NULL, /* log_kill= */ NULL, /* userdata= */ NULL);
return 0;
}
if (r < 0)
return log_error_errno(r, "Failed to create SIGHUP event source: %m");
- r = sd_event_add_post(e, /* ret = */ NULL, on_post, manager);
+ r = sd_event_add_post(e, /* ret= */ NULL, on_post, manager);
if (r < 0)
return log_error_errno(r, "Failed to create post event source: %m");
assert(manager);
assert(ret_varlink_fd);
- int n = sd_listen_fds_with_names(/* unset_environment = */ true, &names);
+ int n = sd_listen_fds_with_names(/* unset_environment= */ true, &names);
if (n < 0)
return log_error_errno(n, "Failed to listen on fds: %m");
udev_builtin_init();
- r = udev_rules_load(&manager->rules, manager->config.resolve_name_timing, /* extra = */ NULL);
+ r = udev_rules_load(&manager->rules, manager->config.resolve_name_timing, /* extra= */ NULL);
if (r < 0)
return log_error_errno(r, "Failed to read udev rules: %m");
/* This device has the equal or a higher priority than the current. Let's create the devlink to our
* device node. */
- return node_create_symlink(dev, /* devnode = */ NULL, slink);
+ return node_create_symlink(dev, /* devnode= */ NULL, slink);
}
static int device_get_devpath_by_devnum(sd_device *dev, char **ret) {
"Removing/updating old device symlink '%s', which is no longer belonging to this device.",
devlink);
- r = link_update(dev, devlink, /* add = */ false);
+ r = link_update(dev, devlink, /* add= */ false);
if (r < 0)
log_device_warning_errno(dev, r,
"Failed to remove/update device symlink '%s', ignoring: %m",
/* create/update symlinks, add symlinks to name index */
FOREACH_DEVICE_DEVLINK(dev, devlink) {
- r = link_update(dev, devlink, /* add = */ true);
+ r = link_update(dev, devlink, /* add= */ true);
if (r < 0)
log_device_warning_errno(dev, r,
"Failed to create/update device symlink '%s', ignoring: %m",
return log_device_debug_errno(dev, r, "Failed to get device path: %m");
/* always add /dev/{block,char}/$major:$minor */
- r = node_create_symlink(dev, /* devnode = */ NULL, filename);
+ r = node_create_symlink(dev, /* devnode= */ NULL, filename);
if (r < 0)
return log_device_warning_errno(dev, r, "Failed to create device symlink '%s': %m", filename);
/* remove/update symlinks, remove symlinks from name index */
FOREACH_DEVICE_DEVLINK(dev, devlink) {
- r = link_update(dev, devlink, /* add = */ false);
+ r = link_update(dev, devlink, /* add= */ false);
if (r < 0)
log_device_warning_errno(dev, r,
"Failed to remove/update device symlink '%s', ignoring: %m",
return log_line_invalid_attr(rule_line, key);
if (!is_match) {
check_value_format_and_warn(rule_line, key, value, false);
- r = rule_line_add_token(rule_line, TK_A_DEVLINK, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_DEVLINK, op, value, NULL, /* is_case_insensitive= */ false, token_str);
} else
r = rule_line_add_token(rule_line, TK_M_DEVLINK, op, value, NULL, is_case_insensitive, token_str);
} else if (streq(key, "NAME")) {
"Ignoring NAME=\"\", as udev will not delete any network interfaces.");
check_value_format_and_warn(rule_line, key, value, false);
- r = rule_line_add_token(rule_line, TK_A_NAME, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_NAME, op, value, NULL, /* is_case_insensitive= */ false, token_str);
} else
r = rule_line_add_token(rule_line, TK_M_NAME, op, value, NULL, is_case_insensitive, token_str);
} else if (streq(key, "ENV")) {
check_value_format_and_warn(rule_line, key, value, false);
- r = rule_line_add_token(rule_line, TK_A_ENV, op, value, attr, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_ENV, op, value, attr, /* is_case_insensitive= */ false, token_str);
} else
r = rule_line_add_token(rule_line, TK_M_ENV, op, value, attr, is_case_insensitive, token_str);
} else if (streq(key, "CONST")) {
if (!is_match) {
check_value_format_and_warn(rule_line, key, value, true);
- r = rule_line_add_token(rule_line, TK_A_TAG, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_TAG, op, value, NULL, /* is_case_insensitive= */ false, token_str);
} else
r = rule_line_add_token(rule_line, TK_M_TAG, op, value, NULL, is_case_insensitive, token_str);
} else if (streq(key, "SUBSYSTEM")) {
if (!is_match) {
check_value_format_and_warn(rule_line, key, value, false);
- r = rule_line_add_token(rule_line, TK_A_ATTR, op, value, attr, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_ATTR, op, value, attr, /* is_case_insensitive= */ false, token_str);
} else
r = rule_line_add_token(rule_line, TK_M_ATTR, op, value, attr, is_case_insensitive, token_str);
} else if (streq(key, "SYSCTL")) {
if (!is_match) {
check_value_format_and_warn(rule_line, key, value, false);
- r = rule_line_add_token(rule_line, TK_A_SYSCTL, op, value, attr, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_SYSCTL, op, value, attr, /* is_case_insensitive= */ false, token_str);
} else
r = rule_line_add_token(rule_line, TK_M_SYSCTL, op, value, attr, is_case_insensitive, token_str);
} else if (streq(key, "KERNELS")) {
if (is_case_insensitive)
return log_line_invalid_prefix(rule_line, key);
- r = rule_line_add_token(rule_line, TK_M_PROGRAM, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_M_PROGRAM, op, value, NULL, /* is_case_insensitive= */ false, token_str);
} else if (streq(key, "IMPORT")) {
if (isempty(attr))
return log_line_invalid_attr(rule_line, key);
return log_line_invalid_prefix(rule_line, key);
if (streq(attr, "file"))
- r = rule_line_add_token(rule_line, TK_M_IMPORT_FILE, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_M_IMPORT_FILE, op, value, NULL, /* is_case_insensitive= */ false, token_str);
else if (streq(attr, "program")) {
UdevBuiltinCommand cmd;
cmd = udev_builtin_lookup(value);
if (cmd >= 0) {
log_line_debug(rule_line, "Found builtin command '%s' for %s, replacing attribute.", value, key);
- r = rule_line_add_token(rule_line, TK_M_IMPORT_BUILTIN, op, value, UDEV_BUILTIN_CMD_TO_PTR(cmd), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_M_IMPORT_BUILTIN, op, value, UDEV_BUILTIN_CMD_TO_PTR(cmd), /* is_case_insensitive= */ false, token_str);
} else
- r = rule_line_add_token(rule_line, TK_M_IMPORT_PROGRAM, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_M_IMPORT_PROGRAM, op, value, NULL, /* is_case_insensitive= */ false, token_str);
} else if (streq(attr, "builtin")) {
UdevBuiltinCommand cmd;
if (cmd < 0)
return log_line_error_errno(rule_line, SYNTHETIC_ERRNO(EINVAL),
"Unknown builtin command: %s", value);
- r = rule_line_add_token(rule_line, TK_M_IMPORT_BUILTIN, op, value, UDEV_BUILTIN_CMD_TO_PTR(cmd), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_M_IMPORT_BUILTIN, op, value, UDEV_BUILTIN_CMD_TO_PTR(cmd), /* is_case_insensitive= */ false, token_str);
} else if (streq(attr, "db"))
- r = rule_line_add_token(rule_line, TK_M_IMPORT_DB, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_M_IMPORT_DB, op, value, NULL, /* is_case_insensitive= */ false, token_str);
else if (streq(attr, "cmdline"))
- r = rule_line_add_token(rule_line, TK_M_IMPORT_CMDLINE, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_M_IMPORT_CMDLINE, op, value, NULL, /* is_case_insensitive= */ false, token_str);
else if (streq(attr, "parent"))
- r = rule_line_add_token(rule_line, TK_M_IMPORT_PARENT, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_M_IMPORT_PARENT, op, value, NULL, /* is_case_insensitive= */ false, token_str);
else
return log_line_invalid_attr(rule_line, key);
} else if (streq(key, "RESULT")) {
op = OP_ASSIGN;
if (streq(value, "dump"))
- r = rule_line_add_token(rule_line, TK_A_OPTIONS_DUMP, op, NULL, UINT_TO_PTR(SD_JSON_FORMAT_OFF), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OPTIONS_DUMP, op, NULL, UINT_TO_PTR(SD_JSON_FORMAT_OFF), /* is_case_insensitive= */ false, token_str);
else if (streq(value, "dump-json"))
- r = rule_line_add_token(rule_line, TK_A_OPTIONS_DUMP, op, NULL, UINT_TO_PTR(SD_JSON_FORMAT_NEWLINE), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OPTIONS_DUMP, op, NULL, UINT_TO_PTR(SD_JSON_FORMAT_NEWLINE), /* is_case_insensitive= */ false, token_str);
else if (streq(value, "string_escape=none"))
- r = rule_line_add_token(rule_line, TK_A_OPTIONS_STRING_ESCAPE_NONE, op, NULL, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OPTIONS_STRING_ESCAPE_NONE, op, NULL, NULL, /* is_case_insensitive= */ false, token_str);
else if (streq(value, "string_escape=replace"))
- r = rule_line_add_token(rule_line, TK_A_OPTIONS_STRING_ESCAPE_REPLACE, op, NULL, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OPTIONS_STRING_ESCAPE_REPLACE, op, NULL, NULL, /* is_case_insensitive= */ false, token_str);
else if (streq(value, "db_persist"))
- r = rule_line_add_token(rule_line, TK_A_OPTIONS_DB_PERSIST, op, NULL, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OPTIONS_DB_PERSIST, op, NULL, NULL, /* is_case_insensitive= */ false, token_str);
else if (streq(value, "watch"))
- r = rule_line_add_token(rule_line, TK_A_OPTIONS_INOTIFY_WATCH, op, NULL, INT_TO_PTR(1), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OPTIONS_INOTIFY_WATCH, op, NULL, INT_TO_PTR(1), /* is_case_insensitive= */ false, token_str);
else if (streq(value, "nowatch"))
- r = rule_line_add_token(rule_line, TK_A_OPTIONS_INOTIFY_WATCH, op, NULL, INT_TO_PTR(0), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OPTIONS_INOTIFY_WATCH, op, NULL, INT_TO_PTR(0), /* is_case_insensitive= */ false, token_str);
else if ((tmp = startswith(value, "static_node=")))
- r = rule_line_add_token(rule_line, TK_A_OPTIONS_STATIC_NODE, op, tmp, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OPTIONS_STATIC_NODE, op, tmp, NULL, /* is_case_insensitive= */ false, token_str);
else if ((tmp = startswith(value, "link_priority="))) {
int prio;
r = safe_atoi(tmp, &prio);
if (r < 0)
return log_line_error_errno(rule_line, r, "Failed to parse link priority '%s': %m", tmp);
- r = rule_line_add_token(rule_line, TK_A_OPTIONS_DEVLINK_PRIORITY, op, NULL, INT_TO_PTR(prio), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OPTIONS_DEVLINK_PRIORITY, op, NULL, INT_TO_PTR(prio), /* is_case_insensitive= */ false, token_str);
} else if ((tmp = startswith(value, "log_level="))) {
int level;
if (level < 0)
return log_line_error_errno(rule_line, level, "Failed to parse log level '%s': %m", tmp);
}
- r = rule_line_add_token(rule_line, TK_A_OPTIONS_LOG_LEVEL, op, NULL, INT_TO_PTR(level), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OPTIONS_LOG_LEVEL, op, NULL, INT_TO_PTR(level), /* is_case_insensitive= */ false, token_str);
} else {
log_line_warning(rule_line, "Invalid value for OPTIONS key, ignoring: '%s'", value);
return 0;
return r;
assert(uid_is_valid(uid));
- r = rule_line_add_token(rule_line, TK_A_OWNER_ID, op, NULL, UID_TO_PTR(uid), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OWNER_ID, op, NULL, UID_TO_PTR(uid), /* is_case_insensitive= */ false, token_str);
} else if (resolve_name_timing != RESOLVE_NAME_NEVER) {
check_value_format_and_warn(rule_line, key, value, true);
- r = rule_line_add_token(rule_line, TK_A_OWNER, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_OWNER, op, value, NULL, /* is_case_insensitive= */ false, token_str);
} else {
log_line_debug(rule_line, "User name resolution is disabled, ignoring %s=\"%s\".", key, value);
return 0;
return r;
assert(gid_is_valid(gid));
- r = rule_line_add_token(rule_line, TK_A_GROUP_ID, op, NULL, GID_TO_PTR(gid), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_GROUP_ID, op, NULL, GID_TO_PTR(gid), /* is_case_insensitive= */ false, token_str);
} else if (resolve_name_timing != RESOLVE_NAME_NEVER) {
check_value_format_and_warn(rule_line, key, value, true);
- r = rule_line_add_token(rule_line, TK_A_GROUP, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_GROUP, op, value, NULL, /* is_case_insensitive= */ false, token_str);
} else {
log_line_debug(rule_line, "Resolving group name is disabled, ignoring GROUP=\"%s\".", value);
return 0;
}
if (parse_mode(value, &mode) >= 0)
- r = rule_line_add_token(rule_line, TK_A_MODE_ID, op, NULL, MODE_TO_PTR(mode), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_MODE_ID, op, NULL, MODE_TO_PTR(mode), /* is_case_insensitive= */ false, token_str);
else {
check_value_format_and_warn(rule_line, key, value, true);
- r = rule_line_add_token(rule_line, TK_A_MODE, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_MODE, op, value, NULL, /* is_case_insensitive= */ false, token_str);
}
} else if (streq(key, "SECLABEL")) {
if (isempty(attr))
op = OP_ASSIGN;
}
- r = rule_line_add_token(rule_line, TK_A_SECLABEL, op, value, attr, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_SECLABEL, op, value, attr, /* is_case_insensitive= */ false, token_str);
} else if (streq(key, "RUN")) {
if (is_match || op == OP_REMOVE)
return log_line_invalid_op(rule_line, key);
check_value_format_and_warn(rule_line, key, value, true);
if (!attr || streq(attr, "program"))
- r = rule_line_add_token(rule_line, TK_A_RUN_PROGRAM, op, value, NULL, /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_RUN_PROGRAM, op, value, NULL, /* is_case_insensitive= */ false, token_str);
else if (streq(attr, "builtin")) {
UdevBuiltinCommand cmd;
if (cmd < 0)
return log_line_error_errno(rule_line, SYNTHETIC_ERRNO(EINVAL),
"Unknown builtin command '%s', ignoring.", value);
- r = rule_line_add_token(rule_line, TK_A_RUN_BUILTIN, op, value, UDEV_BUILTIN_CMD_TO_PTR(cmd), /* is_case_insensitive = */ false, token_str);
+ r = rule_line_add_token(rule_line, TK_A_RUN_BUILTIN, op, value, UDEV_BUILTIN_CMD_TO_PTR(cmd), /* is_case_insensitive= */ false, token_str);
} else
return log_line_invalid_attr(rule_line, key);
} else if (streq(key, "GOTO")) {
return -ENOMEM;
}
- r = strv_extend_strv(&directories, CONF_PATHS_STRV("udev/rules.d"), /* filter_duplicates = */ false);
+ r = strv_extend_strv(&directories, CONF_PATHS_STRV("udev/rules.d"), /* filter_duplicates= */ false);
if (r < 0)
return r;
CLEANUP_ARRAY(files, n_files, conf_file_free_many);
- r = conf_files_list_strv_full(".rules", /* root = */ NULL, CONF_FILES_REGULAR | CONF_FILES_FILTER_MASKED,
+ r = conf_files_list_strv_full(".rules", /* root= */ NULL, CONF_FILES_REGULAR | CONF_FILES_FILTER_MASKED,
(const char* const*) directories, &files, &n_files);
if (r < 0)
return log_debug_errno(r, "Failed to enumerate rules files: %m");
FOREACH_ARRAY(i, files, n_files) {
ConfFile *c = *i;
- r = udev_rules_parse_file(rules, c, /* extra_checks = */ false, /* ret = */ NULL);
+ r = udev_rules_parse_file(rules, c, /* extra_checks= */ false, /* ret= */ NULL);
if (r < 0)
log_debug_errno(r, "Failed to read rules file '%s', ignoring: %m", c->original_path);
}
if (!rules)
return true;
- r = config_get_stats_by_path(".rules", NULL, 0, RULES_DIRS, /* check_dropins = */ false, &stats_by_path);
+ r = config_get_stats_by_path(".rules", NULL, 0, RULES_DIRS, /* check_dropins= */ false, &stats_by_path);
if (r < 0) {
log_warning_errno(r, "Failed to get stats of udev rules, ignoring: %m");
return true;
size_t result_size,
const char *what) {
- return apply_format_full(event, token, token->value, result, result_size, /* replace_whitespace = */ false, what);
+ return apply_format_full(event, token, token->value, result, result_size, /* replace_whitespace= */ false, what);
}
static bool apply_format_attr(
size_t result_size,
const char *what) {
- return apply_format_full(event, token, token->data, result, result_size, /* replace_whitespace = */ false, what);
+ return apply_format_full(event, token, token->data, result, result_size, /* replace_whitespace= */ false, what);
}
static bool token_match_string(UdevEvent *event, UdevRuleToken *token, const char *str, bool log_result) {
value = delete_trailing_chars(vbuf, NULL);
}
- return token_match_string(event, token, value, /* log_result = */ true);
+ return token_match_string(event, token, value, /* log_result= */ true);
case SUBST_TYPE_SUBSYS:
r = udev_resolve_subsys_kernel(name, vbuf, sizeof(vbuf), true);
if (FLAGS_SET(token->match_type, MATCH_REMOVE_TRAILING_WHITESPACE))
delete_trailing_chars(vbuf, NULL);
- return token_match_string(event, token, vbuf, /* log_result = */ true);
+ return token_match_string(event, token, vbuf, /* log_result= */ true);
default:
assert_not_reached();
if (r < 0)
return log_event_error_errno(event, token, r, "Failed to get uevent action type: %m");
- return token_match_string(event, token, device_action_to_string(a), /* log_result = */ true);
+ return token_match_string(event, token, device_action_to_string(a), /* log_result= */ true);
}
case TK_M_DEVPATH: {
const char *val;
if (r < 0)
return log_event_error_errno(event, token, r, "Failed to get devpath: %m");
- return token_match_string(event, token, val, /* log_result = */ true);
+ return token_match_string(event, token, val, /* log_result= */ true);
}
case TK_M_KERNEL:
case TK_M_PARENTS_KERNEL: {
if (r < 0)
return log_event_error_errno(event, token, r, "Failed to get sysname: %m");
- return token_match_string(event, token, val, /* log_result = */ true);
+ return token_match_string(event, token, val, /* log_result= */ true);
}
case TK_M_DEVLINK:
FOREACH_DEVICE_DEVLINK(dev, val)
- if (token_match_string(event, token, strempty(startswith(val, "/dev/")), /* log_result = */ false) == (token->op == OP_MATCH))
+ if (token_match_string(event, token, strempty(startswith(val, "/dev/")), /* log_result= */ false) == (token->op == OP_MATCH))
return log_event_result(event, token, token->op == OP_MATCH);
return log_event_result(event, token, token->op == OP_NOMATCH);
case TK_M_NAME:
- return token_match_string(event, token, event->name, /* log_result = */ true);
+ return token_match_string(event, token, event->name, /* log_result= */ true);
case TK_M_ENV: {
const char *val = NULL;
(void) device_get_property_value_with_fallback(dev, token->data, event->worker ? event->worker->properties : NULL, &val);
- return token_match_string(event, token, val, /* log_result = */ true);
+ return token_match_string(event, token, val, /* log_result= */ true);
}
case TK_M_CONST: {
const char *val, *k = token->data;
val = confidential_virtualization_to_string(detect_confidential_virtualization());
else
assert_not_reached();
- return token_match_string(event, token, val, /* log_result = */ true);
+ return token_match_string(event, token, val, /* log_result= */ true);
}
case TK_M_TAG:
case TK_M_PARENTS_TAG:
FOREACH_DEVICE_CURRENT_TAG(dev, val)
- if (token_match_string(event, token, val, /* log_result = */ false) == (token->op == OP_MATCH))
+ if (token_match_string(event, token, val, /* log_result= */ false) == (token->op == OP_MATCH))
return log_event_result(event, token, token->op == OP_MATCH);
return log_event_result(event, token, token->op == OP_NOMATCH);
else if (r < 0)
return log_event_error_errno(event, token, r, "Failed to get subsystem: %m");
- return token_match_string(event, token, val, /* log_result = */ true);
+ return token_match_string(event, token, val, /* log_result= */ true);
}
case TK_M_DRIVER:
case TK_M_PARENTS_DRIVER: {
else if (r < 0)
return log_event_error_errno(event, token, r, "Failed to get driver: %m");
- return token_match_string(event, token, val, /* log_result = */ true);
+ return token_match_string(event, token, val, /* log_result= */ true);
}
case TK_M_ATTR:
case TK_M_PARENTS_ATTR:
if (r < 0 && r != -ENOENT)
return log_event_error_errno(event, token, r, "Failed to read sysctl \"%s\": %m", buf);
- return token_match_string(event, token, strstrip(value), /* log_result = */ true);
+ return token_match_string(event, token, strstrip(value), /* log_result= */ true);
}
case TK_M_TEST: {
mode_t mode = PTR_TO_MODE(token->data);
log_event_debug(event, token, "Running command \"%s\"", buf);
- r = udev_event_spawn(event, /* accept_failure = */ true, buf, result, sizeof(result), NULL);
+ r = udev_event_spawn(event, /* accept_failure= */ true, buf, result, sizeof(result), NULL);
if (r != 0) {
if (r < 0)
log_event_warning_errno(event, token, r, "Failed to execute \"%s\": %m", buf);
log_event_debug(event, token, "Importing properties from results of \"%s\"", buf);
- r = udev_event_spawn(event, /* accept_failure = */ true, buf, result, sizeof result, &truncated);
+ r = udev_event_spawn(event, /* accept_failure= */ true, buf, result, sizeof result, &truncated);
if (r != 0) {
if (r < 0)
log_event_warning_errno(event, token, r, "Failed to execute \"%s\", ignoring: %m", buf);
return log_event_result(event, token, token->op == (have ? OP_MATCH : OP_NOMATCH));
}
case TK_M_RESULT:
- return token_match_string(event, token, event->program_result, /* log_result = */ true);
+ return token_match_string(event, token, event->program_result, /* log_result= */ true);
case TK_A_OPTIONS_DUMP: {
sd_json_format_flags_t flags = PTR_TO_UINT(token->data);
return true;
if (event->esc == ESCAPE_REPLACE)
- udev_replace_chars_and_log(event, token, p, /* allow = */ NULL, "property value");
+ udev_replace_chars_and_log(event, token, p, /* allow= */ NULL, "property value");
r = device_add_property(dev, name, value_new);
if (r < 0)
if (token->op == OP_ASSIGN)
device_cleanup_tags(dev);
- r = device_add_tag(dev, buf, /* both = */ true);
+ r = device_add_tag(dev, buf, /* both= */ true);
if (r == -ENOMEM)
return log_oom();
if (r < 0)
device_cleanup_devlinks(dev);
if (!apply_format_full(event, token, token->value, buf, sizeof(buf),
- /* replace_whitespace = */ event->esc != ESCAPE_NONE,
+ /* replace_whitespace= */ event->esc != ESCAPE_NONE,
"symbolic link path"))
return true;
/* By default or string_escape=none, allow multiple symlinks separated by spaces. */
if (event->esc == ESCAPE_UNSET)
- udev_replace_chars_and_log(event, token, buf, /* allow = */ "/ ", "device node symlink");
+ udev_replace_chars_and_log(event, token, buf, /* allow= */ "/ ", "device node symlink");
else if (event->esc == ESCAPE_REPLACE)
- udev_replace_chars_and_log(event, token, buf, /* allow = */ "/", "device node symlink");
+ udev_replace_chars_and_log(event, token, buf, /* allow= */ "/", "device node symlink");
for (const char *p = buf;;) {
_cleanup_free_ char *path = NULL;
/* Then, make the path relative again. This also checks if the path being inside of the sysfs. */
_cleanup_free_ char *resolved = NULL;
_cleanup_close_ int fd = -EBADF;
- r = device_chase(dev, buf, /* flags = */ 0, &resolved, &fd);
+ r = device_chase(dev, buf, /* flags= */ 0, &resolved, &fd);
if (r < 0) {
log_event_error_errno(event, token, r, "Could not chase sysfs attribute \"%s\", ignoring: %m", buf);
return true;
if (!copied)
return log_oom();
- r = device_cache_sysattr_value(dev, resolved, copied, /* error = */ 0);
+ r = device_cache_sysattr_value(dev, resolved, copied, /* error= */ 0);
if (r < 0)
log_event_warning_errno(event, token, r, "Failed to cache sysfs attribute \"%s\", ignoring: %m", resolved);
else if (r > 0) {
if (!path)
return log_oom();
- r = verify_regular_at(AT_FDCWD, path, /* follow = */ true);
+ r = verify_regular_at(AT_FDCWD, path, /* follow= */ true);
if (r < 0 && !ERRNO_IS_NEG_PRIVILEGE(r))
log_event_error_errno(event, token, r, "Failed to verify sysctl entry \"%s\" is a regular file: %m", buf);
else
log_device_debug(event->dev, "Running command \"%s\"", command);
- r = udev_event_spawn(event, /* accept_failure = */ false, command, NULL, 0, NULL);
+ r = udev_event_spawn(event, /* accept_failure= */ false, command, NULL, 0, NULL);
if (r < 0)
log_device_warning_errno(event->dev, r, "Failed to execute '%s', ignoring: %m", command);
else if (r > 0) /* returned value is positive when program fails */
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
log_debug("Received io.systemd.service.Reload()");
- manager_reload(userdata, /* force = */ true);
+ manager_reload(userdata, /* force= */ true);
return sd_varlink_reply(link, NULL);
}
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
assert(link);
- r = sd_varlink_dispatch(link, parameters, /* dispatch_table = */ NULL, /* userdata = */ NULL);
+ r = sd_varlink_dispatch(link, parameters, /* dispatch_table= */ NULL, /* userdata= */ NULL);
if (r != 0)
return r;
if (FLAGS_SET(e->mask, IN_IGNORED)) {
log_debug("Received inotify event about removal of watch handle %i.", e->wd);
- r = udev_watch_clear_by_wd(/* dev = */ NULL, /* dirfd = */ -EBADF, e->wd);
+ r = udev_watch_clear_by_wd(/* dev= */ NULL, /* dirfd= */ -EBADF, e->wd);
if (r < 0)
log_warning_errno(r, "Failed to remove saved symlink(s) for watch handle %i, ignoring: %m", e->wd);
if (r < 0)
return r;
- r = sd_event_add_signal(e, /* ret = */ NULL, SIGUSR1 | SD_EVENT_SIGNAL_PROCMASK, on_sigusr1, worker);
+ r = sd_event_add_signal(e, /* ret= */ NULL, SIGUSR1 | SD_EVENT_SIGNAL_PROCMASK, on_sigusr1, worker);
if (r < 0)
return r;
- r = sd_notify(/* unset_environment = */ false, msg);
+ r = sd_notify(/* unset_environment= */ false, msg);
if (r <= 0)
return r;
log_device_debug_errno(dev, errno, "Block device %s is currently locked, requeuing the event.", whole_disk);
- r = sd_notifyf(/* unset_environment = */ false, "TRY_AGAIN=1\nWHOLE_DISK=%s", whole_disk);
+ r = sd_notifyf(/* unset_environment= */ false, "TRY_AGAIN=1\nWHOLE_DISK=%s", whole_disk);
if (r < 0) {
log_device_warning_errno(dev, r, "Failed to send notification message to manager process: %m");
(void) sd_event_exit(worker->event, r);
return 0;
}
- r = sd_notify(/* unset_environment = */ false, "PROCESSED=1");
+ r = sd_notify(/* unset_environment= */ false, "PROCESSED=1");
if (r < 0) {
log_device_warning_errno(dev, r, "Failed to send notification message to manager process: %m");
(void) sd_event_exit(worker->event, r);
}
const char *e = errno_name_no_fallback(r);
- r = sd_notifyf(/* unset_environment = */ false, "ERRNO=%i%s%s", -r, e ? "\nERRNO_NAME=" : "", strempty(e));
+ r = sd_notifyf(/* unset_environment= */ false, "ERRNO=%i%s%s", -r, e ? "\nERRNO_NAME=" : "", strempty(e));
if (r < 0) {
log_device_warning_errno(dev, r, "Failed to send notification message to manager process, ignoring: %m");
(void) sd_event_exit(worker->event, r);
return r;
/* udev rules file does not support dropin configs. So, we can safely pass multiple files as dropins. */
- return cat_files_full(/* file = */ NULL, files, n_files, arg_cat_flags);
+ return cat_files_full(/* file= */ NULL, files, n_files, arg_cat_flags);
}
return log_error_errno(r, "Failed to connect to udev via varlink: %m");
if (arg_exit)
- return varlink_call_and_log(link, "io.systemd.Udev.Exit", /* parameters = */ NULL, /* reply = */ NULL);
+ return varlink_call_and_log(link, "io.systemd.Udev.Exit", /* parameters= */ NULL, /* reply= */ NULL);
if (arg_revert) {
- r = varlink_call_and_log(link, "io.systemd.Udev.Revert", /* parameters = */ NULL, /* reply = */ NULL);
+ r = varlink_call_and_log(link, "io.systemd.Udev.Revert", /* parameters= */ NULL, /* reply= */ NULL);
if (r < 0)
return r;
}
if (arg_log_level >= 0) {
- r = varlink_callbo_and_log(link, "io.systemd.service.SetLogLevel", /* reply = */ NULL,
+ r = varlink_callbo_and_log(link, "io.systemd.service.SetLogLevel", /* reply= */ NULL,
SD_JSON_BUILD_PAIR_INTEGER("level", arg_log_level));
if (r < 0)
return r;
if (arg_start_exec_queue >= 0) {
r = varlink_call_and_log(link, arg_start_exec_queue ? "io.systemd.Udev.StartExecQueue" : "io.systemd.Udev.StopExecQueue",
- /* parameters = */ NULL, /* reply = */ NULL);
+ /* parameters= */ NULL, /* reply= */ NULL);
if (r < 0)
return r;
}
if (arg_reload) {
- r = varlink_call_and_log(link, "io.systemd.service.Reload", /* parameters = */ NULL, /* reply = */ NULL);
+ r = varlink_call_and_log(link, "io.systemd.service.Reload", /* parameters= */ NULL, /* reply= */ NULL);
if (r < 0)
return r;
}
if (!strv_isempty(arg_env)) {
- r = varlink_callbo_and_log(link, "io.systemd.Udev.SetEnvironment", /* reply = */ NULL,
+ r = varlink_callbo_and_log(link, "io.systemd.Udev.SetEnvironment", /* reply= */ NULL,
SD_JSON_BUILD_PAIR_STRV("assignments", arg_env));
if (r < 0)
return r;
}
if (arg_max_children >= 0) {
- r = varlink_callbo_and_log(link, "io.systemd.Udev.SetChildrenMax", /* reply = */ NULL,
+ r = varlink_callbo_and_log(link, "io.systemd.Udev.SetChildrenMax", /* reply= */ NULL,
SD_JSON_BUILD_PAIR_UNSIGNED("number", arg_max_children));
if (r < 0)
return r;
}
if (arg_ping) {
- r = varlink_call_and_log(link, "io.systemd.service.Ping", /* parameters = */ NULL, /* reply = */ NULL);
+ r = varlink_call_and_log(link, "io.systemd.service.Ping", /* parameters= */ NULL, /* reply= */ NULL);
if (r < 0)
return r;
}
if (arg_trace >= 0) {
- r = varlink_callbo_and_log(link, "io.systemd.Udev.SetTrace", /* reply = */ NULL,
+ r = varlink_callbo_and_log(link, "io.systemd.Udev.SetTrace", /* reply= */ NULL,
SD_JSON_BUILD_PAIR_BOOLEAN("enable", arg_trace));
if (r < 0)
return r;
"and the attributes from one single parent device.\n"
"\n");
- r = print_all_attributes(device, /* is_parent = */ false);
+ r = print_all_attributes(device, /* is_parent= */ false);
if (r < 0)
return r;
for (child = device; sd_device_get_parent(child, &parent) >= 0; child = parent) {
- r = print_all_attributes(parent, /* is_parent = */ true);
+ r = print_all_attributes(parent, /* is_parent= */ true);
if (r < 0)
return r;
}
arg_json_format_flags |=SD_JSON_FORMAT_SEQ;
- r = print_all_attributes_in_json(device, /* is_parent = */ false);
+ r = print_all_attributes_in_json(device, /* is_parent= */ false);
if (r < 0)
return r;
for (child = device; sd_device_get_parent(child, &parent) >= 0; child = parent) {
- r = print_all_attributes_in_json(parent, /* is_parent = */ true);
+ r = print_all_attributes_in_json(parent, /* is_parent= */ true);
if (r < 0)
return r;
}
STRV_FOREACH(p, arg_devices) {
_cleanup_(sd_device_unrefp) sd_device *device = NULL;
- r = find_device(*p, /* prefix = */ NULL, &device);
+ r = find_device(*p, /* prefix= */ NULL, &device);
if (r < 0) {
if (r == -EINVAL)
log_error_errno(r, "Bad argument \"%s\", expected an absolute path in /dev/ or /sys/, device ID, or a unit name: %m", *p);
NULL,
&b);
- r = strv_extend_strv_consume(&a, TAKE_PTR(b), /* filter_duplicates = */ true);
+ r = strv_extend_strv_consume(&a, TAKE_PTR(b), /* filter_duplicates= */ true);
if (r < 0)
return r;
}
(void) emit_deprecation_warning();
if (getuid() == 0) {
- r = udev_ping(MAX(5 * USEC_PER_SEC, arg_timeout_usec), /* ignore_connection_failure = */ true);
+ r = udev_ping(MAX(5 * USEC_PER_SEC, arg_timeout_usec), /* ignore_connection_failure= */ true);
if (r <= 0)
return r;
} else {
case 'D': {
_cleanup_free_ char *p = NULL;
- r = parse_path_argument(optarg, /* suppress_root = */ false, &p);
+ r = parse_path_argument(optarg, /* suppress_root= */ false, &p);
if (r < 0)
return r;
assert(e);
STRV_FOREACH(d, arg_devices) {
- r = add_device_match(e, *d, /* prefix = */ NULL);
+ r = add_device_match(e, *d, /* prefix= */ NULL);
if (r < 0)
return r;
}
return r;
if (arg_ping) {
- r = udev_ping(arg_ping_timeout_usec, /* ignore_connection_failure = */ false);
+ r = udev_ping(arg_ping_timeout_usec, /* ignore_connection_failure= */ false);
if (r < 0)
return r;
assert(r > 0);
if (r < 0)
return log_error_errno(r, "Failed to connect to udev via varlink: %m");
- r = varlink_call_and_log(link, "io.systemd.service.Ping", /* parameters = */ NULL, /* reply = */ NULL);
+ r = varlink_call_and_log(link, "io.systemd.service.Ping", /* parameters= */ NULL, /* reply= */ NULL);
if (r < 0)
return r;
assert(rules);
assert(c);
- r = udev_rules_parse_file(rules, c, /* extra_checks = */ true, &file);
+ r = udev_rules_parse_file(rules, c, /* extra_checks= */ true, &file);
if (r < 0)
return log_error_errno(r, "Failed to parse rules file %s: %m", c->original_path);
r = chase_and_stat("/usr", arg_root,
CHASE_PREFIX_ROOT | CHASE_WARN | CHASE_MUST_BE_DIRECTORY,
- /* ret_path = */ NULL,
+ /* ret_path= */ NULL,
&st);
if (r < 0)
return log_error_errno(r, "Failed to stat %s/usr/: %m", strempty(arg_root));
if (arg_boundaries) {
_cleanup_(uid_range_freep) UIDRange *uid_range = NULL;
- r = uid_range_load_userns(/* path = */ NULL, UID_RANGE_USERNS_INSIDE, &uid_range);
+ r = uid_range_load_userns(/* path= */ NULL, UID_RANGE_USERNS_INSIDE, &uid_range);
if (r < 0)
log_debug_errno(r, "Failed to load /proc/self/uid_map, ignoring: %m");
if (arg_boundaries) {
_cleanup_(uid_range_freep) UIDRange *gid_range = NULL;
- r = uid_range_load_userns(/* path = */ NULL, GID_RANGE_USERNS_INSIDE, &gid_range);
+ r = uid_range_load_userns(/* path= */ NULL, GID_RANGE_USERNS_INSIDE, &gid_range);
if (r < 0)
log_debug_errno(r, "Failed to load /proc/self/gid_map, ignoring: %m");
return log_error_errno(errno, "Failed to chown %s: %m", hd);
r = copy_tree(user_record_skeleton_directory(ur), hd, ur->uid, user_record_gid(ur),
- COPY_REFLINK|COPY_MERGE, /* denylist= */ NULL, /* subvolumes= */NULL);
+ COPY_REFLINK|COPY_MERGE, /* denylist= */ NULL, /* subvolumes= */ NULL);
if (r < 0 && r != -ENOENT)
return log_error_errno(r, "Failed to copy skeleton directory to %s: %m", hd);
}
if (isempty(optarg))
arg_services = strv_free(arg_services);
else {
- r = strv_split_and_extend(&arg_services, optarg, ":", /* filter_duplicates = */ true);
+ r = strv_split_and_extend(&arg_services, optarg, ":", /* filter_duplicates= */ true);
if (r < 0)
return log_error_errno(r, "Failed to parse -s/--service= argument: %m");
}
assert(s);
- (void) start_workers(m, /* explicit_request=*/ true); /* Workers told us there's more work, let's add one more worker as long as we are below the high watermark */
+ (void) start_workers(m, /* explicit_request= */ true); /* Workers told us there's more work, let's add one more worker as long as we are below the high watermark */
return 0;
}
m->deferred_start_worker_event_source = sd_event_source_unref(m->deferred_start_worker_event_source);
- (void) start_workers(m, /* explicit_request=*/ false);
+ (void) start_workers(m, /* explicit_request= */ false);
return 0;
}
_cleanup_free_ char *sd_journal_remote = NULL;
r = find_executable_full(
"systemd-journal-remote",
- /* root = */ NULL,
+ /* root= */ NULL,
STRV_MAKE(LIBEXECDIR),
- /* use_path_envvar = */ true, /* systemd-journal-remote should be installed in
+ /* use_path_envvar= */ true, /* systemd-journal-remote should be installed in
* LIBEXECDIR, but for supporting fancy setups. */
&sd_journal_remote,
- /* ret_fd = */ NULL);
+ /* ret_fd= */ NULL);
if (r < 0)
return log_error_errno(r, "Failed to find systemd-journal-remote binary: %m");
return r;
}
- assert_se(sigprocmask_many(SIG_BLOCK, /* ret_old_mask=*/ NULL, SIGCHLD) >= 0);
+ assert_se(sigprocmask_many(SIG_BLOCK, /* ret_old_mask= */ NULL, SIGCHLD) >= 0);
_cleanup_(sd_event_unrefp) sd_event *event = NULL;
r = sd_event_new(&event);
const char *e = secure_getenv("SYSTEMD_VMSPAWN_QEMU_EXTRA");
if (e) {
r = strv_split_and_extend_full(&cmdline, e,
- /* separators = */ NULL, /* filter_duplicates = */ false,
+ /* separators= */ NULL, /* filter_duplicates= */ false,
EXTRACT_CUNESCAPE|EXTRACT_UNQUOTE);
if (r < 0)
return log_error_errno(r, "Failed to parse $SYSTEMD_VMSPAWN_QEMU_EXTRA: %m");
log_debug("Executing: %s", joined);
}
- assert_se(sigprocmask_many(SIG_BLOCK, /* ret_old_mask=*/ NULL, SIGCHLD) >= 0);
+ assert_se(sigprocmask_many(SIG_BLOCK, /* ret_old_mask= */ NULL, SIGCHLD) >= 0);
_cleanup_(pidref_done) PidRef child_pidref = PIDREF_NULL;
r = pidref_safe_fork_full(
} else if (!isempty(arg_background))
(void) pty_forward_set_background_color(forward, arg_background);
- (void) pty_forward_set_window_title(forward, GLYPH_GREEN_CIRCLE, /* hostname = */ NULL,
+ (void) pty_forward_set_window_title(forward, GLYPH_GREEN_CIRCLE, /* hostname= */ NULL,
STRV_MAKE("Virtual Machine", arg_machine));
}
if (!IN_SET(m, VOLATILE_YES, VOLATILE_OVERLAY))
return 0;
- r = path_is_mount_point_full(path, /* root = */ NULL, AT_SYMLINK_FOLLOW);
+ r = path_is_mount_point_full(path, /* root= */ NULL, AT_SYMLINK_FOLLOW);
if (r < 0)
return log_error_errno(r, "Couldn't determine whether %s is a mount point: %m", path);
if (r == 0)
if (!path_escaped)
return log_oom();
- r = generator_open_unit_file(dest, /* source = */ NULL, service->name, &f);
+ r = generator_open_unit_file(dest, /* source= */ NULL, service->name, &f);
if (r < 0)
return r;
projects / thirdparty / systemd.git / commitdiff
