]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Reword the 'shut down hung fetch while resolving' message
authorOndřej Surý <ondrej@isc.org>
Tue, 22 Jul 2025 18:39:00 +0000 (20:39 +0200)
committerOndřej Surý <ondrej@isc.org>
Wed, 23 Jul 2025 20:37:56 +0000 (22:37 +0200)
The log message 'shut down hung fetch while resolving' may be confusing
because no detection of hung fetches actually takes place, but rather
the timer on the fetch context expires and the resolver gives up.

Change the log message to actually say that instead of the original
cryptic message about hung fetch.

lib/dns/resolver.c

index be506e505b90321548eeed0eb92e63ffef7c7020..f5a223e5987d9375c17c28239d1927c2bba5e8fe 100644 (file)
@@ -4423,10 +4423,9 @@ fctx_expired(void *arg) {
        REQUIRE(VALID_FCTX(fctx));
        REQUIRE(fctx->tid == isc_tid());
 
+       FCTXTRACE(isc_result_totext(ISC_R_TIMEDOUT));
        isc_log_write(DNS_LOGCATEGORY_RESOLVER, DNS_LOGMODULE_RESOLVER,
-                     ISC_LOG_INFO,
-                     "shut down hung fetch while resolving %p(%s)", fctx,
-                     fctx->info);
+                     ISC_LOG_INFO, "gave up on resolving '%s'", fctx->info);
 
        dns_ede_add(&fctx->edectx, DNS_EDE_NOREACHABLEAUTH, NULL);