]> git.ipfire.org Git - thirdparty/iproute2.git/commitdiff
dcb: Change --Netns/-N to --netns/-n
authorPetr Machata <me@pmachata.org>
Sun, 3 Jan 2021 10:57:24 +0000 (11:57 +0100)
committerStephen Hemminger <stephen@networkplumber.org>
Sat, 16 Jan 2021 17:12:15 +0000 (09:12 -0800)
This to keep compatible with the major tools, ip and tc. Also
document the option in the man page, which was neglected.

Fixes: 67033d1c1c8a ("Add skeleton of a new tool, dcb")
Signed-off-by: Petr Machata <me@pmachata.org>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
dcb/dcb.c
man/man8/dcb.8

index 0e3c87484f2aff0c4503cd03bd8ecafe6ffc112b..6640deef5688bbd942ca6694fb92396f60432150 100644 (file)
--- a/dcb/dcb.c
+++ b/dcb/dcb.c
@@ -332,7 +332,7 @@ static void dcb_help(void)
 {
        fprintf(stderr,
                "Usage: dcb [ OPTIONS ] OBJECT { COMMAND | help }\n"
-               "       dcb [ -f | --force ] { -b | --batch } filename [ -N | --Netns ] netnsname\n"
+               "       dcb [ -f | --force ] { -b | --batch } filename [ -n | --netns ] netnsname\n"
                "where  OBJECT := { buffer | ets | maxrate | pfc }\n"
                "       OPTIONS := [ -V | --Version | -i | --iec | -j | --json\n"
                "                  | -p | --pretty | -s | --statistics | -v | --verbose]\n");
@@ -379,7 +379,7 @@ int main(int argc, char **argv)
                { "json",               no_argument,            NULL, 'j' },
                { "pretty",             no_argument,            NULL, 'p' },
                { "statistics",         no_argument,            NULL, 's' },
-               { "Netns",              required_argument,      NULL, 'N' },
+               { "netns",              required_argument,      NULL, 'n' },
                { "help",               no_argument,            NULL, 'h' },
                { NULL, 0, NULL, 0 }
        };
@@ -396,7 +396,7 @@ int main(int argc, char **argv)
                return EXIT_FAILURE;
        }
 
-       while ((opt = getopt_long(argc, argv, "b:fhijpsvN:V",
+       while ((opt = getopt_long(argc, argv, "b:fhijn:psvV",
                                  long_options, NULL)) >= 0) {
 
                switch (opt) {
@@ -419,7 +419,7 @@ int main(int argc, char **argv)
                case 's':
                        dcb->stats = true;
                        break;
-               case 'N':
+               case 'n':
                        if (netns_switch(optarg)) {
                                ret = EXIT_FAILURE;
                                goto dcb_free;
index 5964f25d386d8474a9dd35e6d77700d180f1c117..7293bb3035775b17e285158a60fba831808bf6ae 100644 (file)
@@ -27,6 +27,13 @@ dcb \- show / manipulate DCB (Data Center Bridging) settings
 
 .SH OPTIONS
 
+.TP
+.BR "\-n" , " \--netns " <NETNS>
+switches
+.B dcb
+to the specified network namespace
+.IR NETNS .
+
 .TP
 .BR "\-V" , " --Version"
 Print the version of the