]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
accel/qaic: delete qaic_bo.handle
authorSimona Vetter <simona.vetter@ffwll.ch>
Wed, 28 May 2025 09:13:02 +0000 (11:13 +0200)
committerJeff Hugo <jeff.hugo@oss.qualcomm.com>
Fri, 6 Jun 2025 16:24:11 +0000 (10:24 -0600)
Handles are per-file, not global, so this makes no sense. Plus it's
set only after calling drm_gem_handle_create(), and drivers are not
allowed to further initialize a bo after that function has published it
already.

It is also entirely unused, which helps enormously with removing it
:-)

Since we're still holding a reference to the bo nothing bad can
happen, hence not cc: stable material.

Cc: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Cc: Carl Vanderlip <quic_carlv@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org
Signed-off-by: Simona Vetter <simona.vetter@ffwll.ch>
Signed-off-by: Simona Vetter <simona.vetter@intel.com>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Signed-off-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250528091307.1894940-5-simona.vetter@ffwll.ch
drivers/accel/qaic/qaic.h
drivers/accel/qaic/qaic_data.c

index 3fa47385aae403aad7c4054a993bbfcfcc045193..c31081e42cee0a3ac53c05e618bbf36908f4eebf 100644 (file)
@@ -221,8 +221,6 @@ struct qaic_bo {
        bool                    sliced;
        /* Request ID of this BO if it is queued for execution */
        u16                     req_id;
-       /* Handle assigned to this BO */
-       u32                     handle;
        /* Wait on this for completion of DMA transfer of this BO */
        struct completion       xfer_done;
        /*
index 1bce1af7c72c397133b298854291b94dbe8e061a..797289e9d780647b3d498622707850b5612e7a49 100644 (file)
@@ -731,7 +731,6 @@ int qaic_create_bo_ioctl(struct drm_device *dev, void *data, struct drm_file *fi
        if (ret)
                goto free_bo;
 
-       bo->handle = args->handle;
        drm_gem_object_put(obj);
        srcu_read_unlock(&qdev->dev_lock, qdev_rcu_id);
        srcu_read_unlock(&usr->qddev_lock, usr_rcu_id);