]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
check putstr return values
authorEvan Hunt <each@isc.org>
Wed, 13 Jul 2022 23:15:53 +0000 (16:15 -0700)
committerMark Andrews <marka@isc.org>
Thu, 14 Jul 2022 00:04:39 +0000 (00:04 +0000)
The calls to putstr() in named_server_fetchlimit() were not checked
for failure.

bin/named/server.c

index fadab6ece27689a4ef0e5157ecf7e34dac0a0d4e..b49b09d1dcd78e965ef5ca0735428c12bc35bd05 100644 (file)
@@ -16640,10 +16640,10 @@ named_server_fetchlimit(named_server_t *server, isc_lex_t *lex,
                }
 
                if (!first) {
-                       putstr(text, "\n");
+                       CHECK(putstr(text, "\n"));
                }
-               putstr(text, "Rate limited servers, view ");
-               putstr(text, view->name);
+               CHECK(putstr(text, "Rate limited servers, view "));
+               CHECK(putstr(text, view->name));
 
                dns_adb_getquota(view->adb, &val, NULL, NULL, NULL, NULL);
                s = snprintf(tbuf, sizeof(tbuf),
@@ -16652,26 +16652,26 @@ named_server_fetchlimit(named_server_t *server, isc_lex_t *lex,
                        return (ISC_R_NOSPACE);
                }
                first = false;
-               putstr(text, tbuf);
+               CHECK(putstr(text, tbuf));
                used = isc_buffer_usedlength(*text);
                CHECK(dns_adb_dumpquota(view->adb, text));
                if (used == isc_buffer_usedlength(*text)) {
-                       putstr(text, "\n  None.");
+                       CHECK(putstr(text, "\n  None."));
                }
 
-               putstr(text, "\nRate limited servers, view ");
-               putstr(text, view->name);
+               CHECK(putstr(text, "\nRate limited servers, view "));
+               CHECK(putstr(text, view->name));
                val = dns_resolver_getfetchesperzone(view->resolver);
                s = snprintf(tbuf, sizeof(tbuf),
                             " (fetches-per-zone %u):", val);
                if (s < 0 || (unsigned)s > sizeof(tbuf)) {
                        return (ISC_R_NOSPACE);
                }
-               putstr(text, tbuf);
+               CHECK(putstr(text, tbuf));
                used = isc_buffer_usedlength(*text);
                CHECK(dns_resolver_dumpquota(view->resolver, text));
                if (used == isc_buffer_usedlength(*text)) {
-                       putstr(text, "\n  None.");
+                       CHECK(putstr(text, "\n  None."));
                }
        }