regulator: pca9450: Fix error code in probe()

[ Upstream commit 670500b41e543c5cb09eb9f7f0e4e26c5b5fdf7e ]

Return "PTR_ERR(pca9450->sd_vsel_gpio)" instead of "ret".  The "ret"
variable is success at this point.

Fixes: 3ce6f4f943dd ("regulator: pca9450: Fix control register for LDO5")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aSBqnPoBrsNB1Ale@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pca9450-regulator.c
index 4be270f4d6c35a37bb26ccf16918ff897146e80f..91b96dbab328bd368a97294332a40e3d6857c178 100644 (file)
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -1251,10 +1251,9 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
         * to this signal (if SION bit is set in IOMUX).
         */
        pca9450->sd_vsel_gpio = gpiod_get_optional(&ldo5->dev, "sd-vsel", GPIOD_IN);
-       if (IS_ERR(pca9450->sd_vsel_gpio)) {
-               dev_err(&i2c->dev, "Failed to get SD_VSEL GPIO\n");
-               return ret;
-       }
+       if (IS_ERR(pca9450->sd_vsel_gpio))
+               return dev_err_probe(&i2c->dev, PTR_ERR(pca9450->sd_vsel_gpio),
+                                    "Failed to get SD_VSEL GPIO\n");
 
        pca9450->sd_vsel_fixed_low =
                of_property_read_bool(ldo5->dev.of_node, "nxp,sd-vsel-fixed-low");