]> git.ipfire.org Git - thirdparty/knot-dns.git/commitdiff
ctl: try to report the error in zone_backup_cmd()
authorDavid Vašek <david.vasek@nic.cz>
Thu, 3 Dec 2020 13:23:12 +0000 (14:23 +0100)
committerDaniel Salzman <daniel.salzman@nic.cz>
Mon, 8 Feb 2021 18:15:41 +0000 (19:15 +0100)
src/knot/ctl/commands.c

index 482fd4191a07f9620d77ddedb5083a7a719b16b0..9d2c0ea71406b215da0c93d40ecb5fffa3616f49 100644 (file)
@@ -455,13 +455,13 @@ static int zone_backup_cmd(zone_t *zone, ctl_args_t *args)
        ctx->readers++;
        pthread_mutex_unlock(&ctx->readers_mutex);
 
-       (void)schedule_trigger(zone, args, ZONE_EVENT_BACKUP, true);
+       int ret = schedule_trigger(zone, args, ZONE_EVENT_BACKUP, true);
 
-       if (ctx->backup_global) {
-               return KNOT_EOK;
-       } else {
-               return global_backup(ctx, zone->catalog, zone->name);
+       if (ret == KNOT_EOK && !ctx->backup_global) {
+               ret = global_backup(ctx, zone->catalog, zone->name);
        }
+
+       return ret;
 }
 
 static int zone_sign(zone_t *zone, ctl_args_t *args)