]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
soc: qcom: pdr: Fix error return code in pdr_register_listener
authorQinglang Miao <miaoqinglang@huawei.com>
Wed, 25 Nov 2020 06:50:34 +0000 (14:50 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 May 2021 08:49:45 +0000 (10:49 +0200)
[ Upstream commit 769738fc49bb578e05d404b481a9241d18147d86 ]

Fix to return the error code -EREMOTEIO from pdr_register_listener
rather than 0.

Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Link: https://lore.kernel.org/r/20201125065034.154217-1-miaoqinglang@huawei.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soc/qcom/pdr_interface.c

index 209dcdca923f90c732430708a9fed1037511a0cd..915d5bc3d46e67d188ebd9d51fdb6541c1229f25 100644 (file)
@@ -153,7 +153,7 @@ static int pdr_register_listener(struct pdr_handle *pdr,
        if (resp.resp.result != QMI_RESULT_SUCCESS_V01) {
                pr_err("PDR: %s register listener failed: 0x%x\n",
                       pds->service_path, resp.resp.error);
-               return ret;
+               return -EREMOTEIO;
        }
 
        pds->state = resp.curr_state;