modules/stats: sample all expiring records

diff --git a/modules/stats/stats.c b/modules/stats/stats.c
index 6c1fdc40e86834e07a296e3726705ea22dcf3b9f..81263984c970c33976e2a127ad1eeebf743beaa5 100644 (file)
--- a/modules/stats/stats.c
+++ b/modules/stats/stats.c
@@ -121,12 +121,6 @@ static inline int collect_key(char *key, const knot_dname_t *name, uint16_t type
 
 static void collect_sample(struct stat_data *data, struct kr_rplan *rplan, knot_pkt_t *pkt)
 {
-       /* Probabilistic sampling of all queries (consider half) */
-       unsigned roll = kr_rand_uint(FREQUENT_PSAMPLE);
-       if (roll > FREQUENT_PSAMPLE / 2) {
-               return;
-       }
-
        /* Sample key = {[2] type, [1-255] owner} */
        char key[sizeof(uint16_t) + KNOT_DNAME_MAXLEN];
        struct kr_query *qry = NULL;
@@ -141,7 +135,7 @@ static void collect_sample(struct stat_data *data, struct kr_rplan *rplan, knot_
                        if (count)
                                *count += 1;
                /* Consider 1 in N for frequent sampling. */
-               } else if (roll <= 1) {
+               } else if (kr_rand_uint(FREQUENT_PSAMPLE) <= 1) {
                        unsigned *count = lru_set(data->queries.frequent, key, key_len);
                        if (count)
                                *count += 1;