]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
soc: qcom: pbs: fix device leak on lookup
authorJohan Hovold <johan@kernel.org>
Fri, 26 Sep 2025 14:35:11 +0000 (16:35 +0200)
committerBjorn Andersson <andersson@kernel.org>
Wed, 22 Oct 2025 22:23:14 +0000 (17:23 -0500)
Make sure to drop the reference taken to the pbs platform device when
looking up its driver data.

Note that holding a reference to a device does not prevent its driver
data from going away so there is no point in keeping the reference.

Fixes: 5b2dd77be1d8 ("soc: qcom: add QCOM PBS driver")
Cc: stable@vger.kernel.org # 6.9
Cc: Anjelique Melendez <quic_amelende@quicinc.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20250926143511.6715-3-johan@kernel.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/soc/qcom/qcom-pbs.c

index 1cc5d045f9ddfe1393b7cbde22e0cbba49223ef9..06b4a596e275781bdb0554447079701607d4ebaa 100644 (file)
@@ -173,6 +173,8 @@ struct pbs_dev *get_pbs_client_device(struct device *dev)
                return ERR_PTR(-EINVAL);
        }
 
+       platform_device_put(pdev);
+
        return pbs;
 }
 EXPORT_SYMBOL_GPL(get_pbs_client_device);