]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: rockchip: usb: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Wed, 24 Dec 2025 12:44:08 +0000 (13:44 +0100)
committerVinod Koul <vkoul@kernel.org>
Thu, 1 Jan 2026 10:58:56 +0000 (16:28 +0530)
Use scoped for-each loop when iterating over device nodes to make code a
bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20251224124407.208354-4-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-usb.c

index c3c30df29c3ea1a25f7b6100afac36506ec83601..cef96739cf3ff41feef9cb9cd3a9ac4dcd5937e1 100644 (file)
@@ -446,7 +446,6 @@ static int rockchip_usb_phy_probe(struct platform_device *pdev)
        struct device *dev = &pdev->dev;
        struct rockchip_usb_phy_base *phy_base;
        struct phy_provider *phy_provider;
-       struct device_node *child;
        int err;
 
        phy_base = devm_kzalloc(dev, sizeof(*phy_base), GFP_KERNEL);
@@ -472,12 +471,10 @@ static int rockchip_usb_phy_probe(struct platform_device *pdev)
                return PTR_ERR(phy_base->reg_base);
        }
 
-       for_each_available_child_of_node(dev->of_node, child) {
+       for_each_available_child_of_node_scoped(dev->of_node, child) {
                err = rockchip_usb_phy_init(phy_base, child);
-               if (err) {
-                       of_node_put(child);
+               if (err)
                        return err;
-               }
        }
 
        phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);