]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gpio: qixis-fpga: Fix a NULL vs IS_ERR() bug in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 24 Oct 2025 06:19:21 +0000 (09:19 +0300)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 27 Oct 2025 09:19:17 +0000 (10:19 +0100)
The devm_platform_ioremap_resource() function doesn't return NULL, it
returns error pointers.  Fix the checking to match.

Fixes: e88500247dc3 ("gpio: add QIXIS FPGA GPIO controller")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Michael Walle <mwalle@kernel.org>
Link: https://lore.kernel.org/r/aPsaaf0h343Ba7c1@stanley.mountain
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-qixis-fpga.c

index 54c2c76822d566e693f338f6b1c9e5eba1a37096..6e67f43ac0bdd49559e06a2f9988364dca886021 100644 (file)
@@ -56,8 +56,8 @@ static int qixis_cpld_gpio_probe(struct platform_device *pdev)
                 * create our own from the MMIO space.
                 */
                reg = devm_platform_ioremap_resource(pdev, 0);
-               if (!reg)
-                       return -ENODEV;
+               if (IS_ERR(reg))
+                       return PTR_ERR(reg);
 
                regmap = devm_regmap_init_mmio(&pdev->dev, reg, &regmap_config_8r_8v);
                if (!regmap)