]> git.ipfire.org Git - thirdparty/libcgroup.git/commitdiff
tools/cgconfig: use exit code 129 on invalid usage
authorKamalesh Babulal <kamalesh.babulal@oracle.com>
Thu, 29 Sep 2022 10:20:56 +0000 (15:50 +0530)
committerTom Hromatka <tom.hromatka@oracle.com>
Fri, 30 Sep 2022 14:34:55 +0000 (08:34 -0600)
The exit code 1 refers to general error and using -1 wraps to
255, both codes do not signify bad arguments. Let's use exit code 129
(EXIT_BADARGS) for hinting to the users about invalid usage.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>
src/tools/cgconfig.c

index ef57e18401c0f4e5837b2818480e24ff66dc7dde..b541d4b12123eb8447f45d962280da29f03e2ae3 100644 (file)
@@ -80,7 +80,7 @@ int main(int argc, char *argv[])
        cgroup_set_default_logger(-1);
        if (argc < 2) {
                usage(1, argv[0]);
-               return -1;
+               exit(EXIT_BADARGS);
        }
 
        ret = cgroup_init();
@@ -141,14 +141,14 @@ int main(int argc, char *argv[])
                        break;
                default:
                        usage(1, argv[0]);
-                       error = -1;
+                       error = EXIT_BADARGS;
                        goto err;
                }
        }
 
        if (argv[optind]) {
                usage(1, argv[0]);
-               error = -1;
+               error = EXIT_BADARGS;
                goto err;
        }