]> git.ipfire.org Git - thirdparty/curl.git/commitdiff
libtests: drop two redundant `memset()`s
authorViktor Szakats <commit@vsz.me>
Wed, 18 Feb 2026 16:46:36 +0000 (17:46 +0100)
committerViktor Szakats <commit@vsz.me>
Fri, 20 Feb 2026 16:15:49 +0000 (17:15 +0100)
Reported by clang-tidy `bugprone-sizeof-expression`.

Silencing:
```
tests/libtest/cli_h2_pausing.c:164:23: warning: suspicious usage of 'sizeof()' on an expression of pointer type [bugprone-sizeof-expression]
  164 |   memset(&resolve, 0, sizeof(resolve));
      |                       ^
tests/libtest/cli_upload_pausing.c:158:23: warning: suspicious usage of 'sizeof()' on an expression of pointer type [bugprone-sizeof-expression]
  158 |   memset(&resolve, 0, sizeof(resolve));
      |                       ^
```

Ref: https://clang.llvm.org/extra/clang-tidy/checks/bugprone/sizeof-expression.html

Closes #20649

tests/libtest/cli_h2_pausing.c
tests/libtest/cli_upload_pausing.c

index b5b728ec20fc1a84dd7a21794a93a5953d0dae19..ac57b5c5f8aadb83948cc106e245b5a42cbce52f 100644 (file)
@@ -161,7 +161,7 @@ static CURLcode test_cli_h2_pausing(const char *URL)
     result = (CURLcode)1;
     goto cleanup;
   }
-  memset(&resolve, 0, sizeof(resolve));
+
   curl_msnprintf(resolve_buf, sizeof(resolve_buf) - 1, "%s:%s:127.0.0.1",
                  host, port);
   resolve = curl_slist_append(resolve, resolve_buf);
index 64ae2898d5ace7c4d07f77160c6aa7f2d0896ad1..c52117bf788797ac98052fed711834f88e1b7ebf 100644 (file)
@@ -155,7 +155,7 @@ static CURLcode test_cli_upload_pausing(const char *URL)
     result = (CURLcode)1;
     goto cleanup;
   }
-  memset(&resolve, 0, sizeof(resolve));
+
   curl_msnprintf(resolve_buf, sizeof(resolve_buf) - 1, "%s:%s:127.0.0.1",
                  host, port);
   resolve = curl_slist_append(resolve, resolve_buf);