RDMA: Replace memset with = {} pattern for ib_respond_udata()

Most drivers do this already, but some open-code a memset. Switch
all instances found. qedr_copy_qp_uresp() is already called with
zeroed memory so that memset is redundant.

Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>

diff --git a/drivers/infiniband/hw/cxgb4/cq.c b/drivers/infiniband/hw/cxgb4/cq.c
index 47508df4cec023ded6846d12486c9ade85f9d830..d1517f2560b9818b3fe0c83b2edee02eb6aa2f9d 100644 (file)
--- a/drivers/infiniband/hw/cxgb4/cq.c
+++ b/drivers/infiniband/hw/cxgb4/cq.c
@@ -1004,7 +1004,7 @@ int c4iw_create_cq(struct ib_cq *ibcq, const struct ib_cq_init_attr *attr,
        struct c4iw_dev *rhp = to_c4iw_dev(ibcq->device);
        struct c4iw_cq *chp = to_c4iw_cq(ibcq);
        struct c4iw_create_cq ucmd;
-       struct c4iw_create_cq_resp uresp;
+       struct c4iw_create_cq_resp uresp = {};
        int ret, wr_len;
        size_t memsize, hwentries;
        struct c4iw_mm_entry *mm, *mm2;
@@ -1102,7 +1102,6 @@ int c4iw_create_cq(struct ib_cq *ibcq, const struct ib_cq_init_attr *attr,
                if (!mm2)
                        goto err_free_mm;
 
-               memset(&uresp, 0, sizeof(uresp));
                uresp.qid_mask = rhp->rdev.cqmask;
                uresp.cqid = chp->cq.cqid;
                uresp.size = chp->cq.size;

diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c
index f9c7030ac6bfd0d846546bc2653d026787f788c8..e295f79e0cd3e5bcf44e9ad68fa6f3ca0454ed04 100644 (file)
--- a/drivers/infiniband/hw/cxgb4/qp.c
+++ b/drivers/infiniband/hw/cxgb4/qp.c
@@ -2120,7 +2120,7 @@ int c4iw_create_qp(struct ib_qp *qp, struct ib_qp_init_attr *attrs,
        struct c4iw_pd *php;
        struct c4iw_cq *schp;
        struct c4iw_cq *rchp;
-       struct c4iw_create_qp_resp uresp;
+       struct c4iw_create_qp_resp uresp = {};
        unsigned int sqsize, rqsize = 0;
        struct c4iw_ucontext *ucontext = rdma_udata_to_drv_context(
                udata, struct c4iw_ucontext, ibucontext);
@@ -2242,7 +2242,6 @@ int c4iw_create_qp(struct ib_qp *qp, struct ib_qp_init_attr *attrs,
                                goto err_free_sq_db_key;
                        }
                }
-               memset(&uresp, 0, sizeof(uresp));
                if (t4_sq_onchip(&qhp->wq.sq)) {
                        ma_sync_key_mm = kmalloc_obj(*ma_sync_key_mm);
                        if (!ma_sync_key_mm) {
@@ -2686,7 +2685,7 @@ int c4iw_create_srq(struct ib_srq *ib_srq, struct ib_srq_init_attr *attrs,
        struct c4iw_dev *rhp;
        struct c4iw_srq *srq = to_c4iw_srq(ib_srq);
        struct c4iw_pd *php;
-       struct c4iw_create_srq_resp uresp;
+       struct c4iw_create_srq_resp uresp = {};
        struct c4iw_ucontext *ucontext;
        struct c4iw_mm_entry *srq_key_mm, *srq_db_key_mm;
        int rqsize;
@@ -2764,7 +2763,6 @@ int c4iw_create_srq(struct ib_srq *ib_srq, struct ib_srq_init_attr *attrs,
                        ret = -ENOMEM;
                        goto err_free_srq_key_mm;
                }
-               memset(&uresp, 0, sizeof(uresp));
                uresp.flags = srq->flags;
                uresp.qid_mask = rhp->rdev.qpmask;
                uresp.srqid = srq->wq.qid;

diff --git a/drivers/infiniband/hw/erdma/erdma_verbs.c b/drivers/infiniband/hw/erdma/erdma_verbs.c
index c8a35337ba51e8626a64e60fefd1389496ca26fb..b59c2e3a5306d1142bbd309d36affa8684f25ac2 100644 (file)
--- a/drivers/infiniband/hw/erdma/erdma_verbs.c
+++ b/drivers/infiniband/hw/erdma/erdma_verbs.c
@@ -996,7 +996,7 @@ int erdma_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *attrs,
        struct erdma_ucontext *uctx = rdma_udata_to_drv_context(
                udata, struct erdma_ucontext, ibucontext);
        struct erdma_ureq_create_qp ureq;
-       struct erdma_uresp_create_qp uresp;
+       struct erdma_uresp_create_qp uresp = {};
        void *old_entry;
        int ret = 0;
 
@@ -1048,8 +1048,6 @@ int erdma_create_qp(struct ib_qp *ibqp, struct ib_qp_init_attr *attrs,
                if (ret)
                        goto err_out_xa;
 
-               memset(&uresp, 0, sizeof(uresp));
-
                uresp.num_sqe = qp->attrs.sq_size;
                uresp.num_rqe = qp->attrs.rq_size;
                uresp.qp_id = QP_ID(qp);

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index 083f23fc687b314f42597c6bef595401008efd6e..d5fdbd7c8dea26956a725afbdb70b7f554fda5f8 100644 (file)
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -586,11 +586,10 @@ static int ocrdma_copy_pd_uresp(struct ocrdma_dev *dev, struct ocrdma_pd *pd,
        u64 db_page_addr;
        u64 dpp_page_addr = 0;
        u32 db_page_size;
-       struct ocrdma_alloc_pd_uresp rsp;
+       struct ocrdma_alloc_pd_uresp rsp = {};
        struct ocrdma_ucontext *uctx = rdma_udata_to_drv_context(
                udata, struct ocrdma_ucontext, ibucontext);
 
-       memset(&rsp, 0, sizeof(rsp));
        rsp.id = pd->id;
        rsp.dpp_enabled = pd->dpp_enabled;
        db_page_addr = ocrdma_get_db_addr(dev, pd->id);
@@ -930,13 +929,12 @@ static int ocrdma_copy_cq_uresp(struct ocrdma_dev *dev, struct ocrdma_cq *cq,
        int status;
        struct ocrdma_ucontext *uctx = rdma_udata_to_drv_context(
                udata, struct ocrdma_ucontext, ibucontext);
-       struct ocrdma_create_cq_uresp uresp;
+       struct ocrdma_create_cq_uresp uresp = {};
 
        /* this must be user flow! */
        if (!udata)
                return -EINVAL;
 
-       memset(&uresp, 0, sizeof(uresp));
        uresp.cq_id = cq->id;
        uresp.page_size = PAGE_ALIGN(cq->len);
        uresp.num_pages = 1;
@@ -1173,11 +1171,10 @@ static int ocrdma_copy_qp_uresp(struct ocrdma_qp *qp,
 {
        int status;
        u64 usr_db;
-       struct ocrdma_create_qp_uresp uresp;
+       struct ocrdma_create_qp_uresp uresp = {};
        struct ocrdma_pd *pd = qp->pd;
        struct ocrdma_dev *dev = get_ocrdma_dev(pd->ibpd.device);
 
-       memset(&uresp, 0, sizeof(uresp));
        usr_db = dev->nic_info.unmapped_db +
                        (pd->id * dev->nic_info.db_page_size);
        uresp.qp_id = qp->id;
@@ -1730,9 +1727,8 @@ static int ocrdma_copy_srq_uresp(struct ocrdma_dev *dev, struct ocrdma_srq *srq,
                                struct ib_udata *udata)
 {
        int status;
-       struct ocrdma_create_srq_uresp uresp;
+       struct ocrdma_create_srq_uresp uresp = {};
 
-       memset(&uresp, 0, sizeof(uresp));
        uresp.rq_dbid = srq->rq.dbid;
        uresp.num_rq_pages = 1;
        uresp.rq_page_addr[0] = virt_to_phys(srq->rq.va);

diff --git a/drivers/infiniband/hw/qedr/verbs.c b/drivers/infiniband/hw/qedr/verbs.c
index 79190c5b8b50b0533c67e1037255982818874c1c..1af908275ca7290a6a748d2463df675df1860aab 100644 (file)
--- a/drivers/infiniband/hw/qedr/verbs.c
+++ b/drivers/infiniband/hw/qedr/verbs.c
@@ -690,9 +690,7 @@ static void qedr_db_recovery_del(struct qedr_dev *dev,
 static int qedr_copy_cq_uresp(struct qedr_cq *cq, struct ib_udata *udata,
                              u32 db_offset)
 {
-       struct qedr_create_cq_uresp uresp;
-
-       memset(&uresp, 0, sizeof(uresp));
+       struct qedr_create_cq_uresp uresp = {};
 
        uresp.db_offset = db_offset;
        uresp.icid = cq->icid;
@@ -1283,8 +1281,6 @@ static int qedr_copy_qp_uresp(struct qedr_dev *dev,
                              struct qedr_qp *qp, struct ib_udata *udata,
                              struct qedr_create_qp_uresp *uresp)
 {
-       memset(uresp, 0, sizeof(*uresp));
-
        if (qedr_qp_has_sq(qp))
                qedr_copy_sq_uresp(dev, uresp, qp);
 

diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
index e887f03a84d0633a8e53732949e9d769bc0f046b..261f18a83685437657442fe151b190892e3337b4 100644 (file)
--- a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
+++ b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c
@@ -82,15 +82,13 @@ static void usnic_ib_fw_string_to_u64(char *fw_ver_str, u64 *fw_ver)
 static int usnic_ib_fill_create_qp_resp(struct usnic_ib_qp_grp *qp_grp,
                                        struct ib_udata *udata)
 {
-       struct usnic_ib_create_qp_resp resp;
+       struct usnic_ib_create_qp_resp resp = {};
        struct pci_dev *pdev;
        struct vnic_dev_bar *bar;
        struct usnic_vnic_res_chunk *chunk;
        struct usnic_ib_qp_grp_flow *default_flow;
        int i, err;
 
-       memset(&resp, 0, sizeof(resp));
-
        pdev = usnic_vnic_get_pdev(qp_grp->vf->vnic);
        if (!pdev) {
                usnic_err("Failed to get pdev of qp_grp %d\n",