media: rcar-vin: Fix RAW10

Fix the following to get RAW10 formats working:

In rvin_formats, the bpp is set to 4 for RAW10. As VIN unpacks RAW10 to
16-bit containers, the bpp should be 2.

Don't set VNDMR_YC_THR to the VNDMR register. The YC_THR is "YC Data
Through Mode", used for YUV formats and should not be set for RAW10.

Fixes: 1b7e7240eaf3 ("media: rcar-vin: Add support for RAW10")
Cc: stable@vger.kernel.org
Signed-off-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Tested-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20250424-rcar-fix-raw-v2-4-f6afca378124@ideasonboard.com
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
index 65e41c68e62738f6e9017c254330a082c155b384..5c08ee2c980761d0c8b9b200f96b3ae71f870d24 100644 (file)
--- a/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
+++ b/drivers/media/platform/renesas/rcar-vin/rcar-dma.c
@@ -870,7 +870,7 @@ static int rvin_setup(struct rvin_dev *vin)
        case V4L2_PIX_FMT_SGBRG10:
        case V4L2_PIX_FMT_SGRBG10:
        case V4L2_PIX_FMT_SRGGB10:
-               dmr = VNDMR_RMODE_RAW10 | VNDMR_YC_THR;
+               dmr = VNDMR_RMODE_RAW10;
                break;
        default:
                vin_err(vin, "Invalid pixelformat (0x%x)\n",

diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
index ade007a9811f43f79a03c0985f8c4535d2e94195..db091af57c19018aba7fe2c1563057acff63a051 100644 (file)
--- a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
+++ b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
@@ -88,19 +88,19 @@ static const struct rvin_video_format rvin_formats[] = {
        },
        {
                .fourcc                 = V4L2_PIX_FMT_SBGGR10,
-               .bpp                    = 4,
+               .bpp                    = 2,
        },
        {
                .fourcc                 = V4L2_PIX_FMT_SGBRG10,
-               .bpp                    = 4,
+               .bpp                    = 2,
        },
        {
                .fourcc                 = V4L2_PIX_FMT_SGRBG10,
-               .bpp                    = 4,
+               .bpp                    = 2,
        },
        {
                .fourcc                 = V4L2_PIX_FMT_SRGGB10,
-               .bpp                    = 4,
+               .bpp                    = 2,
        },
 };