]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
util: Don't check the output of virGetUserCacheDirectory()
authorFabiano Fidêncio <fidencio@redhat.com>
Thu, 19 Dec 2019 09:12:56 +0000 (10:12 +0100)
committerFabiano Fidêncio <fidencio@redhat.com>
Fri, 20 Dec 2019 08:38:43 +0000 (09:38 +0100)
virGetUserCacheDirectory() *never* *ever* returns NULL, making the
checks for it completely unnecessary.

Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/util/virlog.c

index 10639d7328827fb108a9533ac20f2682b84deb93..6bae56e2e3be5de4aa6fb382c36f992dda41f401 100644 (file)
@@ -180,8 +180,7 @@ virLogSetDefaultOutputToFile(const char *binary, bool privileged)
         virLogDefaultOutput = g_strdup_printf("%d:file:%s/log/libvirt/%s.log",
                                               virLogDefaultPriority, LOCALSTATEDIR, binary);
     } else {
-        if (!(logdir = virGetUserCacheDirectory()))
-            return -1;
+        logdir = virGetUserCacheDirectory();
 
         old_umask = umask(077);
         if (virFileMakePath(logdir) < 0) {