ALSA: ad1816a: Use safer strscpy() instead of strcpy()

Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-23-tiwai@suse.de

diff --git a/sound/isa/ad1816a/ad1816a.c b/sound/isa/ad1816a/ad1816a.c
index 5c9e2d41d9005fc58da681fe97af9a10e2a76ccb..8e84d4091f1ee09c943e302e0a5da0883f1c212b 100644 (file)
--- a/sound/isa/ad1816a/ad1816a.c
+++ b/sound/isa/ad1816a/ad1816a.c
@@ -143,8 +143,8 @@ static int snd_card_ad1816a_probe(int dev, struct pnp_card_link *pcard,
        if (clockfreq[dev] >= 5000 && clockfreq[dev] <= 100000)
                chip->clock_freq = clockfreq[dev];
 
-       strcpy(card->driver, "AD1816A");
-       strcpy(card->shortname, "ADI SoundPort AD1816A");
+       strscpy(card->driver, "AD1816A");
+       strscpy(card->shortname, "ADI SoundPort AD1816A");
        sprintf(card->longname, "%s, SS at 0x%lx, irq %d, dma %d&%d",
                card->shortname, chip->port, irq[dev], dma1[dev], dma2[dev]);
 

diff --git a/sound/isa/ad1816a/ad1816a_lib.c b/sound/isa/ad1816a/ad1816a_lib.c
index 2b87036cb94fba501f9ec56c1d64ef5af2d80363..400ae547bcbab09fab89ccee46e09debff65382b 100644 (file)
--- a/sound/isa/ad1816a/ad1816a_lib.c
+++ b/sound/isa/ad1816a/ad1816a_lib.c
@@ -631,7 +631,7 @@ int snd_ad1816a_pcm(struct snd_ad1816a *chip, int device)
        pcm->private_data = chip;
        pcm->info_flags = (chip->dma1 == chip->dma2 ) ? SNDRV_PCM_INFO_JOINT_DUPLEX : 0;
 
-       strcpy(pcm->name, snd_ad1816a_chip_id(chip));
+       strscpy(pcm->name, snd_ad1816a_chip_id(chip));
        snd_ad1816a_init(chip);
 
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_DEV, chip->card->dev,
@@ -655,7 +655,7 @@ int snd_ad1816a_timer(struct snd_ad1816a *chip, int device)
        error = snd_timer_new(chip->card, "AD1816A", &tid, &timer);
        if (error < 0)
                return error;
-       strcpy(timer->name, snd_ad1816a_chip_id(chip));
+       strscpy(timer->name, snd_ad1816a_chip_id(chip));
        timer->private_data = chip;
        chip->timer = timer;
        timer->hw = snd_ad1816a_timer_table;
@@ -912,7 +912,7 @@ int snd_ad1816a_mixer(struct snd_ad1816a *chip)
 
        card = chip->card;
 
-       strcpy(card->mixername, snd_ad1816a_chip_id(chip));
+       strscpy(card->mixername, snd_ad1816a_chip_id(chip));
 
        for (idx = 0; idx < ARRAY_SIZE(snd_ad1816a_controls); idx++) {
                err = snd_ctl_add(card, snd_ctl_new1(&snd_ad1816a_controls[idx], chip));