serial: pic32: fix missing clk_disable_unprepare() on error in pic32_uart_startup()

[ Upstream commit 6f3cdf2bf1ba9b70de6c2921a415951a0d59873b ]

Fix the missing clk_disable_unprepare() before return
from pic32_uart_startup() in the error handling case.

Fixes: 157b9394709e ("serial: pic32_uart: Add PIC32 UART driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220525021204.2407631-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c
index e3535bd8c8a2cff2261fa555096155252551bbe0..a967b586a0a07f3d45a3e402ae26d2319f875d34 100644 (file)
--- a/drivers/tty/serial/pic32_uart.c
+++ b/drivers/tty/serial/pic32_uart.c
@@ -427,7 +427,7 @@ static int pic32_uart_startup(struct uart_port *port)
        if (!sport->irq_fault_name) {
                dev_err(port->dev, "%s: kasprintf err!", __func__);
                ret = -ENOMEM;
-               goto out_done;
+               goto out_disable_clk;
        }
        irq_set_status_flags(sport->irq_fault, IRQ_NOAUTOEN);
        ret = request_irq(sport->irq_fault, pic32_uart_fault_interrupt,
@@ -501,6 +501,8 @@ out_r:
 out_f:
        free_irq(sport->irq_fault, port);
        kfree(sport->irq_fault_name);
+out_disable_clk:
+       clk_disable_unprepare(sport->clk);
 out_done:
        return ret;
 }