]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs: kill XBF_UNMAPPED
authorChristoph Hellwig <hch@lst.de>
Wed, 7 May 2025 21:59:48 +0000 (14:59 -0700)
committerAndrey Albershteyn <aalbersh@kernel.org>
Wed, 28 May 2025 10:16:39 +0000 (12:16 +0200)
Source kernel commit: a2f790b28512c22f7cf4f420a99e1b008e7098fe

Unmapped buffer access is a pain, so kill it. The switch to large
folios means we rarely pay a vmap penalty for large buffers,
so this functionality is largely unnecessary now.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
libxfs/libxfs_priv.h
libxfs/xfs_ialloc.c
libxfs/xfs_inode_buf.c

index d5f7d28e08e268d25676a7e4122f05d438c67d05..48a84a1089ee47dd763b6003fe545791203633d6 100644 (file)
@@ -359,7 +359,6 @@ static inline unsigned long long mask64_if_power2(unsigned long b)
 
 /* buffer management */
 #define XBF_TRYLOCK                    0
-#define XBF_UNMAPPED                   0
 #define XBF_DONE                       0
 #define xfs_buf_stale(bp)              ((bp)->b_flags |= LIBXFS_B_STALE)
 #define XFS_BUF_UNDELAYWRITE(bp)       ((bp)->b_flags &= ~LIBXFS_B_DIRTY)
index b401299ad933f76b7bbfbeba881ef88428d93982..fa9d94abb6986220cb4245c6d4d56d9f49b2b029 100644 (file)
@@ -359,7 +359,7 @@ xfs_ialloc_inode_init(
                                (j * M_IGEO(mp)->blocks_per_cluster));
                error = xfs_trans_get_buf(tp, mp->m_ddev_targp, d,
                                mp->m_bsize * M_IGEO(mp)->blocks_per_cluster,
-                               XBF_UNMAPPED, &fbuf);
+                               0, &fbuf);
                if (error)
                        return error;
 
index 5ca753465b96260c64cf14d6cb491240fc3fe0d8..4eca3d6dd6a71a3113e80cbea4895345480a64d4 100644 (file)
@@ -134,7 +134,7 @@ xfs_imap_to_bp(
        int                     error;
 
        error = xfs_trans_read_buf(mp, tp, mp->m_ddev_targp, imap->im_blkno,
-                       imap->im_len, XBF_UNMAPPED, bpp, &xfs_inode_buf_ops);
+                       imap->im_len, 0, bpp, &xfs_inode_buf_ops);
        if (xfs_metadata_is_sick(error))
                xfs_agno_mark_sick(mp, xfs_daddr_to_agno(mp, imap->im_blkno),
                                XFS_SICK_AG_INODES);