]> git.ipfire.org Git - thirdparty/collectd.git/commitdiff
disk plugin: Remove ops_time metric for Solaris.
authorFlorian Forster <octo@collectd.org>
Fri, 19 Jan 2024 21:19:16 +0000 (22:19 +0100)
committerFlorian Forster <octo@collectd.org>
Mon, 22 Jan 2024 18:28:50 +0000 (19:28 +0100)
The fields do not mean what we thought they meant. "wtime" means "wait time",
"rtime" means "run time".

Fixes: #3875 (for collectd 6)
src/disk.c

index ca461204a2e9562ab255d412d5cfa95a0cbce356..abbb1f312c83044a39f05a81c9510aaacf18b556 100644 (file)
@@ -1092,14 +1092,6 @@ static int disk_read(void) {
     metric_family_append(&fam_ops, direction_label, write_direction,
                          (value_t){.counter = kio.KIO_WOPS}, &m);
 
-    if (strncmp(ksp[i]->ks_class, "disk", 4) == 0) {
-      /* FIXME: Convert this to microseconds if necessary */
-      metric_family_append(&fam_ops_time, direction_label, read_direction,
-                           (value_t){.counter = kio.KIO_RTIME}, &m);
-      metric_family_append(&fam_ops_time, direction_label, write_direction,
-                           (value_t){.counter = kio.KIO_WTIME}, &m);
-    }
-
     metric_reset(&m);
   }
   /* #endif defined(HAVE_LIBKSTAT) */