]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
selftests: mptcp: join: mark 'delete re-add signal' as skipped if not supported
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Mon, 20 Oct 2025 20:53:29 +0000 (22:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Oct 2025 13:10:24 +0000 (14:10 +0100)
commit c3496c052ac36ea98ec4f8e95ae6285a425a2457 upstream.

The call to 'continue_if' was missing: it properly marks a subtest as
'skipped' if the attached condition is not valid.

Without that, the test is wrongly marked as passed on older kernels.

Fixes: b5e2fb832f48 ("selftests: mptcp: add explicit test case for remove/readd")
Cc: stable@vger.kernel.org
Reviewed-by: Geliang Tang <geliang@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Link: https://patch.msgid.link/20251020-net-mptcp-c-flag-late-add-addr-v1-4-8207030cb0e8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/testing/selftests/net/mptcp/mptcp_join.sh

index dab5b7b0782bb6c962645ae775bef64e7dc5c46c..5579709c3653349d537756440c02589d3156487a 100755 (executable)
@@ -3852,7 +3852,7 @@ endpoint_tests()
 
        # remove and re-add
        if reset_with_events "delete re-add signal" &&
-          mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
+          continue_if mptcp_lib_kallsyms_has "subflow_rebuild_header$"; then
                ip netns exec $ns1 sysctl -q net.mptcp.add_addr_timeout=0
                pm_nl_set_limits $ns1 0 3
                pm_nl_set_limits $ns2 3 3