]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
spi: stm32-ospi: Fix NULL vs IS_ERR() bug in stm32_ospi_get_resources()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 15 Jul 2025 23:01:39 +0000 (18:01 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 16 Jul 2025 15:35:18 +0000 (16:35 +0100)
This code was changed from using devm_ioremap() which returns NULL to
using devm_ioremap_resource() which returns error pointers.  Update
the error checking to match.

Fixes: defe01abfb7f ("spi: stm32-ospi: Use of_reserved_mem_region_to_resource() for "memory-region"")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/fb2a26a2-119b-4b5a-8d44-b29e2c736081@sabinyo.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-stm32-ospi.c

index 72baa402a2c3a3c994fa96f2d12e09fb9238c666..f36fd36da269221689c4bbc36933f0fae0dfc845 100644 (file)
@@ -823,9 +823,9 @@ static int stm32_ospi_get_resources(struct platform_device *pdev)
        if (!ret) {
                ospi->mm_size = resource_size(res);
                ospi->mm_base = devm_ioremap_resource(dev, res);
-               if (!ospi->mm_base) {
+               if (IS_ERR(ospi->mm_base)) {
                        dev_err(dev, "unable to map memory region: %pR\n", res);
-                       ret = -ENOMEM;
+                       ret = PTR_ERR(ospi->mm_base);
                        goto err_dma;
                }