]> git.ipfire.org Git - thirdparty/xz.git/commitdiff
CI: Enable CLMUL in address sanitization test.
authorJia Tan <jiat0218@gmail.com>
Thu, 14 Sep 2023 13:13:23 +0000 (21:13 +0800)
committerJia Tan <jiat0218@gmail.com>
Thu, 14 Sep 2023 13:43:34 +0000 (21:43 +0800)
The crc64_clmul() function should be ignored by the address sanitizer
now so these builds should still pass.

.github/workflows/ci.yml

index f2e8c70aaa496aff65775532163a8f2964a29923..79ceb1411e3920eba40d5e8b59de90531a589875 100644 (file)
@@ -78,19 +78,15 @@ jobs:
             ./build-aux/ci_build.sh -b autotools -p test -f "-m32" -n 32_bit
             cd ../xz_build && make distclean
 
-      # ifunc and clmul must be disabled for this test because they will
-      # fail with -fsanitize=address. __attribute__ ifunc is incompatible
-      # with -fsanitize=address.CLMUL optimizations will read past the
-      # bounds of small buffers and mask out the unneeded values. This
-      # triggers -fsanitize=address to report an error even though the
-      # operation is safe.
+      # ifunc must be disabled for this test because __attribute__ ifunc is
+      # incompatible with -fsanitize=address.
       - name: Build with -fsanitize=address,undefined
         if: ${{ matrix.os == 'ubuntu-latest' && matrix.build_system == 'autotools' }}
-        run: ./build-aux/ci_build.sh -b autotools -p build -f "-fsanitize=address,undefined" -d ifunc,clmul
+        run: ./build-aux/ci_build.sh -b autotools -p build -f "-fsanitize=address,undefined" -d ifunc
       - name: Test with -fsanitize=address,undefined
         if: ${{ matrix.os == 'ubuntu-latest' && matrix.build_system == 'autotools' }}
         run: |
-            ./build-aux/ci_build.sh -b autotools -p test -f "-fsanitize=address,undefined" -d ifunc,clmul
+            ./build-aux/ci_build.sh -b autotools -p test -f "-fsanitize=address,undefined" -d ifunc
             cd ../xz_build && make distclean
 
       - name: Build with full features