]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: platform: rpi1-cfe: drop vb2_ops_wait_prepare/finish
authorHans Verkuil <hverkuil@xs4all.nl>
Tue, 28 Jan 2025 15:03:39 +0000 (16:03 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 18 Feb 2025 07:11:37 +0000 (08:11 +0100)
Since commit 88785982a19d ("media: vb2: use lock if wait_prepare/finish
are NULL") it is no longer needed to set the wait_prepare/finish
vb2_ops callbacks as long as the lock field in vb2_queue is set.

Since the vb2_ops_wait_prepare/finish callbacks already rely on that field,
we can safely drop these callbacks.

This simplifies the code and this is a step towards the goal of deleting
these callbacks.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c

index ed3d18917f2d7d35efe64b1ed22f6258d2e763b7..69a5f23e7954393e74ab2d2a79eddec01d58cc05 100644 (file)
@@ -1317,8 +1317,6 @@ static void cfe_stop_streaming(struct vb2_queue *vq)
 }
 
 static const struct vb2_ops cfe_video_qops = {
-       .wait_prepare = vb2_ops_wait_prepare,
-       .wait_finish = vb2_ops_wait_finish,
        .queue_setup = cfe_queue_setup,
        .buf_prepare = cfe_buffer_prepare,
        .buf_queue = cfe_buffer_queue,