]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: fix hotplug of udp device with no connect host
authorJán Tomko <jtomko@redhat.com>
Tue, 26 Sep 2017 11:56:36 +0000 (13:56 +0200)
committerJán Tomko <jtomko@redhat.com>
Wed, 27 Sep 2017 10:38:27 +0000 (12:38 +0200)
Use an empty string to let qemu fill out the default.
This matches what's done in qemuBuildChrChardevStr.

https://bugzilla.redhat.com/show_bug.cgi?id=1454671

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
src/qemu/qemu_monitor_json.c

index 63b855920be3f4afc93d3e3cafbed76038f29777..c63d250d3642fd811f5d9e387ec2d2649c0fdb7c 100644 (file)
@@ -6522,7 +6522,10 @@ qemuMonitorJSONAttachCharDevCommand(const char *chrID,
 
     case VIR_DOMAIN_CHR_TYPE_UDP:
         backend_type = "udp";
-        addr = qemuMonitorJSONBuildInetSocketAddress(chr->data.udp.connectHost,
+        host = chr->data.udp.connectHost;
+        if (!host)
+            host = "";
+        addr = qemuMonitorJSONBuildInetSocketAddress(host,
                                                      chr->data.udp.connectService);
         if (!addr ||
             virJSONValueObjectAppend(data, "remote", addr) < 0)