]> git.ipfire.org Git - thirdparty/bugzilla.git/commitdiff
Bug 678772: version.pm 0.92 and newer forbids negative values, making checksetup...
authorFrédéric Buclin <LpSolit@gmail.com>
Tue, 16 Aug 2011 01:45:37 +0000 (03:45 +0200)
committerFrédéric Buclin <LpSolit@gmail.com>
Tue, 16 Aug 2011 01:45:37 +0000 (03:45 +0200)
r/a=mkanat

Bugzilla/Install/Requirements.pm

index 3238246419f37044f7d57f745f77ce6d8d5bb535..46790dd8f96756f3a8e335af4006d7f743817443 100644 (file)
@@ -698,8 +698,9 @@ sub _checking_for {
     # show "ok" or "not found".
     if (exists $params->{found}) {
         my $found_string;
-        # We do a string compare in case it's non-numeric.
-        if ($found and $found eq "-1") {
+        # We do a string compare in case it's non-numeric. We make sure
+        # it's not a version object as negative versions are forbidden.
+        if ($found && !ref($found) && $found eq '-1') {
             $found_string = install_string('module_not_found');
         }
         elsif ($found) {