]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
libvirt-qemu: Don't allow NULL cmd in virDomainQemuMonitorCommandWithFiles()
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 8 Mar 2022 14:09:59 +0000 (15:09 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 8 Mar 2022 15:04:24 +0000 (16:04 +0100)
Nothing in daemon code is prepared for the command in
virDomainQemuMonitorCommandWithFiles() to be NULL. In fact, the
client side doesn't expect this either as our RPC describes the
argument as:

    remote_nonnull_string cmd;

Validate the argument in the public API implementation.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/libvirt-qemu.c

index 9e80577b56843fdf47e4fabac4294925fb43b9d9..c4f71c0311ecb866ce34535ff8b2e70d2c3a3ceb 100644 (file)
@@ -153,6 +153,8 @@ virDomainQemuMonitorCommandWithFiles(virDomainPtr domain,
     virCheckDomainReturn(domain, -1);
     conn = domain->conn;
 
+    virCheckNonNullArgGoto(cmd, error);
+
     if (ninfiles > 0 || outfiles) {
         int rc;
         if ((rc = VIR_DRV_SUPPORTS_FEATURE(conn->driver, conn,