]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
prov: remove todos in rsa_keymgmt.c
authorPauli <ppzgs1@gmail.com>
Mon, 15 Mar 2021 23:56:31 +0000 (09:56 +1000)
committerPauli <ppzgs1@gmail.com>
Wed, 17 Mar 2021 00:33:45 +0000 (10:33 +1000)
The TODOs are about OAEP and aren't relevant.

Fixes #14361

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/14565)

providers/implementations/keymgmt/rsa_kmgmt.c

index 425b6c80f29af5f35bc7b9831ff10b7dcd5aa3ff..7869b2dddc52c17cbb6874076ec536f1f13a8d3c 100644 (file)
@@ -164,8 +164,6 @@ static int rsa_import(void *keydata, int selection, const OSSL_PARAM params[])
 
     rsa_type = RSA_test_flags(rsa, RSA_FLAG_TYPE_MASK);
 
-    /* TODO(3.0) OAEP should bring on parameters as well */
-
     if ((selection & OSSL_KEYMGMT_SELECT_OTHER_PARAMETERS) != 0)
         ok = ok && pss_params_fromdata(ossl_rsa_get0_pss_params_30(rsa),
                                        &pss_defaults_set,
@@ -189,8 +187,6 @@ static int rsa_export(void *keydata, int selection,
     if (!ossl_prov_is_running() || rsa == NULL)
         return 0;
 
-    /* TODO(3.0) OAEP should bring on parameters */
-
     tmpl = OSSL_PARAM_BLD_new();
     if (tmpl == NULL)
         return 0;