]> git.ipfire.org Git - thirdparty/Chart.js.git/commitdiff
Context compatibility with dataLabels (#6713)
authorJukka Kurkela <jukka.kurkela@gmail.com>
Sat, 9 Nov 2019 00:59:05 +0000 (02:59 +0200)
committerEvert Timberg <evert.timberg+github@gmail.com>
Sat, 9 Nov 2019 00:59:05 +0000 (19:59 -0500)
* Context compatibility with dataLabels

* document

* THe + wording

docs/getting-started/v3-migration.md
src/core/core.datasetController.js

index 2d27abdb0743252614090554190dedac0444ea2b..51035bc90c70b0a4c9bc6df69d20262aa1b5a620 100644 (file)
@@ -27,6 +27,7 @@ Chart.js is no longer providing the `Chart.bundle.js` and `Chart.bundle.min.js`.
 
 * `custom` attribute of elements was removed. Please use scriptable options
 * The `zeroLine*` options of axes were removed.
+* The `hover` property of scriptable options `context` object was renamed to `active` to align it with the datalabels plugin.
 
 ### Options
 
index 70fdefe534793ec6096b9a33cff840e536e50cb2..cc9601ec3579e001174f65fd91784dc3e0246027 100644 (file)
@@ -704,7 +704,7 @@ helpers.extend(DatasetController.prototype, {
        /**
         * @private
         */
-       _resolveDatasetElementOptions: function(hover) {
+       _resolveDatasetElementOptions: function(active) {
                var me = this;
                var chart = me.chart;
                var datasetOpts = me._config;
@@ -715,15 +715,15 @@ helpers.extend(DatasetController.prototype, {
 
                // Scriptable options
                var context = {
-                       chart: chart,
+                       chart,
                        dataset: me.getDataset(),
                        datasetIndex: me.index,
-                       hover: hover
+                       active
                };
 
                for (i = 0, ilen = elementOptions.length; i < ilen; ++i) {
                        key = elementOptions[i];
-                       readKey = hover ? 'hover' + key.charAt(0).toUpperCase() + key.slice(1) : key;
+                       readKey = active ? 'hover' + key.charAt(0).toUpperCase() + key.slice(1) : key;
                        values[key] = resolve([
                                datasetOpts[readKey],
                                options[readKey]