]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
CLEANUP: sock-unix: Remove an unreachable goto clause
authorChristopher Faulet <cfaulet@haproxy.com>
Wed, 7 Oct 2020 12:37:00 +0000 (14:37 +0200)
committerChristopher Faulet <cfaulet@haproxy.com>
Wed, 7 Oct 2020 12:37:03 +0000 (14:37 +0200)
Coverity reported dead code in sock_unix_bind_receiver() function. A goto clause
is unreachable because of the preceeding if/else block.

This patch should fix the issue #865. No backport needed.

src/sock_unix.c

index a3056df9347f1d6eccd057c7f1776657d213dde9..2be8d6bfb792f09678236c049c61ae48b0a1e50d 100644 (file)
@@ -252,7 +252,6 @@ int sock_unix_bind_receiver(struct receiver *rx, void (*handler)(int fd), char *
                        memprintf(errmsg, "cannot bind UNIX socket (%s)", strerror(errno));
                        goto bind_close_return;
                }
-               goto err_unlink_temp;
        }
 
        /* <uid> and <gid> different of -1 will be used to change the socket owner.