]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: stmmac: convert to use .get_rx_ring_count
authorBreno Leitao <leitao@debian.org>
Thu, 8 Jan 2026 11:43:00 +0000 (03:43 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 10 Jan 2026 20:16:23 +0000 (12:16 -0800)
Convert the stmmac driver to use the new .get_rx_ring_count
ethtool operation instead of implementing .get_rxnfc for handling
ETHTOOL_GRXRINGS command.

Since stmmac_get_rxnfc() only handled ETHTOOL_GRXRINGS (returning
-EOPNOTSUPP for all other commands), remove it entirely and replace
it with the simpler stmmac_get_rx_ring_count() callback.

Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://patch.msgid.link/20260108-gxring_stmicro-v2-1-3dcadc8ed29b@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c

index b155e71aac51f9dd88fc01ab5dace94978cd3ef2..c1e26965d9b5d3f8d6262742644dc8ad10889404 100644 (file)
@@ -914,20 +914,11 @@ static int stmmac_set_per_queue_coalesce(struct net_device *dev, u32 queue,
        return __stmmac_set_coalesce(dev, ec, queue);
 }
 
-static int stmmac_get_rxnfc(struct net_device *dev,
-                           struct ethtool_rxnfc *rxnfc, u32 *rule_locs)
+static u32 stmmac_get_rx_ring_count(struct net_device *dev)
 {
        struct stmmac_priv *priv = netdev_priv(dev);
 
-       switch (rxnfc->cmd) {
-       case ETHTOOL_GRXRINGS:
-               rxnfc->data = priv->plat->rx_queues_to_use;
-               break;
-       default:
-               return -EOPNOTSUPP;
-       }
-
-       return 0;
+       return priv->plat->rx_queues_to_use;
 }
 
 static u32 stmmac_get_rxfh_key_size(struct net_device *dev)
@@ -1121,7 +1112,7 @@ static const struct ethtool_ops stmmac_ethtool_ops = {
        .get_eee = stmmac_ethtool_op_get_eee,
        .set_eee = stmmac_ethtool_op_set_eee,
        .get_sset_count = stmmac_get_sset_count,
-       .get_rxnfc = stmmac_get_rxnfc,
+       .get_rx_ring_count = stmmac_get_rx_ring_count,
        .get_rxfh_key_size = stmmac_get_rxfh_key_size,
        .get_rxfh_indir_size = stmmac_get_rxfh_indir_size,
        .get_rxfh = stmmac_get_rxfh,