]> git.ipfire.org Git - thirdparty/bind9.git/commitdiff
Silence coverity warnings in query.c
authorDiego Fronza <diego@isc.org>
Wed, 25 Nov 2020 19:01:06 +0000 (16:01 -0300)
committerDiego dos Santos Fronza <diego@isc.org>
Thu, 26 Nov 2020 14:55:14 +0000 (14:55 +0000)
Return value of dns_db_getservestalerefresh() and
dns_db_getservestalettl() functions were previously unhandled.

This commit purposefully ignore those return values since there is
no side effect if those results are != ISC_R_SUCCESS, it also supress
Coverity warnings.

lib/ns/query.c

index 393ddaf8ce92c9340d677f0c27a958539ec32397..86b7c944e789d34b9cb37928d3377203a217c628 100644 (file)
@@ -5642,9 +5642,9 @@ query_lookup(query_ctx_t *qctx) {
                dboptions |= DNS_DBFIND_COVERINGNSEC;
        }
 
-       dns_db_getservestalerefresh(qctx->client->view->cachedb,
-                                   &stale_refresh);
-       dns_db_getservestalettl(qctx->client->view->cachedb, &stale_ttl);
+       (void)dns_db_getservestalerefresh(qctx->client->view->cachedb,
+                                         &stale_refresh);
+       (void)dns_db_getservestalettl(qctx->client->view->cachedb, &stale_ttl);
        if (stale_refresh > 0) {
                if (qctx->client->view->staleanswersok == dns_stale_answer_yes)
                {