]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
udev/watch: drop redundant argument
authorYu Watanabe <watanabe.yu+github@gmail.com>
Fri, 30 Jan 2026 15:15:29 +0000 (00:15 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 3 Feb 2026 12:25:01 +0000 (21:25 +0900)
The arguments dev and target are always same.

src/udev/udev-watch.c

index 10cbc848460dbba5c531179e0c582c04b1d2d0e8..bebe575dfb6f3412760396b5c0360a9d6a24e9b5 100644 (file)
@@ -141,21 +141,20 @@ void udev_watch_dump(void) {
         }
 }
 
-static int synthesize_change_one(sd_device *dev, sd_device *target) {
+static int synthesize_change_one(sd_device *dev) {
         int r;
 
         assert(dev);
-        assert(target);
 
         if (DEBUG_LOGGING) {
                 const char *syspath = NULL;
-                (void) sd_device_get_syspath(target, &syspath);
+                (void) sd_device_get_syspath(dev, &syspath);
                 log_device_debug(dev, "device is closed, synthesising 'change' on %s", strna(syspath));
         }
 
-        r = sd_device_trigger(target, SD_DEVICE_CHANGE);
+        r = sd_device_trigger(dev, SD_DEVICE_CHANGE);
         if (r < 0)
-                return log_device_debug_errno(target, r, "Failed to trigger 'change' uevent: %m");
+                return log_device_debug_errno(dev, r, "Failed to trigger 'change' uevent: %m");
 
         DEVICE_TRACE_POINT(synthetic_change_event, dev);
 
@@ -180,13 +179,13 @@ static int synthesize_change(Manager *manager, sd_device *dev) {
         if (r < 0)
                 return r;
         if (r > 0)
-                return synthesize_change_one(dev, dev);
+                return synthesize_change_one(dev);
 
         r = block_device_is_whole_disk(dev);
         if (r < 0)
                 return r;
         if (r == 0)
-                return synthesize_change_one(dev, dev);
+                return synthesize_change_one(dev);
 
         _cleanup_(pidref_done) PidRef pidref = PIDREF_NULL;
         r = pidref_safe_fork(