]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
log: LOG_OPTION is not supported here
authorAki Tuomi <aki.tuomi@dovecot.fi>
Thu, 24 May 2018 17:16:33 +0000 (20:16 +0300)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Wed, 15 Apr 2020 08:58:35 +0000 (08:58 +0000)
Found by coverity, introduced in d176f84ce5ca2073f4dfbafb457b9c74f6bf0d76

src/lib/failures.h
src/log/log-connection.c

index 5235edd5634c324b9d9e4d015948d8480daf7573..1f901b32a66e0ad9bea5bfd334cbc82d917ddd2d 100644 (file)
@@ -23,6 +23,7 @@ enum log_type {
        LOG_TYPE_PANIC,
 
        LOG_TYPE_COUNT,
+       /* special case */
        LOG_TYPE_OPTION
 };
 
index 3a6db8d13ff664d9bd96de9df96465f38eea1331..d50e822bf333117d38106dac7d65e3240dd4f2eb 100644 (file)
@@ -129,7 +129,6 @@ client_log_ctx(struct log_connection *log,
        switch (ctx->type) {
        case LOG_TYPE_DEBUG:
        case LOG_TYPE_INFO:
-       case LOG_TYPE_OPTION:
                break;
        case LOG_TYPE_WARNING:
        case LOG_TYPE_ERROR:
@@ -142,6 +141,7 @@ client_log_ctx(struct log_connection *log,
                err.text = text;
                log_error_buffer_add(log->errorbuf, &err);
                break;
+       case LOG_TYPE_OPTION:
        case LOG_TYPE_COUNT:
                i_unreached();
        }