]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: fsl_pq_mdio: Fix device node reference leak in fsl_pq_mdio_probe
authorErick Karanja <karanja99erick@gmail.com>
Thu, 2 Oct 2025 17:46:17 +0000 (20:46 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 19 Oct 2025 14:23:08 +0000 (16:23 +0200)
[ Upstream commit 521405cb54cd2812bbb6dedd5afc14bca1e7e98a ]

Add missing of_node_put call to release device node tbi obtained
via for_each_child_of_node.

Fixes: afae5ad78b342 ("net/fsl_pq_mdio: streamline probing of MDIO nodes")
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
Link: https://patch.msgid.link/20251002174617.960521-1-karanja99erick@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/freescale/fsl_pq_mdio.c

index 9d58d83344670f64c4f619cdb1988dccd460d8c7..ea49b0df397e5d69d15e13196e6d1c05b8a5ba01 100644 (file)
@@ -482,10 +482,12 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
                                        "missing 'reg' property in node %pOF\n",
                                        tbi);
                                err = -EBUSY;
+                               of_node_put(tbi);
                                goto error;
                        }
                        set_tbipa(*prop, pdev,
                                  data->get_tbipa, priv->map, &res);
+                       of_node_put(tbi);
                }
        }