Don't autostart domains when reloading config

When sending SIGHUP to libvirtd, it will trigger the virStateDriver
reload operation. This is intended to reload the configuration files
for guests. For unknown historical reasons this is also triggering
autostart of all guests. Autostart is generally expected to be
something that happens on OS startup. Starting VMs on SIGHUP will
violate that expectation and potentially cause dangerous scenarios
if the admin has explicitly shutdown a misbehaving VM that has
been marked as autostart

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c
index 2d931db5d408dcfcf9fa79d8745e9c63340df984..c341125c93499a530167dee0542aff214b00df33 100644 (file)
--- a/src/lxc/lxc_driver.c
+++ b/src/lxc/lxc_driver.c
@@ -2750,8 +2750,6 @@ lxcReload(void) {
                             lxcNotifyLoadDomain, lxc_driver);
     lxcDriverUnlock(lxc_driver);
 
-    lxcAutostartConfigs(lxc_driver);
-
     return 0;
 }
 

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index d3988b8655634f86f93b51c1aba00e771320a7ff..46000f45004f6c64b2c211245fb88fa10dc30aee 100644 (file)
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -805,8 +805,6 @@ qemudReload(void) {
                             qemudNotifyLoadDomain, qemu_driver);
     qemuDriverUnlock(qemu_driver);
 
-    qemuAutostartDomains(qemu_driver);
-
     return 0;
 }
 

diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c
index 098ee7ba6b508a2c791aac5b3c219de97d6f6c7d..b8d0ab78ef4b0e68061694e08379a4942b67b47d 100644 (file)
--- a/src/uml/uml_driver.c
+++ b/src/uml/uml_driver.c
@@ -553,8 +553,6 @@ umlReload(void) {
                             umlNotifyLoadDomain, uml_driver);
     umlDriverUnlock(uml_driver);
 
-    umlAutostartConfigs(uml_driver);
-
     return 0;
 }