]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Fix bug in nbdkit-backed backing chains
authorJonathon Jongsma <jjongsma@redhat.com>
Thu, 18 Jan 2024 23:17:07 +0000 (17:17 -0600)
committerJonathon Jongsma <jjongsma@redhat.com>
Wed, 24 Jan 2024 13:45:34 +0000 (07:45 -0600)
When trying to start nbdkit-backed disks in backing chains, we were
accidentally always checking the private data of the top of the chain
instead of using the loop variable.

Signed-off-by: Jonathon Jongsma <jjongsma@redhat.com>
src/qemu/qemu_nbdkit.c

index 85e61be44c4f676a1da54712c233c83d7a4ab76e..1c72b6fe6afd994b503ce79261d0add886b37a30 100644 (file)
@@ -901,7 +901,7 @@ qemuNbdkitStartStorageSource(virQEMUDriver *driver,
     virStorageSource *backing;
 
     for (backing = src; backing != NULL; backing = backing->backingStore) {
-        qemuDomainStorageSourcePrivate *priv = QEMU_DOMAIN_STORAGE_SOURCE_PRIVATE(src);
+        qemuDomainStorageSourcePrivate *priv = QEMU_DOMAIN_STORAGE_SOURCE_PRIVATE(backing);
 
         if (priv && priv->nbdkitProcess &&
             qemuNbdkitProcessStart(priv->nbdkitProcess, vm, driver) < 0)
@@ -919,7 +919,7 @@ qemuNbdkitStopStorageSource(virStorageSource *src,
     virStorageSource *backing;
 
     for (backing = src; backing != NULL; backing = backing->backingStore) {
-        qemuDomainStorageSourcePrivate *priv = QEMU_DOMAIN_STORAGE_SOURCE_PRIVATE(src);
+        qemuDomainStorageSourcePrivate *priv = QEMU_DOMAIN_STORAGE_SOURCE_PRIVATE(backing);
 
         if (priv && priv->nbdkitProcess &&
             qemuNbdkitProcessStop(priv->nbdkitProcess, vm) < 0)